@4djs/assistant 0.0.0

package/test/buildLlmHistory.test.ts

@@ -0,0 +1,95 @@
+import { expect, test } from "bun:test";
+import { buildLlmHistory, sanitizeLlmMessages } from "../src/core/llm-chat.ts";
+import type { LlmChatMessage } from "../src/core/llm-types.ts";
+
+test("buildLlmHistory keeps assistant tool_calls grouped with tool results when trimming", () => {
+	const messages = Array.from({ length: 15 }, (_, index) => ({
+		role: "user" as const,
+		content: `question ${index}`,
+	}));
+
+	messages.push({
+		role: "assistant",
+		content: "Found users",
+		activity: [
+			{
+				name: "query_entities",
+				args: { dataClass: "User" },
+				result: { __COUNT: 1 },
+			},
+			{
+				name: "suggest_replies",
+				args: { question: "Next?", suggestions: ["A", "B"] },
+				result: { displayed: true },
+			},
+		],
+	});
+
+	const history = buildLlmHistory(messages);
+	expect(history[0]?.role).not.toBe("tool");
+	expect(history.some((message) => message.role === "tool")).toBe(true);
+
+	const assistantWithTools = history.find(
+		(message) => message.role === "assistant" && message.tool_calls?.length,
+	);
+	expect(assistantWithTools).toBeDefined();
+	for (const toolCall of assistantWithTools?.tool_calls ?? []) {
+		expect(
+			history.some(
+				(message) =>
+					message.role === "tool" && message.tool_call_id === toolCall.id,
+			),
+		).toBe(true);
+	}
+});
+
+test("sanitizeLlmMessages drops orphan tool messages", () => {
+	const messages: LlmChatMessage[] = [
+		{
+			role: "tool",
+			tool_call_id: "call_orphan",
+			content: "{}",
+		},
+		{ role: "user", content: "hello" },
+		{
+			role: "assistant",
+			content: null,
+			tool_calls: [
+				{
+					id: "call_ok_0",
+					type: "function",
+					function: { name: "query_entities", arguments: "{}" },
+				},
+				{
+					id: "call_ok_1",
+					type: "function",
+					function: { name: "suggest_replies", arguments: "{}" },
+				},
+			],
+		},
+		{ role: "tool", tool_call_id: "call_ok_0", content: "{}" },
+		{ role: "tool", tool_call_id: "call_ok_1", content: "{}" },
+	];
+
+	expect(sanitizeLlmMessages(messages)).toEqual([
+		{ role: "user", content: "hello" },
+		{
+			role: "assistant",
+			content: null,
+			tool_calls: [
+				{
+					id: "call_ok_0",
+					type: "function",
+					function: { name: "query_entities", arguments: "{}" },
+				},
+				{
+					id: "call_ok_1",
+					type: "function",
+					function: { name: "suggest_replies", arguments: "{}" },
+				},
+			],
+		},
+		{ role: "tool", tool_call_id: "call_ok_0", content: "{}" },
+		{ role: "tool", tool_call_id: "call_ok_1", content: "{}" },
+	]);
+});

package/test/llm-config.test.ts

@@ -0,0 +1,72 @@
+import { describe, expect, test } from "bun:test";
+import {
+	isLlmConfigured,
+	isLlmUnavailableMessage,
+	isLocalLlmBaseUrl,
+} from "../src/core/llm-config.ts";
+
+describe("isLocalLlmBaseUrl", () => {
+	test("detects localhost providers", () => {
+		expect(isLocalLlmBaseUrl("http://127.0.0.1:11434/v1")).toBe(true);
+		expect(isLocalLlmBaseUrl("http://localhost:1234/v1")).toBe(true);
+	});
+
+	test("rejects remote providers", () => {
+		expect(isLocalLlmBaseUrl("https://api.openai.com/v1")).toBe(false);
+	});
+});
+
+describe("isLlmConfigured", () => {
+	test("requires an api key for remote providers", () => {
+		expect(
+			isLlmConfigured({
+				enabled: true,
+				baseUrl: "https://api.openai.com/v1",
+				apiKey: null,
+				model: "gpt-4o-mini",
+			}),
+		).toBe(false);
+	});
+
+	test("allows local providers without an api key", () => {
+		expect(
+			isLlmConfigured({
+				enabled: true,
+				baseUrl: "http://127.0.0.1:11434/v1",
+				apiKey: null,
+				model: "llama3.2",
+			}),
+		).toBe(true);
+	});
+
+	test("accepts remote providers with an api key", () => {
+		expect(
+			isLlmConfigured({
+				enabled: true,
+				baseUrl: "https://api.openai.com/v1",
+				apiKey: "sk-test",
+				model: "gpt-4o-mini",
+			}),
+		).toBe(true);
+	});
+});
+
+describe("isLlmUnavailableMessage", () => {
+	test("detects explicit setup flag", () => {
+		expect(
+			isLlmUnavailableMessage({
+				content: "anything",
+				llmSetupRequired: true,
+			}),
+		).toBe(true);
+	});
+
+	test("detects legacy plain-text content", () => {
+		expect(
+			isLlmUnavailableMessage({
+				content:
+					"Chat requires an LLM. Open LLM settings to add your provider base URL, model, and API key (optional for local servers).",
+			}),
+		).toBe(true);
+	});
+});

package/test/llmSettingsStorage.test.ts

@@ -0,0 +1,121 @@
+import { expect, test } from "bun:test";
+import {
+	assistantToStored,
+	createDefaultStoredSettings,
+	isLlmSettingsFormDirty,
+	mergeLlmSettings,
+	normalizeStoredSettings,
+	normalizeStoredSystemPrompt,
+	resolveSelectedModel,
+	storedSettingsHaveOverrides,
+	storedToAssistant,
+	toStoredSettings,
+} from "../src/core/llm-settings-storage.ts";
+
+const base = {
+	enabled: true,
+	baseUrl: "https://api.openai.com/v1",
+	apiKey: "env-key",
+	model: "gpt-4o-mini",
+	models: ["gpt-4o-mini", "gpt-4o"],
+	systemPrompt: "Default prompt",
+};
+
+test("toStoredSettings persists all fields including empty system prompt", () => {
+	const stored = toStoredSettings(
+		{
+			baseUrl: "https://custom.example/v1",
+			apiKey: "",
+			model: "gpt-4o",
+			modelsText: "gpt-4o, gpt-4o-mini",
+			systemPrompt: "",
+		},
+		"existing-key",
+	);
+
+	expect(stored).toEqual({
+		baseUrl: "https://custom.example/v1",
+		apiKey: "existing-key",
+		model: "gpt-4o",
+		models: ["gpt-4o", "gpt-4o-mini"],
+		systemPrompt: "",
+	});
+});
+
+test("stored settings round-trip through merge", () => {
+	const stored = assistantToStored(base);
+	const merged = mergeLlmSettings(
+		{ enabled: false, baseUrl: "x", apiKey: null, model: "y" },
+		stored,
+	);
+
+	expect(merged).toEqual(storedToAssistant(stored));
+});
+
+test("normalizeStoredSettings fills missing legacy fields from base", () => {
+	const normalized = normalizeStoredSettings({ model: "gpt-4.1" }, base);
+
+	expect(normalized?.model).toBe("gpt-4.1");
+	expect(normalized?.baseUrl).toBe(base.baseUrl);
+	expect(normalized?.apiKey).toBe(base.apiKey);
+	expect(normalized?.systemPrompt).toBe(base.systemPrompt);
+});
+
+test("empty stored system prompt falls back to base default", () => {
+	const stored = createDefaultStoredSettings(base);
+	const merged = mergeLlmSettings(base, stored);
+
+	expect(merged.systemPrompt).toBe(base.systemPrompt);
+});
+
+test("storedSettingsHaveOverrides ignores default system prompt content", () => {
+	const defaults = createDefaultStoredSettings(base);
+	expect(storedSettingsHaveOverrides(defaults, base)).toBe(false);
+	expect(
+		storedSettingsHaveOverrides(
+			{ ...defaults, systemPrompt: base.systemPrompt ?? "" },
+			base,
+		),
+	).toBe(false);
+	expect(
+		storedSettingsHaveOverrides(
+			{ ...defaults, systemPrompt: "Custom prompt" },
+			base,
+		),
+	).toBe(true);
+});
+
+test("normalizeStoredSystemPrompt collapses base prompt to empty", () => {
+	expect(normalizeStoredSystemPrompt("", base)).toBe("");
+	expect(normalizeStoredSystemPrompt("Default prompt", base)).toBe("");
+	expect(normalizeStoredSystemPrompt("Custom prompt", base)).toBe(
+		"Custom prompt",
+	);
+});
+
+test("isLlmSettingsFormDirty detects unsaved form edits", () => {
+	const saved = {
+		baseUrl: "https://api.openai.com/v1",
+		apiKey: "",
+		model: "gpt-4o-mini",
+		modelsText: "",
+		systemPrompt: "",
+	};
+
+	expect(isLlmSettingsFormDirty(saved, saved)).toBe(false);
+	expect(isLlmSettingsFormDirty({ ...saved, model: "gpt-4o" }, saved)).toBe(
+		true,
+	);
+});
+
+test("resolveSelectedModel keeps stored custom models", () => {
+	expect(
+		resolveSelectedModel("gpt-4o", "gpt-4o-mini", ["gpt-4o-mini", "gpt-4o"]),
+	).toBe("gpt-4o");
+	expect(
+		resolveSelectedModel("gpt-5.5", "gpt-4o-mini", ["gpt-4o-mini", "gpt-4o"]),
+	).toBe("gpt-5.5");
+	expect(
+		resolveSelectedModel("", "gpt-4o-mini", ["gpt-4o-mini", "gpt-4o"]),
+	).toBe("gpt-4o-mini");
+});

package/test/parse-assistant-error.test.ts

@@ -0,0 +1,24 @@
+import { describe, expect, test } from "bun:test";
+import { parseAssistantError } from "../src/react/lib/parse-assistant-error.ts";
+
+describe("parseAssistantError", () => {
+	test("strips chat prefix and maps fetch failures to network", () => {
+		const parsed = parseAssistantError("Chat failed: Failed to fetch");
+		expect(parsed.title).toBe("Connection lost");
+		expect(parsed.detail).toBe("Failed to fetch");
+		expect(parsed.kind).toBe("network");
+		expect(parsed.hint).toContain("LLM endpoint");
+	});
+
+	test("maps auth errors", () => {
+		const parsed = parseAssistantError("401 Unauthorized");
+		expect(parsed.title).toBe("Authentication failed");
+		expect(parsed.kind).toBe("auth");
+	});
+
+	test("uses suggestions context copy", () => {
+		const parsed = parseAssistantError("Failed to fetch", "suggestions");
+		expect(parsed.title).toBe("Connection lost");
+		expect(parsed.hint).toContain("LLM settings");
+	});
+});

package/tsconfig.json

@@ -0,0 +1,8 @@
+{
+	"extends": "@4d/typescript-config/base.json",
+	"compilerOptions": {
+		"jsx": "react-jsx",
+		"lib": ["ESNext", "DOM", "DOM.Iterable"]
+	},
+	"include": ["src"]
+}