@3dsource/angular-unreal-module 0.0.144 → 0.0.145

package/fesm2022/3dsource-angular-unreal-module.mjs

@@ -3249,6 +3249,20 @@ class WebRtcPlayerService extends SubService {
         this.remoteDescriptionSet = false;
         this.iceCandidateBuffer.length = 0;
     }
+    /**
+     * Single source of truth for tearing down the remote connection: closes the
+     * signaling WebSocket and then the PeerConnection/DataChannel.
+     *
+     * Called by the `destroyRemoteConnections$` effect and, as a
+     * lifecycle-independent safeguard, by `UnrealSceneComponent.onDestroy` (the
+     * route-scoped effects may already be torn down on navigation). Both close
+     * steps are idempotent, so invoking this twice in one teardown is a harmless
+     * no-op.
+     */
+    releaseRemoteConnections(reason) {
+        this.signallingSrv.close({ code: WSCloseCode_FORCE_CIRRUS_CLOSE, reason });
+        this.closePC();
+    }
     canSend() {
         return this.dcClient && this.dcClient.readyState === 'open';
     }
@@ -3816,11 +3830,7 @@ class UnrealEffects {
         });
         this.destroyRemoteConnections$ = createEffect(() => {
             return this.actions$.pipe(ofType(destroyRemoteConnections), tap(({ reason }) => {
-                this.signallingService.close({
-                    code: WSCloseCode_FORCE_CIRRUS_CLOSE,
-                    reason,
-                });
-                this.webRtcPlayerService.closePC();
+                this.webRtcPlayerService.releaseRemoteConnections(reason);
             }), filter(({ reason }) => reason === DisconnectReason.DropConnection), map(() => dropConnection()));
         });
         this.destroyConnectionAndRestart$ = createEffect(() => {
@@ -7171,26 +7181,19 @@ class UnrealSceneComponent {
         this.commandsSender = inject(UnrealCommunicatorService);
         this.videoService = inject(VideoService);
         this.webRtcPlayerService = inject(WebRtcPlayerService);
-        this.signallingService = inject(SignallingService);
         this.destroyRef = inject(DestroyRef);
         this.unrealConfig = inject(UNREAL_CONFIG);
         this.autoHighResolution = false;
         this.destroyRef.onDestroy(() => {
-            // Mirror of the `destroyRemoteConnections$` effect's teardown tap, run
-            // directly here as a safeguard. provideUnrealModule (effects) is
-            // registered per 3D route, so on navigation the route's environment
-            // injector — and its UnrealEffects — may be torn down before the
+            // Release the remote connection synchronously, independent of the
+            // route-scoped UnrealEffects. provideUnrealModule (effects) is registered
+            // per 3D route, so on navigation the route's environment injector — and
+            // its UnrealEffects — may be torn down before the
             // `destroyUnrealScene → destroyRemoteConnections` effect chain closes the
-            // WebSocket/PeerConnection, which would leak the stream session. The
-            // engine services are providedIn:'root' singletons, so we close them
-            // directly. Keep the SAME calls, args and order as the effect's tap
-            // (close → closePC); both are idempotent, so whichever runs second is a
-            // harmless no-op.
-            this.signallingService.close({
-                code: WSCloseCode_FORCE_CIRRUS_CLOSE,
-                reason: DisconnectReason.Destroy,
-            });
-            this.webRtcPlayerService.closePC();
+            // WebSocket/PeerConnection, which would leak the stream session. We call
+            // the same root-singleton method the effect uses, so the two can never
+            // drift; it's idempotent, so whichever runs second is a harmless no-op.
+            this.webRtcPlayerService.releaseRemoteConnections(DisconnectReason.Destroy);
             // State cleanup is reducer-driven, not effect-driven: the
             // `destroyUnrealScene` reducer resets the whole UnrealState to
             // initialState (cirrusConnected/viewportReady/… → false). Reducers run in