@2en/clawly-plugins 1.30.0-beta.2 → 1.30.0-beta.4

package/gateway/offline-push.test.ts

@@ -73,6 +73,11 @@ function createMockApi(): {
   return {api, logs, handlers}
 }
 
+/** Event with a simple assistant message — needed since the skip-on-no-text guard. */
+const eventWithReply = {
+  messages: [{role: 'assistant', content: 'Hello from the assistant'}],
+}
+
 // ── Tests ────────────────────────────────────────────────────────
 
 beforeEach(() => {
@@ -89,7 +94,7 @@ describe('offline-push', () => {
     registerOfflinePush(api)
 
     const handler = handlers.get('agent_end')!
-    await handler({}, {sessionKey: 'agent:clawly:main'})
+    await handler(eventWithReply, {sessionKey: 'agent:clawly:main'})
 
     expect(logs).toContainEqual({
       level: 'info',
@@ -117,8 +122,8 @@ describe('offline-push', () => {
 
     const handler = handlers.get('agent_end')!
 
-    await handler({}, {sessionKey: 'agent:clawly:main'})
-    await handler({}, {sessionKey: 'agent:clawly:main'})
+    await handler(eventWithReply, {sessionKey: 'agent:clawly:main'})
+    await handler(eventWithReply, {sessionKey: 'agent:clawly:main'})
 
     expect(logs.filter((l) => l.msg.includes('notified'))).toHaveLength(2)
   })
@@ -129,11 +134,11 @@ describe('offline-push', () => {
 
     const handler = handlers.get('agent_end')!
 
-    await handler({}, {sessionKey: 'agent:clawly:main'})
+    await handler(eventWithReply, {sessionKey: 'agent:clawly:main'})
     expect(lastPushExtras).toEqual({badge: 1})
     expect(mockBadgeCount).toBe(1)
 
-    await handler({}, {sessionKey: 'agent:clawly:main'})
+    await handler(eventWithReply, {sessionKey: 'agent:clawly:main'})
     expect(lastPushExtras).toEqual({badge: 2})
     expect(mockBadgeCount).toBe(2)
   })
@@ -143,7 +148,7 @@ describe('offline-push', () => {
     const {api, handlers} = createMockApi()
     registerOfflinePush(api)
 
-    await handlers.get('agent_end')!({}, {sessionKey: 'agent:clawly:main'})
+    await handlers.get('agent_end')!(eventWithReply, {sessionKey: 'agent:clawly:main'})
 
     expect(lastPushExtras).toEqual({badge: 1})
     expect(mockBadgeCount).toBe(0) // incremented then decremented
@@ -153,7 +158,7 @@ describe('offline-push', () => {
     const {api, logs, handlers} = createMockApi()
     registerOfflinePush(api)
 
-    await handlers.get('agent_end')!({}, {sessionKey: 'agent:clawly:telegram:12345'})
+    await handlers.get('agent_end')!(eventWithReply, {sessionKey: 'agent:clawly:telegram:12345'})
 
     expect(logs).toContainEqual({
       level: 'info',
@@ -166,7 +171,9 @@ describe('offline-push', () => {
     const {api, logs, handlers} = createMockApi()
     registerOfflinePush(api)
 
-    await handlers.get('agent_end')!({}, {sessionKey: 'agent:clawly:cron:weather-check:run:abc123'})
+    await handlers.get('agent_end')!(eventWithReply, {
+      sessionKey: 'agent:clawly:cron:weather-check:run:abc123',
+    })
 
     expect(logs).toContainEqual({
       level: 'info',
@@ -180,7 +187,7 @@ describe('offline-push', () => {
     registerOfflinePush(api)
 
     const handler = handlers.get('agent_end')!
-    await handler({})
+    await handler(eventWithReply)
 
     expect(logs).toContainEqual({
       level: 'info',
@@ -192,7 +199,10 @@ describe('offline-push', () => {
     const {api, handlers} = createMockApi()
     registerOfflinePush(api)
 
-    await handlers.get('agent_end')!({}, {sessionKey: 'agent:clawly:main', agentId: 'luna'})
+    await handlers.get('agent_end')!(eventWithReply, {
+      sessionKey: 'agent:clawly:main',
+      agentId: 'luna',
+    })
 
     expect(lastPushOpts?.agentId).toBe('luna')
   })
@@ -201,8 +211,9 @@ describe('offline-push', () => {
     const {api, handlers} = createMockApi()
     registerOfflinePush(api)
 
-    await handlers.get('agent_end')!({}, {sessionKey: 'agent:clawly:main'})
+    await handlers.get('agent_end')!(eventWithReply, {sessionKey: 'agent:clawly:main'})
 
+    expect(lastPushOpts).not.toBeNull()
     expect(lastPushOpts?.title).toBeUndefined()
   })
 
@@ -223,17 +234,21 @@ describe('offline-push', () => {
     expect(lastPushOpts?.body).toBe('Hi there! How can I help you today?')
   })
 
-  test('body falls back when no messages', async () => {
-    const {api, handlers} = createMockApi()
+  test('skips push when no messages (no extractable text)', async () => {
+    const {api, logs, handlers} = createMockApi()
     registerOfflinePush(api)
 
     await handlers.get('agent_end')!({}, {sessionKey: 'agent:clawly:main'})
 
-    expect(lastPushOpts?.body).toBe('Your response is ready')
+    expect(lastPushOpts).toBeNull()
+    expect(logs).toContainEqual({
+      level: 'warn',
+      msg: expect.stringContaining('skipped (no extractable assistant text)'),
+    })
   })
 
-  test('body falls back when messages has no assistant role', async () => {
-    const {api, handlers} = createMockApi()
+  test('skips push when messages has no assistant role', async () => {
+    const {api, logs, handlers} = createMockApi()
     registerOfflinePush(api)
 
     await handlers.get('agent_end')!(
@@ -241,7 +256,11 @@ describe('offline-push', () => {
       {sessionKey: 'agent:clawly:main'},
     )
 
-    expect(lastPushOpts?.body).toBe('Your response is ready')
+    expect(lastPushOpts).toBeNull()
+    expect(logs).toContainEqual({
+      level: 'warn',
+      msg: expect.stringContaining('skipped (no extractable assistant text)'),
+    })
   })
 
   test('body strips [[type:value]] placeholders', async () => {
@@ -580,15 +599,15 @@ describe('offline-push with filtered messages', () => {
     })
   })
 
-  test('sends push when event has no messages (safe default)', async () => {
+  test('skips push when event has no messages (no extractable text)', async () => {
     const {api, logs, handlers} = createMockApi()
     registerOfflinePush(api)
 
     await handlers.get('agent_end')!({}, {sessionKey: 'agent:clawly:main'})
 
     expect(logs).toContainEqual({
-      level: 'info',
-      msg: expect.stringContaining('notified (session=agent:clawly:main)'),
+      level: 'warn',
+      msg: expect.stringContaining('skipped (no extractable assistant text)'),
     })
   })
 })

package/gateway/offline-push.ts

@@ -226,6 +226,7 @@ export function registerOfflinePush(api: PluginApi) {
 
       // Extract full assistant text for filtering and preview.
       const fullText = getLastAssistantText(event.messages)
+      const triggerText = getTriggeringUserText(event.messages)
 
       // Skip if the message would be filtered by the mobile UI.
       if (fullText != null) {
@@ -270,6 +271,33 @@ export function registerOfflinePush(api: PluginApi) {
         return
       }
 
+      // Defensive: if we can't extract assistant text, sending a generic
+      // "Your response is ready" is never useful — the message likely wasn't
+      // persisted to the transcript either, so the user opens the app to nothing.
+      // Log the messages structure for debugging, then bail.
+      if (fullText == null || fullText === '') {
+        const msgCount = Array.isArray(event.messages) ? event.messages.length : 'n/a'
+        const lastRoles = Array.isArray(event.messages)
+          ? event.messages
+              .slice(-5)
+              .map(
+                (m: any) =>
+                  `${m?.role ?? '?'}(${typeof m?.content === 'string' ? 'str' : Array.isArray(m?.content) ? `parts:${m.content.length}` : typeof m?.content})`,
+              )
+              .join(', ')
+          : 'n/a'
+        api.logger.warn(
+          `offline-push: skipped (no extractable assistant text) msgCount=${msgCount} lastRoles=[${lastRoles}] triggerText=${triggerText ? `"${triggerText.slice(0, 80)}"` : 'null'}`,
+        )
+        if (isCron) markCronPushSkipped(sessionKey!, 'no extractable text', false)
+        captureEvent('push.skipped', {
+          reason: 'no_extractable_text',
+          is_cron: isCron,
+          ...(sessionKey ? {session_key: sessionKey} : {}),
+        })
+        return
+      }
+
       // Only send push for the main clawly mobile session and cron sessions —
       // skip channel sessions (telegram, slack, discord, etc.) which have their own delivery.
       if (sessionKey !== undefined && sessionKey !== 'agent:clawly:main' && !isCron) {

package/index.ts

@@ -17,7 +17,7 @@
  * Agent tools:
  * - clawly_is_user_online    — check if user's device is connected
  * - clawly_send_app_push     — send a push notification to user's device
- * - clawly_send_image        — send an image to the user (URL download or local file)
+ * - clawly_send_file         — send a file to the user (URL or local path under $HOME/tmp)
  * - clawly_search             — web search via Perplexity (replaces denied web_search)
  * - clawly_send_message      — send a message to user via main session agent (supports role: user|assistant)
  *

package/outbound.ts

@@ -18,6 +18,7 @@ import fsp from 'node:fs/promises'
 import type {IncomingMessage, ServerResponse} from 'node:http'
 import os from 'node:os'
 import path from 'node:path'
+import mime from 'mime'
 
 import type {PluginApi} from './index'
 import {createAccessToken, guardHttpAuth, resolveGatewaySecret, sendJson} from './lib/httpAuth'
@@ -132,24 +133,7 @@ export function registerOutboundMethods(api: PluginApi) {
 
 // ── HTTP route: GET /clawly/file/outbound?path=<original-path> ─────────────
 
-const MIME: Record<string, string> = {
-  '.mp3': 'audio/mpeg',
-  '.wav': 'audio/wav',
-  '.ogg': 'audio/ogg',
-  '.m4a': 'audio/mp4',
-  '.aac': 'audio/aac',
-  '.flac': 'audio/flac',
-  '.webm': 'audio/webm',
-  '.jpg': 'image/jpeg',
-  '.jpeg': 'image/jpeg',
-  '.png': 'image/png',
-  '.gif': 'image/gif',
-  '.webp': 'image/webp',
-  '.bmp': 'image/bmp',
-  '.heic': 'image/heic',
-  '.avif': 'image/avif',
-  '.ico': 'image/x-icon',
-}
+// Content-Type resolution via `mime` package (replaces hardcoded map)
 
 /** Directories from which direct-path serving is allowed (no hash required). */
 let allowedRoots: string[] | null = null
@@ -183,6 +167,12 @@ async function resolveOutboundFile(rawPath: string, stateDir?: string): Promise<
   return null
 }
 
+export function buildContentDisposition(filename: string): string {
+  const asciiName = filename.replace(/[^\x20-\x7E]/g, '_').replace(/["\\]/g, '\\$&')
+  const utf8Name = encodeURIComponent(filename)
+  return `attachment; filename="${asciiName}"; filename*=UTF-8''${utf8Name}`
+}
+
 export function registerOutboundHttpRoute(api: PluginApi) {
   const stateDir = api.runtime.state.resolveStateDir()
 
@@ -219,8 +209,7 @@ export function registerOutboundHttpRoute(api: PluginApi) {
         return
       }
 
-      const ext = path.extname(resolved).toLowerCase()
-      const contentType = MIME[ext] ?? 'application/octet-stream'
+      const contentType = mime.getType(resolved) ?? 'application/octet-stream'
       const stat = await fsp.stat(resolved)
       const total = stat.size
 
@@ -230,6 +219,15 @@ export function registerOutboundHttpRoute(api: PluginApi) {
         return
       }
 
+      const downloadFilename = url.searchParams.get('download')
+      const baseHeaders: Record<string, string | number> = {
+        'Content-Type': contentType,
+        'Accept-Ranges': 'bytes',
+      }
+      if (downloadFilename && path.extname(downloadFilename) === path.extname(resolved)) {
+        baseHeaders['Content-Disposition'] = buildContentDisposition(downloadFilename)
+      }
+
       const rangeHeader = _req.headers.range
 
       if (rangeHeader) {
@@ -241,9 +239,8 @@ export function registerOutboundHttpRoute(api: PluginApi) {
           const stream = fs.createReadStream(resolved, {start, end})
 
           res.writeHead(206, {
-            'Content-Type': contentType,
+            ...baseHeaders,
             'Content-Range': `bytes ${start}-${end}/${total}`,
-            'Accept-Ranges': 'bytes',
             'Content-Length': chunkSize,
           })
           stream.pipe(res)
@@ -256,9 +253,8 @@ export function registerOutboundHttpRoute(api: PluginApi) {
 
       const buffer = await fsp.readFile(resolved)
       res.writeHead(200, {
-        'Content-Type': contentType,
+        ...baseHeaders,
         'Content-Length': total,
-        'Accept-Ranges': 'bytes',
       })
       res.end(buffer)
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@2en/clawly-plugins",
-  "version": "1.30.0-beta.2",
+  "version": "1.30.0-beta.4",
   "module": "index.ts",
   "type": "module",
   "repository": {
@@ -13,8 +13,10 @@
     "@opentelemetry/exporter-logs-otlp-http": "^0.57.0",
     "@opentelemetry/resources": "^1.30.0",
     "@opentelemetry/sdk-logs": "^0.57.0",
-    "posthog-node": "^5.28.0",
     "file-type": "^21.3.0",
+    "json5": "^2.2.3",
+    "mime": "^4.1.0",
+    "posthog-node": "^5.28.0",
     "zx": "npm:zx@8.8.5-lite"
   },
   "files": [
@@ -47,8 +49,5 @@
     "extensions": [
       "./index.ts"
     ]
-  },
-  "devDependencies": {
-    "json5": "^2.2.3"
   }
 }