@1stg/eslint-config 8.4.0 → 9.0.0

package/CHANGELOG.md

@@ -1,5 +1,24 @@
 # Change Log
 
+## 9.0.0
+
+### Major Changes
+
+- [#341](https://github.com/1stG/configs/pull/341) [`8527c5f`](https://github.com/1stG/configs/commit/8527c5f5fd264216a7244dcb6b8aa8f7ff0dd23f) Thanks [@JounQin](https://github.com/JounQin)! - feat(eslint-config)!: mark all framework plugins as optional peer
+
+## 8.5.0
+
+### Minor Changes
+
+- [#336](https://github.com/1stG/configs/pull/336) [`fa39ecf`](https://github.com/1stG/configs/commit/fa39ecf3bc7982e7e4172952721f8745991f4739) Thanks [@JounQin](https://github.com/JounQin)! - feat: enable `eslint-plugin-markup` again
+
+### Patch Changes
+
+- [#336](https://github.com/1stG/configs/pull/336) [`fa39ecf`](https://github.com/1stG/configs/commit/fa39ecf3bc7982e7e4172952721f8745991f4739) Thanks [@JounQin](https://github.com/JounQin)! - chore: bump all (dev) deps
+
+- Updated dependencies [[`fa39ecf`](https://github.com/1stG/configs/commit/fa39ecf3bc7982e7e4172952721f8745991f4739)]:
+  - @1stg/config@1.0.4
+
 ## 8.4.0
 
 ### Minor Changes

package/README.md

@@ -2,15 +2,17 @@
 
 Personal but Shareable ESLint Configuration for all 1stG.me projects
 
-[![Sponsors](https://raw.githubusercontent.com/1stG/static/master/sponsors.svg)](https://github.com/sponsors/JounQin)
+## Sponsors and Backers
 
-## Sponsors
+[![Sponsors and Backers](https://raw.githubusercontent.com/1stG/static/master/sponsors.svg)](https://github.com/sponsors/JounQin)
+
+### Sponsors
 
 | 1stG                                                                                                                   | RxTS                                                                                                                   | UnTS                                                                                                                   |
 | ---------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------- |
 | [![1stG Open Collective sponsors](https://opencollective.com/1stG/organizations.svg)](https://opencollective.com/1stG) | [![RxTS Open Collective sponsors](https://opencollective.com/rxts/organizations.svg)](https://opencollective.com/rxts) | [![UnTS Open Collective sponsors](https://opencollective.com/unts/organizations.svg)](https://opencollective.com/unts) |
 
-## Backers
+### Backers
 
 | 1stG                                                                                                                | RxTS                                                                                                                | UnTS                                                                                                                |
 | ------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------- |

package/_util.js

@@ -8,14 +8,14 @@ import {
   isPkgAvailable,
   getMonorepoPkgs,
   tryRequirePkg,
+  tryFile,
+  tryPkg,
 } from '@pkgr/utils'
 import configPrettier from 'eslint-config-prettier'
 import prettierRecommended from 'eslint-plugin-prettier/recommended'
 import tseslint from 'typescript-eslint'
 
-/**
- * @type {string[]}
- */
+/** @type {string[]} */
 let allowModules = []
 
 if (isMonorepo()) {
@@ -38,7 +38,8 @@ export { allowModules }
 
 export const isTsAvailable = isPkgAvailable('typescript')
 
-export const isWebpackAvailable = isPkgAvailable('webpack')
+export const isWebpackAvailable =
+  isPkgAvailable('webpack') || isPkgAvailable('@rspack/core')
 
 export const webpackSpecVars = [
   '__non_webpack_require__',
@@ -61,3 +62,15 @@ export const magicNumbers = [
 export const prettierExtends = tseslint.config(
   preferPrettier ? configPrettier : prettierRecommended,
 )
+
+export const project =
+  tryFile('tsconfig.eslint.json') ||
+  tryFile('tsconfig.base.json') ||
+  tryFile('tsconfig.json') ||
+  tryPkg('@1stg/tsconfig')
+
+export const nonSourceRules = /** @type {const} */ ({
+  'n/no-extraneous-import': 0,
+  'n/no-extraneous-require': 0,
+  'n/no-unsupported-features/es-builtins': 0,
+})

package/angular.js

@@ -0,0 +1,48 @@
+// @ts-check
+
+import { preferPrettier } from '@1stg/config'
+import angular_ from 'angular-eslint'
+import angularTemplateParser from 'angular-eslint-template-parser'
+import * as markup_ from 'eslint-plugin-markup'
+import tseslint from 'typescript-eslint'
+
+import { prettierExtends, project } from './_util.js'
+
+export const angular = tseslint.config(
+  {
+    name: '@1stg/angular-ts',
+    files: ['**/*.ts'],
+    ignores: ['**/*.d.ts'],
+    languageOptions: {
+      parserOptions: {
+        project,
+      },
+    },
+    extends: [angular_.configs.tsRecommended, prettierExtends],
+    processor: angular_.processInlineTemplates,
+    rules: {
+      '@angular-eslint/prefer-on-push-component-change-detection': 1,
+    },
+  },
+  {
+    name: '@1stg/angular-template',
+    files: ['**/*.html'],
+    extends: [
+      angular_.configs.templateRecommended,
+      markup_.configs.flatRecommended,
+      prettierExtends,
+    ],
+    languageOptions: {
+      parser: angularTemplateParser,
+    },
+    rules: {
+      '@angular-eslint/template/eqeqeq': [2, { allowNullOrUndefined: true }],
+      'prettier/prettier': preferPrettier ? 0 : [2, { parser: 'angular' }],
+      'spaced-comment': 0,
+    },
+  },
+  {
+    files: ['**/*inline-template-*.component.html'],
+    rules: { 'unicorn/no-empty-file': 0 },
+  },
+)

package/jest.js

@@ -0,0 +1,17 @@
+// @ts-check
+
+import jest_ from 'eslint-plugin-jest'
+import globals from 'globals'
+import tseslint from 'typescript-eslint'
+
+import { test } from './test.js'
+
+export const jest = tseslint.config({
+  name: '@1stg/jest',
+  files: ['**/*.{spec,test}.{js,jsx,ts,tsx}'],
+  extends: [jest_.configs['flat/recommended']],
+  languageOptions: {
+    globals: globals.jest,
+  },
+  rules: test.rules,
+})

package/js-base.js

@@ -0,0 +1,47 @@
+// @ts-check
+
+/** @import {TSESLint} from '@typescript-eslint/utils' */
+
+import { tryFile, tryPkg, tryRequirePkg } from '@pkgr/utils'
+
+/** @type {string | undefined} */
+let configFile
+
+export const isBabelAvailable =
+  tryPkg('@babel/eslint-parser') && tryPkg('@babel/eslint-plugin')
+
+/** @satisfies {TSESLint.FlatConfig.Config} */
+export const jsBase = {
+  name: '@1stg/js-base',
+  files: ['**/*.{cjs,mjs,js,jsx}'],
+  languageOptions: isBabelAvailable
+    ? {
+        parser: tryRequirePkg('@babel/eslint-parser'),
+        // eslint-disable-next-line no-cond-assign, sonarjs/no-nested-assignment
+        parserOptions: (configFile =
+          tryFile('babel.config.js') ||
+          tryFile('.babelrc.js') ||
+          tryPkg('@1stg/babel-preset/config'))
+          ? { babelOptions: { configFile } }
+          : { requireConfigFile: false },
+      }
+    : {},
+  plugins: isBabelAvailable
+    ? {
+        '@babel': /** @type {Omit<TSESLint.FlatConfig.Plugin, 'configs'>} */ (
+          tryRequirePkg('@babel/eslint-plugin')
+        ),
+      }
+    : undefined,
+  rules: {
+    camelcase: [2, { properties: 'never', ignoreDestructuring: true }],
+    ...(isBabelAvailable && {
+      'new-cap': 0,
+      'no-invalid-this': 0,
+      'no-unused-expressions': 0,
+      '@babel/new-cap': 2,
+      '@babel/no-invalid-this': 2,
+      '@babel/no-unused-expressions': 2,
+    }),
+  },
+}

package/js.js

@@ -0,0 +1,22 @@
+// @ts-check
+
+import jsdoc from 'eslint-plugin-jsdoc'
+import tseslint from 'typescript-eslint'
+
+import { isTsAvailable } from './_util.js'
+import { jsBase } from './js-base.js'
+
+const jsdocConfig = jsdoc.configs['flat/recommended']
+
+export const js = tseslint.config({
+  ...jsBase,
+  name: '@1stg/js',
+  extends: [jsdocConfig],
+  rules: {
+    ...jsBase.rules,
+    'jsdoc/require-jsdoc': 0,
+    'jsdoc/require-param-description': 0,
+    'jsdoc/tag-lines': [1, 'never', { startLines: 1 }],
+  },
+  settings: isTsAvailable ? { jsdoc: { mode: 'typescript' } } : undefined,
+})

package/overrides.js

@@ -1,249 +1,35 @@
 // @ts-check
 
-/**
- * @import {Linter} from 'eslint'
- */
-
-import path from 'node:path'
+/** @import {TSESLint} from '@typescript-eslint/utils' */
 
 import { jsoncFiles, nonJsonRcFiles, preferPrettier } from '@1stg/config'
-import babelParser from '@babel/eslint-parser'
-import babel from '@babel/eslint-plugin'
-import react_ from '@eslint-react/eslint-plugin'
-import { isPkgAvailable, tryFile, tryPkg } from '@pkgr/utils'
-import vitest_ from '@vitest/eslint-plugin'
-import angular_ from 'angular-eslint'
-import angularTemplateParser from 'angular-eslint-template-parser'
-import { createTypeScriptImportResolver } from 'eslint-import-resolver-typescript'
+import { isPkgAvailable } from '@pkgr/utils'
 import * as eslintMdx from 'eslint-mdx'
-import importX from 'eslint-plugin-import-x'
-import jest_ from 'eslint-plugin-jest'
-import jsdoc from 'eslint-plugin-jsdoc'
 import jsonc_ from 'eslint-plugin-jsonc'
+import * as markup_ from 'eslint-plugin-markup'
 import * as mdx_ from 'eslint-plugin-mdx'
-import * as reactHooks_ from 'eslint-plugin-react-hooks'
 import toml_ from 'eslint-plugin-toml'
-import vue_ from 'eslint-plugin-vue'
 import yml_ from 'eslint-plugin-yml'
-import globals from 'globals'
 import tseslint from 'typescript-eslint'
-import vueParser from 'vue-eslint-parser'
-
-import { isTsAvailable, magicNumbers, prettierExtends } from './_util.js'
-
-/**
- * @import {TSESLint} from '@typescript-eslint/utils'
- */
-
-const configFile =
-  tryFile(path.resolve('babel.config.js')) ||
-  tryFile(path.resolve('.babelrc.js')) ||
-  tryPkg('@1stg/babel-preset/config')
-
-/**
- * @satisfies {TSESLint.FlatConfig.Config}
- */
-const jsBase = {
-  name: '@1stg/js-base',
-  files: ['**/*.{cjs,mjs,js,jsx}'],
-  languageOptions: {
-    parser: babelParser,
-    parserOptions: configFile
-      ? { babelOptions: { configFile } }
-      : { requireConfigFile: false },
-  },
-  plugins: {
-    '@babel': babel,
-  },
-  rules: {
-    camelcase: [
-      2,
-      {
-        properties: 'never',
-        ignoreDestructuring: true,
-      },
-    ],
-    'new-cap': 0,
-    'no-invalid-this': 0,
-    'no-unused-expressions': 0,
-    '@babel/new-cap': 2,
-    '@babel/no-invalid-this': 2,
-    '@babel/no-unused-expressions': 2,
-  },
-}
-
-const jsdocConfig = jsdoc.configs['flat/recommended']
-
-export const js = tseslint.config({
-  ...jsBase,
-  name: '@1stg/js',
-  extends: [jsdocConfig],
-  rules: {
-    ...jsBase.rules,
-    'jsdoc/require-jsdoc': 0,
-    'jsdoc/require-param-description': 0,
-    'jsdoc/tag-lines': [
-      1,
-      'never',
-      {
-        startLines: 1,
-      },
-    ],
-  },
-  settings: isTsAvailable
-    ? {
-        jsdoc: {
-          mode: 'typescript',
-        },
-      }
-    : undefined,
-})
 
-const project =
-  tryFile(path.resolve('tsconfig.eslint.json')) ||
-  tryFile(path.resolve('tsconfig.base.json')) ||
-  tryFile(path.resolve('tsconfig.json')) ||
-  tryPkg('@1stg/tsconfig')
-
-const resolveSettings = {
-  'import-x/external-module-folders': [
-    'node_modules',
-    'node_modules/@d-ts',
-    'node_modules/@types',
-  ],
-  'import-x/resolver-next': [
-    createTypeScriptImportResolver({
-      alwaysTryTypes: true,
-      project,
-    }),
-  ],
-}
-
-const tsBase = tseslint.config({
-  name: '@1stg/ts-base',
-  files: ['**/*.{cts,mts,ts,tsx}'],
-  languageOptions: {
-    parserOptions: {
-      project,
-    },
-  },
-  extends: [
-    tseslint.configs.eslintRecommended,
-    tseslint.configs.recommended,
-    importX.flatConfigs.typescript,
-    prettierExtends,
-  ],
-  settings: resolveSettings,
-  rules: {
-    '@typescript-eslint/adjacent-overload-signatures': 2,
-    '@typescript-eslint/array-type': [
-      2,
-      {
-        default: 'array-simple',
-      },
-    ],
-    '@typescript-eslint/ban-ts-comment': 0,
-    '@typescript-eslint/consistent-type-definitions': [2, 'interface'],
-    '@typescript-eslint/explicit-function-return-type': 0,
-    '@typescript-eslint/explicit-member-accessibility': [
-      2,
-      {
-        accessibility: 'no-public',
-        overrides: {
-          parameterProperties: 'off',
-        },
-      },
-    ],
-    '@typescript-eslint/explicit-module-boundary-types': 0,
-    '@typescript-eslint/member-ordering': 2,
-    // eslint-disable-line sonarjs/todo-tag -- TODO: find better config
-    '@typescript-eslint/naming-convention': 0,
-    '@typescript-eslint/no-empty-function': 2,
-    '@typescript-eslint/no-extraneous-class': [
-      2,
-      {
-        allowWithDecorator: true,
-      },
-    ],
-    '@typescript-eslint/no-for-in-array': 2,
-    '@typescript-eslint/no-non-null-assertion': 0,
-    '@typescript-eslint/no-parameter-properties': 0,
-    '@typescript-eslint/no-require-imports': 2,
-    '@typescript-eslint/no-this-alias': [
-      2,
-      {
-        allowDestructuring: true,
-        allowedNames: ['self'],
-      },
-    ],
-    '@typescript-eslint/no-use-before-define': [
-      2,
-      {
-        classes: false,
-        functions: false,
-      },
-    ],
-    '@typescript-eslint/no-useless-constructor': 2,
-    '@typescript-eslint/no-unused-vars': [
-      2,
-      {
-        argsIgnorePattern: '^_',
-        varsIgnorePattern: '^_',
-      },
-    ],
-    '@typescript-eslint/prefer-for-of': 2,
-    '@typescript-eslint/prefer-function-type': 2,
-    '@typescript-eslint/prefer-ts-expect-error': 2,
-    '@typescript-eslint/sort-type-constituents': 2,
-    '@typescript-eslint/triple-slash-reference': [
-      2,
-      {
-        lib: 'never',
-        path: 'always',
-        types: 'prefer-import',
-      },
-    ],
-    '@typescript-eslint/unified-signatures': 2,
-    camelcase: 0,
-    'import-x/default': 0,
-    'import-x/named': 0,
-    'import-x/namespace': 0,
-    'import-x/no-duplicates': 2,
-    'import-x/no-named-as-default': 0,
-    'import-x/no-named-as-default-member': 0,
-    'no-empty-function': 0,
-    'no-restricted-syntax': [
-      2,
-      {
-        selector:
-          'TSTypeAliasDeclaration > .typeAnnotation[type=/^(TS.*Keyword|TSTypeReference)$/]:not(:has(TSTypeParameterInstantiation)):not(:has(TSQualifiedName))',
-        message:
-          'Type alias references simple `Ts*Keyword`s or `TSTypeReference` only is not allowed',
-      },
-    ],
-    'no-unused-vars': 0,
-    'no-use-before-define': 0,
-    'no-useless-constructor': 0,
-    // covered by @typescript-eslint/no-floating-promises
-    'promise/always-return': 0,
-    'promise/catch-or-return': 0,
-    // ts itself has guaranteed it
-    'unicorn/no-array-callback-reference': 0,
-    // covered by @typescript-eslint/no-extraneous-class
-    'unicorn/no-static-only-class': 0,
-    // covered by @typescript-eslint/no-this-alias
-    'unicorn/no-this-assignment': 0,
-  },
-})
+import {
+  isTsAvailable,
+  magicNumbers,
+  nonSourceRules,
+  prettierExtends,
+} from './_util.js'
+import { jsBase } from './js-base.js'
+import { js } from './js.js'
+import { reactJsx } from './react.js'
+import { test } from './test.js'
+import { resolveSettings, tsBase } from './ts-base.js'
 
 export const ts = tseslint.config(
   tsBase,
   {
     name: '@1stg/cli',
     files: ['**/{bin,cli}.ts'],
-    rules: {
-      'n/hashbang': 0,
-    },
+    rules: { 'n/hashbang': 0 },
   },
   {
     name: '@1stg/code-block',
@@ -264,12 +50,7 @@ export const ts = tseslint.config(
     ],
     extends: [tseslint.configs.recommendedTypeChecked],
     rules: {
-      '@typescript-eslint/no-floating-promises': [
-        2,
-        {
-          ignoreVoid: true,
-        },
-      ],
+      '@typescript-eslint/no-floating-promises': [2, { ignoreVoid: true }],
       '@typescript-eslint/no-magic-numbers': [
         2,
         {
@@ -290,9 +71,7 @@ export const ts = tseslint.config(
       '@typescript-eslint/prefer-string-starts-ends-with': 2,
       '@typescript-eslint/require-array-sort-compare': [
         2,
-        {
-          ignoreStringArrays: true,
-        },
+        { ignoreStringArrays: true },
       ],
       '@typescript-eslint/restrict-plus-operands': 2,
       'no-constant-condition': 0,
@@ -307,9 +86,7 @@ export const ts = tseslint.config(
   },
 )
 
-/**
- * @satisfies {TSESLint.FlatConfig.Config}
- */
+/** @satisfies {TSESLint.FlatConfig.Config} */
 export const dTs = {
   name: '@1stg/d-ts',
   files: ['**/*.d.{cts,mts,ts}', '**/*.d.*.{cts,mts,ts}'],
@@ -323,177 +100,22 @@ export const dTs = {
   },
 }
 
-const reactJsx = tseslint.config({
-  name: '@1stg/react-jsx',
-  extends: [react_.configs.recommended, prettierExtends],
-  settings: {
-    react: {
-      version: 'detect',
-    },
-  },
-})
-
-export const react = tseslint.config(
-  {
-    name: '@1stg/react',
-    files: ['**/*.{js,jsx,tsx}'],
-    extends: [reactJsx],
-    rules: {
-      '@eslint-react/avoid-shorthand-boolean': 2,
-      // '@eslint-react/naming-convention/handler-prop': [
-      //   2,
-      //   {
-      //     eventHandlerPrefix: false,
-      //     eventHandlerPropPrefix: 'on',
-      //   },
-      // ],
-      'sonarjs/function-name': isTsAvailable
-        ? [2, { format: String.raw`^_?[a-zA-Z][a-zA-Z0-9]*\$?$` }]
-        : 0,
-    },
-  },
-  {
-    name: '@1stg/react-tsx',
-    files: ['**/*.tsx'],
-    rules: {
-      '@eslint-react/display-name': 0,
-    },
-  },
-  {
-    name: '@1stg/react-hooks',
-    files: ['**/*.{js,jsx,ts,tsx}'],
-    plugins: { 'react-hooks': reactHooks_ },
-    rules: {
-      'react-hooks/rules-of-hooks': 2,
-      'react-hooks/exhaustive-deps': 2,
-    },
-  },
-  {
-    name: '@1stg/react-ts',
-    files: ['**/*.{ts,tsx}'],
-    rules: {
-      'no-restricted-imports': [2, 'prop-types'],
-      '@eslint-react/prop-types': 0,
-    },
-  },
-)
-
-const vueExtends = tseslint.config(
-  vue_.configs['flat/recommended'],
-  prettierExtends,
-)
-
-export const vue = tseslint.config(
-  {
-    ...jsBase,
-    name: '@1stg/js-vue',
-    files: /** @type {string[]} */ (
-      [...jsBase.files, !isTsAvailable && '**/*.vue'].filter(Boolean)
-    ),
-    languageOptions: {
-      parser: vueParser,
-      parserOptions: {
-        ...jsBase.languageOptions.parserOptions,
-        parser: babelParser,
-      },
-    },
-    extends: vueExtends,
-  },
-  isTsAvailable
-    ? {
-        name: '@1stg/ts-vue',
-        extends: [...tsBase, ...vueExtends],
-        files: [.../** @type {string[]} */ (tsBase[0].files), '**/*.vue'],
-        languageOptions: {
-          parser: vueParser,
-          parserOptions: {
-            parser: tseslint.parser,
-            extraFileExtensions: ['.vue'],
-          },
-        },
-      }
-    : [],
-  {
-    name: '@1stg/vue',
-    files: ['**/*.vue'],
-    extends: [
-      // 'plugin:markup/recommended',
-      ...vueExtends,
-    ],
-    rules: {
-      'no-unused-vars': 0,
-      '@typescript-eslint/no-unused-vars': 0,
-    },
-  },
-)
-
-export const angular = tseslint.config(
+export const markup = tseslint.config(
   {
-    name: '@1stg/angular-ts',
-    files: ['**/*.ts'],
-    ignores: ['**/*.d.ts'],
-    languageOptions: {
-      parserOptions: {
-        project,
-      },
-    },
-    extends: [angular_.configs.tsRecommended, prettierExtends],
-    processor: angular_.processInlineTemplates,
-    rules: {
-      '@angular-eslint/prefer-on-push-component-change-detection': 1,
-    },
-  },
-  {
-    name: '@1stg/angular-template',
+    name: '@1stg/markup-html',
     files: ['**/*.html'],
-    extends: [
-      angular_.configs.templateRecommended,
-      // 'plugin:markup/recommended',
-      prettierExtends,
-    ],
-    languageOptions: {
-      parser: angularTemplateParser,
-    },
+    extends: [markup_.configs.flatRecommended],
     rules: {
-      '@angular-eslint/template/eqeqeq': [
-        2,
-        {
-          allowNullOrUndefined: true,
-        },
-      ],
-      'prettier/prettier': preferPrettier ? 0 : [2, { parser: 'angular' }],
-      'spaced-comment': 0,
+      'prettier/prettier': [preferPrettier ? 0 : 2, { parser: 'html' }],
     },
   },
   {
-    files: ['**/*inline-template-*.component.html'],
-    rules: {
-      'unicorn/no-empty-file': 0,
-    },
+    name: '@1stg/markup-pug',
+    files: ['**/*.pug'],
+    extends: [markup_.configs.flatRecommended, ...prettierExtends],
   },
 )
 
-/* eslint-disable sonarjs/no-commented-code */
-// export const markup = [
-//   {
-//     files: '**/*.html',
-//     extends: 'plugin:markup/recommended',
-//     rules: {
-//       'prettier/prettier': [
-//         preferPrettier ? 0 : 2,
-//         {
-//           parser: 'html',
-//         },
-//       ],
-//     },
-//   },
-//   {
-//     files: '**/*.pug',
-//     extends: ['plugin:markup/recommended', ...prettierExtends],
-//   },
-// ]
-/* eslint-enable sonarjs/no-commented-code */
-
 export const md = tseslint.config(
   {
     name: '@1stg/md',
@@ -523,46 +145,7 @@ export const mdx = tseslint.config(
   mdx_.configs.flatCodeBlocks,
 )
 
-const nonSourceRules = /** @type {const} */ ({
-  'n/no-extraneous-import': 0,
-  'n/no-extraneous-require': 0,
-  'n/no-unsupported-features/es-builtins': 0,
-})
-
-/**
- * @satisfies {TSESLint.FlatConfig.Config}
- */
-export const test = {
-  name: '@1stg/test',
-  files: ['**/{__test__,test,tests}/**/*'],
-  rules: nonSourceRules,
-}
-
-export const tests = test
-
-export const jest = tseslint.config({
-  name: '@1stg/jest',
-  files: ['**/*.{spec,test}.{js,jsx,ts,tsx}'],
-  extends: [jest_.configs['flat/recommended']],
-  languageOptions: {
-    globals: globals.jest,
-  },
-  rules: test.rules,
-})
-
-export const vitest = tseslint.config({
-  name: '@1stg/vitest',
-  files: ['**/*.{spec,test}.{js,jsx,ts,tsx}'],
-  extends: [vitest_.configs.recommended],
-  languageOptions: {
-    globals: globals.vitest,
-  },
-  rules: test.rules,
-})
-
-/**
- * @satisfies {TSESLint.FlatConfig.Config}
- */
+/** @satisfies {TSESLint.FlatConfig.Config} */
 export const script = {
   name: '@1stg/script',
   files: ['**/scripts/**/*'],
@@ -571,9 +154,7 @@ export const script = {
 
 export const scripts = script
 
-/**
- * @satisfies {TSESLint.FlatConfig.Config}
- */
+/** @satisfies {TSESLint.FlatConfig.Config} */
 export const story = {
   name: '@1stg/story',
   files: ['**/.storybook/**/*', '**/stories/**/*'],
@@ -582,9 +163,7 @@ export const story = {
 
 export const stories = story
 
-/**
- * @satisfies {TSESLint.FlatConfig.Config}
- */
+/** @satisfies {TSESLint.FlatConfig.Config} */
 export const config = {
   name: '@1stg/config',
   files: ['**/.*.js', '**/*.config.{js,ts}'],
@@ -634,20 +213,28 @@ export const yaml = tseslint.config({
 
 export const yml = yaml
 
-const isReactAvailable = isPkgAvailable('react')
-
 export const overrides = tseslint.config(
-  isPkgAvailable('@babel/core') ? js : [],
+  js,
   isTsAvailable ? ts : [],
-  isReactAvailable ? react : [],
+  isPkgAvailable('@eslint-react/eslint-plugin')
+    ? await import('./react.js').then(({ react }) => react)
+    : [],
   // The order matters, the later should to be preferred
-  // markup,
-  isPkgAvailable('vue') ? vue : [],
-  isPkgAvailable('@angular/core') ? angular : [],
+  markup,
+  isPkgAvailable('eslint-plugin-vue')
+    ? await import('./vue.js').then(({ vue }) => vue)
+    : [],
+  isPkgAvailable('angular-eslint')
+    ? await import('./angular.js').then(({ angular }) => angular)
+    : [],
   md,
   mdx,
-  isPkgAvailable('jest') ? jest : [],
-  isPkgAvailable('vitest') ? vitest : [],
+  isPkgAvailable('eslint-plugin-jest')
+    ? await import('./jest.js').then(({ jest }) => jest)
+    : [],
+  isPkgAvailable('@vitest/eslint-plugin')
+    ? await import('./vitest.js').then(({ vitest }) => vitest)
+    : [],
   test,
   scripts,
   stories,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@1stg/eslint-config",
-  "version": "8.4.0",
+  "version": "9.0.0",
   "type": "module",
   "description": "Personal but Shareable ESLint Configuration for all 1stG.me projects",
   "repository": "https://github.com/1stG/configs.git",
@@ -21,26 +21,57 @@
     "./recommended": "./recommended.js"
   },
   "peerDependencies": {
-    "eslint": ">=8.0.0"
+    "@babel/eslint-parser": "^7.0.0",
+    "@babel/eslint-plugin": "^7.0.0",
+    "@eslint-react/eslint-plugin": "^1.0.0",
+    "@vitest/eslint-plugin": "^1.0.0",
+    "angular-eslint": "^19.0.0",
+    "angular-eslint-template-parser": "^0.1.0",
+    "eslint": ">=8.0.0",
+    "eslint-plugin-jest": "^28.0.0",
+    "eslint-plugin-react-hooks": "^5.0.0",
+    "eslint-plugin-vue": "^10.0.0"
+  },
+  "peerDependenciesMeta": {
+    "@babel/eslint-parser": {
+      "optional": true
+    },
+    "@babel/eslint-plugin": {
+      "optional": true
+    },
+    "@eslint-react/eslint-plugin": {
+      "optional": true
+    },
+    "@vitest/eslint-plugin": {
+      "optional": true
+    },
+    "angular-eslint": {
+      "optional": true
+    },
+    "angular-eslint-template-parser": {
+      "optional": true
+    },
+    "eslint-plugin-jest": {
+      "optional": true
+    },
+    "eslint-plugin-react-hooks": {
+      "optional": true
+    },
+    "eslint-plugin-vue": {
+      "optional": true
+    }
   },
   "dependencies": {
-    "@1stg/config": "^1.0.3",
-    "@babel/eslint-parser": "^7.27.0",
-    "@babel/eslint-plugin": "^7.27.0",
-    "@eslint-community/eslint-plugin-eslint-comments": "^4.4.1",
-    "@eslint-react/eslint-plugin": "^1.40.3",
+    "@1stg/config": "^1.0.4",
+    "@eslint-community/eslint-plugin-eslint-comments": "^4.5.0",
     "@eslint/js": "^9.24.0",
-    "@pkgr/utils": "^3.1.0",
-    "@typescript-eslint/eslint-plugin": "^8.29.0",
-    "@typescript-eslint/parser": "^8.29.0",
-    "@vitest/eslint-plugin": "^1.1.39",
-    "angular-eslint": "^19.3.0",
-    "angular-eslint-template-parser": "^0.1.3",
-    "eslint-config-prettier": "^10.1.1",
-    "eslint-import-resolver-typescript": "^4.3.1",
+    "@pkgr/utils": "^3.1.1",
+    "@typescript-eslint/eslint-plugin": "^8.29.1",
+    "@typescript-eslint/parser": "^8.29.1",
+    "eslint-config-prettier": "^10.1.2",
+    "eslint-import-resolver-typescript": "^4.3.2",
     "eslint-plugin-css": "^0.11.0",
-    "eslint-plugin-import-x": "^4.10.1",
-    "eslint-plugin-jest": "^28.11.0",
+    "eslint-plugin-import-x": "^4.10.3",
     "eslint-plugin-jsdoc": "^50.6.9",
     "eslint-plugin-jsonc": "^2.20.0",
     "eslint-plugin-markup": "^1.0.0",
@@ -48,16 +79,14 @@
     "eslint-plugin-n": "^17.17.0",
     "eslint-plugin-prettier": "^5.2.6",
     "eslint-plugin-promise": "^7.2.1",
-    "eslint-plugin-react-hooks": "^5.2.0",
     "eslint-plugin-regexp": "^2.7.0",
     "eslint-plugin-simple-import-sort": "^12.1.1",
     "eslint-plugin-sonarjs": "^3.0.2",
     "eslint-plugin-toml": "^0.12.0",
     "eslint-plugin-unicorn": "^58.0.0",
-    "eslint-plugin-vue": "^10.0.0",
     "eslint-plugin-yml": "^1.17.0",
     "globals": "^16.0.0",
-    "typescript-eslint": "^8.29.0"
+    "typescript-eslint": "^8.29.1"
   },
   "publishConfig": {
     "access": "public"

package/react.js

@@ -0,0 +1,66 @@
+// @ts-check
+
+import react_ from '@eslint-react/eslint-plugin'
+import { tryRequirePkg } from '@pkgr/utils'
+import tseslint from 'typescript-eslint'
+
+import { isTsAvailable, prettierExtends } from './_util.js'
+
+export const reactJsx = tseslint.config({
+  name: '@1stg/react-jsx',
+  extends: [react_.configs.recommended, prettierExtends],
+  settings: {
+    react: {
+      version: 'detect',
+    },
+  },
+})
+
+const reactHooks_ = tryRequirePkg('eslint-plugin-react-hooks')
+
+export const react = tseslint.config(
+  {
+    name: '@1stg/react',
+    files: ['**/*.{js,jsx,tsx}'],
+    extends: [reactJsx],
+    rules: {
+      '@eslint-react/avoid-shorthand-boolean': 2,
+      // '@eslint-react/naming-convention/handler-prop': [
+      //   2,
+      //   {
+      //     eventHandlerPrefix: false,
+      //     eventHandlerPropPrefix: 'on',
+      //   },
+      // ],
+      'sonarjs/function-name': isTsAvailable
+        ? [2, { format: String.raw`^_?[a-zA-Z][a-zA-Z0-9]*\$?$` }]
+        : 0,
+    },
+  },
+  {
+    name: '@1stg/react-tsx',
+    files: ['**/*.tsx'],
+    rules: {
+      '@eslint-react/display-name': 0,
+    },
+  },
+  reactHooks_
+    ? {
+        name: '@1stg/react-hooks',
+        files: ['**/*.{js,jsx,ts,tsx}'],
+        plugins: { 'react-hooks': reactHooks_ },
+        rules: {
+          'react-hooks/rules-of-hooks': 2,
+          'react-hooks/exhaustive-deps': 2,
+        },
+      }
+    : [],
+  {
+    name: '@1stg/react-ts',
+    files: ['**/*.{ts,tsx}'],
+    rules: {
+      'no-restricted-imports': [2, 'prop-types'],
+      '@eslint-react/prop-types': 0,
+    },
+  },
+)

package/test.js

@@ -0,0 +1,14 @@
+// @ts-check
+
+/** @import {TSESLint} from '@typescript-eslint/utils' */
+
+import { nonSourceRules } from './_util.js'
+
+/** @satisfies {TSESLint.FlatConfig.Config} */
+export const test = {
+  name: '@1stg/test',
+  files: ['**/{__test__,test,tests}/**/*'],
+  rules: nonSourceRules,
+}
+
+export const tests = test

package/ts-base.js

@@ -0,0 +1,138 @@
+// @ts-check
+
+import { createTypeScriptImportResolver } from 'eslint-import-resolver-typescript'
+import importX from 'eslint-plugin-import-x'
+import tseslint from 'typescript-eslint'
+
+import { prettierExtends, project } from './_util.js'
+
+export const resolveSettings = {
+  'import-x/external-module-folders': [
+    'node_modules',
+    'node_modules/@d-ts',
+    'node_modules/@types',
+  ],
+  'import-x/resolver-next': [
+    createTypeScriptImportResolver({
+      alwaysTryTypes: true,
+      project,
+    }),
+  ],
+}
+
+export const tsBase = tseslint.config({
+  name: '@1stg/ts-base',
+  files: ['**/*.{cts,mts,ts,tsx}'],
+  languageOptions: {
+    parserOptions: {
+      project,
+    },
+  },
+  extends: [
+    tseslint.configs.eslintRecommended,
+    tseslint.configs.recommended,
+    importX.flatConfigs.typescript,
+    prettierExtends,
+  ],
+  settings: resolveSettings,
+  rules: {
+    '@typescript-eslint/adjacent-overload-signatures': 2,
+    '@typescript-eslint/array-type': [
+      2,
+      {
+        default: 'array-simple',
+      },
+    ],
+    '@typescript-eslint/ban-ts-comment': 0,
+    '@typescript-eslint/consistent-type-definitions': [2, 'interface'],
+    '@typescript-eslint/explicit-function-return-type': 0,
+    '@typescript-eslint/explicit-member-accessibility': [
+      2,
+      {
+        accessibility: 'no-public',
+        overrides: {
+          parameterProperties: 'off',
+        },
+      },
+    ],
+    '@typescript-eslint/explicit-module-boundary-types': 0,
+    '@typescript-eslint/member-ordering': 2,
+    // eslint-disable-line sonarjs/todo-tag -- TODO: find better config
+    '@typescript-eslint/naming-convention': 0,
+    '@typescript-eslint/no-empty-function': 2,
+    '@typescript-eslint/no-extraneous-class': [
+      2,
+      {
+        allowWithDecorator: true,
+      },
+    ],
+    '@typescript-eslint/no-for-in-array': 2,
+    '@typescript-eslint/no-non-null-assertion': 0,
+    '@typescript-eslint/no-parameter-properties': 0,
+    '@typescript-eslint/no-require-imports': 2,
+    '@typescript-eslint/no-this-alias': [
+      2,
+      {
+        allowDestructuring: true,
+        allowedNames: ['self'],
+      },
+    ],
+    '@typescript-eslint/no-use-before-define': [
+      2,
+      {
+        classes: false,
+        functions: false,
+      },
+    ],
+    '@typescript-eslint/no-useless-constructor': 2,
+    '@typescript-eslint/no-unused-vars': [
+      2,
+      {
+        argsIgnorePattern: '^_',
+        varsIgnorePattern: '^_',
+      },
+    ],
+    '@typescript-eslint/prefer-for-of': 2,
+    '@typescript-eslint/prefer-function-type': 2,
+    '@typescript-eslint/prefer-ts-expect-error': 2,
+    '@typescript-eslint/sort-type-constituents': 2,
+    '@typescript-eslint/triple-slash-reference': [
+      2,
+      {
+        lib: 'never',
+        path: 'always',
+        types: 'prefer-import',
+      },
+    ],
+    '@typescript-eslint/unified-signatures': 2,
+    camelcase: 0,
+    'import-x/default': 0,
+    'import-x/named': 0,
+    'import-x/namespace': 0,
+    'import-x/no-duplicates': 2,
+    'import-x/no-named-as-default': 0,
+    'import-x/no-named-as-default-member': 0,
+    'no-empty-function': 0,
+    'no-restricted-syntax': [
+      2,
+      {
+        selector:
+          'TSTypeAliasDeclaration > .typeAnnotation[type=/^(TS.*Keyword|TSTypeReference)$/]:not(:has(TSTypeParameterInstantiation)):not(:has(TSQualifiedName))',
+        message:
+          'Type alias references simple `Ts*Keyword`s or `TSTypeReference` only is not allowed',
+      },
+    ],
+    'no-unused-vars': 0,
+    'no-use-before-define': 0,
+    'no-useless-constructor': 0,
+    // covered by @typescript-eslint/no-floating-promises
+    'promise/always-return': 0,
+    'promise/catch-or-return': 0,
+    // ts itself has guaranteed it
+    'unicorn/no-array-callback-reference': 0,
+    // covered by @typescript-eslint/no-extraneous-class
+    'unicorn/no-static-only-class': 0,
+    // covered by @typescript-eslint/no-this-alias
+    'unicorn/no-this-assignment': 0,
+  },
+})

package/vitest.js

@@ -0,0 +1,17 @@
+// @ts-check
+
+import vitest_ from '@vitest/eslint-plugin'
+import globals from 'globals'
+import tseslint from 'typescript-eslint'
+
+import { test } from './test.js'
+
+export const vitest = tseslint.config({
+  name: '@1stg/vitest',
+  files: ['**/*.{spec,test}.{js,jsx,ts,tsx}'],
+  extends: [vitest_.configs.recommended],
+  languageOptions: {
+    globals: globals.vitest,
+  },
+  rules: test.rules,
+})

package/vue.js

@@ -0,0 +1,57 @@
+// @ts-check
+
+import babelParser from '@babel/eslint-parser'
+import * as markup from 'eslint-plugin-markup'
+import vue_ from 'eslint-plugin-vue'
+import tseslint from 'typescript-eslint'
+import vueParser from 'vue-eslint-parser'
+
+import { isTsAvailable, prettierExtends } from './_util.js'
+import { jsBase } from './js-base.js'
+import { tsBase } from './ts-base.js'
+
+const vueExtends = tseslint.config(
+  vue_.configs['flat/recommended'],
+  prettierExtends,
+)
+
+export const vue = tseslint.config(
+  {
+    ...jsBase,
+    name: '@1stg/js-vue',
+    files: /** @type {string[]} */ (
+      [...jsBase.files, !isTsAvailable && '**/*.vue'].filter(Boolean)
+    ),
+    languageOptions: {
+      parser: vueParser,
+      parserOptions: {
+        ...jsBase.languageOptions.parserOptions,
+        parser: babelParser,
+      },
+    },
+    extends: vueExtends,
+  },
+  isTsAvailable
+    ? {
+        name: '@1stg/ts-vue',
+        extends: [...tsBase, ...vueExtends],
+        files: [.../** @type {string[]} */ (tsBase[0].files), '**/*.vue'],
+        languageOptions: {
+          parser: vueParser,
+          parserOptions: {
+            parser: tseslint.parser,
+            extraFileExtensions: ['.vue'],
+          },
+        },
+      }
+    : [],
+  {
+    name: '@1stg/vue',
+    files: ['**/*.vue'],
+    extends: [markup.configs.flatRecommended, ...vueExtends],
+    rules: {
+      'no-unused-vars': 0,
+      '@typescript-eslint/no-unused-vars': 0,
+    },
+  },
+)