@1mancompany/onemancompany 0.7.27 → 0.7.30

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@1mancompany/onemancompany",
-  "version": "0.7.27",
+  "version": "0.7.30",
   "description": "The AI Operating System for One-Person Companies",
   "bin": {
     "onemancompany": "bin/cli.js"

package/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "onemancompany"
-version = "0.7.27"
+version = "0.7.30"
 description = "A one-man company simulation with pixel art visualization and LangChain AI agents"
 requires-python = ">=3.12"
 dependencies = [

package/src/onemancompany/api/routes.py

@@ -7197,8 +7197,11 @@ async def api_list_issues(slug: str, status: str = "", priority: str = "") -> li
     from onemancompany.core import product as prod
     from onemancompany.core.models import IssuePriority, IssueStatus
 
-    status_filter = IssueStatus(status) if status else None
-    priority_filter = IssuePriority(priority) if priority else None
+    try:
+        status_filter = IssueStatus(status) if status else None
+        priority_filter = IssuePriority(priority) if priority else None
+    except ValueError as exc:
+        raise HTTPException(status_code=400, detail=str(exc))
     return prod.list_issues(slug, status=status_filter, priority=priority_filter)
 
 
@@ -7223,13 +7226,17 @@ async def api_update_issue(slug: str, issue_id: str, request: Request) -> dict:
     ISSUE_MUTABLE_FIELDS = {"title", "status", "priority", "assignee_id", "labels", "milestone_version", "description", "story_points", "sprint"}
     body = await request.json()
     filtered = {k: v for k, v in body.items() if k in ISSUE_MUTABLE_FIELDS}
-    if "status" in filtered:
-        filtered["status"] = _IS(filtered["status"]).value
-    if "priority" in filtered:
-        filtered["priority"] = _IP2(filtered["priority"]).value
-    result = prod.update_issue(slug, issue_id, **filtered)
-    if not result:
-        raise HTTPException(status_code=404, detail=f"Issue '{issue_id}' not found")
+    try:
+        if "status" in filtered:
+            filtered["status"] = _IS(filtered["status"]).value
+        if "priority" in filtered:
+            filtered["priority"] = _IP2(filtered["priority"]).value
+    except ValueError as exc:
+        raise HTTPException(status_code=400, detail=str(exc))
+    try:
+        result = prod.update_issue(slug, issue_id, **filtered)
+    except ValueError as exc:
+        raise HTTPException(status_code=404, detail=str(exc))
 
     # Publish ISSUE_ASSIGNED event when assignee changes
     if "assignee_id" in filtered and filtered["assignee_id"]:
@@ -7257,9 +7264,14 @@ async def api_close_issue(slug: str, issue_id: str, request: Request) -> dict:
 
     body = await request.json() if request.headers.get("content-length", "0") != "0" else {}
     resolution_str = body.get("resolution", "fixed")
-    result = prod.close_issue(slug, issue_id, resolution=IssueResolution(resolution_str))
-    if not result:
-        raise HTTPException(status_code=404, detail=f"Issue '{issue_id}' not found")
+    try:
+        resolution = IssueResolution(resolution_str)
+    except ValueError as exc:
+        raise HTTPException(status_code=400, detail=str(exc))
+    try:
+        result = prod.close_issue(slug, issue_id, resolution=resolution)
+    except ValueError as exc:
+        raise HTTPException(status_code=404, detail=str(exc))
     await event_bus.publish(
         CompanyEvent(
             type=EventType.ISSUE_CLOSED,
@@ -7275,9 +7287,10 @@ async def api_reopen_issue(slug: str, issue_id: str) -> dict:
     """Reopen a closed issue."""
     from onemancompany.core import product as prod
 
-    result = prod.reopen_issue(slug, issue_id)
-    if not result:
-        raise HTTPException(status_code=404, detail=f"Issue '{issue_id}' not found")
+    try:
+        result = prod.reopen_issue(slug, issue_id)
+    except ValueError as exc:
+        raise HTTPException(status_code=404, detail=str(exc))
     return result
 
 

package/src/onemancompany/core/product.py

@@ -287,9 +287,11 @@ def create_issue(
     sprint: str | None = None,
 ) -> dict:
     """Create an issue for a product. Returns the issue dict."""
-    issue_id = _gen_id("issue_")
     product = load_product(slug)
-    product_id = product["id"] if product else ""
+    if not product:
+        raise ValueError(f"Product '{slug}' not found")
+    issue_id = _gen_id("issue_")
+    product_id = product["id"]
     now = datetime.now().isoformat()
 
     data = {
@@ -380,14 +382,13 @@ def list_issues(
     return results
 
 
-def update_issue(slug: str, issue_id: str, **fields) -> dict | None:
-    """Update issue fields. Returns updated dict or None if not found."""
+def update_issue(slug: str, issue_id: str, **fields) -> dict:
+    """Update issue fields. Returns updated dict. Raises ValueError if not found."""
     with _get_slug_lock(slug):
         path = _issues_dir(slug) / f"{issue_id}.yaml"
         data = _read_yaml(path)
         if not data:
-            logger.warning("update_issue: issue {} not found in {}", issue_id, slug)
-            return None
+            raise ValueError(f"Issue '{issue_id}' not found in product '{slug}'")
         for key, value in fields.items():
             if value is not None:
                 old_value = data.get(key)
@@ -404,14 +405,13 @@ def close_issue(
     issue_id: str,
     *,
     resolution: IssueResolution = IssueResolution.FIXED,
-) -> dict | None:
-    """Close an issue with a resolution. Returns updated dict or None."""
+) -> dict:
+    """Close an issue with a resolution. Returns updated dict. Raises ValueError if not found."""
     with _get_slug_lock(slug):
         path = _issues_dir(slug) / f"{issue_id}.yaml"
         data = _read_yaml(path)
         if not data:
-            logger.warning("close_issue: issue {} not found in {}", issue_id, slug)
-            return None
+            raise ValueError(f"Issue '{issue_id}' not found in product '{slug}'")
         old_status = data.get("status")
         _append_history(data, "status", old_status, IssueStatus.DONE.value, changed_by="system")
         data["status"] = IssueStatus.DONE.value
@@ -423,14 +423,13 @@ def close_issue(
     return data
 
 
-def reopen_issue(slug: str, issue_id: str) -> dict | None:
-    """Reopen a closed issue. Increments reopened_count. Returns updated dict or None."""
+def reopen_issue(slug: str, issue_id: str) -> dict:
+    """Reopen a closed issue. Increments reopened_count. Returns updated dict. Raises ValueError if not found."""
     with _get_slug_lock(slug):
         path = _issues_dir(slug) / f"{issue_id}.yaml"
         data = _read_yaml(path)
         if not data:
-            logger.warning("reopen_issue: issue {} not found in {}", issue_id, slug)
-            return None
+            raise ValueError(f"Issue '{issue_id}' not found in product '{slug}'")
         old_status = data.get("status")
         _append_history(data, "status", old_status, IssueStatus.BACKLOG.value, changed_by="system")
         data["status"] = IssueStatus.BACKLOG.value
@@ -478,6 +477,13 @@ def add_issue_link(
     rel_value = relation.value if hasattr(relation, "value") else relation
     reverse_rel = _REVERSE_RELATION[rel_value]
 
+    # Circular dependency check for blocking relations
+    if rel_value == IssueRelation.BLOCKS.value:
+        _check_block_cycle(slug, issue_id, target_id)
+    elif rel_value == IssueRelation.BLOCKED_BY.value:
+        # blocked_by is the reverse: target blocks issue
+        _check_block_cycle(slug, target_id, issue_id)
+
     # Add forward link (idempotent)
     _add_link_entry(slug, issue_id, target_id, rel_value)
     # Add reverse link
@@ -487,6 +493,34 @@ def add_issue_link(
     logger.debug("Linked {} —{}→ {}", issue_id, rel_value, target_id)
 
 
+def _check_block_cycle(slug: str, blocker_id: str, blocked_id: str) -> None:
+    """Raise ValueError if adding 'blocker_id blocks blocked_id' would create a cycle.
+
+    Walks the existing 'blocks' graph starting from blocked_id to see if
+    blocker_id is reachable (meaning blocked_id already transitively blocks blocker_id).
+    """
+    visited: set[str] = set()
+    queue = [blocked_id]
+    while queue:
+        current = queue.pop()
+        if current in visited:
+            continue
+        visited.add(current)
+        issue = load_issue(slug, current)
+        if not issue:
+            continue
+        for link in issue.get("issue_links", []):
+            if link["relation"] != IssueRelation.BLOCKS.value:
+                continue
+            downstream = link["issue_id"]
+            if downstream == blocker_id:
+                raise ValueError(
+                    f"Circular dependency: {blocked_id} already transitively "
+                    f"blocks {blocker_id}"
+                )
+            queue.append(downstream)
+
+
 def _add_link_entry(slug: str, issue_id: str, target_id: str, relation: str) -> None:
     """Add a single link entry to an issue (idempotent)."""
     with _get_slug_lock(slug):