@1agh/maude 0.58.0 → 0.58.2

package/apps/studio/client/panels/timeline-media-cache.js

@@ -80,7 +80,10 @@ export function stripBucket(widthPx) {
   return 7;
 }
 
-async function extractStrip(url, count) {
+/** Hidden <video>, loaded and waited on through `loadedmetadata`/`canplay` so
+ *  `.duration`/`.videoWidth`/`.videoHeight` are readable. Caller owns cleanup
+ *  (`video.remove()`) once done with it. */
+async function loadVideoMetadata(url, timeoutMs) {
   const video = document.createElement('video');
   video.muted = true;
   video.playsInline = true;
@@ -99,7 +102,7 @@ async function extractStrip(url, count) {
   }
   try {
     await new Promise((res, rej) => {
-      const to = setTimeout(() => rej(new Error('metadata timeout')), 8000);
+      const to = setTimeout(() => rej(new Error('metadata timeout')), timeoutMs);
       const ok = () => {
         clearTimeout(to);
         res();
@@ -114,6 +117,39 @@ async function extractStrip(url, count) {
     });
   } catch (err) {
     video.remove();
+    throw err;
+  }
+  return video;
+}
+
+/** Real duration (seconds) of a video/audio src, probed via a hidden <video>
+ *  element — never throws, resolves null on failure so callers (e.g. the
+ *  timeline drop handler) can fall back to a default duration cleanly. */
+export async function probeMediaDuration(url) {
+  let video;
+  try {
+    video = await loadVideoMetadata(url, 6000);
+  } catch {
+    return null;
+  }
+  const dur = video.duration;
+  video.remove();
+  return Number.isFinite(dur) && dur > 0 ? dur : null;
+}
+
+/** durationInFrames for a clip dropped on the timeline: the real probed
+ *  duration when available, else a fallback (probe failure, or synthetic
+ *  content with no inherent duration like a title/image). */
+export function durationFramesForDrop(fps, probedSeconds, fallbackSeconds = 3) {
+  const sec = Number.isFinite(probedSeconds) && probedSeconds > 0 ? probedSeconds : fallbackSeconds;
+  return Math.max(1, Math.round(fps * sec));
+}
+
+async function extractStrip(url, count) {
+  let video;
+  try {
+    video = await loadVideoMetadata(url, 8000);
+  } catch (err) {
     console.warn('[timeline] filmstrip extraction failed for', url, err?.message || err);
     throw err;
   }

package/apps/studio/client/styles/6-acp-chat.css

@@ -1235,6 +1235,18 @@
   .chat-qa {
     font-family: var(--font-mono);
   }
+  /* Issue #74 — the "Implement N comments" action. Its siblings are literal
+     slash commands (hence mono); this one is prose ABOUT the canvas's current
+     state and only appears when there is something to act on, so it reads as
+     the row's contextual action: proportional type + a light accent tint. */
+  .chat-qa--comments {
+    font-family: inherit;
+    border-color: var(--accent-muted);
+    color: var(--accent);
+  }
+  .chat-qa--comments:hover {
+    background: var(--accent-tint);
+  }
 
   /* Composer */
   .chat-composer {

package/apps/studio/clip-ops.ts

@@ -1802,26 +1802,51 @@ export function applyMoveClipToOverlay(
     });
   }
   const mediaStart = directMediaTagStart(source, clip);
-  if (mediaStart == null || !clip.mediaSrc || clip.durationInFrames == null) {
-    throw new CanvasEditError('only a media clip with a direct source can move between layers', {
-      canvas: canvasAbsPath,
-      id: stableId,
-    });
+  const isPlaceholder = clip.placeholder != null;
+  if (!isPlaceholder && (mediaStart == null || !clip.mediaSrc || clip.durationInFrames == null)) {
+    throw new CanvasEditError(
+      'only a media clip with a direct source, or an AI placeholder, can move between layers',
+      { canvas: canvasAbsPath, id: stableId }
+    );
+  }
+  if (isPlaceholder && clip.durationInFrames == null) {
+    throw new CanvasEditError(
+      'only a media clip with a direct source, or an AI placeholder, can move between layers',
+      { canvas: canvasAbsPath, id: stableId }
+    );
   }
   const start = clipAbsoluteStart(source, canvasAbsPath, artboardId, stableId);
-  const trim =
-    numAttrText(source, mediaStart, 'trimBefore') ??
-    numAttrText(source, mediaStart, 'startFrom') ??
-    0;
-  const rate = numAttrText(source, mediaStart, 'playbackRate') ?? 1;
-  const ins = applyInsertClipAt(canvasAbsPath, source, artboardId, {
-    lane: 'overlay',
-    from: start,
-    durationInFrames: clip.durationInFrames,
-    mediaTag: clip.mediaTag === 'Audio' ? 'Audio' : 'Video',
-    src: clip.mediaSrc,
-  });
-  let out = graftMediaAttrs(canvasAbsPath, ins.source, artboardId, ins.stableId, trim, rate);
+  // A placeholder slate has no media element to graft trim/rate onto — it
+  // rides over as-is (prompt + kind), never as media.
+  const ins = isPlaceholder
+    ? applyInsertClipAt(canvasAbsPath, source, artboardId, {
+        lane: 'overlay',
+        from: start,
+        durationInFrames: clip.durationInFrames as number,
+        placeholder: {
+          prompt: clip.placeholder?.prompt ?? '',
+          kind: clip.placeholder?.kind ?? 'veo',
+        },
+      })
+    : applyInsertClipAt(canvasAbsPath, source, artboardId, {
+        lane: 'overlay',
+        from: start,
+        durationInFrames: clip.durationInFrames as number,
+        mediaTag: clip.mediaTag === 'Audio' ? 'Audio' : 'Video',
+        src: clip.mediaSrc,
+      });
+  let out = isPlaceholder
+    ? ins.source
+    : graftMediaAttrs(
+        canvasAbsPath,
+        ins.source,
+        artboardId,
+        ins.stableId,
+        numAttrText(source, mediaStart as number, 'trimBefore') ??
+          numAttrText(source, mediaStart as number, 'startFrom') ??
+          0,
+        numAttrText(source, mediaStart as number, 'playbackRate') ?? 1
+      );
   const again = enumerateClips(canvasAbsPath, out, artboardId);
   const insertedHash = again.clips.find((c) => c.stableId === ins.stableId)?.contentHash ?? null;
   const original = again.clips.find(
@@ -1861,24 +1886,48 @@ export function applyMoveClipToStoryline(
     throw new CanvasEditError('already a storyline beat', { canvas: canvasAbsPath, id: stableId });
   }
   const mediaStart = directMediaTagStart(source, clip);
-  if (mediaStart == null || !clip.mediaSrc || clip.durationInFrames == null) {
-    throw new CanvasEditError('only a media clip with a direct source can move between layers', {
-      canvas: canvasAbsPath,
-      id: stableId,
-    });
+  const isPlaceholder = clip.placeholder != null;
+  if (!isPlaceholder && (mediaStart == null || !clip.mediaSrc || clip.durationInFrames == null)) {
+    throw new CanvasEditError(
+      'only a media clip with a direct source, or an AI placeholder, can move between layers',
+      { canvas: canvasAbsPath, id: stableId }
+    );
   }
-  const trim =
-    numAttrText(source, mediaStart, 'trimBefore') ??
-    numAttrText(source, mediaStart, 'startFrom') ??
-    0;
-  const rate = numAttrText(source, mediaStart, 'playbackRate') ?? 1;
-  const ins = applyInsertClipAt(canvasAbsPath, source, artboardId, {
-    lane: 'storyline',
-    durationInFrames: clip.durationInFrames,
-    mediaTag: clip.mediaTag === 'Audio' ? 'Audio' : 'Video',
-    src: clip.mediaSrc,
-  });
-  let out = graftMediaAttrs(canvasAbsPath, ins.source, artboardId, ins.stableId, trim, rate);
+  if (isPlaceholder && clip.durationInFrames == null) {
+    throw new CanvasEditError(
+      'only a media clip with a direct source, or an AI placeholder, can move between layers',
+      { canvas: canvasAbsPath, id: stableId }
+    );
+  }
+  // A placeholder slate has no media element to graft trim/rate onto — it
+  // rides over as-is (prompt + kind), never as media.
+  const ins = isPlaceholder
+    ? applyInsertClipAt(canvasAbsPath, source, artboardId, {
+        lane: 'storyline',
+        durationInFrames: clip.durationInFrames as number,
+        placeholder: {
+          prompt: clip.placeholder?.prompt ?? '',
+          kind: clip.placeholder?.kind ?? 'veo',
+        },
+      })
+    : applyInsertClipAt(canvasAbsPath, source, artboardId, {
+        lane: 'storyline',
+        durationInFrames: clip.durationInFrames as number,
+        mediaTag: clip.mediaTag === 'Audio' ? 'Audio' : 'Video',
+        src: clip.mediaSrc,
+      });
+  let out = isPlaceholder
+    ? ins.source
+    : graftMediaAttrs(
+        canvasAbsPath,
+        ins.source,
+        artboardId,
+        ins.stableId,
+        numAttrText(source, mediaStart as number, 'trimBefore') ??
+          numAttrText(source, mediaStart as number, 'startFrom') ??
+          0,
+        numAttrText(source, mediaStart as number, 'playbackRate') ?? 1
+      );
   const again = enumerateClips(canvasAbsPath, out, artboardId);
   const insertedHash = again.clips.find((c) => c.stableId === ins.stableId)?.contentHash ?? null;
   const original = again.clips.find(