@1agh/maude 0.53.2 → 0.55.0

package/apps/studio/client/panels/CloudBar.jsx

@@ -14,7 +14,7 @@
 
 import { useEffect, useRef, useState } from 'react';
 
-import { invoke, isNativeApp, listen } from '../github.js';
+import { invoke, isNativeApp, listen, openCloudUrl } from '../github.js';
 
 const api = async (path, init) => {
   const res = await fetch(path, init);
@@ -22,6 +22,87 @@ const api = async (path, init) => {
   return { ok: res.ok, status: res.status, json };
 };
 
+/**
+ * Reach the OS browser from whichever surface this is running on.
+ *
+ * In the desktop shell `window.open` does nothing at all — WKWebView drops it
+ * silently — which is what used to strand a person mid-sign-in holding a code
+ * and no page to type it into. The shell therefore goes through the Rust
+ * opener, which zone-locks the URL against the configured cloud address (the
+ * webview is untrusted, DDR-054: there is deliberately no general opener).
+ *
+ * Best-effort by design: an older shell has no such command, a self-hosted
+ * origin can drift, and the browser can block the popup — so every caller ALSO
+ * shows the address as something the person can click or copy by hand.
+ */
+/**
+ * Is this an address we are willing to render as a link at all?
+ *
+ * The zone lock lives in Rust, but the dialog SHOWS the address and offers to
+ * copy it — so an off-zone `verification_url` (hostile/compromised control
+ * plane, MITM'd plaintext self-host) would be presented in trusted app chrome
+ * with a label inviting the person to open it by hand. Refusing to render it is
+ * the only place that can be stopped (attacker pass 2026-08-04, B4).
+ */
+export function isDisplayableUrl(url, cloudUrl) {
+  let u;
+  let base;
+  try {
+    u = new URL(String(url));
+    base = new URL(String(cloudUrl ?? DEFAULT_CLOUD_URL));
+  } catch {
+    return false;
+  }
+  if (!/^https?:$/.test(u.protocol)) return false;
+  // Same two arms the Rust opener enforces. A scheme check alone was NOT enough:
+  // `https://evil.example/activate?code=…` from a hostile or MITM'd control plane
+  // passed it and still rendered as a live href with a Copy button — and a
+  // middle-click or "Open link" never reaches the click handler, let alone Rust
+  // (attacker re-review 2026-08-04, NEW-3).
+  if (u.origin === base.origin) return true;
+  const host = u.hostname;
+  return (
+    u.protocol === 'https:' &&
+    !u.port &&
+    (u.pathname === '' || u.pathname === '/') &&
+    !u.search &&
+    !u.hash &&
+    (host === DEFAULT_CLOUD_HOST || host.endsWith(`.${DEFAULT_CLOUD_HOST}`))
+  );
+}
+
+/**
+ * Reach the OS browser. Resolves to true when the open was accepted.
+ *
+ * A refusal must NOT be swallowed: the Rust side refusing is precisely the
+ * security event, and a silently dead click under a label reading "if your
+ * browser didn't open, go to:" teaches the person to copy the address into a
+ * browser the lock cannot see (B4). Callers surface the failure instead.
+ */
+function openExternal(url) {
+  if (!url) return Promise.resolve('failed');
+  if (isNativeApp()) {
+    return openCloudUrl(url).then(
+      () => 'ok',
+      // A REFUSAL is the security event and reads differently from "no browser
+      // would start" — collapsing both into one boolean lost the distinction the
+      // dialog needs to say something true.
+      (err) => (/Refusing to open/i.test(String(err)) ? 'refused' : 'failed')
+    );
+  }
+  // `window.open(..., 'noopener')` returns null even on SUCCESS (that is the
+  // whole point of noopener), so its result says nothing about whether a tab
+  // opened. Treating null as failure made the browser build print "Maude
+  // couldn't open your browser" on every single sign-in — training people that
+  // the one warning this dialog has is noise (attacker re-review, NEW-2).
+  try {
+    window.open(url, '_blank', 'noopener');
+    return Promise.resolve('ok');
+  } catch {
+    return Promise.resolve('failed');
+  }
+}
+
 /**
  * Parse a maude://open/<project>?code=mhc_… deep link. Untrusted input — a
  * drive-by page can navigate to maude:// — so nothing here is acted on
@@ -31,21 +112,141 @@ const api = async (path, init) => {
 export function parseDeepLink(url) {
   const m = /^maude:\/\/open\/([a-z0-9]+(?:-[a-z0-9]+)*)\/?\?(.*)$/.exec(String(url ?? ''));
   if (!m) return null;
+  // The platform caps a project id at 40 chars (deriveProjectId), but that bound
+  // lives server-side and a drive-by maude:// link never passes through it — so
+  // without this, arbitrary attacker text renders in the dialog's heading, prose
+  // and aria-label. Nothing longer can name a real project anyway.
+  if (m[1].length > 40) return null;
   const code = new URLSearchParams(m[2]).get('code') ?? '';
   if (!/^mhc_[0-9a-f]{16,128}$/.test(code)) return null;
   return { project: m[1], code };
 }
 
-/** The share view's address for a project cell URL (viewer's browser home). */
+/**
+ * A viewer's browser home for a project — the project's OWN address.
+ *
+ * It used to derive `view-<host>`, which no longer exists: the read-only gallery
+ * was deleted in Cloud Phase 25 C5, and `tenantFromHostname` now hard-refuses any
+ * `view-` label (deliberately, so a leftover custom domain can't spin up a cell
+ * literally named `view-alligators`). So this returned a guaranteed 404 — which
+ * was invisible while `window.open` was a no-op in the desktop shell, and would
+ * have become a visibly dead menu item the moment the opener started working
+ * (attacker re-review 2026-08-04). The browser door replaced the gallery: the
+ * real project, for people who actually have access.
+ */
 export function shareViewUrl(projectUrl, projectId) {
   try {
     const u = new URL(projectUrl);
-    return `${u.protocol}//view-${u.host}`;
+    return `${u.protocol}//${u.host}`;
   } catch {
-    return `https://view-${projectId}.cloud.maude.sh`;
+    return `https://${projectId}.${DEFAULT_CLOUD_HOST}`;
   }
 }
 
+/** Where Maude Cloud lives by default — mirrors the Rust opener's compiled host. */
+const DEFAULT_CLOUD_URL = 'https://cloud.maude.sh';
+const DEFAULT_CLOUD_HOST = 'cloud.maude.sh';
+
+/**
+ * Fold a name the way the PLATFORM does, so a folder and a project id can be
+ * compared at all.
+ *
+ * This mirrors `deriveProjectId` (apps/cloud/checkout.mjs) deliberately, NFKD
+ * strip and 40-char cap included. A plain kebab-case fold looked equivalent and
+ * wasn't: `Zkušební tým` derives the id `zkusebni-tym` on the platform but folded
+ * to `zku-ebn-t-m` here, so every accented project name failed to match its own
+ * workspace and warned on a perfectly legitimate connect — and any name over 40
+ * characters did the same, because the platform truncates and this didn't. A
+ * warning that fires on correct behaviour is a warning people learn to dismiss.
+ */
+const norm = (s) =>
+  String(s ?? '')
+    .normalize('NFKD')
+    .replace(/[̀-ͯ]/g, '')
+    .toLowerCase()
+    .replace(/[^a-z0-9]+/g, '-')
+    .replace(/^-+|-+$/g, '')
+    .replace(/-{2,}/g, '-')
+    .slice(0, 40)
+    .replace(/-+$/, '');
+
+/** The host an address carries, or '' if it isn't a readable URL. */
+const hostOf = (url) => {
+  try {
+    return new URL(url).hostname;
+  } catch {
+    return '';
+  }
+};
+
+/** The project label a cell address carries, or '' if it carries none. */
+function projectFromHubUrl(hubUrl, cloudHost) {
+  const host = hostOf(hubUrl);
+  if (!cloudHost || host === cloudHost) return '';
+  // `<project>.cloud.maude.sh` — only meaningful INSIDE the configured zone.
+  if (!host.endsWith(`.${cloudHost}`)) return '';
+  return norm(host.slice(0, -(cloudHost.length + 1)).replace(/^view-/, ''));
+}
+
+/**
+ * Does this folder look like the cloud project a link is naming?
+ *
+ * A hint about a decision the person makes — never an authorization gate. It
+ * exists because the confusing half of "Open in Maude" is that it attaches
+ * whatever folder happens to be open, so somebody with one project open who
+ * presses it on another is one click from syncing the wrong designs into the
+ * wrong workspace.
+ *
+ * WHAT THIS FUNCTION LEARNED THE HARD WAY (attacker pass 2026-08-04, B1): the
+ * first version treated a near-match — either name containing the other — as
+ * agreement, to avoid crying wolf over `alligators-web` vs `alligators`. That
+ * reasoning assumed a NON-ADVERSARIAL name collision. It isn't one: the name
+ * being compared against is a cloud project id, which anyone can register. An
+ * attacker registers `alligators-design-sync`, it contains `alligators`, and the
+ * hint falls silent on exactly the case it exists for. The server's 409 does not
+ * stand behind it either, because the claim and the actual project agree — it
+ * genuinely IS the attacker's project.
+ *
+ * So a near-match no longer resolves to "fine". It gets its OWN state, and says
+ * out loud that two similar names are still two different workspaces. Only an
+ * exact match (or a credentialed link) is silent.
+ *
+ * States: 'linked' (a real, credentialed link to this project) · 'match' (the
+ * names are the same) · 'similar' (alike but NOT the same — warn, softly) ·
+ * 'mismatch' (unrelated, or linked elsewhere — warn) · 'unknown' (no signal:
+ * status hasn't resolved, or the addresses carry no project name, as on every
+ * self-host and e2e stub at `http://127.0.0.1:<port>`). 'unknown' warns too —
+ * quietly, because failing open here is what B3 was.
+ */
+export function localIdentityHint({
+  localProject,
+  linkedHubUrl,
+  linkedHubCredentialed,
+  cloudUrl,
+  claimed,
+  resolved = true,
+}) {
+  if (!resolved) return 'unknown';
+  const want = norm(claimed);
+  if (!want) return 'unknown';
+
+  // A linkedHub only reassures when a stored credential corroborates it — the
+  // config file it comes from is committed and travels with the repo (B2).
+  const linkedProject = linkedHubUrl ? projectFromHubUrl(linkedHubUrl, hostOf(cloudUrl)) : '';
+  if (linkedProject && linkedHubCredentialed) {
+    return linkedProject === want ? 'linked' : 'mismatch';
+  }
+
+  // Otherwise the folder's own name is the signal — the one that catches the
+  // reported case (one project open, "Open in Maude" pressed on another).
+  const local = norm(localProject);
+  if (!local) return 'unknown';
+  if (local === want) return 'match';
+  const shorter = local.length <= want.length ? local : want;
+  const related = shorter.length >= 4 && (local.includes(want) || want.includes(local));
+  return related ? 'similar' : 'mismatch';
+}
+
 function Spark({ size = 15 }) {
   return (
     <svg width={size} height={size} viewBox="0 0 32 32" fill="currentColor" aria-hidden="true">
@@ -70,6 +271,14 @@ function Icon({ name, size = 15 }) {
         <path d="M3 10.5V3.2A.7.7 0 0 1 3.7 2.5H10" />
       </>
     ),
+    // Direction, not departure — the decision modal's two sides are joined by
+    // "flows into", and the `external` glyph read as "opens in the browser".
+    'arrow-right': (
+      <>
+        <line x1="2.5" y1="8" x2="12.5" y2="8" />
+        <polyline points="9 4.5 12.5 8 9 11.5" />
+      </>
+    ),
     link: (
       <>
         <path d="M6.5 9.5l3-3" />
@@ -102,17 +311,42 @@ export default function CloudBar() {
   const [note, setNote] = useState('');
   const [error, setError] = useState('');
   const [copied, setCopied] = useState(false);
+  const [copiedLink, setCopiedLink] = useState(false);
+  const [openFailed, setOpenFailed] = useState(''); // '' | 'refused' | 'failed'
+  const [cloudUrl, setCloudUrl] = useState('https://cloud.maude.sh');
+  // `resolved` gates the deep-link dialog: rendering the decision before the
+  // data it turns on made the hint fail OPEN on the launch path (B3).
+  const [local, setLocal] = useState({ project: '', linkedHub: null, resolved: false });
   const [pending, setPending] = useState(null); // { project, code } from maude://
   const railRef = useRef(null);
   const pollRef = useRef(null);
 
   useEffect(() => {
-    api('/_api/cloud/status').then((r) => {
-      if (r.ok && r.json?.connected) {
-        setEmail(r.json.email);
-        setState('in');
-      } else setState('out');
-    });
+    api('/_api/cloud/status')
+      .then((r) => {
+        if (r.json?.url) setCloudUrl(r.json.url);
+        // Resolved even on an error body — what must never happen is staying
+        // un-resolved forever and leaving the dialog unreachable; an empty
+        // project name resolves to 'unknown', which warns rather than reassures.
+        setLocal({
+          project: r.json?.project ?? '',
+          linkedHub: r.json?.linkedHub ?? null,
+          resolved: true,
+        });
+        if (r.ok && r.json?.connected) {
+          setEmail(r.json.email);
+          setState('in');
+        } else setState('out');
+      })
+      .catch(() => {
+        // A rejected fetch (the sidecar restarting under a launch-path deep link)
+        // would otherwise leave `resolved` false forever — and since the dialog
+        // is gated on it, the parked link would never be shown at all, silently
+        // burning a one-shot two-minute code. Resolve into the 'unknown' branch,
+        // which warns, and let the rail fall back to signed-out.
+        setLocal((l) => ({ ...l, resolved: true }));
+        setState('out');
+      });
     return () => clearInterval(pollRef.current);
   }, []);
 
@@ -124,7 +358,7 @@ export default function CloudBar() {
     const consume = (url) => {
       const parsed = parseDeepLink(url);
       if (!parsed) return;
-      // NEVER replace a link the person is already looking at. The strip is a
+      // NEVER replace a link the person is already looking at. The dialog is a
       // single slot, so an overwrite would swap the code out from under a
       // click that was aimed at the previous one — the person confirms the
       // name they read and connects the link that arrived last (validate
@@ -163,6 +397,18 @@ export default function CloudBar() {
     }
   }
 
+  // Escape answers the decision modal the same way the scrim does: Not now.
+  // Declining must always be the cheap move — the dashboard re-mints a code on
+  // the next "Open in Maude".
+  useEffect(() => {
+    if (!pending) return undefined;
+    const onKey = (e) => {
+      if (e.key === 'Escape') setPending(null);
+    };
+    document.addEventListener('keydown', onKey);
+    return () => document.removeEventListener('keydown', onKey);
+  }, [pending]);
+
   useEffect(() => {
     if (!menuOpen) return undefined;
     const onDoc = (e) => {
@@ -180,7 +426,8 @@ export default function CloudBar() {
       return;
     }
     setDevice(r.json);
-    window.open(r.json.verificationUrl, '_blank', 'noopener');
+    setOpenFailed('');
+    openExternal(r.json.verificationUrl).then((s) => setOpenFailed(s === 'ok' ? '' : s));
     pollRef.current = setInterval(async () => {
       const p = await api('/_api/cloud/signin/poll', {
         method: 'POST',
@@ -245,41 +492,158 @@ export default function CloudBar() {
     setState('out');
   }
 
-  function copyCode() {
-    if (!device?.userCode) return;
-    navigator.clipboard?.writeText(device.userCode).then(
+  // One clipboard write, one 1.5 s "Copied" flash. The code and the link are the
+  // same gesture, so they share the mechanism — and both swallow a refusal
+  // (no clipboard permission) silently: the value is on screen either way.
+  function copyToClipboard(text, mark) {
+    if (!text) return;
+    navigator.clipboard?.writeText(text).then(
       () => {
-        setCopied(true);
-        setTimeout(() => setCopied(false), 1500);
+        mark(true);
+        setTimeout(() => mark(false), 1500);
       },
       () => {}
     );
   }
 
+  const copyCode = () => copyToClipboard(device?.userCode, setCopied);
+  const copyLink = () => copyToClipboard(device?.verificationUrl, setCopiedLink);
+
   if (state === 'loading') return null;
 
+  const hint = pending
+    ? localIdentityHint({
+        localProject: local.project,
+        linkedHubUrl: local.linkedHub?.url,
+        linkedHubCredentialed: local.linkedHub?.credentialed,
+        cloudUrl,
+        claimed: pending.project,
+        resolved: local.resolved,
+      })
+    : 'unknown';
+  // Anything but a clean, corroborated agreement gets the warning treatment and
+  // a demoted Connect. Silence is reserved for the two cases we can vouch for.
+  const reassured = hint === 'linked' || hint === 'match';
+
   return (
     <div className="gi-rail cb-rail" ref={railRef} data-testid="cloud-bar">
-      {pending && (
-        <div className="gi-rail-confirm" data-testid="cloud-deeplink">
-          <span className="gi-rail-hint">Connect this project to {pending.project}?</span>
-          <button
-            type="button"
-            className="btn btn--sm"
-            disabled={busy === 'deeplink'}
-            onClick={connectPending}
-            data-testid="cloud-deeplink-connect"
-          >
-            {busy === 'deeplink' ? 'Connecting…' : 'Connect'}
-          </button>
-          <button
-            type="button"
-            className="btn btn--ghost btn--sm"
-            onClick={() => setPending(null)}
-            data-testid="cloud-deeplink-dismiss"
-          >
-            Not now
-          </button>
+      {/* Not until `local` has resolved: the launch-path deep link can beat the
+          status fetch, and a modal rendered without the local half showed no
+          warning and a primary Connect — failing OPEN in the one scenario with
+          the least context (attacker pass B3). */}
+      {pending && local.resolved && (
+        <div
+          className="gi-modal"
+          role="dialog"
+          aria-modal="true"
+          aria-label={`Connect this folder to ${pending.project}`}
+        >
+          <div className="gi-scrim" aria-hidden="true" onClick={() => setPending(null)} />
+          <div className="gi-dialog gi-dialog--code" data-testid="cloud-deeplink-dialog">
+            <div className="gi-dc-head">
+              <span className="gi-dc-marks"><Icon name="link" size={24} /></span>
+              <h2>Connect to {pending.project}?</h2>
+            </div>
+            {/* Both sides, named. The old strip said "Connect this project to X?"
+                — which never told anyone WHICH project "this" was, the one thing
+                the decision turns on. */}
+            <div className="gi-dl-pair">
+              <span className="gi-dl-side">
+                <span className="gi-dl-lbl">This folder</span>
+                <span className="gi-dl-val" data-testid="cloud-deeplink-local">{local.project || 'the open project'}</span>
+              </span>
+              <span className="gi-dl-arrow" aria-hidden="true"><Icon name="arrow-right" size={16} /></span>
+              <span className="gi-dl-side">
+                <span className="gi-dl-lbl">Cloud project</span>
+                <span className="gi-dl-val">{pending.project}</span>
+              </span>
+            </div>
+            <p className="gi-dl-what">
+              This folder’s <code>.design/</code> canvases will sync with the {pending.project}{' '}
+              workspace. Nothing else in this repo is uploaded.
+            </p>
+            {hint === 'linked' && (
+              <p className="gi-dl-note">This folder is already linked to {pending.project} — connecting refreshes the link.</p>
+            )}
+            {!reassured && (
+              <div className="gi-dl-warn" data-testid="cloud-deeplink-mismatch">
+                <strong>
+                  {hint === 'similar' ? (
+                    <>
+                      {local.project} and {pending.project} are different workspaces.
+                    </>
+                  ) : hint === 'unknown' ? (
+                    <>Maude can’t tell which project this folder is.</>
+                  ) : (
+                    <>
+                      This folder looks like {local.project || 'something else'}, not{' '}
+                      {pending.project}.
+                    </>
+                  )}
+                </strong>
+                <span>
+                  Connecting will sync <em>this folder’s</em> designs into {pending.project}. If you
+                  meant to work on {pending.project}, open its folder in Maude and press “Open in
+                  Maude” again. Don’t have it on this machine? It opens in{' '}
+                  {isDisplayableUrl(cloudUrl, cloudUrl) ? (
+                    <a
+                      className="gi-dc-link-a"
+                      href={cloudUrl}
+                      rel="noopener noreferrer"
+                      target="_blank"
+                      onClick={(e) => {
+                        e.preventDefault();
+                        openExternal(cloudUrl);
+                      }}
+                    >
+                      your browser
+                    </a>
+                  ) : (
+                    'your browser'
+                  )}
+                  .
+                </span>
+              </div>
+            )}
+            <div className="gi-dc-foot">
+              {/* On a mismatch the safe action leads and connecting is the one you
+                  have to mean. No project switcher lives here on purpose: the
+                  handoff code is one-shot with a two-minute life, and a switch
+                  restarts the server — the person would come back to a dead code
+                  and a question they already answered. */}
+              {!reassured ? (
+                <>
+                  <button type="button" className="btn" onClick={() => setPending(null)} data-testid="cloud-deeplink-dismiss">
+                    Not now
+                  </button>
+                  <button
+                    type="button"
+                    className="btn btn--ghost"
+                    disabled={busy === 'deeplink'}
+                    onClick={connectPending}
+                    data-testid="cloud-deeplink-connect"
+                  >
+                    {busy === 'deeplink' ? 'Connecting…' : 'Connect anyway'}
+                  </button>
+                </>
+              ) : (
+                <>
+                  <button
+                    type="button"
+                    className="btn"
+                    disabled={busy === 'deeplink'}
+                    onClick={connectPending}
+                    data-testid="cloud-deeplink-connect"
+                  >
+                    {busy === 'deeplink' ? 'Connecting…' : 'Connect'}
+                  </button>
+                  <button type="button" className="btn btn--ghost" onClick={() => setPending(null)} data-testid="cloud-deeplink-dismiss">
+                    Not now
+                  </button>
+                </>
+              )}
+            </div>
+          </div>
         </div>
       )}
       {state === 'out' && (
@@ -332,7 +696,7 @@ export default function CloudBar() {
                       type="button"
                       className="gi-menu-item"
                       role="menuitem"
-                      onClick={() => window.open(shareViewUrl(p.url, p.id), '_blank', 'noopener')}
+                      onClick={() => openExternal(shareViewUrl(p.url, p.id))}
                       title="Viewing works in the browser. Editing in the app needs the member role — ask whoever runs the project."
                       data-testid={`cloud-project-${p.id}`}
                     >
@@ -356,7 +720,7 @@ export default function CloudBar() {
                   )
                 )}
               <div className="gi-menu-sep" />
-              <button type="button" className="gi-menu-item" role="menuitem" onClick={() => window.open('https://cloud.maude.sh', '_blank', 'noopener')}>
+              <button type="button" className="gi-menu-item" role="menuitem" onClick={() => openExternal(cloudUrl)}>
                 <Icon name="external" size={15} /> Open the dashboard
               </button>
               <button type="button" className="gi-menu-item gi-menu-item--danger" role="menuitem" onClick={signOut}>
@@ -374,7 +738,11 @@ export default function CloudBar() {
             <div className="gi-dc-head">
               <span className="gi-dc-marks"><Spark size={26} /></span>
               <h2>Sign in to Maude Cloud</h2>
-              <p>Maude opened your dashboard in the browser. Confirm this code there to connect.</p>
+              {/* Says what to DO, not what supposedly already happened. The old
+                  copy claimed the browser had opened — a claim this surface
+                  cannot make, since the shell's open is best-effort and the
+                  person is the one who finds out it didn't. */}
+              <p>Confirm this code on your Maude Cloud dashboard to connect.</p>
             </div>
             <div className="gi-code">
               <span className="gi-code-val" data-testid="cloud-user-code">{device.userCode}</span>
@@ -382,6 +750,59 @@ export default function CloudBar() {
                 <Icon name="copy" size={15} /> {copied ? 'Copied' : 'Copy'}
               </button>
             </div>
+            {/* The manual path, always present — never conditional on whether the
+                open "worked". It is the only thing standing between an older
+                shell / a drifted self-host origin / a blocked popup and a dead
+                end. The address already carries the code (`/activate?code=…`),
+                so following it is one click, not a re-type. */}
+            {device.verificationUrl && isDisplayableUrl(device.verificationUrl, cloudUrl) && (
+              <div className="gi-dc-link">
+                <span className="gi-dc-link-lbl">
+                  {openFailed === 'failed'
+                    ? 'Maude couldn’t open your browser. Open this address yourself:'
+                    : 'If your browser didn’t open, go to:'}
+                </span>
+                <div className="gi-dc-link-row">
+                  <a
+                    className="gi-dc-url gi-dc-link-a"
+                    href={device.verificationUrl}
+                    rel="noopener noreferrer"
+                    target="_blank"
+                    data-testid="cloud-signin-link"
+                    onClick={(e) => {
+                      e.preventDefault();
+                      openExternal(device.verificationUrl).then((s) =>
+                        setOpenFailed(s === 'ok' ? '' : s)
+                      );
+                    }}
+                  >
+                    {device.verificationUrl}
+                  </a>
+                  <button type="button" className="btn btn--ghost btn--sm" onClick={copyLink} aria-label="Copy the link">
+                    <Icon name="copy" size={14} /> {copiedLink ? 'Copied' : 'Copy link'}
+                  </button>
+                </div>
+              </div>
+            )}
+            {openFailed === 'refused' && (
+              // A REFUSAL is not "your browser didn't open" — it is Maude saying
+              // that address isn't Maude Cloud. Saying so, and NOT offering to
+              // help open it, is the whole difference (attacker re-review NEW-2).
+              <div className="gi-dl-warn" data-testid="cloud-signin-refused">
+                <strong>Maude wouldn’t open that address.</strong>
+                <span>It isn’t a Maude Cloud address. Sign in on your dashboard instead.</span>
+              </div>
+            )}
+            {device.verificationUrl && !isDisplayableUrl(device.verificationUrl, cloudUrl) && (
+              // An address we won't put behind a link or a copy button. Naming it
+              // is the point — silently dropping it would look like a bug.
+              <div className="gi-dl-warn" data-testid="cloud-signin-badurl">
+                <strong>Maude Cloud sent an address that doesn’t look right.</strong>
+                <span>
+                  Nothing was opened. Sign in on your dashboard directly instead of following it.
+                </span>
+              </div>
+            )}
             <div className="gi-dc-status" aria-live="polite">
               <span className="gi-pulse" aria-hidden="true" />
               <span>Waiting for you to confirm in the browser…</span>

package/apps/studio/client/panels/SettingsPanel.jsx

@@ -802,7 +802,12 @@ function AppearanceTab({ theme, onSetTheme, cpMode, onSetCpMode }) {
 
 export default function SettingsPanel({
   /** `{ dashboardUrl, projectName }` when this is a cloud tab, else null. */
-  cloud = null,
+  // Tri-state (see the note where this value is created): `undefined` until
+  // the server config answers, `null` for the desktop, an object for a cloud
+  // tab. Defaulting it to `null` here is what re-broke the boot 404 after the
+  // call sites were fixed — a default fires on `undefined`, so "not known yet"
+  // became "not cloud" one layer further in, invisibly.
+  cloud,
   onClose,
   initialTab,
   theme,