@1agh/maude 0.51.1 → 0.52.1

package/apps/studio/client/panels/timeline-media-cache.js

@@ -0,0 +1,274 @@
+// timeline-media-cache.js — feature-enhanced-video-editing (Task 7).
+// Client-side extraction of REAL clip visuals for the Timeline: filmstrip
+// thumbnails (a hidden <video> seeked N times → canvas → JPEG dataURLs) and
+// audio waveform peaks (fetch → WebAudio decodeAudioData → max-abs bins).
+//
+// Contract:
+//   • async + cancellable-by-neglect: callers pass an onReady callback; a
+//     stale generation simply ignores the result. Today's plain blocks are the
+//     instant fallback while extraction runs.
+//   • never blocks the scrub: extraction is queued (max 2 concurrent decodes —
+//     WKWebView memory) and kicked from idle callbacks.
+//   • cached in memory keyed `<src>|<bucket>` AND persisted server-side under
+//     `<designRoot>/_canvas-state/timeline-media/` (per-machine runtime state,
+//     DDR-115) via /_api/timeline-media.
+
+const memory = new Map(); // key → { strip?: string[], peaks?: number[] }
+const pending = new Map(); // key → Promise
+let running = 0;
+const queue = [];
+const MAX_CONCURRENT = 2;
+const THUMB_W = 160;
+
+function pump() {
+  while (running < MAX_CONCURRENT && queue.length) {
+    const job = queue.shift();
+    running += 1;
+    const idle = window.requestIdleCallback || ((fn) => setTimeout(fn, 40));
+    idle(() => {
+      job()
+        .catch(() => {})
+        .finally(() => {
+          running -= 1;
+          pump();
+        });
+    });
+  }
+}
+
+function enqueue(fn) {
+  return new Promise((resolve) => {
+    queue.push(() => fn().then(resolve, () => resolve(null)));
+    pump();
+  });
+}
+
+/** Server-persisted cache key — the content-addressed sha8 in the asset path
+ *  when present (stable across machines/paths), else a djb2 of the src. */
+export function mediaCacheKey(src, bucket) {
+  const sha = String(src).match(/([a-f0-9]{8,})\.[a-z0-9]+$/i)?.[1]?.slice(0, 12);
+  if (sha) return `${sha}-${bucket}`;
+  let h = 5381;
+  for (let i = 0; i < src.length; i += 1) h = ((h << 5) + h + src.charCodeAt(i)) >>> 0;
+  return `h${h.toString(16)}-${bucket}`;
+}
+
+async function serverGet(key) {
+  try {
+    const r = await fetch(`/_api/timeline-media?key=${encodeURIComponent(key)}`);
+    if (!r.ok) return null;
+    const j = await r.json();
+    return j?.ok && j.data && typeof j.data === 'object' ? j.data : null;
+  } catch {
+    return null;
+  }
+}
+
+function serverPut(key, data) {
+  fetch(`/_api/timeline-media?key=${encodeURIComponent(key)}`, {
+    method: 'PUT',
+    headers: { 'content-type': 'application/json' },
+    body: JSON.stringify(data),
+  }).catch(() => {});
+}
+
+/** Thumbnail bucket for a block width in px: 1 / 3 / 5 / 7 frames by zoom. */
+export function stripBucket(widthPx) {
+  if (widthPx < 90) return 1;
+  if (widthPx < 200) return 3;
+  if (widthPx < 340) return 5;
+  return 7;
+}
+
+async function extractStrip(url, count) {
+  const video = document.createElement('video');
+  video.muted = true;
+  video.playsInline = true;
+  video.preload = 'auto';
+  video.crossOrigin = 'anonymous';
+  // WKWebView refuses to decode a detached <video> in some codec paths (the
+  // desktop "no filmstrips" bug) — keep it in the document, invisible, for the
+  // whole extraction, and kick the load explicitly.
+  video.style.cssText = 'position:fixed;left:-9999px;top:-9999px;width:2px;height:2px;opacity:0;pointer-events:none;';
+  document.body.appendChild(video);
+  video.src = url;
+  try {
+    video.load();
+  } catch {
+    /* load() is best-effort */
+  }
+  try {
+    await new Promise((res, rej) => {
+      const to = setTimeout(() => rej(new Error('metadata timeout')), 8000);
+      const ok = () => {
+        clearTimeout(to);
+        res();
+      };
+      video.addEventListener('loadedmetadata', ok, { once: true });
+      video.addEventListener('canplay', ok, { once: true });
+      video.addEventListener(
+        'error',
+        () => rej(new Error(`video error (${video.error?.code ?? '?'})`)),
+        { once: true }
+      );
+    });
+  } catch (err) {
+    video.remove();
+    console.warn('[timeline] filmstrip extraction failed for', url, err?.message || err);
+    throw err;
+  }
+  const dur = video.duration;
+  if (!Number.isFinite(dur) || dur <= 0) throw new Error('no duration');
+  const ratio = (video.videoHeight || 9) / (video.videoWidth || 16);
+  const canvas = document.createElement('canvas');
+  canvas.width = THUMB_W;
+  canvas.height = Math.max(2, Math.round(THUMB_W * ratio));
+  const g = canvas.getContext('2d');
+  const strip = [];
+  try {
+    for (let k = 0; k < count; k += 1) {
+      const t = ((k + 0.5) / count) * dur;
+      // eslint-disable-next-line no-await-in-loop
+      await new Promise((res, rej) => {
+        const to = setTimeout(() => rej(new Error('seek timeout')), 6000);
+        video.addEventListener(
+          'seeked',
+          () => {
+            clearTimeout(to);
+            res();
+          },
+          { once: true }
+        );
+        video.currentTime = Math.min(dur - 0.01, Math.max(0, t));
+      });
+      g.drawImage(video, 0, 0, canvas.width, canvas.height);
+      strip.push(canvas.toDataURL('image/jpeg', 0.55));
+    }
+  } catch (err) {
+    // WKWebView quirk — some codecs never fire `seeked` when paused. A partial
+    // strip (or a single poster frame) still beats an anonymous slab.
+    if (strip.length === 0) {
+      try {
+        await new Promise((res, rej) => {
+          if (video.readyState >= 2) {
+            res();
+            return;
+          }
+          const to = setTimeout(() => rej(new Error('data timeout')), 4000);
+          video.addEventListener(
+            'loadeddata',
+            () => {
+              clearTimeout(to);
+              res();
+            },
+            { once: true }
+          );
+        });
+        g.drawImage(video, 0, 0, canvas.width, canvas.height);
+        strip.push(canvas.toDataURL('image/jpeg', 0.55));
+      } catch {
+        video.remove();
+        console.warn('[timeline] filmstrip seek+poster both failed for', url, err?.message || err);
+        throw err; // truly nothing extractable
+      }
+    }
+    while (strip.length < count) strip.push(strip[strip.length - 1]);
+  }
+  video.removeAttribute('src');
+  try {
+    video.load();
+  } catch {
+    /* teardown */
+  }
+  video.remove();
+  return strip;
+}
+
+async function extractPeaks(url, bins = 400) {
+  const res = await fetch(url);
+  if (!res.ok) throw new Error(`fetch ${res.status}`);
+  const buf = await res.arrayBuffer();
+  const Ctor = window.AudioContext || window.webkitAudioContext;
+  if (!Ctor) throw new Error('no AudioContext');
+  const ctx = new Ctor();
+  try {
+    const decoded = await ctx.decodeAudioData(buf);
+    const data = decoded.getChannelData(0);
+    const step = Math.max(1, Math.floor(data.length / bins));
+    const peaks = [];
+    for (let b = 0; b < bins; b += 1) {
+      let max = 0;
+      const start = b * step;
+      const end = Math.min(data.length, start + step);
+      // Sample sparsely inside the bin — full max over 10M samples is wasted work.
+      const inner = Math.max(1, Math.floor((end - start) / 64));
+      for (let i = start; i < end; i += inner) {
+        const v = Math.abs(data[i]);
+        if (v > max) max = v;
+      }
+      peaks.push(Math.round(max * 100) / 100);
+    }
+    return peaks;
+  } finally {
+    ctx.close?.().catch?.(() => {});
+  }
+}
+
+/** Filmstrip for a video src (resolved URL). Resolves to string[] | null. */
+export function getFilmstrip(url, bucket) {
+  const key = mediaCacheKey(url, `s${bucket}`);
+  const hit = memory.get(key);
+  if (hit?.strip) return Promise.resolve(hit.strip);
+  if (pending.has(key)) return pending.get(key);
+  const p = (async () => {
+    const cached = await serverGet(key);
+    if (Array.isArray(cached?.strip)) {
+      memory.set(key, { strip: cached.strip });
+      return cached.strip;
+    }
+    const strip = await enqueue(() => extractStrip(url, bucket));
+    if (!strip) return null;
+    memory.set(key, { strip });
+    serverPut(key, { strip });
+    return strip;
+  })().finally(() => pending.delete(key));
+  pending.set(key, p);
+  return p;
+}
+
+/** Waveform peaks for an audio src (resolved URL). Resolves to number[] | null. */
+export function getPeaks(url) {
+  const key = mediaCacheKey(url, 'peaks');
+  const hit = memory.get(key);
+  if (hit?.peaks) return Promise.resolve(hit.peaks);
+  if (pending.has(key)) return pending.get(key);
+  const p = (async () => {
+    const cached = await serverGet(key);
+    if (Array.isArray(cached?.peaks)) {
+      memory.set(key, { peaks: cached.peaks });
+      return cached.peaks;
+    }
+    const peaks = await enqueue(() => extractPeaks(url));
+    if (!peaks) return null;
+    memory.set(key, { peaks });
+    serverPut(key, { peaks });
+    return peaks;
+  })().finally(() => pending.delete(key));
+  pending.set(key, p);
+  return p;
+}
+
+/** Build the SVG path for a peak array in a 100×12 viewBox (mirrored wave). */
+export function peaksToPath(peaks) {
+  if (!peaks?.length) return '';
+  const n = peaks.length;
+  const top = [];
+  const bottom = [];
+  for (let i = 0; i < n; i += 1) {
+    const px = (i / (n - 1)) * 100;
+    const a = Math.max(0.04, Math.min(1, peaks[i])) * 5;
+    top.push(`${px.toFixed(2)} ${(6 - a).toFixed(2)}`);
+    bottom.unshift(`${px.toFixed(2)} ${(6 + a).toFixed(2)}`);
+  }
+  return `M${top.join(' L')} L${bottom.join(' L')} Z`;
+}

package/apps/studio/client/panels/timeline-parse.js

@@ -133,6 +133,10 @@ export function parseCompTimeline(source, totalFrames, selectedArtboardId) {
   }
 
   const items = [];
+  // Spans of clip bodies — used below to spot LOOSE media (a bare
+  // <OffthreadVideo>/<Img> sibling outside every Sequence), which previously
+  // never showed on the timeline at all (dogfood 2026-07-30).
+  const clipSpans = [];
   const tagRe =
     /<(TransitionSeries\.Sequence|TransitionSeries\.Transition|Series\.Sequence|Sequence)\b([^>]*)>/g;
   let m;
@@ -152,6 +156,7 @@ export function parseCompTimeline(source, totalFrames, selectedArtboardId) {
       // a phantom audio). FALLBACK badge only; the enumerator (comp-clips)
       // overlays authoritative media by index (incl. wrapper-component media).
       const closeIdx = scope.indexOf(`</${kind}>`, openEnd);
+      clipSpans.push([m.index, closeIdx >= 0 ? closeIdx : openEnd + 240]);
       const bound = closeIdx >= 0 ? Math.min(closeIdx, openEnd + 400) : openEnd + 240;
       const after = scope.slice(openEnd, bound);
       const lm = after.match(/<([A-Z][A-Za-z0-9]*)\b/);
@@ -178,13 +183,23 @@ export function parseCompTimeline(source, totalFrames, selectedArtboardId) {
 
   let cursor = 0;
   const sequences = [];
+  // Task 5 (enhanced-video-editing) — seam transitions between series beats,
+  // so the storyline lane can draw its ⧓ chips: { afterIndex, dur } where
+  // afterIndex is the sequence-row index the transition FOLLOWS.
+  const transitions = [];
+  let pendingTransition = null;
   for (const it of items) {
     if (it.type === 'transition') {
       cursor -= it.dur || 0;
+      if (sequences.length > 0) pendingTransition = { afterIndex: sequences.length - 1, dur: it.dur || 0 };
       continue;
     }
     const from = it.from != null ? it.from : cursor;
     const duration = it.dur != null ? it.dur : 30;
+    if (pendingTransition) {
+      transitions.push(pendingTransition);
+      pendingTransition = null;
+    }
     sequences.push({
       label: it.compName ?? `Seq ${sequences.length + 1}`,
       series: !!it.series,
@@ -216,14 +231,44 @@ export function parseCompTimeline(source, totalFrames, selectedArtboardId) {
     audio.push({
       kind: 'audio',
       label: name,
+      src: srcM ? srcM[1] : null,
       from: Math.max(0, from),
       duration: dur != null ? Math.max(1, dur) : Math.max(1, total - from),
     });
   }
 
+  // Loose VISUAL media — a bare <OffthreadVideo>/<Video>/<Img> sibling outside
+  // every clip span. Remotion renders it from frame 0 for the whole comp, so
+  // show it as a read-only overlay row (`loose: true` — no clip ops; it has no
+  // enumerator identity). Dogfood 2026-07-30: these were invisible before.
+  for (const lm of scope.matchAll(/<(OffthreadVideo|Video|Img)\b([^>]*?)\/?>/g)) {
+    const at = lm.index ?? 0;
+    if (clipSpans.some(([s2, e2]) => at >= s2 && at <= e2)) continue;
+    const srcM = lm[2].match(/src=["']([^"']+)["']/);
+    if (!srcM) continue;
+    const name = String(srcM[1]).split(/[\\/]/).pop();
+    sequences.push({
+      label: name || lm[1],
+      series: false,
+      loose: true,
+      mediaTag: lm[1],
+      mediaSrc: srcM[1],
+      from: 0,
+      duration: Math.max(1, total),
+      keyframes: [],
+    });
+  }
+
   // `artboardId` is the DCArtboard the timeline scoped to — the shell passes it
   // to /_api/comp-clips + every clip op so the enumerator targets the SAME comp
   // (on a multi-comp canvas its own fallback picks a different one — the
   // showreel badge/replace mis-scoped to the wrong comp without this).
-  return { total, fps: scopedFps || undefined, sequences, audio, artboardId: scopedArtboardId };
+  return {
+    total,
+    fps: scopedFps || undefined,
+    sequences,
+    audio,
+    transitions,
+    artboardId: scopedArtboardId,
+  };
 }

package/apps/studio/client/panels/timeline-scale.js

@@ -0,0 +1,64 @@
+// timeline-scale.js — feature-enhanced-video-editing (Task 4). Pure zoom/scale
+// helpers for the Timeline: all block/handle/caret/playhead math goes through
+// ONE px-per-frame scale (replacing the old %-of-total positioning), so drags
+// land on the same frames at every zoom level. Pure + DOM-free → unit-tested.
+
+/** Fit-to-width scale: the whole comp spans the viewport exactly. */
+export function fitPxPerFrame(viewportPx, totalFrames) {
+  const w = Math.max(1, viewportPx || 1);
+  const t = Math.max(1, totalFrames || 1);
+  return w / t;
+}
+
+/** Hard zoom bounds: never below fit (no dead space right of the comp), never
+ *  above MAX_PX_PER_FRAME (a frame wider than ~40px stops being useful). */
+export const MAX_PX_PER_FRAME = 40;
+
+export function clampPxPerFrame(pxPerFrame, viewportPx, totalFrames) {
+  const fit = fitPxPerFrame(viewportPx, totalFrames);
+  const v = Number(pxPerFrame);
+  if (!Number.isFinite(v) || v <= 0) return fit;
+  return Math.min(MAX_PX_PER_FRAME, Math.max(fit, v));
+}
+
+export function frameToPx(frame, pxPerFrame) {
+  return frame * pxPerFrame;
+}
+
+export function pxToFrame(px, pxPerFrame) {
+  return pxPerFrame > 0 ? px / pxPerFrame : 0;
+}
+
+/**
+ * Zoom keeping `anchorFrame` stationary on screen: given the current scroll
+ * offset and the anchor's viewport position, return the scrollLeft that puts
+ * the anchor back at the same viewport x under the new scale.
+ */
+export function zoomAroundScroll(prevPxPerFrame, nextPxPerFrame, anchorFrame, prevScrollLeft) {
+  const anchorViewportX = frameToPx(anchorFrame, prevPxPerFrame) - prevScrollLeft;
+  return Math.max(0, frameToPx(anchorFrame, nextPxPerFrame) - anchorViewportX);
+}
+
+/**
+ * Adaptive ruler tick step (in frames): the densest step from the ladder whose
+ * ticks stay ≥ `minPx` apart. Ladder walks 1 f → 5 f → 10 f → 1 s → 5 s → 10 s
+ * → 30 s → 60 s, so zooming in refines seconds into frames.
+ */
+export function tickStepFrames(pxPerFrame, fps, minPx = 56) {
+  const f = Math.max(1, Math.round(fps || 30));
+  const ladder = [1, 5, 10, f, 5 * f, 10 * f, 30 * f, 60 * f];
+  for (const step of ladder) {
+    if (step * pxPerFrame >= minPx) return step;
+  }
+  return ladder[ladder.length - 1];
+}
+
+/** Ruler tick labels: whole seconds label as `Ns`, sub-second ticks as `Nf`. */
+export function tickLabel(frame, fps) {
+  const f = Math.max(1, Math.round(fps || 30));
+  if (frame % f === 0) return `${frame / f}s`;
+  return `${frame}f`;
+}
+
+/** Multiplicative zoom step (⌘+/⌘− and the slider use the same factor). */
+export const ZOOM_STEP = 1.5;

package/apps/studio/client/report-bug.jsx

@@ -327,24 +327,24 @@ export function ReportBugDialog({ open, onClose }) {
   const canPreview = description.trim().length > 0;
 
   return (
-    <div className="help-modal-backdrop" onClick={close} data-testid="report-bug-dialog">
+    <div className="st-scrim" onClick={close} data-testid="report-bug-dialog">
       <div
-        className="help-modal rb-modal"
+        className="st-dialog rb-dialog"
         role="dialog"
         aria-modal="true"
         aria-labelledby="rb-title"
         onClick={(e) => e.stopPropagation()}
       >
-        <header className="help-modal-hd">
-          <span className="title" id="rb-title">
+        <div className="st-dialog-hd">
+          <span className="st-dialog-title" id="rb-title">
             Report a bug
           </span>
-          <button type="button" className="help-modal-close" onClick={close} aria-label="Close">
+          <button type="button" className="st-iconbtn" onClick={close} aria-label="Close">
             ×
           </button>
-        </header>
+        </div>
 
-        <div className="help-modal-body rb-body">
+        <div className="st-dialog-bd rb-body">
           {step === 'describe' && (
             <>
               <label className="rb-label" htmlFor="rb-desc">
@@ -352,7 +352,7 @@ export function ReportBugDialog({ open, onClose }) {
               </label>
               <textarea
                 id="rb-desc"
-                className="rb-desc"
+                className="textarea"
                 data-testid="report-bug-description"
                 rows={5}
                 autoFocus
@@ -364,12 +364,12 @@ export function ReportBugDialog({ open, onClose }) {
                 Next you'll see exactly what gets attached — nothing is sent until you approve it.
               </p>
               <footer className="rb-actions">
-                <button type="button" className="rb-btn" onClick={close}>
+                <button type="button" className="st-btn" onClick={close}>
                   Cancel
                 </button>
                 <button
                   type="button"
-                  className="rb-btn rb-primary"
+                  className="st-btn rb-primary"
                   data-testid="report-bug-preview"
                   disabled={!canPreview}
                   onClick={() => setStep('preview')}
@@ -501,12 +501,12 @@ export function ReportBugDialog({ open, onClose }) {
                 repository only maintainers can open.
               </p>
               <footer className="rb-actions">
-                <button type="button" className="rb-btn" onClick={() => setStep('describe')}>
+                <button type="button" className="st-btn" onClick={() => setStep('describe')}>
                   Back
                 </button>
                 <button
                   type="button"
-                  className="rb-btn rb-primary"
+                  className="st-btn rb-primary"
                   data-testid="report-bug-send"
                   onClick={send}
                 >
@@ -556,7 +556,7 @@ export function ReportBugDialog({ open, onClose }) {
                 </p>
               )}
               <footer className="rb-actions">
-                <button type="button" className="rb-btn rb-primary" onClick={close}>
+                <button type="button" className="st-btn rb-primary" onClick={close}>
                   Done
                 </button>
               </footer>
@@ -574,10 +574,10 @@ export function ReportBugDialog({ open, onClose }) {
                 attach them by hand.
               </p>
               <footer className="rb-actions">
-                <button type="button" className="rb-btn" onClick={() => setStep('preview')}>
+                <button type="button" className="st-btn" onClick={() => setStep('preview')}>
                   Back
                 </button>
-                <button type="button" className="rb-btn rb-primary" onClick={saveFallback}>
+                <button type="button" className="st-btn rb-primary" onClick={saveFallback}>
                   Save locally &amp; open GitHub
                 </button>
               </footer>