@1agh/maude 0.50.0 → 0.51.1

package/apps/studio/client/app.jsx

@@ -78,6 +78,7 @@ import { PhotoKnobs } from './photo-knobs.jsx';
 import {
   appIsFirstRun,
   isNativeApp,
+  onMenuReportBug,
   onUpdateReady,
   pickMediaFile,
   pickMediaFiles,
@@ -88,6 +89,7 @@ import { TourOverlay } from './tour/overlay.jsx';
 import { QUICK_SETUP_TOUR } from './tour/quick-setup-tour.js';
 import { USAGE_TOUR } from './tour/usage-tour.js';
 import { ExportBadge, ExportPanel, ExportToast, useExportCenter } from './export-center.jsx';
+import { ReportBugDialog } from './report-bug.jsx';
 import { useWhatsNew, WhatsNewPanel, WhatsNewToast } from './whats-new.jsx';
 
 const USAGE_TOUR_STORE = 'mdcc-usage-tour-seen';
@@ -3408,6 +3410,7 @@ function HelpDropdown({ onAction, onClose }) {
       items={[
         { id: 'shortcuts', label: 'Keyboard shortcuts', shortcut: '?' },
         { id: 'help', label: 'Help · commands & flows', shortcut: 'F1' },
+        { id: 'report-bug', label: 'Report a bug…' },
         { sep: true },
         { id: 'tour', label: 'Take the tour' },
         { id: 'watch-intro', label: 'Watch the intro' },
@@ -3552,6 +3555,7 @@ function Menubar({
   onToggleShowHidden,
   onOpenHelp,
   onOpenShortcuts,
+  onReportBug,
   onStartTour,
   onStartCollabTour,
   annotationsVisible,
@@ -3878,6 +3882,7 @@ function Menubar({
           onAction={(id) => {
             if (id === 'shortcuts') onOpenShortcuts?.();
             else if (id === 'help') onOpenHelp?.();
+            else if (id === 'report-bug') onReportBug?.();
             else if (id === 'tour') onStartTour?.();
             else if (id === 'collab-tour') onStartCollabTour?.();
             else if (id === 'quick-setup') onOpenQuickSetup?.();
@@ -9158,6 +9163,17 @@ function App() {
   const [showHidden, setShowHidden] = useState(() => readBoolStore(SHOW_HIDDEN_STORE, false));
   const [sectionsExpanded, setSectionsExpanded] = useState(() => readJsonStore(SECTIONS_STORE, {}));
   const [helpOpen, setHelpOpen] = useState(false);
+  const [reportBugOpen, setReportBugOpen] = useState(false);
+
+  // Native Help ▸ Report a Bug… (menu.rs emits `menu://report-bug`) — same
+  // lane as IdentityBar's File ▸ New Project… subscription.
+  useEffect(() => {
+    if (!isNativeApp()) return;
+    const p = onMenuReportBug(() => setReportBugOpen(true));
+    return () => {
+      p.then((un) => un()).catch(() => {});
+    };
+  }, []);
   const [readinessOpen, setReadinessOpen] = useState(false);
   const [introOpen, setIntroOpen] = useState(false);
   const [quickSetupOpen, setQuickSetupOpen] = useState(false);
@@ -13309,6 +13325,13 @@ function App() {
         kbd: 'F1',
         run: () => setHelpOpen(true),
       },
+      {
+        id: 'report-bug',
+        group: 'Help',
+        label: 'Report a bug…',
+        icon: 'help',
+        run: () => setReportBugOpen(true),
+      },
     ],
     [openSystem, toggleTheme, reloadActive, whatsNew]
   );
@@ -13522,6 +13545,7 @@ function App() {
           onToggleShowHidden={() => setShowHidden((v) => !v)}
           onOpenHelp={() => setHelpOpen(true)}
           onOpenShortcuts={() => setShortcutsOpen(true)}
+          onReportBug={() => setReportBugOpen(true)}
           onStartTour={() => startTour(USAGE_TOUR)}
           onStartCollabTour={() => startTour(COLLAB_TOUR)}
           annotationsVisible={annotationsVisible}
@@ -14182,6 +14206,7 @@ function App() {
           startTour(USAGE_TOUR);
         }}
       />
+      <ReportBugDialog open={reportBugOpen} onClose={() => setReportBugOpen(false)} />
       <WhatsNewPanel wn={whatsNew} onStartTour={startTour} />
       <ExportPanel center={exportCenter} />
       <ReadinessDialog open={readinessOpen} onClose={() => setReadinessOpen(false)} />

package/apps/studio/client/github.js

@@ -45,6 +45,8 @@ export const onDeviceCode = (cb) => listen('github://device-code', cb);
 export const onSignedIn = (cb) => listen('github://signed-in', cb);
 /** Fire when the native File ▸ New Project… menu item is chosen. Returns an unlisten promise. */
 export const onMenuNewProject = (cb) => listen('menu://new-project', cb);
+/** Fire when the native Help ▸ Report a Bug… menu item is chosen. Returns an unlisten promise. */
+export const onMenuReportBug = (cb) => listen('menu://report-bug', cb);
 
 // ── dev-server endpoints ────────────────────────────────────────────────────────
 async function api(path, opts = {}) {

package/apps/studio/client/panels/CloudBar.jsx

@@ -14,12 +14,38 @@
 
 import { useEffect, useRef, useState } from 'react';
 
+import { invoke, isNativeApp, listen } from '../github.js';
+
 const api = async (path, init) => {
   const res = await fetch(path, init);
   const json = await res.json().catch(() => ({}));
   return { ok: res.ok, status: res.status, json };
 };
 
+/**
+ * Parse a maude://open/<project>?code=mhc_… deep link. Untrusted input — a
+ * drive-by page can navigate to maude:// — so nothing here is acted on
+ * without the person pressing Connect, and the code is only ever exchanged
+ * against the app's own configured Maude Cloud address.
+ */
+export function parseDeepLink(url) {
+  const m = /^maude:\/\/open\/([a-z0-9]+(?:-[a-z0-9]+)*)\/?\?(.*)$/.exec(String(url ?? ''));
+  if (!m) return null;
+  const code = new URLSearchParams(m[2]).get('code') ?? '';
+  if (!/^mhc_[0-9a-f]{16,128}$/.test(code)) return null;
+  return { project: m[1], code };
+}
+
+/** The share view's address for a project cell URL (viewer's browser home). */
+export function shareViewUrl(projectUrl, projectId) {
+  try {
+    const u = new URL(projectUrl);
+    return `${u.protocol}//view-${u.host}`;
+  } catch {
+    return `https://view-${projectId}.cloud.maude.sh`;
+  }
+}
+
 function Spark({ size = 15 }) {
   return (
     <svg width={size} height={size} viewBox="0 0 32 32" fill="currentColor" aria-hidden="true">
@@ -76,6 +102,7 @@ export default function CloudBar() {
   const [note, setNote] = useState('');
   const [error, setError] = useState('');
   const [copied, setCopied] = useState(false);
+  const [pending, setPending] = useState(null); // { project, code } from maude://
   const railRef = useRef(null);
   const pollRef = useRef(null);
 
@@ -89,6 +116,43 @@ export default function CloudBar() {
     return () => clearInterval(pollRef.current);
   }, []);
 
+  // maude:// deep links (Phase 17) — native shell only. The link that LAUNCHED
+  // the app is parked in the shell (take once); links while running arrive as
+  // events. Either way: ask, never auto-connect.
+  useEffect(() => {
+    if (!isNativeApp()) return undefined;
+    const consume = (url) => {
+      const parsed = parseDeepLink(url);
+      if (parsed) setPending(parsed);
+    };
+    invoke('take_pending_deep_link')
+      .then((url) => url && consume(url))
+      .catch(() => {});
+    let unlisten = null;
+    listen('maude://deep-link', consume).then((fn) => {
+      unlisten = fn;
+    });
+    return () => unlisten?.();
+  }, []);
+
+  async function connectPending() {
+    if (!pending) return;
+    setBusy('deeplink');
+    setError('');
+    const r = await api('/_api/cloud/attach/code', {
+      method: 'POST',
+      headers: { 'content-type': 'application/json' },
+      body: JSON.stringify({ code: pending.code }),
+    });
+    setBusy('');
+    setPending(null);
+    if (r.ok && r.json?.ok) {
+      setNote(`Linked to ${r.json.project ?? pending.project} — restart the studio server to start syncing.`);
+    } else {
+      setError(r.json?.error || 'The workspace could not be connected.');
+    }
+  }
+
   useEffect(() => {
     if (!menuOpen) return undefined;
     const onDoc = (e) => {
@@ -186,6 +250,28 @@ export default function CloudBar() {
 
   return (
     <div className="gi-rail cb-rail" ref={railRef} data-testid="cloud-bar">
+      {pending && (
+        <div className="gi-rail-confirm" data-testid="cloud-deeplink">
+          <span className="gi-rail-hint">Connect this project to {pending.project}?</span>
+          <button
+            type="button"
+            className="btn btn--sm"
+            disabled={busy === 'deeplink'}
+            onClick={connectPending}
+            data-testid="cloud-deeplink-connect"
+          >
+            {busy === 'deeplink' ? 'Connecting…' : 'Connect'}
+          </button>
+          <button
+            type="button"
+            className="btn btn--ghost btn--sm"
+            onClick={() => setPending(null)}
+            data-testid="cloud-deeplink-dismiss"
+          >
+            Not now
+          </button>
+        </div>
+      )}
       {state === 'out' && (
         <>
           <button type="button" className="btn btn--ghost btn--sm gi-rail-signin" onClick={startSignIn} data-testid="cloud-signin">
@@ -226,21 +312,39 @@ export default function CloudBar() {
                 <div className="gi-menu-item" aria-disabled="true">No projects yet — start one on the dashboard.</div>
               )}
               {Array.isArray(projects) &&
-                projects.map((p) => (
-                  <button
-                    key={p.id}
-                    type="button"
-                    className="gi-menu-item"
-                    role="menuitem"
-                    disabled={busy === p.id}
-                    onClick={() => connect(p.id)}
-                    title={`Connect this project to ${p.url} (${p.role})`}
-                    data-testid={`cloud-project-${p.id}`}
-                  >
-                    <Icon name="link" size={15} /> {busy === p.id ? 'Connecting…' : `Connect ${p.name || p.id}`}
-                    <span className="gi-menu-login" style={{ marginLeft: 'auto' }}>{p.stateLabel}</span>
-                  </button>
-                ))}
+                projects.map((p) =>
+                  p.role === 'viewer' ? (
+                    // Viewer dignity (Phase 17 T4): no dead Connect that would
+                    // 403 at the workspace — viewing has a first-class home in
+                    // the browser, and the label says why.
+                    <button
+                      key={p.id}
+                      type="button"
+                      className="gi-menu-item"
+                      role="menuitem"
+                      onClick={() => window.open(shareViewUrl(p.url, p.id), '_blank', 'noopener')}
+                      title="Viewing works in the browser. Editing in the app needs the member role — ask whoever runs the project."
+                      data-testid={`cloud-project-${p.id}`}
+                    >
+                      <Icon name="external" size={15} /> View {p.name || p.id} in the browser
+                      <span className="gi-menu-login" style={{ marginLeft: 'auto' }}>viewer</span>
+                    </button>
+                  ) : (
+                    <button
+                      key={p.id}
+                      type="button"
+                      className="gi-menu-item"
+                      role="menuitem"
+                      disabled={busy === p.id}
+                      onClick={() => connect(p.id)}
+                      title={`Connect this project to ${p.url} (${p.role})`}
+                      data-testid={`cloud-project-${p.id}`}
+                    >
+                      <Icon name="link" size={15} /> {busy === p.id ? 'Connecting…' : `Connect ${p.name || p.id}`}
+                      <span className="gi-menu-login" style={{ marginLeft: 'auto' }}>{p.stateLabel}</span>
+                    </button>
+                  )
+                )}
               <div className="gi-menu-sep" />
               <button type="button" className="gi-menu-item" role="menuitem" onClick={() => window.open('https://cloud.maude.sh', '_blank', 'noopener')}>
                 <Icon name="external" size={15} /> Open the dashboard