@1agh/maude 0.42.0 → 0.43.0

package/apps/studio/stickers/project-status/manifest.json

@@ -0,0 +1,328 @@
+{
+  "name": "Project status stickers",
+  "author": "Iconfinder",
+  "attributionUrl": "https://www.figma.com/community/file/1128224635870836270",
+  "license": "Figma Community (see attributionUrl for terms)",
+  "stickers": [
+    {
+      "file": "group-100.png",
+      "keywords": ["thumbs-up", "awesome", "approve"]
+    },
+    {
+      "file": "group-101.png",
+      "keywords": ["super-star", "star", "cool"]
+    },
+    {
+      "file": "group-102.png",
+      "keywords": ["off", "launch", "rocket"]
+    },
+    {
+      "file": "group-103.png",
+      "keywords": ["star", "sparkle", "favorite"]
+    },
+    {
+      "file": "group-104.png",
+      "keywords": ["hot", "fire", "skull"]
+    },
+    {
+      "file": "group-105.png",
+      "keywords": ["yeah", "rock-on", "excited"]
+    },
+    {
+      "file": "group-106.png",
+      "keywords": ["plus-one", "+1", "agree"]
+    },
+    {
+      "file": "group-107.png",
+      "keywords": ["no", "reject"]
+    },
+    {
+      "file": "group-108.png",
+      "keywords": ["hate-it", "dislike", "broken-heart"]
+    },
+    {
+      "file": "group-109.png",
+      "keywords": ["fresh", "new"]
+    },
+    {
+      "file": "group-110.png",
+      "keywords": ["sleepy", "zzz", "tired"]
+    },
+    {
+      "file": "group-111.png",
+      "keywords": ["meh", "unimpressed", "neutral"]
+    },
+    {
+      "file": "group-112.png",
+      "keywords": ["ok", "thumbs-up"]
+    },
+    {
+      "file": "group-113.png",
+      "keywords": ["nope", "no", "reject"]
+    },
+    {
+      "file": "group-114.png",
+      "keywords": ["star", "sparkle", "favorite"]
+    },
+    {
+      "file": "group-115.png",
+      "keywords": ["party-time", "celebrate", "party"]
+    },
+    {
+      "file": "group-117.png",
+      "keywords": ["peace", "peace-sign"]
+    },
+    {
+      "file": "group-118.png",
+      "keywords": ["omg", "surprised", "shocked"]
+    },
+    {
+      "file": "group-119.png",
+      "keywords": ["love-it", "heart", "like"]
+    },
+    {
+      "file": "group-120.png",
+      "keywords": ["ok", "okay-hand"]
+    },
+    {
+      "file": "group-121.png",
+      "keywords": ["great-idea", "idea", "lightbulb"]
+    },
+    {
+      "file": "group-122.png",
+      "keywords": ["hmm", "thinking", "question"]
+    },
+    {
+      "file": "group-41.png",
+      "keywords": ["lol", "funny", "laugh"]
+    },
+    {
+      "file": "group-42.png",
+      "keywords": ["sparkle", "shiny", "star"]
+    },
+    {
+      "file": "group-43.png",
+      "keywords": ["good-idea", "idea", "lightbulb"]
+    },
+    {
+      "file": "group-44.png",
+      "keywords": ["thanks", "thank-you"]
+    },
+    {
+      "file": "group-45.png",
+      "keywords": ["ok", "okay"]
+    },
+    {
+      "file": "group-46.png",
+      "keywords": ["done", "finished", "complete"]
+    },
+    {
+      "file": "group-47.png",
+      "keywords": ["flagged", "flag", "important"]
+    },
+    {
+      "file": "group-48.png",
+      "keywords": ["awesome", "great"]
+    },
+    {
+      "file": "group-49.png",
+      "keywords": ["dead", "skull", "killed-it"]
+    },
+    {
+      "file": "group-50.png",
+      "keywords": ["hot", "fire", "trending"]
+    },
+    {
+      "file": "group-51.png",
+      "keywords": ["done", "thumbs-up", "approved"]
+    },
+    {
+      "file": "group-52.png",
+      "keywords": ["meh", "unimpressed", "neutral"]
+    },
+    {
+      "file": "group-53.png",
+      "keywords": ["feedback", "question"]
+    },
+    {
+      "file": "group-54.png",
+      "keywords": ["work-busy", "busy", "clock"]
+    },
+    {
+      "file": "group-55.png",
+      "keywords": ["chill", "relax", "cool"]
+    },
+    {
+      "file": "group-56.png",
+      "keywords": ["almost-done", "nearly-finished", "hourglass"]
+    },
+    {
+      "file": "group-57.png",
+      "keywords": ["no", "reject"]
+    },
+    {
+      "file": "group-58.png",
+      "keywords": ["nope", "no", "reject"]
+    },
+    {
+      "file": "group-59.png",
+      "keywords": ["star", "favorite"]
+    },
+    {
+      "file": "group-60.png",
+      "keywords": ["peace", "peace-sign"]
+    },
+    {
+      "file": "group-61.png",
+      "keywords": ["hmm", "thinking", "question"]
+    },
+    {
+      "file": "group-62.png",
+      "keywords": ["thumbs-up", "awesome", "approve"]
+    },
+    {
+      "file": "group-63.png",
+      "keywords": ["ok", "okay-hand"]
+    },
+    {
+      "file": "group-64.png",
+      "keywords": ["love-it", "heart", "like"]
+    },
+    {
+      "file": "group-65.png",
+      "keywords": ["fresh", "new"]
+    },
+    {
+      "file": "group-66.png",
+      "keywords": ["off", "launch", "rocket"]
+    },
+    {
+      "file": "group-67.png",
+      "keywords": ["hate-it", "dislike", "broken-heart"]
+    },
+    {
+      "file": "group-68.png",
+      "keywords": ["wow", "heart", "surprised"]
+    },
+    {
+      "file": "group-69.png",
+      "keywords": ["yes", "agree"]
+    },
+    {
+      "file": "group-70.png",
+      "keywords": ["plus-one", "+1", "agree"]
+    },
+    {
+      "file": "group-71.png",
+      "keywords": ["party-time", "celebrate", "party"]
+    },
+    {
+      "file": "group-72.png",
+      "keywords": ["omg", "surprised", "shocked"]
+    },
+    {
+      "file": "group-73.png",
+      "keywords": ["hot", "fire", "skull"]
+    },
+    {
+      "file": "group-74.png",
+      "keywords": ["sleepy", "zzz", "tired"]
+    },
+    {
+      "file": "group-75.png",
+      "keywords": ["wow", "surprised"]
+    },
+    {
+      "file": "group-76.png",
+      "keywords": ["yeah", "rock-on", "excited"]
+    },
+    {
+      "file": "group-77.png",
+      "keywords": ["high-alert", "warning", "urgent"]
+    },
+    {
+      "file": "group-78.png",
+      "keywords": ["thumbs-down", "dislike"]
+    },
+    {
+      "file": "group-79.png",
+      "keywords": ["great-idea", "idea", "lightbulb"]
+    },
+    {
+      "file": "group-80.png",
+      "keywords": ["super-star", "star", "cool"]
+    },
+    {
+      "file": "group-81.png",
+      "keywords": ["wow", "heart", "surprised"]
+    },
+    {
+      "file": "group-82.png",
+      "keywords": ["done", "thumbs-up", "approved"]
+    },
+    {
+      "file": "group-83.png",
+      "keywords": ["wow", "surprised"]
+    },
+    {
+      "file": "group-84.png",
+      "keywords": ["work-busy", "busy", "clock"]
+    },
+    {
+      "file": "group-85.png",
+      "keywords": ["thumbs-down", "dislike"]
+    },
+    {
+      "file": "group-86.png",
+      "keywords": ["thanks", "thank-you"]
+    },
+    {
+      "file": "group-87.png",
+      "keywords": ["flagged", "flag", "important"]
+    },
+    {
+      "file": "group-88.png",
+      "keywords": ["dead", "skull"]
+    },
+    {
+      "file": "group-89.png",
+      "keywords": ["high-alert", "warning", "urgent"]
+    },
+    {
+      "file": "group-90.png",
+      "keywords": ["good-idea", "idea", "lightbulb"]
+    },
+    {
+      "file": "group-91.png",
+      "keywords": ["lol", "funny", "laugh"]
+    },
+    {
+      "file": "group-92.png",
+      "keywords": ["awesome", "great"]
+    },
+    {
+      "file": "group-93.png",
+      "keywords": ["hot", "fire"]
+    },
+    {
+      "file": "group-94.png",
+      "keywords": ["chill", "relax", "cool"]
+    },
+    {
+      "file": "group-96.png",
+      "keywords": ["done", "finished", "complete"]
+    },
+    {
+      "file": "group-97.png",
+      "keywords": ["feedback", "question"]
+    },
+    {
+      "file": "group-98.png",
+      "keywords": ["yes", "agree"]
+    },
+    {
+      "file": "group-99.png",
+      "keywords": ["almost-done", "nearly-finished", "hourglass"]
+    }
+  ]
+}

package/apps/studio/test/acp-bootstrap-brief.test.ts

@@ -164,4 +164,15 @@ describe('buildStudioBrief — native session commands available (DDR-143)', ()
       buildStudioBrief({ designRel: '.design', projectLabel: 'maude', commandsAvailable: true })
     ).toBe(brief);
   });
+
+  test('names board + the whiteboard capability so it is reached for unprompted (Phase 5, whiteboard-improvements)', () => {
+    expect(brief).toContain('board');
+    expect(brief.toLowerCase()).toContain('whiteboard');
+  });
+
+  test('web path (commandsAvailable falsy) names board in the command family but skips the whiteboard capability fact (no in-session claim)', () => {
+    const web = buildStudioBrief({ designRel: '.design', projectLabel: 'maude' });
+    expect(web).toContain('board');
+    expect(web.toLowerCase()).not.toContain('whiteboard');
+  });
 });

package/apps/studio/test/acp-commands.test.ts

@@ -101,7 +101,8 @@ describe('Acp manager — warm frame broadcasts + open replays commands', () =>
       acp.onOpen(b.ws);
       const replay = b.frames.find((f) => f.t === 'commands');
       expect(replay).toBeDefined();
-      expect((replay?.commands as Array<{ name: string }>).length).toBe(2);
+      const replayCommands = replay?.commands as Array<{ name: string }>;
+      expect(replayCommands.length).toBe(2);
       acp.onClose(b.ws);
     } finally {
       acp.onClose(a.ws);

package/apps/studio/test/asset-api.test.ts

@@ -11,7 +11,7 @@ import { describe, expect, test } from 'bun:test';
 import { existsSync, readdirSync } from 'node:fs';
 import { join } from 'node:path';
 
-import { sniffImageType } from '../api.ts';
+import { ASSET_MAX_BYTES, sniffImageType } from '../api.ts';
 import { bootServer, killProc, makeSandbox, nextPort } from './_helpers.ts';
 
 // ── Minimal valid magic-byte headers (padded so length checks pass). ──────────
@@ -107,9 +107,9 @@ describe('asset-api / POST /_api/asset (endpoint round-trip)', () => {
     });
   });
 
-  test('rejects an oversize body (> 10 MB) with 413', async () => {
+  test('rejects an oversize body (> ASSET_MAX_BYTES) with 413', async () => {
     await withServer(async (port) => {
-      const big = new Uint8Array(10 * 1024 * 1024 + 1);
+      const big = new Uint8Array(ASSET_MAX_BYTES + 1);
       big.set([0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a], 0); // valid PNG header
       const res = await postAsset(port, big);
       expect(res.status).toBe(413);

package/apps/studio/test/canvas-edit.test.ts

@@ -377,10 +377,13 @@ describe('canvas-edit / applyTextEdit', () => {
     expect(() => applyTextEdit(CANVAS, src, id, 'x')).toThrow(CanvasEditError);
   });
 
-  test('refuses an element whose only child is a JSX expression', () => {
-    const src = 'function Demo() { const t = "x"; return <h1>{t}</h1>; }';
+  // unified-text-editing follow-up — a `{identifier}` bound to a const string
+  // is now traced back to that const and edited THERE (was a hard refusal).
+  test('edits an {identifier} child bound to a const string (traces to the const)', () => {
+    const src = 'const t = "x";\nfunction Demo() { return <h1>{t}</h1>; }';
     const id = idsOf(src).h1 as string;
-    expect(() => applyTextEdit(CANVAS, src, id, 'x')).toThrow(CanvasEditError);
+    const out = applyTextEdit(CANVAS, src, id, 'New', { before: 'x' });
+    expect(out.source).toContain('const t = "New"');
   });
 
   test('refuses a self-closing / empty element (no text to edit)', () => {
@@ -412,10 +415,18 @@ describe('canvas-edit / applyTextEdit', () => {
     expect(() => transpileCanvasSource(CANVAS, out.source)).not.toThrow();
   });
 
-  test('still refuses a dynamic {identifier} child (routes to /design:edit)', () => {
-    const src = 'function Demo() { const title = "x"; return <h1>{title}</h1>; }';
+  test('still refuses a genuinely-computed expression child (routes to /design:edit)', () => {
+    // Call expression — no single source string to rewrite → hard refusal.
+    const src = 'const price = 9;\nfunction Demo() { return <h1>{price.toFixed(2)}</h1>; }';
     const id = idsOf(src).h1 as string;
-    expect(() => applyTextEdit(CANVAS, src, id, 'x')).toThrow(CanvasEditError);
+    expect(() => applyTextEdit(CANVAS, src, id, 'x', { before: '9.00' })).toThrow(CanvasEditError);
+  });
+
+  test('refuses an {identifier} that does not resolve to a string const', () => {
+    // `count` is a number const — no string to trace to → refuse.
+    const src = 'const count = 3;\nfunction Demo() { return <h1>{count}</h1>; }';
+    const id = idsOf(src).h1 as string;
+    expect(() => applyTextEdit(CANVAS, src, id, 'x', { before: '3' })).toThrow(CanvasEditError);
   });
 });
 

package/apps/studio/test/canvas-origin-gate.test.ts

@@ -162,6 +162,19 @@ describe('canvas-origin gate — A1/A2 traversal + privilege containment', () =>
         // untrusted canvas origin must never read (or write) the user's pasted
         // chat images; a GET here 403s at the gate, not 404 from the handler.
         '/_api/acp/attachment',
+        // Phase 4 (feature-whiteboard-annotation-improvements) — the sticker
+        // catalogue + bundled sticker PNGs are MAIN-ORIGIN ONLY, same posture
+        // as /_api/assets above: the StickerPicker is shell UI, absent from
+        // CANVAS_SAFE_API + startCanvasServer's routes. A GET here 403s at
+        // the gate on both — the catalogue route and the static PNG serve.
+        '/_api/stickers',
+        '/_stickers/some-pack/some-sticker.png',
+        // feature-footage-analysis-director — the footage-analysis + EDL sidecar
+        // route is MAIN-ORIGIN ONLY (written by the analyst/director agents over
+        // loopback; absent from CANVAS_SAFE_API + startCanvasServer's routes). The
+        // untrusted canvas origin must never read/write the director's analysis —
+        // a GET here 403s at the gate, not 405 from a reached handler.
+        '/_api/footage',
         '/package.json',
       ]) {
         expect(await code(p)).toBe(403);

package/apps/studio/test/dynamic-text-edit.test.ts

@@ -0,0 +1,162 @@
+import { describe, expect, test } from 'bun:test';
+import { applyTextEdit } from '../canvas-edit.ts';
+import { transpileCanvasSource } from '../canvas-pipeline.ts';
+
+// unified-text-editing follow-up — editing text that comes from a `{variable}`
+// or `{item.prop}` by tracing it back to its source string (a local const or a
+// `.map()`ed array element). The safety contract: never rewrite the wrong item
+// — occurrence picks the `.map()` slot, `before` verifies/rescues it, and an
+// unresolvable expression still throws (routes to /design:edit).
+
+const CANVAS = '/virtual/Cards.tsx';
+const SRC = `const TOPICS = [
+  { key: "a", body: "Alpha body text." },
+  { key: "b", body: "Beta body text." },
+  { key: "c", body: "Gamma body text." },
+];
+const TAGS = ["first", "second", "third"];
+const HEADLINE = "The one headline";
+export default function Cards() {
+  return (
+    <div>
+      <h1>{HEADLINE}</h1>
+      <section>
+        {TOPICS.map((t) => (
+          <article key={t.key}>
+            <p>{t.body}</p>
+          </article>
+        ))}
+      </section>
+      <ul>
+        {TAGS.map((tag) => (
+          <li key={tag}>{tag}</li>
+        ))}
+      </ul>
+      <p>Total: {TOPICS.length} topics</p>
+      <span>{price.toFixed(2)}</span>
+    </div>
+  );
+}
+const price = 9;
+`;
+
+function ids(withIds: string, tag: string, inner: string): string {
+  // Grab the data-cd-id of the <tag …>inner… element.
+  const re = new RegExp(`<${tag}\\s+data-cd-id="([^"]+)"[^>]*>\\s*\\{?${inner}`);
+  const m = withIds.match(re);
+  if (!m) throw new Error(`no ${tag} matching ${inner}`);
+  return m[1] as string;
+}
+
+describe('dynamic text edit — resolveDynamicTextSpan via applyTextEdit', () => {
+  const { withIds } = transpileCanvasSource(CANVAS, SRC);
+
+  test('{item.prop} in a .map — occurrence picks the array item', () => {
+    const pId = ids(withIds, 'p', 't\\.body');
+    // occurrence 1 → TOPICS[1].body, verified by `before`.
+    const { source } = applyTextEdit(CANVAS, withIds, pId, 'Beta EDITED', {
+      occurrence: 1,
+      before: 'Beta body text.',
+    });
+    expect(source).toContain('body: "Beta EDITED"');
+    expect(source).toContain('body: "Alpha body text."'); // sibling untouched
+    expect(source).toContain('body: "Gamma body text."');
+  });
+
+  test('{item.prop} — index drift rescued by unique before-match', () => {
+    const pId = ids(withIds, 'p', 't\\.body');
+    // Wrong occurrence, but `before` uniquely identifies Gamma → rewrite it.
+    const { source } = applyTextEdit(CANVAS, withIds, pId, 'Gamma EDITED', {
+      occurrence: 0,
+      before: 'Gamma body text.',
+    });
+    expect(source).toContain('body: "Gamma EDITED"');
+    expect(source).toContain('body: "Alpha body text."');
+  });
+
+  test('{item} in a .map over a string array', () => {
+    const liId = ids(withIds, 'li', 'tag');
+    const { source } = applyTextEdit(CANVAS, withIds, liId, 'SECOND', {
+      occurrence: 1,
+      before: 'second',
+    });
+    expect(source).toContain('"first", "SECOND", "third"');
+  });
+
+  test('{localConst} — rewrites the const string', () => {
+    const h1Id = ids(withIds, 'h1', 'HEADLINE');
+    const { source } = applyTextEdit(CANVAS, withIds, h1Id, 'A new headline', {
+      before: 'The one headline',
+    });
+    expect(source).toContain('HEADLINE = "A new headline"');
+  });
+
+  test('{prop.field} — component fed BEATS[k] resolves to BEATS[k].field', () => {
+    // A reusable component whose `beat` prop is fed `BEATS[0..2]` at each usage
+    // (the Remotion-style pattern). Editing the 2nd usage's caption must hit
+    // BEATS[1].caption via occurrence, not card 0 or 2.
+    const SRC2 = `const BEATS = [
+  { n: "01", caption: "Beat one caption." },
+  { n: "02", caption: "Beat two caption." },
+  { n: "03", caption: "Beat three caption." },
+];
+function GuideBeat({ beat }: { beat: (typeof BEATS)[number] }) {
+  return <p>{beat.caption}</p>;
+}
+export default function Reel() {
+  return (
+    <div>
+      <GuideBeat beat={BEATS[0]} />
+      <GuideBeat beat={BEATS[1]} />
+      <GuideBeat beat={BEATS[2]} />
+    </div>
+  );
+}`;
+    const built = transpileCanvasSource(CANVAS, SRC2).withIds;
+    const pId = /<p\s+data-cd-id="([^"]+)"[^>]*>\s*\{beat\.caption\}/.exec(built)?.[1] as string;
+    const { source } = applyTextEdit(CANVAS, built, pId, 'Beat two EDITED', {
+      occurrence: 1,
+      before: 'Beat two caption.',
+    });
+    expect(source).toContain('caption: "Beat two EDITED"');
+    expect(source).toContain('caption: "Beat one caption."');
+    expect(source).toContain('caption: "Beat three caption."');
+  });
+
+  test('genuinely computed text still refuses (routes to /design:edit)', () => {
+    const spanId = ids(withIds, 'span', 'price\\.toFixed');
+    expect(() =>
+      applyTextEdit(CANVAS, withIds, spanId, 'nope', { occurrence: 0, before: '9.00' })
+    ).toThrow(/dynamic content/);
+  });
+
+  test('mixed literal+expression (Total: {n} topics) refuses', () => {
+    // This <p> has text + expression + text → mixed, never offered.
+    const m = withIds.match(/<p[^>]*data-cd-id="([^"]+)"[^>]*>Total:/);
+    expect(m).toBeTruthy();
+    expect(() => applyTextEdit(CANVAS, withIds, (m as RegExpMatchArray)[1] as string, 'x')).toThrow(
+      /mixed or expression/
+    );
+  });
+
+  test('no occurrence + no before on an ambiguous .map refuses (never guesses)', () => {
+    const pId = ids(withIds, 'p', 't\\.body');
+    // Without occurrence or before there is no way to know which card → refuse.
+    expect(() => applyTextEdit(CANVAS, withIds, pId, 'x')).toThrow(/dynamic content/);
+  });
+});
+
+describe('stamp marks var-editable text', () => {
+  const { withIds } = transpileCanvasSource(CANVAS, SRC);
+  test('{item.prop}, {item}, {const} get data-cd-editable="var"', () => {
+    expect(withIds).toMatch(/<p[^>]*data-cd-editable="var"[^>]*>\s*\{t\.body\}/);
+    expect(withIds).toMatch(/<li[^>]*data-cd-editable="var"[^>]*>\s*\{tag\}/);
+    expect(withIds).toMatch(/<h1[^>]*data-cd-editable="var"[^>]*>\s*\{HEADLINE\}/);
+  });
+  test('computed + mixed text are NOT marked', () => {
+    const span = withIds.match(/<span[^>]*>\{price\.toFixed/);
+    expect((span as RegExpMatchArray)[0].includes('data-cd-editable')).toBe(false);
+    const p = withIds.match(/<p[^>]*>Total:/);
+    expect((p as RegExpMatchArray)[0].includes('data-cd-editable')).toBe(false);
+  });
+});

package/apps/studio/test/edit-source-command.test.ts

@@ -30,9 +30,32 @@ describe('createEditSourceCommand', () => {
       id: 'cd-1',
       key: 'color',
       value: 'blue',
+      // do() writes `after` over `before`, so `from` = before; css has no occurrence.
+      from: 'red',
+      occurrence: undefined,
     });
   });
 
+  test('do()/undo() carry occurrence + from for a text edit (variable re-target)', async () => {
+    const applyFn = mock(() => {});
+    const textEdit: EditSourcePayload = {
+      op: 'text',
+      canvas: '.design/ui/Foo.tsx',
+      id: 'cd-9',
+      key: '',
+      before: 'Old',
+      after: 'New',
+      occurrence: 2,
+    };
+    const cmd = createEditSourceCommand({ payload: textEdit, applyFn });
+    await cmd.do();
+    // redo/do: write New over Old → from = Old.
+    expect(applyFn.mock.calls[0]?.[0]).toMatchObject({ value: 'New', from: 'Old', occurrence: 2 });
+    await cmd.undo();
+    // undo: write Old over New → from = New.
+    expect(applyFn.mock.calls[1]?.[0]).toMatchObject({ value: 'Old', from: 'New', occurrence: 2 });
+  });
+
   test('undo() applies the BEFORE value', async () => {
     const applyFn = mock(() => {});
     const cmd = createEditSourceCommand({ payload: cssEdit, applyFn });