@1agh/maude 0.28.0 → 0.29.0

package/apps/studio/test/canvas-url.test.ts

@@ -0,0 +1,99 @@
+// DDR-093 — canvasUrl() token-resolution. Regression guard for the
+// "non-default-DS UI canvas renders unstyled" bug: every `ui/*.tsx` authored
+// under a non-default design system used to load designSystems[0]'s tokens
+// (scoped to a different `.<rootClass>` subtree) so every `var(--*)` went
+// undefined and the canvas rendered white.
+
+import { describe, expect, test } from 'bun:test';
+
+import { canvasUrl, urlOf } from '../client/canvas-url.js';
+
+// Mirrors this repo's real multi-DS config: `project` is the default (ds0),
+// `maude` is the non-default one that the bug broke.
+const cfg = {
+  designRel: '.design',
+  designSystems: [
+    { name: 'project', path: 'system/project', tokensCssRel: 'system/project/colors_and_type.css' },
+    { name: 'maude', path: 'system/maude', tokensCssRel: 'system/maude/colors_and_type.css' },
+  ],
+};
+
+function paramsOf(url: string): URLSearchParams {
+  const qs = url.split('?')[1] ?? '';
+  return new URLSearchParams(qs);
+}
+
+describe('canvasUrl — per-canvas design-system token resolution', () => {
+  test('explicit opts.ds resolves a non-default DS canvas to its OWN tokens', () => {
+    const p = paramsOf(canvasUrl('.design/ui/Studio.tsx', cfg, { ds: 'maude' }));
+    expect(p.get('tokens')).toBe('system/maude/colors_and_type.css');
+    expect(p.get('components')).toBe('system/maude/preview/_components.css');
+  });
+
+  test('RCA interface form — relative path + opts.ds', () => {
+    const p = paramsOf(canvasUrl('ui/Studio.tsx', cfg, { ds: 'maude' }));
+    expect(p.get('tokens')).toBe('system/maude/colors_and_type.css');
+    expect(p.get('components')).toBe('system/maude/preview/_components.css');
+  });
+
+  test('opts.ds = the default DS resolves to ds0 tokens', () => {
+    const p = paramsOf(canvasUrl('.design/ui/Studio.tsx', cfg, { ds: 'project' }));
+    expect(p.get('tokens')).toBe('system/project/colors_and_type.css');
+    expect(p.get('components')).toBe('system/project/preview/_components.css');
+  });
+
+  test('cfg.canvasDesignSystems map drives resolution when opts.ds is absent', () => {
+    const withMap = { ...cfg, canvasDesignSystems: { '.design/ui/Studio.tsx': 'maude' } };
+    const p = paramsOf(canvasUrl('.design/ui/Studio.tsx', withMap));
+    expect(p.get('tokens')).toBe('system/maude/colors_and_type.css');
+    expect(p.get('components')).toBe('system/maude/preview/_components.css');
+  });
+
+  test('opts.ds wins over the map', () => {
+    const withMap = { ...cfg, canvasDesignSystems: { '.design/ui/Studio.tsx': 'maude' } };
+    const p = paramsOf(canvasUrl('.design/ui/Studio.tsx', withMap, { ds: 'project' }));
+    expect(p.get('tokens')).toBe('system/project/colors_and_type.css');
+  });
+
+  test('unknown / no DS falls back to ds0 (single-DS + legacy behavior intact)', () => {
+    const p = paramsOf(canvasUrl('.design/ui/Plain.tsx', cfg, {}));
+    expect(p.get('tokens')).toBe('system/project/colors_and_type.css');
+    expect(p.get('components')).toBe('system/project/preview/_components.css');
+  });
+
+  test('an unknown DS name (not in designSystems) falls back to ds0, never undefined', () => {
+    const p = paramsOf(canvasUrl('.design/ui/Ghost.tsx', cfg, { ds: 'does-not-exist' }));
+    expect(p.get('tokens')).toBe('system/project/colors_and_type.css');
+  });
+
+  test('specimen paths stay path-resolved and are unaffected by the map', () => {
+    const withWrongMap = {
+      ...cfg,
+      // A bogus map entry must NOT override the specimen branch.
+      canvasDesignSystems: { '.design/system/maude/preview/Buttons.tsx': 'project' },
+    };
+    const p = paramsOf(canvasUrl('.design/system/maude/preview/Buttons.tsx', withWrongMap));
+    expect(p.get('tokens')).toBe('system/maude/colors_and_type.css');
+    expect(p.get('layout')).toBe('system/maude/preview/_layout.css');
+    expect(p.get('components')).toBe('system/maude/preview/_components.css');
+  });
+
+  test('the bug it guards against: ds0 is the WRONG DS for a maude canvas', () => {
+    // Documents the failure mode — with neither opts.ds nor a map entry the
+    // resolver returns designSystems[0] (project), which is exactly what broke a
+    // maude canvas before DDR-093. The fix is that the map now supplies 'maude'.
+    const p = paramsOf(canvasUrl('.design/ui/Studio.tsx', cfg));
+    expect(p.get('tokens')).toBe('system/project/colors_and_type.css'); // ds0 — wrong for maude
+    const fixed = paramsOf(
+      canvasUrl('.design/ui/Studio.tsx', {
+        ...cfg,
+        canvasDesignSystems: { '.design/ui/Studio.tsx': 'maude' },
+      })
+    );
+    expect(fixed.get('tokens')).toBe('system/maude/colors_and_type.css'); // fixed
+  });
+
+  test('non-tsx paths bypass the shell and return a direct URL', () => {
+    expect(canvasUrl('.design/ui/legacy.html', cfg)).toBe(urlOf('.design/ui/legacy.html'));
+  });
+});

package/{plugins/design/dev-server → apps/studio}/test/collab-annotations-bridge.test.ts

@@ -45,7 +45,7 @@ describe('Registry.syncRoomFromAnnotations', () => {
   test('inspector-write origin propagates through doc.update', () => {
     const r = createRegistry(noopCallbacks());
     const room = r.get('echo-slug');
-    let lastOrigin: unknown = undefined;
+    let lastOrigin: unknown;
     room.doc.on('update', (_update, origin) => {
       lastOrigin = origin;
     });

package/{plugins/design/dev-server → apps/studio}/test/collab-bridge.test.ts

@@ -71,7 +71,7 @@ describe('Registry inspector-bridge', () => {
   test('inspector-write origin triggers doc.update broadcast', async () => {
     const r = createRegistry(noopCallbacks());
     const room = r.get('echo-slug');
-    let lastOrigin: unknown = undefined;
+    let lastOrigin: unknown;
     room.doc.on('update', (_update, origin) => {
       lastOrigin = origin;
     });

package/{plugins/design/dev-server → apps/studio}/test/collab-room.test.ts

@@ -12,7 +12,7 @@ import {
   encodeSyncUpdate,
   handleMessage,
 } from '../collab/protocol.ts';
-import { type RoomCallbacks, type RoomConn, createRoom } from '../collab/room.ts';
+import { createRoom, type RoomCallbacks, type RoomConn } from '../collab/room.ts';
 
 function makeConn(id: string): RoomConn & { recv: Uint8Array[] } {
   const recv: Uint8Array[] = [];

package/{plugins/design/dev-server → apps/studio}/test/collab-stress.test.ts

@@ -19,7 +19,7 @@ import { afterEach, describe, expect, test } from 'bun:test';
 import { Awareness } from 'y-protocols/awareness';
 import * as Y from 'yjs';
 
-import { type RoomConn, createRoom } from '../collab/room.ts';
+import { createRoom, type RoomConn } from '../collab/room.ts';
 
 const STRESS_MS = Number(process.env.MAUDE_STRESS_MS ?? 10_000);
 const RSS_GROWTH_LIMIT_MB = 20;

package/{plugins/design/dev-server → apps/studio}/test/comments-api.test.ts

@@ -11,11 +11,10 @@
 //     git sandbox; gracefully empty if git fails)
 //   - Reply on unknown id → 404
 
+import { describe, expect, test } from 'bun:test';
 import { mkdirSync, readFileSync, writeFileSync } from 'node:fs';
 import { join } from 'node:path';
 
-import { describe, expect, test } from 'bun:test';
-
 import { bootServer, killProc, makeSandbox, nextPort } from './_helpers.ts';
 
 async function initGit(root: string) {

package/{plugins/design/dev-server → apps/studio}/test/compile-entry.test.ts

@@ -4,12 +4,11 @@
 // no spawn): given a target, it writes two files (`init-oxc-<slug>.ts` +
 // `server-<slug>.ts`) under dist/.compile-entries/ and returns the entry path.
 
+import { describe, expect, test } from 'bun:test';
 import { existsSync, readFileSync, rmSync } from 'node:fs';
 import { dirname, join } from 'node:path';
 import { fileURLToPath } from 'node:url';
 
-import { describe, expect, test } from 'bun:test';
-
 import { writeCompileEntry } from '../build.ts';
 
 const ROOT = dirname(fileURLToPath(import.meta.url));

package/{plugins/design/dev-server → apps/studio}/test/exporters/canva.test.ts

@@ -4,9 +4,8 @@
 // + the empty/file-tree branches.
 
 import { describe, expect, test } from 'bun:test';
-
-import { buildHandoffMarkdown } from '../../exporters/canva-handoff-prompt.ts';
 import { run } from '../../exporters/canva.ts';
+import { buildHandoffMarkdown } from '../../exporters/canva-handoff-prompt.ts';
 
 const CTX = {
   designRoot: '/tmp/.design',

package/{plugins/design/dev-server → apps/studio}/test/exporters/history.test.ts

@@ -1,10 +1,9 @@
 // Phase 6.5 T10 — export history persistence + endpoint.
 
+import { describe, expect, test } from 'bun:test';
 import { readFileSync } from 'node:fs';
 import { join } from 'node:path';
 
-import { describe, expect, test } from 'bun:test';
-
 import { bootServer, killProc, makeSandbox, nextPort } from '../_helpers.ts';
 
 interface HistoryShape {

package/{plugins/design/dev-server → apps/studio}/test/exporters/pw-launch.test.ts

@@ -7,7 +7,7 @@
 
 import { describe, expect, test } from 'bun:test';
 
-import { INSTALL_HINT, NO_BROWSER_EXIT, isMissingBrowserError } from '../../bin/_pw-launch.mjs';
+import { INSTALL_HINT, isMissingBrowserError, NO_BROWSER_EXIT } from '../../bin/_pw-launch.mjs';
 
 describe('_pw-launch — missing-browser classifier', () => {
   test('matches the real Playwright "Executable doesn\'t exist" message', () => {

package/{plugins/design/dev-server → apps/studio}/test/exporters/scope.test.ts

@@ -4,12 +4,11 @@
 // `_active.json` shapes. `project-raw` exercises the fs walk inside a
 // throwaway temp dir; the other three branches don't touch disk.
 
+import { describe, expect, test } from 'bun:test';
 import { mkdirSync, mkdtempSync, writeFileSync } from 'node:fs';
 import { tmpdir } from 'node:os';
 import { join } from 'node:path';
 
-import { describe, expect, test } from 'bun:test';
-
 import { type ActiveJsonShape, resolveScope } from '../../exporters/scope.ts';
 
 function emptyActive(): ActiveJsonShape {

package/{plugins/design/dev-server → apps/studio}/test/exporters/zip.test.ts

@@ -3,11 +3,10 @@
 // Real walk + bundle against a sandboxed designRoot, then unzip the result
 // and diff against expected contents.
 
+import { describe, expect, test } from 'bun:test';
 import { mkdirSync, mkdtempSync, writeFileSync } from 'node:fs';
 import { tmpdir } from 'node:os';
 import { join } from 'node:path';
-
-import { describe, expect, test } from 'bun:test';
 import JSZip from 'jszip';
 
 import { resolveScope } from '../../exporters/scope.ts';

package/{plugins/design/dev-server → apps/studio}/test/git-lifecycle.test.ts

@@ -8,12 +8,11 @@
 // already exposes flushAll(). The integration with .git/HEAD writes is
 // exercised manually in the Task 7 acceptance test (Phase 8 plan validate row).
 
+import { afterEach, beforeEach, describe, expect, test } from 'bun:test';
 import { existsSync, mkdirSync, mkdtempSync, rmSync, writeFileSync } from 'node:fs';
 import { tmpdir } from 'node:os';
 import path from 'node:path';
 
-import { afterEach, beforeEach, describe, expect, test } from 'bun:test';
-
 import { createGitLifecycle } from '../collab/git-lifecycle.ts';
 import { createRegistry } from '../collab/registry.ts';
 import type { RoomCallbacks } from '../collab/room.ts';

package/{plugins/design/dev-server → apps/studio}/test/handoff-static-frames.test.ts

@@ -5,7 +5,7 @@
 import { describe, expect, test } from 'bun:test';
 
 import { buildLibMap, inlineUsedExports } from '../canvas-lib-inline.ts';
-import { HANDOFF_STATIC_FRAME_EXPORTS, applyHandoffStaticOverrides } from '../handoff.ts';
+import { applyHandoffStaticOverrides, HANDOFF_STATIC_FRAME_EXPORTS } from '../handoff.ts';
 
 const LIB_PATH = '/virtual/_lib/canvas-lib.tsx';
 

package/{plugins/design/dev-server → apps/studio}/test/hmr-broadcast.test.ts

@@ -3,7 +3,7 @@
 import { describe, expect, test } from 'bun:test';
 
 import { type Context, createBus } from '../context.ts';
-import { HMR_DEBOUNCE_MS, type HmrMessage, createHmrBroadcaster } from '../hmr-broadcast.ts';
+import { createHmrBroadcaster, HMR_DEBOUNCE_MS, type HmrMessage } from '../hmr-broadcast.ts';
 
 function mkCtx(): Context {
   const bus = createBus();

package/apps/studio/test/index-data-canvas-ds.test.ts

@@ -0,0 +1,97 @@
+// DDR-093 — `/_index-data` attaches a per-canvas design-system map so the
+// client's canvasUrl() can inject each UI canvas's OWN tokens instead of always
+// designSystems[0]. This is the server half of the
+// "non-default-DS canvas renders unstyled" fix.
+
+import { describe, expect, test } from 'bun:test';
+import { mkdirSync, mkdtempSync, writeFileSync } from 'node:fs';
+import { tmpdir } from 'node:os';
+import { join } from 'node:path';
+
+import { bootServer, killProc, nextPort } from './_helpers.ts';
+
+// A two-DS sandbox: `project` is the default (ds0, rootClass mdcc), `maude` is
+// the non-default one (rootClass maude) the bug broke.
+function makeMultiDsSandbox(): { root: string; designRoot: string } {
+  const root = mkdtempSync(join(tmpdir(), 'mdcc-multids-'));
+  const designRoot = join(root, '.design');
+  mkdirSync(designRoot, { recursive: true });
+  writeFileSync(
+    join(designRoot, 'config.json'),
+    JSON.stringify(
+      {
+        name: 'multi-ds-test',
+        designRoot: '.design',
+        canvasGroups: [
+          { label: 'Design system', path: 'system' },
+          { label: 'UI kit', path: 'ui' },
+        ],
+        designSystems: [
+          { name: 'project', path: 'system/project', rootClass: 'mdcc' },
+          { name: 'maude', path: 'system/maude', rootClass: 'maude' },
+        ],
+        defaultDesignSystem: 'project',
+      },
+      null,
+      2
+    )
+  );
+
+  const tsx = 'export default function C(){return <main/>}\n';
+
+  // UI canvas authored under the NON-default DS — declares it in its sidecar.
+  mkdirSync(join(designRoot, 'ui'), { recursive: true });
+  writeFileSync(join(designRoot, 'ui', 'Studio.tsx'), tsx);
+  writeFileSync(
+    join(designRoot, 'ui', 'Studio.meta.json'),
+    JSON.stringify({ designSystem: 'maude' })
+  );
+
+  // UI canvas with a sidecar that omits designSystem → resolves to the default.
+  writeFileSync(join(designRoot, 'ui', 'Plain.tsx'), tsx);
+  writeFileSync(join(designRoot, 'ui', 'Plain.meta.json'), JSON.stringify({ title: 'Plain' }));
+
+  // UI canvas with NO sidecar at all → also defaults.
+  writeFileSync(join(designRoot, 'ui', 'Bare.tsx'), tsx);
+
+  // Specimens — DS resolved path-authoritatively (no sidecar needed).
+  mkdirSync(join(designRoot, 'system', 'maude', 'preview'), { recursive: true });
+  writeFileSync(join(designRoot, 'system', 'maude', 'preview', 'Buttons.tsx'), tsx);
+  mkdirSync(join(designRoot, 'system', 'project', 'preview'), { recursive: true });
+  writeFileSync(join(designRoot, 'system', 'project', 'preview', 'Cards.tsx'), tsx);
+
+  return { root, designRoot };
+}
+
+interface IndexData {
+  canvasDesignSystems?: Record<string, string>;
+  groups?: { paths?: string[] }[];
+}
+
+describe('/_index-data — per-canvas design-system map', () => {
+  test('attaches the right DS for UI canvases (sidecar) and specimens (path)', async () => {
+    const { root } = makeMultiDsSandbox();
+    const port = nextPort();
+    const proc = await bootServer(root, port);
+    try {
+      const r = await fetch(`http://localhost:${port}/_index-data`);
+      expect(r.status).toBe(200);
+      const data = (await r.json()) as IndexData;
+      const map = data.canvasDesignSystems ?? {};
+
+      // The bug: this used to be implicitly designSystems[0] ('project'). The
+      // sidecar declares 'maude', so the server must surface 'maude'.
+      expect(map['.design/ui/Studio.tsx']).toBe('maude');
+
+      // Sidecar without designSystem, and no sidecar at all → project default.
+      expect(map['.design/ui/Plain.tsx']).toBe('project');
+      expect(map['.design/ui/Bare.tsx']).toBe('project');
+
+      // Specimens resolve from their `system/<ds>/` folder.
+      expect(map['.design/system/maude/preview/Buttons.tsx']).toBe('maude');
+      expect(map['.design/system/project/preview/Cards.tsx']).toBe('project');
+    } finally {
+      await killProc(proc);
+    }
+  });
+});

package/apps/studio/test/motion-sample.test.ts

@@ -0,0 +1,35 @@
+// Unit cover for the live-motion proof sampler's pure delta test. The browser
+// drive itself is integration-shape (needs Chromium + a running dev server);
+// here we pin the `signatureChanged` classifier that decides motion-proven vs
+// dead-mechanism, so a regression can't silently turn a freeze-frame "pass"
+// into a false motion confirmation (DDR-094 M1).
+
+import { describe, expect, test } from 'bun:test';
+import { signatureChanged } from '../bin/_motion-sample-playwright.mjs';
+
+const base = { x: 10, y: 10, width: 80, height: 80, transform: 'none', opacity: 1 };
+
+describe('signatureChanged', () => {
+  test('identical samples ⇒ no change (dead mechanism)', () => {
+    expect(signatureChanged(base, { ...base })).toBe(false);
+  });
+  test('a bbox shift (morph/scale/translate) ⇒ change', () => {
+    expect(signatureChanged(base, { ...base, width: 92 })).toBe(true);
+  });
+  test('a transform-matrix change ⇒ change (rotate/scale via CSS)', () => {
+    expect(signatureChanged(base, { ...base, transform: 'matrix(1,0.2,0,1,0,0)' })).toBe(true);
+  });
+  test('an opacity fade ⇒ change (no bbox delta)', () => {
+    expect(signatureChanged(base, { ...base, opacity: 0.4 })).toBe(true);
+  });
+  test('sub-epsilon numeric jitter is NOT a change (anti-flake)', () => {
+    expect(signatureChanged(base, { ...base, x: 10.1 })).toBe(false);
+    expect(signatureChanged(base, { ...base, x: 10.1 }, 0.05)).toBe(true); // tighter eps catches it
+  });
+  test('the internal __missing marker never counts as a change', () => {
+    expect(signatureChanged({ __missing: true }, { __missing: true })).toBe(false);
+  });
+  test('a null sample is not a change (fail closed)', () => {
+    expect(signatureChanged(null, base)).toBe(false);
+  });
+});

package/{plugins/design/dev-server → apps/studio}/test/perf-harness.ts

@@ -1,7 +1,7 @@
 #!/usr/bin/env bun
 // Performance harness for Phase 3.4 budgets.
 //
-//   bun run plugins/design/dev-server/test/perf-harness.ts
+//   bun run apps/studio/test/perf-harness.ts
 //
 // Boots the dev-server against a synthetic .design/ fixture, measures the
 // budget table from `.ai/plans/phase-3.4-architecture-refactor.md`, and writes

package/{plugins/design/dev-server → apps/studio}/test/phase-3.6-smoke.test.ts

@@ -19,7 +19,9 @@ import { buildCanvasModule } from '../canvas-build.ts';
 import { transpileCanvasSource } from '../canvas-pipeline.ts';
 import { emitRegistryItem } from '../handoff.ts';
 
-const REPO_ROOT = path.resolve(import.meta.dir, '../../../..');
+// apps/studio/test → ../../.. = repo root (DDR-095: was ../../../.. at the old
+// plugins/design/dev-server/test depth).
+const REPO_ROOT = path.resolve(import.meta.dir, '../../..');
 const DESIGN_ROOT = path.join(REPO_ROOT, '.design');
 const DOCS_SITE = path.join(DESIGN_ROOT, 'ui/Docs Site.tsx');
 const CANVAS_VIEWPORT = path.join(DESIGN_ROOT, 'ui/Canvas Viewport.tsx');