@1agh/maude 0.26.0 → 0.27.0

package/plugins/design/dev-server/sync/agent.ts

@@ -317,15 +317,30 @@ export function createCanvasSyncAgent(opts: CanvasSyncAgentOptions): CanvasSyncA
     lastMeta = docMeta;
     lastCss = docCss;
     if (localHtml !== docHtml) {
-      // Local had divergent, non-empty content that hub-wins is discarding —
-      // notify so the user knows their local edits were overwritten (Task 8).
-      // An absent/empty local file is a clean first-sync, not a conflict.
-      if (localHtml !== null && localHtml.trim() !== '') {
-        opts.onConflict?.({ slug, kind: 'cold-start-hub-wins' });
+      // DATA-LOSS GUARD: an EMPTY hub doc at cold-start means the hub holds no
+      // body for this slug yet (fresh / never-seeded hub) — NOT an authoritative
+      // "this canvas is blank". Overwriting a non-empty local body with it would
+      // silently destroy the canvas (observed in the wild: a fresh hub emptied
+      // every local .tsx on first connect). The comments/annotations/meta/css
+      // branches below already skip empty-doc writes, and the shared-doc
+      // projection path documents the same "never clobber non-empty local with
+      // an empty doc value" rule — the HTML body was the one branch missing it.
+      // Resolution: seed the doc FROM local instead, so the body survives AND
+      // the hub gets our content (local→doc, exactly like a first-sync seed).
+      if (docHtml === '' && localHtml !== null && localHtml.trim() !== '') {
+        applyHtmlToDoc(doc, localHtml, origin);
+        lastHtml = localHtml;
+      } else {
+        // Local had divergent, non-empty content that hub-wins is discarding —
+        // notify so the user knows their local edits were overwritten (Task 8).
+        // An absent/empty local file is a clean first-sync, not a conflict.
+        if (localHtml !== null && localHtml.trim() !== '') {
+          opts.onConflict?.({ slug, kind: 'cold-start-hub-wins' });
+        }
+        const hash = hashBytes(docHtml);
+        echoGuard.record(paths.html, hash);
+        writer(paths.html, docHtml);
       }
-      const hash = hashBytes(docHtml);
-      echoGuard.record(paths.html, hash);
-      writer(paths.html, docHtml);
     }
     if (docCommentsStr !== '' && localComments !== docCommentsStr) {
       const hash = hashBytes(docCommentsStr);

package/plugins/design/dev-server/test/sync-agent.test.ts

@@ -202,6 +202,34 @@ describe('CanvasSyncAgent — cold start reconciliation', () => {
     expect(htmlFromDoc(docB)).toBe('<button>hub-v2</button>');
   });
 
+  test('empty hub doc does NOT clobber a non-empty local body — seeds local up instead (data-loss guard)', async () => {
+    // Local holds the real canvas body; the hub is fresh — no state for this
+    // slug yet (docB starts empty → docHtml === ''). The old behaviour wrote
+    // the empty doc over disk and emptied the file; the guard must keep local.
+    writeFileSync(paths().html, '<button>real-canvas</button>');
+
+    let conflicts = 0;
+    agent = createCanvasSyncAgent({
+      slug: 'screen',
+      doc: docB,
+      paths: paths(),
+      echoGuard: createEchoGuard(),
+      flushMs: 0,
+      onConflict: () => {
+        conflicts++;
+      },
+    });
+    agent.start();
+    await agent.reconcile();
+
+    // The local body MUST survive — an empty hub must never empty a real canvas.
+    expect(readFileSync(paths().html, 'utf8')).toBe('<button>real-canvas</button>');
+    // …and it is seeded UP to the hub instead of being discarded (local→doc).
+    expect(htmlFromDoc(docA)).toBe('<button>real-canvas</button>');
+    // An empty-hub seed is not a "hub overwrote your local" conflict.
+    expect(conflicts).toBe(0);
+  });
+
   test('identical disk + doc states: no disk write', async () => {
     writeFileSync(paths().html, '<button>same</button>');
     applyHtmlToDoc(docA, '<button>same</button>');