@1aboveio/skills 1.0.8 → 1.0.9

package/skills/engineering/better-review/scripts/scan-diff.test.mjs

@@ -1,414 +0,0 @@
-import { test } from 'node:test'
-import assert from 'node:assert/strict'
-import { spawnSync } from 'node:child_process'
-import fs from 'node:fs'
-import os from 'node:os'
-import path from 'node:path'
-import { fileURLToPath } from 'node:url'
-import { parseAddedLines, interceptionLeads, regexLeads, branchLeads, weakAssertionLeads, scanDiff, parseFileChanges, characterizationLeads, extractMockTarget, classifyMockTarget, overMockFindings, concurrencyFixtureLeads, parseCliArgs, ScanDiffCliError, NO_INPUT_EXIT, USAGE_EXIT } from './scan-diff.mjs'
-
-const SCRIPT = fileURLToPath(new URL('./scan-diff.mjs', import.meta.url))
-// Run the real CLI: returns { status, stdout, stderr }. `input` is piped to stdin.
-function runCli(args = [], input = '') {
-  const r = spawnSync(process.execPath, [SCRIPT, ...args], { input, encoding: 'utf8' })
-  return { status: r.status, stdout: r.stdout, stderr: r.stderr }
-}
-
-const DIFF = `diff --git a/src/match.ts b/src/match.ts
---- a/src/match.ts
-+++ b/src/match.ts
-@@ -10,3 +10,6 @@ export function f() {
-   const keep = 1
-+  const re = /\\/api\\/foo/
-+  if (path.startsWith(x)) return true
-+  const anchored = /^\\/exact$/
-@@ -40,2 +40,3 @@
-   ctx()
-+  page.route('**/api/x', r => r.fulfill({}))
-`
-
-const TESTDIFF = `--- a/e2e/x.spec.ts
-+++ b/e2e/x.spec.ts
-@@ -1,2 +1,3 @@
- import { test } from '@playwright/test'
-+  await page.route('**/api/y', r => r.fulfill({ status: 200 }))
-`
-
-test('parseAddedLines tracks file + new-file line numbers, skips removed', () => {
-  const added = parseAddedLines(DIFF)
-  // first hunk starts at new line 10: keep(10), re(11), if(12), anchored(13)
-  const reLine = added.find((a) => a.text.includes('const re ='))
-  assert.equal(reLine.file, 'src/match.ts')
-  assert.equal(reLine.line, 11)
-  const pr = added.find((a) => a.text.includes('page.route'))
-  assert.equal(pr.line, 41) // second hunk new-start 40: ctx(40), page.route(41)
-})
-
-test('regexLeads flags unanchored regex, not anchored ones', () => {
-  const leads = regexLeads(parseAddedLines(DIFF))
-  assert.ok(leads.some((l) => l.type === 'unanchored-pattern' && l.snippet.includes('api')), 'unanchored regex flagged')
-  assert.ok(!leads.some((l) => l.snippet.includes('exact')), 'anchored /^...$/ not flagged')
-})
-
-test('branchLeads flags new if + ternary', () => {
-  const leads = branchLeads(parseAddedLines('--- a/x.ts\n+++ b/x.ts\n@@ -1 +1,2 @@\n+  if (a) b()\n+  const y = c ? d : e\n'))
-  assert.equal(leads.length, 2)
-})
-
-test('interceptionLeads only fires in test/spec files', () => {
-  assert.equal(interceptionLeads(parseAddedLines(DIFF)).length, 0, 'page.route in a non-test file is not an interception lead')
-  const t = interceptionLeads(parseAddedLines(TESTDIFF))
-  assert.equal(t.length, 1)
-  assert.equal(t[0].type, 'first-party-interception')
-})
-
-test('weakAssertionLeads flags catch-swallow + disjunctive-truthy in test files only', () => {
-  // Mirrors the real storefront-journeys.spec.ts auth tests.
-  const diff = `--- a/e2e/journeys.spec.ts
-+++ b/e2e/journeys.spec.ts
-@@ -1,2 +1,5 @@
- import { test, expect } from '@playwright/test'
-+    const hasEmail = await page.getByLabel(/email/i).isVisible().catch(() => false)
-+    expect(hasEmail || hasPassword || hasLoginButton).toBeTruthy()
-+    expect(ok).toBe(true)
-`
-  const leads = weakAssertionLeads(parseAddedLines(diff))
-  assert.ok(leads.some((l) => l.type === 'swallowed-assertion'), 'catch(() => false) flagged')
-  assert.ok(leads.some((l) => l.type === 'weak-assertion'), 'disjunctive toBeTruthy flagged')
-  // A plain expect(ok).toBe(true) with no `||` is not a weak-assertion lead.
-  assert.ok(!leads.some((l) => l.type === 'weak-assertion' && l.snippet.includes('toBe(true)')), 'non-disjunctive toBe(true) not flagged')
-})
-
-test('weakAssertionLeads does not fire outside test files', () => {
-  const diff = `--- a/src/app.ts\n+++ b/src/app.ts\n@@ -1 +1,2 @@\n+  const v = await thing().catch(() => false)\n`
-  assert.equal(weakAssertionLeads(parseAddedLines(diff)).length, 0)
-})
-
-test('scanDiff aggregates leads + the decidable findings channel', () => {
-  const r = scanDiff(DIFF)
-  assert.equal(r.kind, 'leads+findings')
-  assert.ok(r.counts['unanchored-pattern'] >= 1)
-  assert.ok(r.counts['new-branch'] >= 1)
-  assert.ok(Array.isArray(r.leads))
-  assert.ok(Array.isArray(r.findings))
-  assert.deepEqual(r.findings, [], 'DIFF fixture has no first-party mock → no over-mock findings')
-})
-
-// --- over-mock: the vendored, decidable internal-seam detector (FINDINGS) ---
-
-test('extractMockTarget pulls vi/jest/vitest mock + doMock specifiers', () => {
-  assert.equal(extractMockTarget("vi." + "mock('@/lib/x')"), '@/lib/x')
-  assert.equal(extractMockTarget('jest.' + 'mock("pkg")'), 'pkg')
-  assert.equal(extractMockTarget('vitest.' + 'doMock(`./rel`)'), './rel')
-  assert.equal(extractMockTarget('expect(x).toBe(1)'), null)
-})
-
-test('classifyMockTarget: first-party seam internal, external/stdlib/test-util exempt', () => {
-  assert.equal(classifyMockTarget('@/lib/auth').internal, true)        // alias
-  assert.equal(classifyMockTarget('~/db').internal, true)              // alias
-  assert.equal(classifyMockTarget('../services/billing').internal, true) // relative into source
-  assert.equal(classifyMockTarget('node:fs').internal, false)          // stdlib
-  assert.equal(classifyMockTarget('react').internal, false)            // bare pkg
-  assert.equal(classifyMockTarget('./__mocks__/x').internal, false)    // test util
-  // declared topology: a monorepo scope is first-party; a generated dir is exempt
-  const topo = { firstPartyAliasPrefixes: ['@/'], firstPartyPackages: ['@acme/'], externals: ['^@/generated/'], testUtilHints: [] }
-  assert.equal(classifyMockTarget('@acme/shared', topo).internal, true)
-  assert.equal(classifyMockTarget('@/generated/openapi', topo).internal, false)
-})
-
-test('overMockFindings flags an ADDED first-party mock in a test file (the incident vector)', () => {
-  const diff = [
-    '--- a/src/__tests__/route.test.ts',
-    '+++ b/src/__tests__/route.test.ts',
-    '@@ -1,1 +1,2 @@',
-    ' import x',
-    "+vi." + "mock('@/lib/org-allowlist-client')",
-    '',
-  ].join('\n')
-  const f = overMockFindings(parseAddedLines(diff))
-  assert.equal(f.length, 1)
-  assert.equal(f[0].type, 'over-mock-internal-seam')
-  assert.equal(f[0].target, '@/lib/org-allowlist-client')
-})
-
-test('overMockFindings does not flag an external mock, or a mock outside a test file', () => {
-  const ext = `--- a/src/x.test.ts\n+++ b/src/x.test.ts\n@@ -1 +1,2 @@\n+vi.mock('stripe')\n`
-  assert.equal(overMockFindings(parseAddedLines(ext)).length, 0)
-  const nonTest = ['--- a/src/app.ts', '+++ b/src/app.ts', '@@ -1 +1,2 @@', "+vi." + "mock('@/lib/x')", ''].join('\n')
-  assert.equal(overMockFindings(parseAddedLines(nonTest)).length, 0)
-})
-
-// --- characterization: modifies-existing-behavior detection ---
-
-// A source file whose existing lines are CHANGED (has `-` content) → owes a
-// characterization test. (The shared DIFF fixture is all additions, so it must
-// NOT fire — see the pure-addition test below; this uses a real modification.)
-const MODDIFF = `--- a/src/price.ts
-+++ b/src/price.ts
-@@ -10,3 +10,3 @@ export function total(items) {
-   const base = sum(items)
--  return base * 1.2
-+  return base * 1.15
-`
-test('characterizationLeads flags a source file with changed existing lines', () => {
-  const leads = characterizationLeads(MODDIFF)
-  assert.equal(leads.length, 1)
-  assert.equal(leads[0].type, 'modifies-existing-behavior')
-  assert.equal(leads[0].file, 'src/price.ts')
-  assert.ok(leads[0].line > 0)
-})
-
-test('characterizationLeads does NOT fire on the all-additions DIFF fixture', () => {
-  assert.equal(characterizationLeads(DIFF).length, 0, 'no removed lines => no existing behavior modified')
-})
-
-test('characterizationLeads ignores a brand-new file (new behavior, not modification)', () => {
-  const diff = `diff --git a/src/new.ts b/src/new.ts
-new file mode 100644
---- /dev/null
-+++ b/src/new.ts
-@@ -0,0 +1,2 @@
-+export function n() { return 1 }
-+export const k = 2
-`
-  assert.equal(characterizationLeads(diff).length, 0)
-})
-
-test('characterizationLeads ignores a pure addition into an existing file', () => {
-  const diff = `--- a/src/app.ts
-+++ b/src/app.ts
-@@ -5,0 +6,2 @@
-+export function added() { return 1 }
-+export const k = 2
-`
-  assert.equal(characterizationLeads(diff).length, 0, 'no removed lines => added behavior, not a modification')
-})
-
-test('characterizationLeads ignores test files and non-source files', () => {
-  const testDiff = `--- a/e2e/x.spec.ts\n+++ b/e2e/x.spec.ts\n@@ -1,2 +1,2 @@\n-  old()\n+  neo()\n`
-  const docDiff = `--- a/README.md\n+++ b/README.md\n@@ -1,2 +1,2 @@\n-old\n+new\n`
-  assert.equal(characterizationLeads(testDiff).length, 0, 'editing a test is not modifying production behavior')
-  assert.equal(characterizationLeads(docDiff).length, 0, 'docs carry no behavior to pin')
-})
-
-test('parseFileChanges records isNew, removed/added counts, and firstLine', () => {
-  const files = parseFileChanges(MODDIFF)
-  const m = files.get('src/price.ts')
-  assert.equal(m.isNew, false)
-  assert.ok(m.removed >= 1 && m.added >= 1)
-  assert.ok(m.firstLine > 0)
-})
-
-// Regression fixture: the real shape from skyee-ai-risk PR #957 / issue #938, where a
-// test titled "replays and races" read an already-sealed plan, so both concurrent
-// callers took the early return and the contended first seal was never exercised.
-// The adversarial reviewer needed 5 real-PostgreSQL trials to find what the fixture
-// states outright.
-const RACE_FALSE_GREEN = `--- a/src/lib/x.integration.test.ts
-+++ b/src/lib/x.integration.test.ts
-@@ -270,0 +271,10 @@
-+  it("replays and races deterministically, retains immutable authority", async () => {
-+    const source = await db.blacklistRepairRun.findFirstOrThrow({
-+      where: { ownerExecutionId: PREFIX },
-+      include: { caseAuthorizationPlan: true },
-+    })
-+    const firstId = source.caseAuthorizationPlan!.id
-+    const [left, right] = await Promise.all([
-+      authorize(source.id, binding, { db }),
-+      authorize(source.id, binding, { db }),
-+    ])
-`
-
-test('concurrencyFixtureLeads flags a race test whose fixture reads pre-existing state', () => {
-  const leads = concurrencyFixtureLeads(parseAddedLines(RACE_FALSE_GREEN))
-  assert.equal(leads.length, 1)
-  assert.equal(leads[0].type, 'concurrency-test-preexisting-fixture')
-  assert.match(leads[0].snippet, /findFirstOrThrow|caseAuthorizationPlan/)
-  assert.ok(scanDiff(RACE_FALSE_GREEN).leads.some((l) => l.type === 'concurrency-test-preexisting-fixture'),
-    'must surface through scanDiff, not just the exported helper')
-})
-
-test('concurrencyFixtureLeads stays quiet on a race test that builds its own state', () => {
-  const clean = `--- a/src/lib/y.integration.test.ts
-+++ b/src/lib/y.integration.test.ts
-@@ -1,0 +1,8 @@
-+  it("races two first-seal callers", async () => {
-+    await db.plan.deleteMany({ where: { runId } })
-+    const [a, b] = await Promise.allSettled([
-+      authorize(runId, binding, { db: clientA }),
-+      authorize(runId, binding, { db: clientB }),
-+    ])
-`
-  assert.equal(concurrencyFixtureLeads(parseAddedLines(clean)).length, 0,
-    'a race test that starts from absent state is the correct shape, not a lead')
-})
-
-test('concurrencyFixtureLeads ignores non-concurrency tests and non-test files', () => {
-  const ordinary = `--- a/src/lib/z.test.ts
-+++ b/src/lib/z.test.ts
-@@ -1,0 +1,4 @@
-+  it("returns the sealed plan", async () => {
-+    const row = await db.plan.findFirstOrThrow({ where: { runId } })
-+    const [x, y] = await Promise.all([load(row.id), load(row.id)])
-`
-  assert.equal(concurrencyFixtureLeads(parseAddedLines(ordinary)).length, 0,
-    'Promise.all in a test that never claims to race is ordinary parallelism')
-  const src = RACE_FALSE_GREEN.replace(/x\.integration\.test\.ts/g, 'x.ts')
-  assert.equal(concurrencyFixtureLeads(parseAddedLines(src)).length, 0, 'production files carry no test fixture')
-})
-
-// Review catch (vera932 on #364): tracking only concurrency titles left the test
-// scope open for the rest of the file, so the NEXT ordinary test's fixture was
-// attributed to a race test that had already ended. The negative case above only
-// passed because nothing preceded it — order is the whole bug.
-const RACE_THEN_ORDINARY = `--- a/src/lib/x.integration.test.ts
-+++ b/src/lib/x.integration.test.ts
-@@ -1,0 +1,12 @@
-+  it("races two first-seal callers", async () => {
-+    await db.plan.deleteMany({ where: { runId } })
-+    const [a, b] = await Promise.allSettled([
-+      authorize(runId, binding, { db: clientA }),
-+      authorize(runId, binding, { db: clientB }),
-+    ])
-+  })
-+  it("loads the sealed plan", async () => {
-+    const row = await db.plan.findFirstOrThrow({ where: { runId } })
-+    const [x, y] = await Promise.all([load(row.id), load(row.id)])
-+  })
-`
-
-test('concurrencyFixtureLeads closes scope at the next test title, whatever it is named', () => {
-  assert.equal(concurrencyFixtureLeads(parseAddedLines(RACE_THEN_ORDINARY)).length, 0,
-    'an ordinary test following a correct race test must not inherit its scope')
-})
-
-test('concurrencyFixtureLeads still fires when the offending test follows another test', () => {
-  const after = `--- a/src/lib/x.integration.test.ts
-+++ b/src/lib/x.integration.test.ts
-@@ -1,0 +1,10 @@
-+  it("seeds the fixture", async () => {
-+    await db.plan.create({ data: { runId } })
-+  })
-+  it("races deterministically", async () => {
-+    const source = await db.run.findFirstOrThrow({ where: { runId } })
-+    const firstId = source.plan!.id
-+    const [l, r] = await Promise.all([authorize(runId), authorize(runId)])
-+  })
-`
-  const leads = concurrencyFixtureLeads(parseAddedLines(after))
-  assert.equal(leads.length, 1, 'scope reset must not suppress a real hit later in the file')
-  assert.match(leads[0].snippet, /findFirstOrThrow/)
-})
-
-// --- CLI arg parsing: reject the exact --base/--head producer mistake (#416) ---
-
-test('parseCliArgs accepts a bare invocation (piped stdin) and --diff <file>', () => {
-  assert.deepEqual(parseCliArgs([]), { diffPath: null })
-  assert.deepEqual(parseCliArgs(['--diff', 'changes.patch']), { diffPath: 'changes.patch' })
-})
-
-test('parseCliArgs rejects the --base/--head invocation that scanned empty stdin', () => {
-  // The whole point of #416: --base/--head must HARD-FAIL, not fall through to stdin.
-  assert.throws(() => parseCliArgs(['--base', 'a', '--head', 'b']), (e) =>
-    e instanceof ScanDiffCliError && e.code === USAGE_EXIT && /unknown flag/i.test(e.message) && /--base/.test(e.message))
-})
-
-test('parseCliArgs rejects any other unknown flag and a bare positional arg', () => {
-  assert.throws(() => parseCliArgs(['--nope']), (e) => e instanceof ScanDiffCliError && e.code === USAGE_EXIT && /--nope/.test(e.message))
-  assert.throws(() => parseCliArgs(['stray.patch']), (e) => e instanceof ScanDiffCliError && e.code === USAGE_EXIT)
-})
-
-test('parseCliArgs errors when --diff has no path', () => {
-  assert.throws(() => parseCliArgs(['--diff']), (e) => e instanceof ScanDiffCliError && e.code === USAGE_EXIT && /--diff/.test(e.message))
-})
-
-// --- CLI end-to-end (real subprocess): exit codes + stderr, the fail-open closed ---
-
-// scan-diff detects a first-party-seam mock call. Writing that call literally in
-// a fixture would put the detected pattern on an ADDED line of THIS file — which
-// trips scan-diff's own findings channel over this PR's diff and makes the
-// reviewer-parity proof non-empty for the detector's own test. Assemble the mock
-// line from fragments so no single added source line matches the detector, while
-// the runtime string is the exact diff line under test.
-const mockLine = (target) => `+vi.` + `mock('${target}')`
-const REAL_OVER_MOCK_DIFF = [
-  '--- a/src/__tests__/route.test.ts',
-  '+++ b/src/__tests__/route.test.ts',
-  '@@ -1,1 +1,2 @@',
-  ' import x',
-  mockLine('@/lib/org-allowlist-client'),
-  '',
-].join('\n')
-
-const REAL_CLEAN_DIFF = `--- a/src/app.ts
-+++ b/src/app.ts
-@@ -1,0 +1,2 @@
-+export function added() { return 1 }
-+export const k = 2
-`
-
-test('CLI: empty stdin fails LOUD (non-zero + stderr), no clean-looking JSON', () => {
-  const r = runCli([], '')
-  assert.notEqual(r.status, 0, 'must NOT exit 0 on zero-byte input (the fail-open #416 closes)')
-  assert.equal(r.status, NO_INPUT_EXIT)
-  assert.equal(r.stdout.trim(), '', 'no vacuous {findings:[],leads:[]} on empty input')
-  assert.match(r.stderr, /no diff/i)
-  assert.match(r.stderr, /git diff .*scan-diff/, 'error points at the correct piped invocation')
-})
-
-test('CLI: whitespace-only stdin also fails loud (not a real diff)', () => {
-  const r = runCli([], '   \n\t\n')
-  assert.equal(r.status, NO_INPUT_EXIT)
-  assert.equal(r.stdout.trim(), '')
-  assert.match(r.stderr, /no diff/i)
-})
-
-test('CLI: --diff <empty-file> fails loud, same as empty stdin', () => {
-  const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'scan-diff-'))
-  const empty = path.join(dir, 'empty.patch')
-  fs.writeFileSync(empty, '')
-  try {
-    const r = runCli(['--diff', empty], '')
-    assert.equal(r.status, NO_INPUT_EXIT)
-    assert.equal(r.stdout.trim(), '')
-    assert.match(r.stderr, /no diff|empty/i)
-  } finally {
-    fs.rmSync(dir, { recursive: true, force: true })
-  }
-})
-
-test('CLI: unknown flag (--base X --head Y) exits 2 + "unknown flag", not empty-stdin scan', () => {
-  const r = runCli(['--base', 'aaa', '--head', 'bbb'], '')
-  assert.equal(r.status, USAGE_EXIT)
-  assert.equal(r.stdout.trim(), '', 'the producer mistake no longer yields a false-clean proof')
-  assert.match(r.stderr, /unknown flag/i)
-  assert.match(r.stderr, /--base/)
-})
-
-test('CLI: a real diff with a planted over-mock still detected — guard did not break scanning', () => {
-  const r = runCli([], REAL_OVER_MOCK_DIFF)
-  assert.equal(r.status, 0)
-  const out = JSON.parse(r.stdout)
-  assert.equal(out.findings.length, 1, 'the real over-mock finding is still emitted')
-  assert.equal(out.findings[0].type, 'over-mock-internal-seam')
-})
-
-test('CLI: a real diff with no findings exits 0 with empty findings (legit clean result)', () => {
-  const r = runCli([], REAL_CLEAN_DIFF)
-  assert.equal(r.status, 0, 'input with content but zero findings is the legitimate clean result, not "no input"')
-  const out = JSON.parse(r.stdout)
-  assert.deepEqual(out.findings, [])
-})
-
-test('CLI: --diff <file> with a real diff works (the non-piped legit path)', () => {
-  const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'scan-diff-'))
-  const p = path.join(dir, 'real.patch')
-  fs.writeFileSync(p, REAL_OVER_MOCK_DIFF)
-  try {
-    const r = runCli(['--diff', p], '')
-    assert.equal(r.status, 0)
-    assert.equal(JSON.parse(r.stdout).findings.length, 1)
-  } finally {
-    fs.rmSync(dir, { recursive: true, force: true })
-  }
-})

package/skills/engineering/better-review/scripts/vendor-sync.test.mjs

@@ -1,96 +0,0 @@
-// Drift check for the VENDORED over-mock classifier in scan-diff.mjs.
-//
-// scan-diff.mjs carries a self-contained copy of ensure-coverage's
-// `mock-internal-seam` classifier so better-review enforces no-over-mock with zero
-// dependency on ensure-coverage being installed. ensure-coverage stays CANONICAL
-// ("if the two diverge, ensure-coverage wins and this copy is stale → resync").
-// That resync rule used to be prose; this test mechanizes it: it runs the full
-// classification decision tree through BOTH copies and fails on any divergence
-// in verdict or reason, plus compares the default topology field-for-field.
-//
-// When the canonical module is absent (better-review installed standalone), the
-// whole suite skips — there is nothing to be out of sync with.
-
-import { test } from 'node:test'
-import assert from 'node:assert/strict'
-import fs from 'node:fs'
-import path from 'node:path'
-import { fileURLToPath } from 'node:url'
-
-const here = path.dirname(fileURLToPath(import.meta.url))
-const CANONICAL = path.resolve(here, '../../ensure-coverage/scripts/mock-policy-config.mjs')
-const standalone = !fs.existsSync(CANONICAL)
-
-const vendored = await import('./scan-diff.mjs')
-const canonical = standalone ? null : await import(CANONICAL)
-
-// One topology per declared-config shape we support; classifyMockTarget takes
-// the same plain object in both copies (canonical compiles externals lazily).
-const TOPOLOGIES = {
-  defaults: undefined, // both sides fall back to their own DEFAULT_*
-  declared: {
-    firstPartyAliasPrefixes: ['@/', '~/', '#app/'],
-    firstPartyPackages: ['@acme/', 'our-lib'],
-    externals: ['^@acme/generated-', '^virtual:'],
-    testUtilHints: ['__mocks__', 'fixtures', 'test-utils'],
-  },
-  badExternalRegex: {
-    firstPartyAliasPrefixes: ['@/'],
-    firstPartyPackages: [],
-    externals: ['[unclosed'], // must be ignored identically, never thrown
-    testUtilHints: ['mocks'],
-  },
-}
-
-// Targets covering every branch of the precedence chain:
-// declared externals > stdlib > relative(util vs source) > alias > first-party
-// package (exact / subpath / trailing-slash config) > bare package > no target.
-const TARGETS = [
-  null, '', 'node:fs', 'node:path',
-  './db', '../services/payment', './__mocks__/db', '../fixtures/user', './test-utils/render',
-  '../mocks/server', './helpers/seed', '@/lib/db', '@/server/auth', '~/utils/format',
-  '#app/db', '@acme/core', '@acme/core/client', '@acme/generated-client', 'our-lib',
-  'our-lib/deep', 'our-library', 'virtual:module', 'react', 'msw', '@tanstack/react-query',
-  'lodash/merge',
-]
-
-test('vendored classifier tracks ensure-coverage (canonical)', { skip: standalone && 'ensure-coverage not installed — standalone better-review, nothing to sync against' }, async (t) => {
-  await t.test('default topology fields match DEFAULT_MOCK_POLICY', () => {
-    const want = canonical.DEFAULT_MOCK_POLICY
-    const got = vendored.DEFAULT_MOCK_TOPOLOGY
-    for (const field of ['firstPartyAliasPrefixes', 'firstPartyPackages', 'externals', 'testUtilHints']) {
-      assert.deepEqual(got[field], want[field], `DEFAULT_MOCK_TOPOLOGY.${field} drifted from canonical DEFAULT_MOCK_POLICY.${field}`)
-    }
-  })
-
-  await t.test('extractMockTarget agrees on a line corpus', () => {
-    const LINES = [
-      `vi.${'mock'}('@/lib/db')`,
-      `jest.${'mock'}("../services/payment", () => ({}))`,
-      `vitest.${'mock'}(\`~/utils/format\`)`,
-      `vi.${'doMock'}('./db')`,
-      `jest.${'doMock'}('react')`,
-      `vi . mock ( '@acme/core' )`,
-      `vi.mock(someVariable)`, // non-literal → null
-      `expect(page).toBeTruthy()`,
-      '', null,
-    ]
-    for (const line of LINES) {
-      assert.equal(vendored.extractMockTarget(line), canonical.extractMockTarget(line), `extractMockTarget diverged on: ${JSON.stringify(line)}`)
-    }
-  })
-
-  await t.test('classifyMockTarget agrees across the full precedence tree', () => {
-    for (const [name, topo] of Object.entries(TOPOLOGIES)) {
-      for (const target of TARGETS) {
-        const got = topo === undefined ? vendored.classifyMockTarget(target) : vendored.classifyMockTarget(target, topo)
-        const want = topo === undefined ? canonical.classifyMockTarget(target) : canonical.classifyMockTarget(target, topo)
-        assert.deepEqual(
-          { internal: got.internal, reason: got.reason },
-          { internal: want.internal, reason: want.reason },
-          `classifyMockTarget diverged on target=${JSON.stringify(target)} topology=${name}`
-        )
-      }
-    }
-  })
-})

package/skills/engineering/contributing/scripts/persist-conventions.test.mjs

@@ -1,118 +0,0 @@
-// Tests for persist-conventions: the real CLI against real files in a temp repo.
-import { test } from 'node:test'
-import assert from 'node:assert/strict'
-import { spawnSync } from 'node:child_process'
-import { lstatSync, mkdtempSync, readFileSync, readlinkSync, rmSync, writeFileSync } from 'node:fs'
-import { tmpdir } from 'node:os'
-import { join } from 'node:path'
-import { fileURLToPath } from 'node:url'
-
-import { markers } from './persist-conventions-core.mjs'
-
-const CLI = fileURLToPath(new URL('./persist-conventions.mjs', import.meta.url))
-const [START, END] = markers('tracker')
-
-function withRepo(fn, remote) {
-  const dir = mkdtempSync(join(tmpdir(), 'contributing-'))
-  try {
-    if (remote) {
-      spawnSync('git', ['init', '-q', dir])
-      spawnSync('git', ['-C', dir, 'remote', 'add', 'origin', remote])
-    }
-    return fn(dir, (name) => readFileSync(join(dir, name), 'utf8'))
-  } finally {
-    rmSync(dir, { recursive: true, force: true })
-  }
-}
-
-function run(dir, ...args) {
-  const res = spawnSync(process.execPath, [CLI, '--repo-root', dir, ...args], { encoding: 'utf8' })
-  return { code: res.status, out: res.stdout }
-}
-
-test('--write creates CONTRIBUTING.md with the section, the repo from origin, and the Linear projects', () => {
-  withRepo((dir, read) => {
-    const { code } = run(dir, '--linear-project', 'Checkout Risk', '--write')
-    assert.equal(code, 0)
-    const text = read('CONTRIBUTING.md')
-    assert.ok(text.startsWith('# Contributing\n'))
-    assert.ok(text.includes(START) && text.includes(END))
-    assert.match(text, /GitHub issues on `acme\/widgets`/)
-    assert.match(text, /Linear \(projects: Checkout Risk\)/)
-    assert.match(text, /gh issue list --repo acme\/widgets/)
-    assert.doesNotMatch(text, /\{\{/)
-  }, 'git@github.com:acme/widgets.git')
-})
-
-test('an https remote and an explicit --github-repo both name the repo', () => {
-  withRepo((dir, read) => {
-    assert.equal(run(dir, '--write').code, 0)
-    assert.match(read('CONTRIBUTING.md'), /GitHub issues on `acme\/widgets`\. Product work is tracked in Linear\./)
-  }, 'https://github.com/acme/widgets')
-  withRepo((dir, read) => {
-    assert.equal(run(dir, '--github-repo', 'acme/other', '--write').code, 0)
-    assert.match(read('CONTRIBUTING.md'), /`acme\/other`/)
-  })
-})
-
-test('without a GitHub remote or --github-repo it refuses with exit 2 and writes nothing', () => {
-  withRepo((dir) => {
-    const { code, out } = run(dir, '--write')
-    assert.equal(code, 2)
-    assert.match(out, /--github-repo/)
-    assert.throws(() => readFileSync(join(dir, 'CONTRIBUTING.md')))
-  })
-})
-
-test('--if-missing appends to an existing CONTRIBUTING.md once, then leaves the section alone', () => {
-  withRepo((dir, read) => {
-    writeFileSync(join(dir, 'CONTRIBUTING.md'), '# Contributing\n\nRun the tests.\n')
-    assert.equal(run(dir, '--if-missing', '--write').code, 0)
-    const first = read('CONTRIBUTING.md')
-    assert.ok(first.startsWith('# Contributing\n\nRun the tests.\n'))
-    assert.ok(first.includes(START))
-
-    const edited = first.replace('acme/widgets`. Product', 'acme/widgets`. Hand-edited. Product')
-    writeFileSync(join(dir, 'CONTRIBUTING.md'), edited)
-    const { code, out } = run(dir, '--if-missing', '--linear-project', 'Other', '--write')
-    assert.equal(code, 0)
-    assert.match(out, /already present/)
-    assert.equal(read('CONTRIBUTING.md'), edited)
-  }, 'git@github.com:acme/widgets.git')
-})
-
-test('without --write it previews and writes nothing', () => {
-  withRepo((dir) => {
-    const { code, out } = run(dir)
-    assert.equal(code, 0)
-    assert.match(out, /CONTRIBUTING\.md: would create/)
-    assert.throws(() => readFileSync(join(dir, 'CONTRIBUTING.md')))
-  }, 'git@github.com:acme/widgets.git')
-})
-
-test('the first run indexes CONTRIBUTING.md from AGENTS.md and links CLAUDE.md, once', () => {
-  withRepo((dir, read) => {
-    assert.equal(run(dir, '--if-missing', '--write').code, 0)
-    assert.match(read('AGENTS.md'), /\[CONTRIBUTING\.md\]\(CONTRIBUTING\.md\).*issue tracking/)
-    assert.ok(lstatSync(join(dir, 'CLAUDE.md')).isSymbolicLink())
-    assert.equal(readlinkSync(join(dir, 'CLAUDE.md')), 'AGENTS.md')
-  }, 'git@github.com:acme/widgets.git')
-  withRepo((dir, read) => {
-    writeFileSync(join(dir, 'AGENTS.md'), '# Agents\n\nSee CONTRIBUTING.md for everything.\n')
-    assert.equal(run(dir, '--if-missing', '--write').code, 0)
-    assert.equal(read('AGENTS.md'), '# Agents\n\nSee CONTRIBUTING.md for everything.\n')
-  }, 'git@github.com:acme/widgets.git')
-})
-
-test('--if-missing restores a missing AGENTS.md index even when the section is already present', () => {
-  withRepo((dir, read) => {
-    assert.equal(run(dir, '--write').code, 0)
-    const section = read('CONTRIBUTING.md')
-    writeFileSync(join(dir, 'AGENTS.md'), '# Agents\n')
-    const { code, out } = run(dir, '--if-missing', '--write')
-    assert.equal(code, 0)
-    assert.match(out, /already present; 1 index file\(s\) written/)
-    assert.match(read('AGENTS.md'), /^# Agents\n\n## Contributing\n/)
-    assert.equal(read('CONTRIBUTING.md'), section)
-  }, 'git@github.com:acme/widgets.git')
-})