@1aboveio/skills 1.0.8 → 1.0.10

package/skills/app-dev/android-foundation/scripts/device-run.test.mjs

@@ -1,436 +0,0 @@
-// Run the real shell lifecycle against fake external executables, never a device
-// or container daemon. Every fixture records its own processes for test cleanup.
-import { test } from 'node:test';
-import assert from 'node:assert/strict';
-import { spawn, spawnSync } from 'node:child_process';
-import { chmodSync, mkdirSync, mkdtempSync, readFileSync, writeFileSync, existsSync, rmSync } from 'node:fs';
-import { createServer } from 'node:net';
-import { tmpdir } from 'node:os';
-import { dirname, join } from 'node:path';
-import { fileURLToPath } from 'node:url';
-import { setTimeout as delay } from 'node:timers/promises';
-
-const SCRIPT = process.env.DEVICE_RUN_SCRIPT ?? join(dirname(fileURLToPath(import.meta.url)), 'device-run.sh');
-
-function alive(pid) {
-  const r = spawnSync('ps', ['-o', 'stat=', '-p', String(pid)], { encoding: 'utf8' });
-  return r.status === 0 && r.stdout.trim() !== '' && !r.stdout.trim().startsWith('Z');
-}
-
-async function until(check, message, milliseconds = 5000) {
-  const end = Date.now() + milliseconds;
-  while (!check()) {
-    assert.ok(Date.now() < end, message);
-    await delay(20);
-  }
-}
-
-async function fakeHost(t) {
-  const root = mkdtempSync(join(tmpdir(), 'device-run-'));
-  const bin = join(root, 'bin');
-  const sdk = join(root, 'sdk');
-  mkdirSync(bin);
-  mkdirSync(join(sdk, 'emulator'), { recursive: true });
-  const log = join(root, 'calls.log');
-  writeFileSync(log, '');
-  const pids = () => existsSync(join(root, 'pids'))
-    ? readFileSync(join(root, 'pids'), 'utf8').trim().split('\n').filter(Boolean).map((line) => Number(line.split(' ')[1])) : [];
-  t.after(() => {
-    for (const pid of pids()) {
-      if (alive(pid)) { try { process.kill(pid, 'SIGKILL'); } catch {} }
-    }
-    rmSync(root, { recursive: true, force: true });
-  });
-  const tool = (path, body) => {
-    writeFileSync(path, `#!/usr/bin/env bash\necho "$(basename "$0") $*" >> "$FAKE_LOG"\n${body}\n`);
-    chmodSync(path, 0o755);
-  };
-  writeFileSync(join(bin, 'worker'), `#!/usr/bin/env python3
-import os, signal, sys, time
-label = sys.argv[1]
-root = os.environ['FAKE_ROOT']
-def record(name):
-    with open(root + '/pids', 'a') as f: f.write('%s %s\\n' % (name, os.getpid()))
-record(label)
-if label in ('startup', 'journey', 'emulator-tree'):
-    pid = os.fork()
-    if pid == 0:
-        signal.signal(signal.SIGTERM, signal.SIG_IGN)
-        record(label + '-child')
-        open(root + '/' + label + '-child-ready', 'w').close()
-        while True: time.sleep(1)
-    while not os.path.exists(root + '/' + label + '-child-ready'): time.sleep(0.01)
-if label == 'emulator-tree':
-    open(root + '/emulator-ready', 'w').close()
-    while not os.path.exists(root + '/release-emulator'): time.sleep(0.01)
-    sys.exit(0)
-if os.environ.get('FAKE_EMULATOR_IGNORES_TERM') and label == 'emulator':
-    signal.signal(signal.SIGTERM, signal.SIG_IGN)
-open(root + '/' + label + '-ready', 'w').close()
-while True: time.sleep(1)
-`);
-  chmodSync(join(bin, 'worker'), 0o755);
-  tool(join(sdk, 'emulator', 'emulator'), `
-if test -n "\${FAKE_EMULATOR_TREE:-}"; then exec worker emulator-tree; fi
-exec worker emulator`);
-  tool(join(bin, 'adb'), `
-printf 'adb-env %s %s\\n' "\${ADB_SERVER_SOCKET:-}" "\${ANDROID_SERIAL:-}" >> "$FAKE_LOG"
-case "$*" in
-  start-server)
-    if test -n "\${FAKE_ADB_START_HANG:-}"; then exec worker startup; fi
-    if test -n "\${FAKE_ADB_START_SIGNAL:-}"; then kill -TERM $$; fi
-    exit 0 ;;
-  *getprop*) if test -n "\${FAKE_ADB_HANG:-}"; then exec worker probe; fi; echo 1 ;;
-esac`);
-  tool(join(bin, 'docker'), `
-case "$1" in
-  run)
-    while test $# -gt 0; do
-      if test "$1" = --cidfile && test -z "\${FAKE_NO_CID:-}"; then echo fakecid42 > "$2"; fi
-      shift
-    done
-    if test -n "\${FAKE_DOCKER_RUN_HANG:-}"; then exec worker startup; fi
-    echo fakecid42 ;;
-  port) echo 127.0.0.1:55432 ;;
-  exec) exit 0 ;;
-  rm) if test -n "\${FAKE_RM_HANG:-}"; then exec worker remove; fi; exit 0 ;;
-  ps) if test -n "\${FAKE_CONTAINER_REMAINS:-}"; then echo fakecid42; fi; exit 0 ;;
-esac`);
-  return { root, bin, sdk, log, pids, ports: await hostPorts() };
-}
-
-function listen(port) {
-  return new Promise((resolve, reject) => {
-    const server = createServer();
-    server.once('error', reject);
-    server.listen(port, '127.0.0.1', () => resolve(server));
-  });
-}
-
-async function freePort() {
-  const server = await listen(0);
-  const { port } = server.address();
-  await new Promise((resolve) => server.close(resolve));
-  return port;
-}
-
-async function freeEmulatorPort() {
-  for (let port = 5554; port <= 5584; port += 2) {
-    const held = [];
-    try {
-      held.push(await listen(port));
-      held.push(await listen(port + 1));
-      return port;
-    } catch {
-      // taken; try the next pair
-    } finally {
-      await Promise.all(held.map((server) => new Promise((resolve) => server.close(resolve))));
-    }
-  }
-  throw new Error('no free emulator port pair in 5554-5584');
-}
-
-async function hostPorts() {
-  return {
-    EMULATOR_PORT: String(await freeEmulatorPort()),
-    ANDROID_BACKEND_PORT: String(await freePort()),
-    ANDROID_METRO_PORT: String(await freePort()),
-  };
-}
-
-async function run(host, { journey = ['bash', '-c', 'exit 0'], drop, env = {}, signalAt, input = '' } = {}) {
-  drop ??= ['bash', '-c', 'echo "drop $SHARD_DB_NAME $SHARD_ADMIN_URL" >> "$FAKE_LOG"'];
-  const child = spawn('bash', [SCRIPT, '--drop', ...drop, '--', ...journey], {
-    cwd: host.root,
-    detached: true,
-    env: {
-      PATH: `${host.bin}:${process.env.PATH}`,
-      TMPDIR: host.root,
-      FAKE_LOG: host.log,
-      FAKE_ROOT: host.root,
-      ANDROID_HOME: host.sdk,
-      SETUP_AVD: 'Test_Phone',
-      ...host.ports,
-      DB_NAME_PREFIX: 'app_e2e_',
-      KILL_GRACE_SECONDS: '1',
-      BOUNDED_SECONDS: '2',
-      ...env,
-    },
-  });
-  child.stdin.end(input);
-  let stdout = '', stderr = '';
-  child.stdout.on('data', (chunk) => { stdout += chunk; });
-  child.stderr.on('data', (chunk) => { stderr += chunk; });
-  let expired = false;
-  const timer = setTimeout(() => {
-    expired = true;
-    try { process.kill(-child.pid, 'SIGKILL'); } catch {}
-    for (const pid of host.pids()) { try { process.kill(pid, 'SIGKILL'); } catch {} }
-  }, 12_000);
-  const closed = new Promise((resolve) => child.once('close', (status, signal) => resolve({ status, signal })));
-  try {
-    if (signalAt) {
-      await until(() => existsSync(join(host.root, signalAt)), `never reached ${signalAt}`);
-      child.kill('SIGTERM'); // Signal only the launcher, as an external caller does.
-    }
-    const result = await closed;
-    const emulatorLog = join(host.root, '.cache/logs/emulator.log');
-    return { ...result, stdout, stderr: stderr + (existsSync(emulatorLog) ? readFileSync(emulatorLog, 'utf8') : ''), expired, calls: readFileSync(host.log, 'utf8') };
-  } finally {
-    clearTimeout(timer);
-    if (child.exitCode === null && child.signalCode === null) {
-      try { process.kill(-child.pid, 'SIGKILL'); } catch {}
-    }
-  }
-}
-
-async function stopped(host) {
-  await until(() => host.pids().every((pid) => !alive(pid)), 'owned descendants survived cleanup', 1500);
-}
-
-function outcome(r, original, cleanup) {
-  assert.equal(r.expired, false, `test safety deadline fired: ${r.stderr}`);
-  assert.equal(r.status, original || cleanup, r.stderr);
-  assert.match(r.stdout, new RegExp(`original_stage_exit=${original} cleanup_exit=${cleanup}\\n$`), r.stderr);
-}
-
-test('a passing journey cleans up everything it started and exits 0', async (t) => {
-  const host = await fakeHost(t);
-  const marker = join(host.root, 'journey ran.txt');
-  const r = await run(host, { journey: ['bash', '-c', 'echo "$ANDROID_EMULATOR_SERIAL $SHARD_DB_NAME" > "$1"', 'journey', marker] });
-  outcome(r, 0, 0);
-  const port = host.ports.EMULATOR_PORT;
-  assert.match(readFileSync(marker, 'utf8'), new RegExp(`^emulator-${port} app_e2e_\\d+_\\d+\\n$`));
-  assert.ok(r.calls.indexOf('adb start-server') < r.calls.indexOf(`emulator -avd Test_Phone -port ${port}`));
-  assert.match(r.calls, new RegExp(`^emulator -avd Test_Phone -port ${port} -memory 4096 `, 'm'));
-  assert.match(r.calls, /^drop app_e2e_\d+_\d+ postgresql:\/\/postgres:postgres@127\.0\.0\.1:55432\/postgres$/m);
-  assert.match(r.calls, /^docker rm --force fakecid42$/m);
-  await stopped(host);
-});
-
-test('a failing journey keeps its status and still cleans up', async (t) => {
-  const host = await fakeHost(t);
-  const r = await run(host, { journey: ['bash', '-c', 'exit 42'] });
-  outcome(r, 42, 0);
-  assert.match(r.calls, /^drop app_e2e_/m);
-  assert.match(r.calls, /^docker rm --force fakecid42$/m);
-});
-
-test('an emulator that ignores TERM is killed and reported as a cleanup failure', async (t) => {
-  const host = await fakeHost(t);
-  // Wait for the fake to install its handler, not an assumed startup delay.
-  const r = await run(host, { env: { FAKE_EMULATOR_IGNORES_TERM: '1' }, journey: ['bash', '-c', 'while ! test -e "$FAKE_ROOT/emulator-ready"; do sleep 0.02; done'] });
-  outcome(r, 0, 1);
-  assert.match(r.calls, /^docker rm --force fakecid42$/m);
-  await stopped(host);
-});
-
-test('a stalled readiness probe ends the run with 124 and no journey', async (t) => {
-  const host = await fakeHost(t);
-  const marker = join(host.root, 'journey-ran');
-  const r = await run(host, { journey: ['touch', marker], env: { FAKE_ADB_HANG: '1', BOUNDED_SECONDS: '0.5' } });
-  outcome(r, 124, 0);
-  assert.equal(existsSync(marker), false);
-  assert.doesNotMatch(r.calls, /^drop /m);
-  assert.match(r.calls, /^docker rm --force fakecid42$/m);
-  await stopped(host);
-});
-
-test('a busy port stops the run before anything starts', async (t) => {
-  const host = await fakeHost(t);
-  const server = await listen(Number(host.ports.ANDROID_BACKEND_PORT));
-  try {
-    const r = await run(host);
-    assert.notEqual(r.status, 0);
-    assert.match(r.stdout, /cleanup_exit=0/);
-    assert.equal(r.calls, '');
-  } finally {
-    await new Promise((resolve) => server.close(resolve));
-  }
-});
-
-test('an emulator port outside the range adb scans is refused', async (t) => {
-  const host = await fakeHost(t);
-  const r = await run(host, { env: { EMULATOR_PORT: '5588' } });
-  assert.equal(r.status, 2);
-  assert.match(r.stderr, /even port in 5554-5584/);
-  assert.equal(r.calls, '');
-});
-
-test('a timed out docker startup removes its recorded CID and kills descendants', async (t) => {
-  const host = await fakeHost(t);
-  const r = await run(host, { env: { FAKE_DOCKER_RUN_HANG: '1', BOUNDED_SECONDS: '0.5' } });
-  outcome(r, 124, 0);
-  assert.match(r.calls, /^docker rm --force fakecid42$/m);
-  assert.doesNotMatch(r.calls, /^drop /m);
-  await stopped(host);
-});
-
-for (const stage of ['startup', 'journey']) {
-  test(`SIGTERM during ${stage} stops descendants and preserves 143`, async (t) => {
-    const host = await fakeHost(t);
-    const r = await run(host, {
-      signalAt: `${stage}-ready`,
-      journey: ['worker', 'journey'],
-      env: stage === 'startup' ? { FAKE_DOCKER_RUN_HANG: '1', BOUNDED_SECONDS: '8' } : {},
-    });
-    outcome(r, 143, 0);
-    assert.match(r.calls, /^docker rm --force fakecid42$/m);
-    if (stage === 'journey') assert.match(r.calls, /^drop /m);
-    else assert.doesNotMatch(r.calls, /^drop /m);
-    await stopped(host);
-  });
-}
-
-test('a journey deadline kills its whole process group and still drops the database', async (t) => {
-  const host = await fakeHost(t);
-  const r = await run(host, { journey: ['worker', 'journey'], env: { JOURNEY_SECONDS: '0.5' } });
-  outcome(r, 124, 0);
-  assert.match(r.calls, /^drop /m);
-  assert.match(r.calls, /^docker rm --force fakecid42$/m);
-  await stopped(host);
-});
-
-test('an emulator descendant is removed even after the emulator leader exits', async (t) => {
-  const host = await fakeHost(t);
-  const r = await run(host, {
-    env: { FAKE_EMULATOR_TREE: '1' },
-    journey: ['bash', '-c', 'while ! test -e "$FAKE_ROOT/emulator-ready"; do sleep 0.02; done; touch "$FAKE_ROOT/release-emulator"'],
-  });
-  assert.equal(r.expired, false);
-  await stopped(host);
-  outcome(r, 0, 1); // A descendant that requires KILL is a cleanup failure.
-});
-
-test('cleanup timeouts do not replace an original failure or skip remaining cleanup', async (t) => {
-  const host = await fakeHost(t);
-  const r = await run(host, {
-    journey: ['bash', '-c', 'exit 42'], drop: ['worker', 'drop'],
-    env: { FAKE_RM_HANG: '1', BOUNDED_SECONDS: '0.5' },
-  });
-  outcome(r, 42, 1);
-  assert.match(r.calls, /^docker rm --force fakecid42$/m);
-  assert.match(r.calls, /^docker ps /m);
-  await stopped(host);
-});
-
-test('a command killed by a signal keeps the shell signal status', async (t) => {
-  const host = await fakeHost(t);
-  const r = await run(host, { journey: ['bash', '-c', 'kill -TERM $$'] });
-  outcome(r, 143, 0);
-});
-
-test('a missing journey executable keeps shell status 127', async (t) => {
-  const host = await fakeHost(t);
-  const r = await run(host, { journey: [join(host.root, 'missing')] });
-  outcome(r, 127, 0);
-  assert.match(r.calls, /^drop /m);
-  assert.match(r.calls, /^docker rm --force fakecid42$/m);
-});
-
-test('a non-executable journey keeps shell status 126', async (t) => {
-  const host = await fakeHost(t);
-  const path = join(host.root, 'not executable');
-  writeFileSync(path, '#!/bin/sh\nexit 0\n');
-  const r = await run(host, { journey: [path] });
-  outcome(r, 126, 0);
-});
-
-test('a signal-ended startup command preserves shell status 143', async (t) => {
-  const host = await fakeHost(t);
-  const r = await run(host, { env: { FAKE_ADB_START_SIGNAL: '1' } });
-  outcome(r, 143, 0);
-  assert.doesNotMatch(r.calls, /emulator -avd|docker run/);
-});
-
-test('an unacknowledged docker startup reports uncertain cleanup without guessing an ID', async (t) => {
-  const host = await fakeHost(t);
-  const r = await run(host, { env: { FAKE_DOCKER_RUN_HANG: '1', FAKE_NO_CID: '1', BOUNDED_SECONDS: '0.5' } });
-  outcome(r, 124, 1);
-  assert.doesNotMatch(r.calls, /^docker rm |^drop /m);
-  await stopped(host);
-});
-
-test('a container still listed after removal is a cleanup failure', async (t) => {
-  const host = await fakeHost(t);
-  const r = await run(host, { env: { FAKE_CONTAINER_REMAINS: '1' } });
-  outcome(r, 0, 1);
-});
-
-test('journey stdin and literal argument boundaries are preserved', async (t) => {
-  const host = await fakeHost(t);
-  const r = await run(host, {
-    input: 'input line\n',
-    journey: ['bash', '-c', 'IFS= read -r line; printf "received <%s> <%s> <%s>\\n" "$line" "$1" "$2"', 'journey', 'a b', '--'],
-  });
-  outcome(r, 0, 0);
-  assert.match(r.stdout, /^received <input line> <a b> <-->$/m);
-});
-
-test('cleanup leaves an unrelated process running', async (t) => {
-  const host = await fakeHost(t);
-  const peer = spawn(join(host.bin, 'worker'), ['peer'], {
-    detached: true, stdio: 'ignore', env: { ...process.env, FAKE_ROOT: host.root },
-  });
-  const exited = new Promise((resolve) => peer.once('close', resolve));
-  t.after(async () => { peer.kill('SIGKILL'); await exited; });
-  await until(() => existsSync(join(host.root, 'peer-ready')), 'peer did not start');
-  const r = await run(host);
-  outcome(r, 0, 0);
-  assert.equal(alive(peer.pid), true);
-});
-
-for (const env of [
-  { BOUNDED_SECONDS: '0' }, { BOUNDED_SECONDS: 'NaN' },
-  { JOURNEY_SECONDS: '-1' }, { KILL_GRACE_SECONDS: 'infinity' },
-  { BOOT_ATTEMPTS: '0' }, { DB_URL_VAR: 'bad-name' }, { DB_NAME_VAR: 'SHARD_ADMIN_URL' },
-]) {
-  test(`invalid settings are refused before startup: ${JSON.stringify(env)}`, async (t) => {
-    const host = await fakeHost(t);
-    const r = await run(host, { env });
-    assert.equal(r.status, 2, r.stderr);
-    assert.equal(r.calls, '');
-  });
-}
-
-for (const assignment of ['active_pid=$!', 'emulator_pid=$!']) {
-  test(`TERM between spawn and recording ${assignment} retains ownership`, async (t) => {
-    const host = await fakeHost(t);
-    const hook = join(host.root, 'launch-race.bash');
-    const ready = assignment.startsWith('active') ? 'startup-ready' : 'emulator-ready';
-    writeFileSync(hook, `
-set -T
-trap 'if [[ "$BASH_SUBSHELL" = "0" && "$BASH_COMMAND" = "$RACE_ASSIGNMENT" && ! -e "$FAKE_ROOT/race-fired" ]]; then
-  printf "supervisor %s\\n" "$!" >> "$FAKE_ROOT/pids"
-  touch "$FAKE_ROOT/race-fired"
-  while ! test -e "$FAKE_ROOT/$RACE_READY"; do sleep 0.02; done
-  kill -TERM "$$"
-fi' DEBUG
-`);
-    const r = await run(host, { env: {
-      BASH_ENV: hook, RACE_ASSIGNMENT: assignment, RACE_READY: ready,
-      ...(assignment.startsWith('active') ? { FAKE_ADB_START_HANG: '1', BOUNDED_SECONDS: '60' } : {}),
-    } });
-    assert.equal(existsSync(join(host.root, 'race-fired')), true, r.stderr);
-    outcome(r, 143, 0);
-    assert.doesNotMatch(r.calls, /^docker run/m);
-    await stopped(host);
-  });
-}
-
-// The default commands intentionally use the original environment-variable contract.
-test('caller-selected adb endpoint and custom database names reach both commands', async (t) => {
-  const host = await fakeHost(t);
-  const command = ['bash', '-c', 'printf "contract %s %s %s %s\\n" "$ADB_SERVER_SOCKET" "$ANDROID_EMULATOR_SERIAL" "$TEST_ADMIN_URL" "$TEST_DB" >> "$FAKE_LOG"'];
-  const r = await run(host, {
-    journey: command, drop: command,
-    env: { ADB_SERVER_SOCKET: 'tcp:127.0.0.1:15037', DB_URL_VAR: 'TEST_ADMIN_URL', DB_NAME_VAR: 'TEST_DB' },
-  });
-  outcome(r, 0, 0);
-  assert.match(r.calls, /^adb-env tcp:127\.0\.0\.1:15037 /m);
-  const lines = r.calls.split('\n').filter((line) => line.startsWith('contract '));
-  assert.equal(lines.length, 2);
-  assert.equal(lines[0], lines[1]);
-  assert.match(lines[0], new RegExp(`^contract tcp:127\\.0\\.0\\.1:15037 emulator-${host.ports.EMULATOR_PORT} postgresql://postgres:postgres@127\\.0\\.0\\.1:55432/postgres app_e2e_`));
-  assert.doesNotMatch(r.calls, /kill-server|emu kill|system prune/);
-});

package/skills/app-dev/data-catalog/scripts/data-catalog.test.mjs

@@ -1,36 +0,0 @@
-import assert from 'node:assert/strict';
-import { spawnSync } from 'node:child_process';
-import { mkdtempSync, readFileSync, rmSync } from 'node:fs';
-import { tmpdir } from 'node:os';
-import { dirname, join } from 'node:path';
-import { fileURLToPath } from 'node:url';
-import test from 'node:test';
-
-const scriptsDir = dirname(fileURLToPath(import.meta.url));
-const conventions = readFileSync(join(scriptsDir, '../references/data-catalog-conventions.md'), 'utf8');
-
-test('data-catalog test_data_catalog.py', () => {
-  const result = spawnSync('python3', [join(scriptsDir, 'test_data_catalog.py')], { encoding: 'utf8' });
-  assert.equal(result.status, 0, `${result.stdout}\n${result.stderr}`);
-});
-
-test('persist-conventions writes the Data catalog section only with --write', () => {
-  const dir = mkdtempSync(join(tmpdir(), 'data-catalog-conventions-'));
-  try {
-    const cli = join(scriptsDir, 'persist-conventions.mjs');
-    const preview = spawnSync(process.execPath, [cli, '--repo-root', dir], { encoding: 'utf8' });
-    assert.match(preview.stdout, /preview only, 3 file\(s\) would change/);
-    assert.equal(spawnSync(process.execPath, [cli, '--repo-root', dir, '--write'], { encoding: 'utf8' }).status, 0);
-    const text = readFileSync(join(dir, 'CONTRIBUTING.md'), 'utf8');
-    assert.match(text, /<!-- conventions:data-catalog:start -->[\s\S]*## Data catalog conventions[\s\S]*<!-- conventions:data-catalog:end -->/);
-  } finally {
-    rmSync(dir, { recursive: true, force: true });
-  }
-});
-
-test('every engine command the conventions tell people to run exists', () => {
-  const cited = [...conventions.matchAll(/data_catalog\.py (\w+)/g)].map((m) => m[1]);
-  assert.deepEqual([...new Set(cited)].sort(), ['audit', 'drift', 'generate']);
-  const help = spawnSync('python3', [join(scriptsDir, 'data_catalog.py'), '--help'], { encoding: 'utf8' }).stdout;
-  for (const command of cited) assert.match(help, new RegExp(`\\b${command}\\b`), `${command} missing from the engine`);
-});

package/skills/app-dev/data-quality/scripts/data-quality.test.mjs

@@ -1,12 +0,0 @@
-import assert from 'node:assert/strict';
-import { spawnSync } from 'node:child_process';
-import { dirname, join } from 'node:path';
-import { fileURLToPath } from 'node:url';
-import test from 'node:test';
-
-const scriptsDir = dirname(fileURLToPath(import.meta.url));
-
-test('data-quality test_data_quality.py', () => {
-  const result = spawnSync('python3', [join(scriptsDir, 'test_data_quality.py')], { encoding: 'utf8' });
-  assert.equal(result.status, 0, `${result.stdout}\n${result.stderr}`);
-});