@1aboveio/skills 1.0.7 → 1.0.9

package/skills/engineering/ensure-coverage/scripts/lint-tests.test.mjs

@@ -1,289 +0,0 @@
-// Tests for the lint-tests gate engine (pure core, no filesystem/git).
-import { test } from 'node:test'
-import assert from 'node:assert/strict'
-
-import { scanText, scanDiff, selectRules, RULES, ALL_RULES, isTestFile, stripComment, runCli } from './lint-tests.mjs'
-import { resolveMockPolicy } from './mock-policy-config.mjs'
-
-test('default rules = all gate rules incl. the default-on mock-internal-seam', () => {
-  assert.deepEqual(
-    selectRules().map((r) => r.id).sort(),
-    ['mock-internal-seam', 'no-empty-test', 'no-fixed-timeout', 'no-skip', 'no-swallowed-assertion'],
-  )
-  assert.equal(RULES.length, 4) // the four authoring gates; mock-internal-seam lives in ALL_RULES
-})
-
-test('no-skip rule flags skip/only/xfail (carries rule + kind)', () => {
-  // non-empty bodies so this isolates no-skip from the no-empty-test rule
-  const f = scanText('a.spec.ts', 'test.skip("x", () => { go() })\ndescribe.only("y", () => { go() })')
-  assert.deepEqual(f.map((x) => [x.rule, x.kind]), [['no-skip', 'skip'], ['no-skip', 'only']])
-})
-
-test('no-fixed-timeout flags waitForTimeout / numeric cy.wait / time.sleep', () => {
-  const f = scanText('a.spec.ts', [
-    'await page.waitForTimeout(500)',
-    "cy.wait(1000)",
-    'time.sleep(2)',
-  ].join('\n'))
-  assert.deepEqual(f.map((x) => x.kind), ['waitForTimeout', 'cy.wait', 'time.sleep'])
-  assert.ok(f.every((x) => x.rule === 'no-fixed-timeout'))
-})
-
-test('no-fixed-timeout does NOT flag an aliased cy.wait (not a fixed sleep)', () => {
-  assert.deepEqual(scanText('a.spec.ts', "cy.wait('@getUser')"), [])
-})
-
-test('--rules selection runs only the chosen rule', () => {
-  const text = 'test.skip("x", () => {})\nawait page.waitForTimeout(500)'
-  const onlySkip = scanText('a.spec.ts', text, ['no-skip'])
-  assert.deepEqual(onlySkip.map((x) => x.rule), ['no-skip'])
-  const onlyTimeout = scanText('a.spec.ts', text, ['no-fixed-timeout'])
-  assert.deepEqual(onlyTimeout.map((x) => x.rule), ['no-fixed-timeout'])
-})
-
-test('a single line can trip two different rules', () => {
-  // contrived but valid: a skipped test on the same line as a timeout call
-  const f = scanText('a.spec.ts', 'test.skip("x", async () => { await page.waitForTimeout(1) })')
-  assert.deepEqual(f.map((x) => x.rule).sort(), ['no-fixed-timeout', 'no-skip'])
-})
-
-test('scanDiff flags only ADDED violations in test files, with new-file line numbers', () => {
-  const diff = [
-    '+++ b/e2e/x.spec.ts',
-    '@@ -10,2 +10,3 @@',
-    ' context',
-    '+await page.waitForTimeout(300)',
-    '-old line',
-  ].join('\n')
-  const f = scanDiff(diff)
-  assert.equal(f.length, 1)
-  assert.equal(f[0].rule, 'no-fixed-timeout')
-  assert.equal(f[0].line, 11)
-})
-
-test('scanDiff ignores violations added to NON-test files', () => {
-  const diff = ['+++ b/src/util.ts', '@@ -1,1 +1,2 @@', '+await sleepThing.waitForTimeout(5)'].join('\n')
-  assert.deepEqual(scanDiff(diff), [])
-})
-
-test('isTestFile is shared and recognizes spec/test paths, rejects app code', () => {
-  for (const p of ['e2e/a.spec.ts', 'src/x.test.tsx', 'tests/e2e/b.spec.js', 'api/test_views.py', 'pkg/foo_test.py', '__tests__/c.ts']) {
-    assert.equal(isTestFile(p), true, p)
-  }
-  for (const p of ['src/app/page.tsx', 'lib/util.ts', 'README.md']) {
-    assert.equal(isTestFile(p), false, p)
-  }
-})
-
-// ---- no-skip rule: richer cases (folded in from the former skip-lint suite) ----
-
-test('no-skip leaves conditional skips to test-quality (a lead, not a gate)', () => {
-  // A runtime or annotated skip depends on a condition: legitimate for a platform
-  // CI still runs elsewhere, a hole otherwise. A gate cannot tell which.
-  const f = scanText('a.spec.ts', 'if (!user) test.skip();\ntest.skip(true, "https://github.com/o/r/issues/1")')
-  assert.equal(f.filter((x) => x.rule === 'no-skip').length, 0)
-})
-
-test('no-skip flags unconditional Python skips, not skipif/runtime skip/xfail', () => {
-  const text = [
-    '@pytest.mark.skip(reason="x")',
-    '@pytest.mark.skipif(cond)',
-    '@unittest.skip("x")',
-    '    pytest.skip("x")',
-    '@pytest.mark.xfail',
-  ].join('\n')
-  assert.deepEqual(scanText('test_x.py', text).filter((f) => f.rule === 'no-skip').map((f) => [f.line, f.kind]), [[1, 'skip'], [3, 'skip']])
-})
-
-test('no-skip flags declared-skipped and todo tests', () => {
-  const f = scanText('a.spec.ts', 'test.skip("later", () => { go() })\ntest.todo("write me")')
-  assert.deepEqual(f.filter((x) => x.rule === 'no-skip').map((x) => x.kind), ['skip', 'todo'])
-})
-
-test('no-skip does not flag a commented-out or doc mention', () => {
-  const text = [
-    '// never use test.skip() — banned',
-    '# doc: test.skip is not allowed',
-    'const xs = items.skip(2) // unrelated array method',
-  ].join('\n')
-  assert.deepEqual(scanText('a.spec.ts', text), [])
-})
-
-test('no-skip does not flag .only/.skip method calls that are not test forms', () => {
-  assert.deepEqual(scanText('a.spec.ts', 'arr.skip(1); foo.only;'), [])
-})
-
-// ---- no-empty-test rule: the decidable floor of the Missing-Assertion smell ----
-
-test('no-empty-test flags empty arrow/function/playwright/.each/.concurrent bodies', () => {
-  const cases = [
-    "test('a', () => {})",
-    'it("b", async () => {})',
-    "test('c', function () {})",
-    "test('d', async ({ page }) => {})",
-    "it.each([1,2])('e', () => {})",
-    "test.concurrent('f', () => {})",
-  ]
-  for (const c of cases) {
-    const f = scanText('a.spec.ts', c, ['no-empty-test'])
-    assert.equal(f.length, 1, `should flag: ${c}`)
-    assert.equal(f[0].kind, 'empty-test')
-  }
-})
-
-test('no-empty-test does NOT flag a test that has a body', () => {
-  const cases = [
-    "test('a', () => { expect(1).toBe(1) })",
-    "it('b', async () => { await verifyDashboard(page) })", // asserts via helper — not empty, not flagged
-    "test('c', () => { doThing() })",
-  ]
-  for (const c of cases) assert.deepEqual(scanText('a.spec.ts', c, ['no-empty-test']), [], c)
-})
-
-test('no-empty-test does NOT flag describe/suite, look-alike identifiers, or 1-arg calls', () => {
-  const text = [
-    "describe('group', () => {})",   // empty suite is not a fake test
-    "emit('evt', () => {})",          // 'it' inside emit — word boundary protects
-    "submit('x', () => {})",          // 'it' inside submit
-    "it('pending')",                  // no callback — not an empty-bodied test
-    'const t = () => {}',             // not a test call
-  ].join('\n')
-  assert.deepEqual(scanText('a.spec.ts', text, ['no-empty-test']), [])
-})
-
-test('no-empty-test leaves a multi-line empty body to the review lead (no false block)', () => {
-  // The opening line has no closing brace, so the single-line gate does not fire.
-  assert.deepEqual(scanText('a.spec.ts', "it('x', () => {\n})", ['no-empty-test']), [])
-})
-
-// ---- no-swallowed-assertion rule: the vacuous-green form behind #237 ----
-
-test('no-swallowed-assertion flags a matcher whose rejection is eaten by .catch()', () => {
-  const cases = [
-    "await expect(page.locator('#cta')).not.toBeVisible().catch(() => {})", // the #237 form
-    "await expect(btn).toHaveText('Sign in').catch(() => null)",
-    'await expect(x).toBe(1).catch(() => {})',
-  ]
-  for (const c of cases) {
-    const f = scanText('a.spec.ts', c, ['no-swallowed-assertion'])
-    assert.equal(f.length, 1, `should flag: ${c}`)
-    assert.equal(f[0].kind, 'swallowed-catch')
-    assert.equal(f[0].rule, 'no-swallowed-assertion')
-  }
-})
-
-test('no-swallowed-assertion does NOT flag a legitimate assertion or an unrelated .catch', () => {
-  const cases = [
-    "await expect(page.locator('#cta')).toBeVisible()",              // real assertion, no swallow
-    "const v = await fetchThing().catch(() => fallback)",            // .catch on setup, not a matcher
-    "promise.then(ok).catch(handleError)",                           // plain promise handling
-  ]
-  for (const c of cases) assert.deepEqual(scanText('a.spec.ts', c, ['no-swallowed-assertion']), [], c)
-})
-
-test('no-swallowed-assertion is a default gate and flags it in a PR diff', () => {
-  const diff = [
-    '+++ b/e2e/login.sweep.spec.ts',
-    '@@ -1,1 +1,2 @@',
-    ' context',
-    "+await expect(page.locator('#cta')).not.toBeVisible().catch(() => {})",
-  ].join('\n')
-  const f = scanDiff(diff) // default rule set, no explicit --rules
-  assert.equal(f.length, 1)
-  assert.equal(f[0].rule, 'no-swallowed-assertion')
-})
-
-test('stripComment removes // and # trailing comments', () => {
-  assert.equal(stripComment('code // test.skip()').includes('test.skip'), false)
-  assert.equal(stripComment('code  # pytest.skip').includes('pytest.skip'), false)
-})
-
-test('scanDiff ignores a pre-existing skip on an unchanged (context) line', () => {
-  const diff = ['+++ b/e2e/x.spec.ts', '@@ -1,2 +1,3 @@', ' test.skip("inherited", () => {})', '+test("added clean", () => { ok() })'].join('\n')
-  assert.deepEqual(scanDiff(diff), [])
-})
-
-// ---- mock-internal-seam rule: the zero-tolerance, default-on over-mock gate ----
-
-const SEAM_CTX = { policy: resolveMockPolicy({ firstPartyPackages: ['@agentier/'] }) }
-
-test('mock-internal-seam is default-on: in ALL_RULES and in the default gate set', () => {
-  assert.ok(ALL_RULES.some((r) => r.id === 'mock-internal-seam'))
-  // zero-tolerance: it runs by default, no opt-in needed
-  assert.ok(selectRules().some((r) => r.id === 'mock-internal-seam'))
-  assert.deepEqual(
-    selectRules().map((r) => r.id).sort(),
-    ['mock-internal-seam', 'no-empty-test', 'no-fixed-timeout', 'no-skip', 'no-swallowed-assertion'],
-  )
-})
-
-test('mock-internal-seam cannot be opted out via config (enabled:false is ignored)', () => {
-  // the gate is defaultOn:true; selectRules does not consult policy.enabled
-  assert.ok(selectRules().some((r) => r.id === 'mock-internal-seam'))
-  // and naming a subset still resolves it from the registry
-  assert.deepEqual(selectRules(['mock-internal-seam']).map((r) => r.id), ['mock-internal-seam'])
-})
-
-test('mock-internal-seam flags a first-party alias mock (the studio incident)', () => {
-  const f = scanText('a.test.ts', "vi." + "mock('@/lib/org-allowlist-client')", ['mock-internal-seam'], SEAM_CTX)
-  assert.equal(f.length, 1)
-  assert.equal(f[0].rule, 'mock-internal-seam')
-  assert.equal(f[0].detail, '@/lib/org-allowlist-client')
-})
-
-test('mock-internal-seam exempts stdlib and third-party packages', () => {
-  const text = ["vi.mock('node:fs')", "jest.mock('react')", "vi.mock('@playwright/test')"].join('\n')
-  assert.deepEqual(scanText('a.test.ts', text, ['mock-internal-seam'], SEAM_CTX), [])
-})
-
-test('mock-internal-seam ignores an inline @mock-ok comment (no waivers)', () => {
-  const text = "vi." + "mock('@/lib/cp') // @mock-ok: covered by cp.real.test.ts"
-  const f = scanText('a.test.ts', text, ['mock-internal-seam'], SEAM_CTX)
-  assert.equal(f.length, 1) // still flagged — zero-tolerance, no escape hatch
-  assert.equal(f[0].detail, '@/lib/cp')
-})
-
-test('mock-internal-seam flags a declared first-party workspace package', () => {
-  const f = scanText('a.test.ts', "vi.mock('@agentier/shared')", ['mock-internal-seam'], SEAM_CTX)
-  assert.equal(f.length, 1)
-  assert.equal(f[0].detail, '@agentier/shared')
-})
-
-test('mock-internal-seam fires with NO ctx policy (never silently inert; @/ defaults apply)', () => {
-  // zero-tolerance: omitting config must not disable the gate — it falls back
-  // to DEFAULT_MOCK_POLICY, which flags conventional @/ first-party mocks.
-  const f = scanText('a.test.ts', "vi." + "mock('@/lib/x')", ['mock-internal-seam'])
-  assert.equal(f.length, 1)
-  assert.equal(f[0].detail, '@/lib/x')
-})
-
-test('mock-internal-seam flags an ADDED first-party mock in a PR diff (PR lane)', () => {
-  const diff = ['+++ b/src/__tests__/x.test.ts', '@@ -1,1 +1,2 @@', " import x", "+vi." + "mock('@/lib/cp')"].join('\n')
-  const f = scanDiff(diff, ['mock-internal-seam'], SEAM_CTX)
-  assert.equal(f.length, 1)
-  assert.equal(f[0].rule, 'mock-internal-seam')
-})
-
-test('mock-internal-seam flags an INHERITED (un-added) mock in a whole-tree scan (no grandfathering)', () => {
-  // whole-tree lane: scanText sees every line, not just diff additions, so the
-  // 781-style inherited debt is flagged until removed.
-  const f = scanText('src/__tests__/x.test.ts', "import x\nvi.mock('@/lib/cp')\n", ['mock-internal-seam'], SEAM_CTX)
-  assert.equal(f.length, 1)
-  assert.equal(f[0].detail, '@/lib/cp')
-})
-
-test('mock-internal-seam does not fire on a commented-out mock line', () => {
-  assert.deepEqual(scanText('a.test.ts', "// vi.mock('@/lib/x')", ['mock-internal-seam'], SEAM_CTX), [])
-})
-
-test('--help prints usage and exits 0 without scanning the tree', () => {
-  const lines = []
-  const orig = console.log
-  console.log = (s) => lines.push(String(s))
-  try {
-    assert.equal(runCli(['--help']), 0)
-  } finally {
-    console.log = orig
-  }
-  assert.match(lines.join('\n'), /usage: lint-tests\.mjs/)
-})

package/skills/engineering/ensure-coverage/scripts/mock-policy-config.test.mjs

@@ -1,119 +0,0 @@
-// Tests for the mock-policy classifier (pure; one fs case via a temp dir).
-import { test } from 'node:test'
-import assert from 'node:assert/strict'
-import fs from 'node:fs'
-import os from 'node:os'
-import path from 'node:path'
-
-import {
-  DEFAULT_MOCK_POLICY,
-  resolveMockPolicy,
-  loadMockPolicy,
-  loadMockPolicyFromFile,
-  extractMockTarget,
-  classifyMockTarget,
-} from './mock-policy-config.mjs'
-
-test('default policy is zero-tolerance: default-on, no waiver tag', () => {
-  assert.equal(DEFAULT_MOCK_POLICY.enabled, true)
-  // the inline-waiver escape hatch is gone
-  assert.equal(DEFAULT_MOCK_POLICY.waiverTag, undefined)
-})
-
-test('extractMockTarget pulls the specifier from vi/jest/vitest mock+doMock', () => {
-  assert.equal(extractMockTarget("vi." + "mock('@/lib/x')"), '@/lib/x')
-  assert.equal(extractMockTarget('jest.' + 'mock("pkg")'), 'pkg')
-  assert.equal(extractMockTarget('vi.' + 'doMock(`@/a/b`)'), '@/a/b')
-  assert.equal(extractMockTarget('vitest.' + 'mock("./rel")'), './rel')
-  assert.equal(extractMockTarget('const x = mockThing()'), null) // bare mock() is not a module mock
-  assert.equal(extractMockTarget('expect(x).toBe(1)'), null)
-})
-
-test('classify: first-party alias @/ and ~/ are internal seams (the incident case)', () => {
-  const p = resolveMockPolicy({})
-  assert.equal(classifyMockTarget('@/lib/org-allowlist-client', p).internal, true)
-  assert.equal(classifyMockTarget('~/services/cp', p).internal, true)
-})
-
-test('classify: stdlib and third-party packages are external (exempt)', () => {
-  const p = resolveMockPolicy({})
-  assert.equal(classifyMockTarget('node:fs', p).internal, false)
-  assert.equal(classifyMockTarget('react', p).internal, false)
-  assert.equal(classifyMockTarget('@playwright/test', p).internal, false)
-})
-
-test('classify: relative import into source is internal; into a test util/fixture is not', () => {
-  const p = resolveMockPolicy({})
-  assert.equal(classifyMockTarget('../services/payments', p).internal, true)
-  assert.equal(classifyMockTarget('./helpers/operator-session-store', p).internal, false)
-  assert.equal(classifyMockTarget('../__mocks__/cp', p).internal, false)
-  assert.equal(classifyMockTarget('../fixtures/data', p).internal, false)
-})
-
-test('classify: declared first-party workspace package is internal', () => {
-  const p = resolveMockPolicy({ firstPartyPackages: ['@acme/'] })
-  assert.equal(classifyMockTarget('@acme/db', p).internal, true)
-  assert.equal(classifyMockTarget('@acme', p).internal, true)
-  assert.equal(classifyMockTarget('@other/db', p).internal, false)
-})
-
-test('classify: declared externals allowlist exempts a first-party-looking target', () => {
-  const p = resolveMockPolicy({ externals: ['^@/generated/'] })
-  assert.equal(classifyMockTarget('@/generated/openapi', p).internal, false) // exempted
-  assert.equal(classifyMockTarget('@/lib/x', p).internal, true) // still flagged
-})
-
-test('compiled _externalsRe is non-enumerable: does not leak into JSON / enumeration', () => {
-  const p = resolveMockPolicy({ externals: ['^@/generated/'] })
-  // the compiled RegExp cache works...
-  assert.equal(classifyMockTarget('@/generated/openapi', p).internal, false)
-  // ...but is hidden from enumeration and serialization
-  assert.ok(!Object.keys(p).includes('_externalsRe'))
-  assert.equal(JSON.parse(JSON.stringify(p))._externalsRe, undefined)
-})
-
-test('loadMockPolicy reads coverage.config.json topology, defaults to on with no config', () => {
-  const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'mpc-'))
-  // no config → zero-tolerance default (on), conventional topology
-  assert.equal(loadMockPolicy(dir).enabled, true)
-  // with config → declared topology is merged in (config declares topology, not on/off)
-  fs.writeFileSync(
-    path.join(dir, 'coverage.config.json'),
-    JSON.stringify({ mockPolicy: { firstPartyPackages: ['@acme/'] } }),
-  )
-  const p = loadMockPolicy(dir)
-  assert.equal(p.enabled, true)
-  assert.deepEqual(p.firstPartyPackages, ['@acme/'])
-  // inherited default array still present
-  assert.ok(p.firstPartyAliasPrefixes.includes('@/'))
-})
-
-test('loadMockPolicy never throws on malformed config (and stays on)', () => {
-  const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'mpc-'))
-  fs.writeFileSync(path.join(dir, 'coverage.config.json'), '{ not json')
-  assert.equal(loadMockPolicy(dir).enabled, true)
-})
-
-test('loadMockPolicyFromFile reads the NAMED file (finding #1: not just its dirname)', () => {
-  const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'mpc-'))
-  const file = path.join(dir, 'team-coverage.json') // deliberately non-standard name
-  fs.writeFileSync(file, JSON.stringify({ mockPolicy: { enabled: true, externals: ['^@/generated/'] } }))
-  const p = loadMockPolicyFromFile(file)
-  assert.equal(p.enabled, true)
-  // the declared externals must actually apply (proof the file was read, not defaults)
-  assert.equal(classifyMockTarget('@/generated/openapi', p).internal, false)
-  assert.equal(classifyMockTarget('@/lib/auth', p).internal, true)
-})
-
-test('loadMockPolicyFromFile falls back to defaults when the named file is missing', () => {
-  // finding #1: a declared config that does not apply must not look like a clean pass.
-  // (It warns on stderr; here we assert the zero-tolerance default — gate stays ON.)
-  const p = loadMockPolicyFromFile(path.join(os.tmpdir(), 'definitely-absent-config-xyz.json'))
-  assert.equal(p.enabled, true)
-})
-
-test('loadMockPolicyFromFile with no argument discovers coverage.config.json in cwd', () => {
-  const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'mpc-'))
-  fs.writeFileSync(path.join(dir, 'coverage.config.json'), JSON.stringify({ mockPolicy: { enabled: true } }))
-  assert.equal(loadMockPolicyFromFile(undefined, dir).enabled, true)
-})