@1aboveio/engineering-skills 0.1.33 → 0.1.35
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +1 -0
- package/package.json +2 -2
- package/skills/acceptance-design/LICENSE +3 -0
- package/skills/acceptance-design/SKILL.md +47 -0
- package/skills/acceptance-design/references/project-setup.md +8 -0
- package/skills/acceptance-design/release-check.mjs +95 -0
- package/skills/better-review/SKILL.md +1 -1
- package/skills/e2e-test/SKILL.md +1 -1
- package/skills/engineering/SKILL.md +3 -1
- package/skills/engineering-runtime/SKILL.md +1 -1
- package/skills/engineering-runtime/coherence/workflow.json +32 -15
- package/skills/engineering-runtime/scripts/workflow-policy.mjs +6 -1
- package/skills/ensure-coverage/SKILL.md +3 -1
- package/skills/golden-path/SKILL.md +1 -1
- package/skills/harness-runtime/SKILL.md +1 -1
- package/skills/resolve-issues/SKILL.md +3 -3
- package/skills/resolve-release/SKILL.md +1 -1
- package/skills/rush-issues/SKILL.md +1 -1
- package/skills/rush-release/SKILL.md +1 -1
- package/skills/test-quality/SKILL.md +3 -1
package/README.md
CHANGED
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@1aboveio/engineering-skills",
|
|
3
|
-
"version": "0.1.
|
|
3
|
+
"version": "0.1.35",
|
|
4
4
|
"description": "Issue-to-PR and release orchestrators, review, coverage, golden paths and test quality.",
|
|
5
5
|
"license": "MIT",
|
|
6
6
|
"repository": {
|
|
@@ -27,7 +27,7 @@
|
|
|
27
27
|
"id": "engineering",
|
|
28
28
|
"core": "@1aboveio/core-skills",
|
|
29
29
|
"coreSkills": [],
|
|
30
|
-
"digest": "
|
|
30
|
+
"digest": "54f895e7d7402ff77ffe547d56e178c3ff611b8c363ebce15e417d8f292a44e6"
|
|
31
31
|
},
|
|
32
32
|
"publishConfig": {
|
|
33
33
|
"registry": "https://registry.npmjs.org/",
|
|
@@ -0,0 +1,47 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: acceptance-design
|
|
3
|
+
release-version: 0.50.15
|
|
4
|
+
description: Design or audit issue acceptance criteria. Use when asked whether existing standards are necessary and sufficient, to replay an issue or wave and assess its acceptance design, to select direct tests, or to decide what to rerun or record. Project setup persists these conventions; ordinary use does not write project guidance.
|
|
5
|
+
---
|
|
6
|
+
**Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
|
|
7
|
+
# Acceptance design
|
|
8
|
+
|
|
9
|
+
## First principle: what are we accepting?
|
|
10
|
+
|
|
11
|
+
Identify the claim before judging its criteria. Product acceptance concerns the consequences of a user's action, including effects they cannot see: submitting a payment once must not charge them twice. Migration acceptance asks whether the new entry point actually exercises the promised behavior. A test tool can have its own contract: detecting a failed readback proves the observer reported a fault, not that the product rejected the input. Attribute each observation to the claim it supports. Call out a mismatch when it changes the verdict; do not add a required report field.
|
|
12
|
+
|
|
13
|
+
Before using the existing checklist, reconstruct the journey from the requirement, agreed issue corrections, applicable project conventions and governing ADRs. For branches the requirement distinguishes, name the action, the affected object, and what should change or stay unchanged. For example, cancelling a filter edit should leave the list unchanged; applying it should show matching records. Now compare the checklist with those outcomes: a test that only opens the filter can pass when both branches are broken. Do not invent branches to fill a matrix. If sources disagree, identify the decision the owner needs to make.
|
|
14
|
+
|
|
15
|
+
Use the part needed for the current task. When writing an issue, return criteria; when designing tests, return actions and observations; when accepting a change, report the result. These are not three new checkpoints.
|
|
16
|
+
|
|
17
|
+
## Criteria: individually necessary, jointly sufficient
|
|
18
|
+
|
|
19
|
+
For an existing set of standards, use `/acceptance-design audit <issue, wave, or criteria>` or an equivalent natural-language request. Audit the criteria, not the implementation status. Read the source requirements and applicable ADRs before judging the checklist; for a historical replay distinguish original requirements from later approved corrections. If a source is missing, name what cannot be judged.
|
|
20
|
+
|
|
21
|
+
1. Separate promised behavior, explicit engineering deliverables (such as migrating a test runner), and operational prerequisites. Each can be legitimate, but satisfying one does not prove another.
|
|
22
|
+
2. Apply the two counterexample checks below. For each material problem identify the original criterion and source, the counterexample, and the smallest correction: remove a redundant condition, move a delivery check, rewrite a proxy as an observable result, or add a missing condition. Keep justified constraints even when costly.
|
|
23
|
+
3. Give a judgment on the set: reasonable as written, needs changes, or insufficient source to decide. Show the recommended criteria and the minimum direct observation needed for disputed items. Group repeated findings across a wave and name the affected issues. A failed run is not evidence of a bad criterion, nor a passing run evidence of a good one. Do not rerun jobs, edit issues, or waive gates as part of an audit unless separately requested.
|
|
24
|
+
|
|
25
|
+
**Necessity:** For each criterion, try to describe a valid implementation that would fail it. Suppose users must be able to change their nickname and see the new nickname after refreshing their profile. A save without a green confirmation toast can meet that requirement. Drop the toast criterion unless a governing requirement specifies it. Apply the same reasoning to configuration and infrastructure: keep them when they are the deliverable or an explicit constraint. Remove duplicate criteria that add no condition.
|
|
26
|
+
|
|
27
|
+
**Sufficiency:** Can all the criteria pass while the user's task still fails? A profile may show an edited nickname immediately but revert after refresh. A criterion that stops at the initial display misses the promise. Write: *After the user saves a nickname different from the current one and refreshes their profile, that account's nickname equals the value they saved.* This names the observable result without prescribing storage, a UI selector, or a sample string.
|
|
28
|
+
|
|
29
|
+
## Execution: what does this check directly verify?
|
|
30
|
+
|
|
31
|
+
Name the unproven condition, the action, and the observation that distinguishes success from failure. In the nickname case, compare the same account's nickname field after refresh with the value submitted in this run. Searching the whole page for a fixed string could match another user's name. A healthy database connection may help diagnose a failure but does not establish the profile result. Reuse an existing check that already makes the decisive observation.
|
|
32
|
+
|
|
33
|
+
Before requesting a rerun, identify what changed and which earlier conclusion that change could invalidate. A change to nickname loading can affect the refresh result. An unrelated documentation commit does not invalidate it just because the SHA changed; an altered test account can matter even with the same SHA. Repeat the affected checks. If the impact cannot be narrowed, explain why before expanding the rerun. Required CI, merge, audit and release checks still apply; distinguish candidate qualification from new product acceptance criteria.
|
|
34
|
+
|
|
35
|
+
## Evidence: keep the minimum that supports the verdict
|
|
36
|
+
|
|
37
|
+
For a replay, use the agreed scope and the observations available at the recorded checkpoint. Separate the behavior observed, whether the check ran to completion, and whether the candidate qualified for delivery. A cancelled job or missing artifact can block qualification without contradicting an earlier observation. A green build cannot establish a journey it never exercised. Preserve explicit proof obligations; label proposed scope changes as proposals unless the owner approved them.
|
|
38
|
+
|
|
39
|
+
When background work may legitimately change state, compare the business invariants affected by the action, not an entire snapshot. Verify the cause and ownership of permitted changes; do not ignore a whole class of changes merely to make a check pass.
|
|
40
|
+
|
|
41
|
+
Start with the actual observations. **Pass:** after saving a different nickname and refreshing, the account's nickname matched the submitted value. **Fail:** after refresh the old nickname returned. **Unverified:** the display changed after save, but nobody checked after refresh; verify that last step. Do not treat missing evidence as failure or a partial observation as success.
|
|
42
|
+
|
|
43
|
+
Record the requirement and the observed result in the original issue, or link the source if reporting elsewhere. Keep enough to distinguish what passed, failed, or remains unknown. If removing a screenshot, log, hash, or repeated description leaves the conclusion equally supported, do not duplicate it in the acceptance note. Preserve artifacts required by project policy. One observation can support several criteria; no separate ledger is required.
|
|
44
|
+
|
|
45
|
+
## Project or session use
|
|
46
|
+
|
|
47
|
+
Read existing project conventions without changing them. Without a saved policy, use the defaults above. For an explicit setup request, follow [project setup](references/project-setup.md). On a standalone invocation with no task or scope, offer Project (persist) or Session (no writes); `/acceptance-design init` selects Project. An issue, test or acceptance handoff never authorizes setup.
|
|
@@ -0,0 +1,8 @@
|
|
|
1
|
+
# Save project acceptance conventions
|
|
2
|
+
|
|
3
|
+
Session means no writes. Only initialize on an explicit Project choice, `/acceptance-design init`, or a request to save these rules. During ordinary work read existing project guidance; if absent, use the skill defaults and offer setup at most once per project per session.
|
|
4
|
+
|
|
5
|
+
1. Identify the authorized project root. Read its CONTRIBUTING.md, AGENTS.md and any CLAUDE.md entrypoint, including linked local instructions. Inspect all targets before writing. Stop on conflicting policies, invalid text, unsafe links, multiply linked files, or an unclosed fence/comment that would hide new instructions. Never edit inherited or global files. Resolve in-project aliases once.
|
|
6
|
+
2. In CONTRIBUTING.md preserve equivalent existing guidance; otherwise add `## Acceptance design` with these defaults: first identify what is being accepted. Derive the expected outcome from the requirement and applicable ADRs before judging the checklist. Product, migration and test-tool observations support different claims. Each criterion must be necessary; together they must be sufficient. Test the promised behavior directly. Reuse results unless a relevant change invalidates them. Record the requirement, source and observed outcome without duplicating evidence. Preserve mandatory CI and release checks. Do not overwrite project-specific choices.
|
|
7
|
+
3. In AGENTS.md add a task-entry rule unless an active equivalent already exists: “Before drafting or auditing acceptance criteria, designing acceptance tests, or deciding what to verify, rerun or record, apply `acceptance-design` and the [project acceptance conventions](CONTRIBUTING.md#acceptance-design).” Adapt the anchor to the actual section. Create missing files only within the project. Ensure any separate CLAUDE.md can reach that rule; add a short link to its AGENTS.md section only if needed.
|
|
8
|
+
4. Re-read from each entrypoint. Check both the skill trigger and the policy link, including a project that previously linked CONTRIBUTING.md but lacked a trigger. Re-evaluate the additions: if equivalent active instructions exist, make no changes. Report files changed or already configured. Report unavailable skills or unreachable guidance as incomplete; never install packages or grant delivery permissions during setup.
|
|
@@ -0,0 +1,95 @@
|
|
|
1
|
+
#!/usr/bin/env node
|
|
2
|
+
import { spawnSync } from 'node:child_process';
|
|
3
|
+
import { mkdirSync, readFileSync, writeFileSync } from 'node:fs';
|
|
4
|
+
import { homedir } from 'node:os';
|
|
5
|
+
import { dirname, join, resolve } from 'node:path';
|
|
6
|
+
import { fileURLToPath } from 'node:url';
|
|
7
|
+
|
|
8
|
+
const DAY_MS = 24 * 60 * 60 * 1000;
|
|
9
|
+
const WEEK_MS = 7 * DAY_MS;
|
|
10
|
+
const here = dirname(fileURLToPath(import.meta.url));
|
|
11
|
+
|
|
12
|
+
function readJson(path, fallback = {}) {
|
|
13
|
+
try { return JSON.parse(readFileSync(path, 'utf8')); } catch { return fallback; }
|
|
14
|
+
}
|
|
15
|
+
|
|
16
|
+
function frontmatterValue(text, key) {
|
|
17
|
+
const frontmatter = /^---\n([\s\S]*?)\n---/.exec(text)?.[1] ?? '';
|
|
18
|
+
const match = new RegExp('^' + key + ':\\s*([^\\n]+)$', 'm').exec(frontmatter);
|
|
19
|
+
return match?.[1].trim().replace(/^['"]|['"]$/g, '') ?? null;
|
|
20
|
+
}
|
|
21
|
+
|
|
22
|
+
function repositoryOf(source) {
|
|
23
|
+
const value = String(source ?? '').trim();
|
|
24
|
+
const match = /^(?:git@github\.com:|https:\/\/github\.com\/)?([A-Za-z0-9_.-]+\/[A-Za-z0-9_.-]+?)(?:\.git)?$/.exec(value);
|
|
25
|
+
return match?.[1] ?? null;
|
|
26
|
+
}
|
|
27
|
+
|
|
28
|
+
function stableVersion(value) {
|
|
29
|
+
const match = /^v?(\d+)\.(\d+)\.(\d+)$/.exec(String(value ?? '').trim());
|
|
30
|
+
return match ? match.slice(1).map(Number) : null;
|
|
31
|
+
}
|
|
32
|
+
|
|
33
|
+
function newer(left, right) {
|
|
34
|
+
for (let index = 0; index < 3; index += 1) {
|
|
35
|
+
if (left[index] !== right[index]) return left[index] > right[index];
|
|
36
|
+
}
|
|
37
|
+
return false;
|
|
38
|
+
}
|
|
39
|
+
|
|
40
|
+
function writeCache(path, value) {
|
|
41
|
+
try {
|
|
42
|
+
mkdirSync(dirname(path), { recursive: true });
|
|
43
|
+
writeFileSync(path, JSON.stringify(value));
|
|
44
|
+
} catch { /* A read-only cache must not block skill use. */ }
|
|
45
|
+
}
|
|
46
|
+
|
|
47
|
+
function main(now = Date.now()) {
|
|
48
|
+
if (process.env.ONEABOVEIO_NO_UPDATE_CHECK) return;
|
|
49
|
+
const bundle = readJson(join(resolve(here, '../../..'), 'package.json'));
|
|
50
|
+
if (bundle.name === '@1aboveio/skills' && bundle.nativeCodex?.schemaVersion === 1) return;
|
|
51
|
+
const skill = readFileSync(join(here, 'SKILL.md'), 'utf8');
|
|
52
|
+
const name = frontmatterValue(skill, 'name');
|
|
53
|
+
const localVersion = stableVersion(frontmatterValue(skill, 'release-version'));
|
|
54
|
+
if (!name || !localVersion) return;
|
|
55
|
+
|
|
56
|
+
const lock = readJson(join(process.env.HOME || homedir(), '.agents', '.skill-lock.json'));
|
|
57
|
+
const entry = lock.skills?.[name];
|
|
58
|
+
const repository = repositoryOf(entry?.sourceUrl || entry?.source);
|
|
59
|
+
if (!repository) return;
|
|
60
|
+
|
|
61
|
+
const cacheRoot = process.env.XDG_CACHE_HOME || join(process.env.HOME || homedir(), '.cache');
|
|
62
|
+
const cachePath = join(cacheRoot, '1aboveio-skills', 'release-check.json');
|
|
63
|
+
const all = readJson(cachePath);
|
|
64
|
+
const cache = all[repository] && typeof all[repository] === 'object' ? all[repository] : {};
|
|
65
|
+
|
|
66
|
+
if (!cache.lastCheck || now - cache.lastCheck >= DAY_MS) {
|
|
67
|
+
const result = spawnSync('gh', ['api', 'repos/' + repository + '/releases/latest', '--jq', '.tag_name'], {
|
|
68
|
+
encoding: 'utf8',
|
|
69
|
+
stdio: ['ignore', 'pipe', 'ignore'],
|
|
70
|
+
timeout: 1500,
|
|
71
|
+
});
|
|
72
|
+
cache.lastCheck = now;
|
|
73
|
+
if (result.status === 0 && stableVersion(result.stdout)) cache.latestTag = result.stdout.trim();
|
|
74
|
+
else delete cache.latestTag;
|
|
75
|
+
all[repository] = cache;
|
|
76
|
+
writeCache(cachePath, all);
|
|
77
|
+
}
|
|
78
|
+
|
|
79
|
+
const latestVersion = stableVersion(cache.latestTag);
|
|
80
|
+
if (!latestVersion || !newer(latestVersion, localVersion)) return;
|
|
81
|
+
if (cache.notifiedTag === cache.latestTag && cache.notifiedAt && now - cache.notifiedAt < WEEK_MS) return;
|
|
82
|
+
|
|
83
|
+
cache.notifiedTag = cache.latestTag;
|
|
84
|
+
cache.notifiedAt = now;
|
|
85
|
+
all[repository] = cache;
|
|
86
|
+
writeCache(cachePath, all);
|
|
87
|
+
const command = `npx skills@1.5.23 add '${repository}#${cache.latestTag}' --global --agent universal claude-code --skill ${name} --yes`;
|
|
88
|
+
process.stdout.write(
|
|
89
|
+
`UPDATE_AVAILABLE: A newer 1AboveIO skills release (${cache.latestTag}) is available; this skill is `
|
|
90
|
+
+ `v${localVersion.join('.')}. Ask once whether to refresh ${name}. On approval run \`${command}\`. `
|
|
91
|
+
+ 'The refreshed instructions apply next session. Either way, continue the current task and do not ask again this session.\n',
|
|
92
|
+
);
|
|
93
|
+
}
|
|
94
|
+
|
|
95
|
+
try { main(); } catch { /* Update checks are advisory and always fail silent. */ }
|
|
@@ -4,7 +4,7 @@ description: "Slash/explicit-only (/better-review). Single-agent adversarial rev
|
|
|
4
4
|
disable-model-invocation: true
|
|
5
5
|
dependencies:
|
|
6
6
|
- engineering-runtime
|
|
7
|
-
release-version: 0.50.
|
|
7
|
+
release-version: 0.50.15
|
|
8
8
|
---
|
|
9
9
|
**Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
|
|
10
10
|
# Better Review
|
package/skills/e2e-test/SKILL.md
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: e2e-test
|
|
3
3
|
description: "Playwright end-to-end guidance for affected browser journeys, render health and presentation checks, with route manifests and sweeps for broader audits. Use when browser routes or user flows ship or change, or a Playwright test flakes. NOT for non-browser tests, defining what to test (ensure-coverage), the curated ALIVE/DEAD golden-path gate (golden-path), or CI workflow YAML (github-actions)."
|
|
4
|
-
release-version: 0.50.
|
|
4
|
+
release-version: 0.50.15
|
|
5
5
|
---
|
|
6
6
|
**Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
|
|
7
7
|
# E2E Testing Standard
|
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: engineering
|
|
3
3
|
description: "Engineering conventions: feature-delivery priorities, focused verification and review, operational boundaries, and tracker routing. Standalone /engineering offers Global, Project, or Session setup and targeted resets for configured scopes; /engineering init keeps explicit project setup. Use when setting up AGENTS.md or CONTRIBUTING.md, saving or resetting engineering defaults, or before creating an engineering issue, spec, epic, ticket, or sub-issue on GitHub or Linear. Reads existing policy without writing during ordinary work. NOT the issue-to-PR workflow (resolve-issues), release execution (resolve-release), Git delivery (github-flow), or CI setup (github-actions)."
|
|
4
|
-
release-version: 0.50.
|
|
4
|
+
release-version: 0.50.15
|
|
5
5
|
---
|
|
6
6
|
**Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
|
|
7
7
|
# Engineering
|
|
@@ -184,6 +184,8 @@ Report a write error honestly; do not claim setup completed when it did not.
|
|
|
184
184
|
|
|
185
185
|
## Tracker routing
|
|
186
186
|
|
|
187
|
+
When drafting or revising issue acceptance criteria, apply `acceptance-design` to the product requirement and applicable ADRs before recording the criteria. Tracker routing stays here.
|
|
188
|
+
|
|
187
189
|
Read the destination from project guidance first, then the GitHub resources linked
|
|
188
190
|
from a source Linear project; ask if unresolved. An explicit user destination wins.
|
|
189
191
|
|
|
@@ -3,7 +3,7 @@ name: engineering-runtime
|
|
|
3
3
|
description: Internal support package for shared Engineering Workflow executable behavior. Never select or invoke this package as a user capability.
|
|
4
4
|
disable-model-invocation: true
|
|
5
5
|
user-invocable: false
|
|
6
|
-
release-version: 0.50.
|
|
6
|
+
release-version: 0.50.15
|
|
7
7
|
---
|
|
8
8
|
**Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
|
|
9
9
|
# Engineering Runtime
|
|
@@ -12,6 +12,7 @@
|
|
|
12
12
|
"test-quality",
|
|
13
13
|
"better-review",
|
|
14
14
|
"engineering",
|
|
15
|
+
"acceptance-design",
|
|
15
16
|
"engineering-runtime"
|
|
16
17
|
],
|
|
17
18
|
"dependencies": [
|
|
@@ -56,6 +57,7 @@
|
|
|
56
57
|
"resolve-issues",
|
|
57
58
|
"golden-path",
|
|
58
59
|
"better-review",
|
|
60
|
+
"acceptance-design",
|
|
59
61
|
"engineering-runtime"
|
|
60
62
|
],
|
|
61
63
|
"generatedIdentities": []
|
|
@@ -68,6 +70,7 @@
|
|
|
68
70
|
"resolve-issues",
|
|
69
71
|
"golden-path",
|
|
70
72
|
"better-review",
|
|
73
|
+
"acceptance-design",
|
|
71
74
|
"engineering-runtime"
|
|
72
75
|
],
|
|
73
76
|
"generatedIdentities": []
|
|
@@ -369,7 +372,7 @@
|
|
|
369
372
|
"repository": "1aboveio/ai",
|
|
370
373
|
"revision": "main"
|
|
371
374
|
},
|
|
372
|
-
"contentDigest": "
|
|
375
|
+
"contentDigest": "76a7c0c5177050c5f34d10db2ee062a9c62eb92bd48623bf65ca9bd4f8dfe217",
|
|
373
376
|
"digestExcludes": []
|
|
374
377
|
},
|
|
375
378
|
{
|
|
@@ -382,7 +385,7 @@
|
|
|
382
385
|
"repository": "1aboveio/ai",
|
|
383
386
|
"revision": "main"
|
|
384
387
|
},
|
|
385
|
-
"contentDigest": "
|
|
388
|
+
"contentDigest": "3bd732e41e2451bd4d4a53985995ef8ecb155bb73b9cc1f6e8da82b10f827adc",
|
|
386
389
|
"digestExcludes": []
|
|
387
390
|
},
|
|
388
391
|
{
|
|
@@ -395,7 +398,7 @@
|
|
|
395
398
|
"repository": "1aboveio/ai",
|
|
396
399
|
"revision": "main"
|
|
397
400
|
},
|
|
398
|
-
"contentDigest": "
|
|
401
|
+
"contentDigest": "4fa813e0da162ef607758c10d695097485e82174d2d7ec7c4153d14c68ea7b34",
|
|
399
402
|
"digestExcludes": []
|
|
400
403
|
},
|
|
401
404
|
{
|
|
@@ -408,7 +411,7 @@
|
|
|
408
411
|
"repository": "1aboveio/ai",
|
|
409
412
|
"revision": "main"
|
|
410
413
|
},
|
|
411
|
-
"contentDigest": "
|
|
414
|
+
"contentDigest": "2d3135e4e6a5a72d51e680bcf02b9ae6470c6b7593706880faddfb6ee4691f4b",
|
|
412
415
|
"digestExcludes": []
|
|
413
416
|
},
|
|
414
417
|
{
|
|
@@ -421,7 +424,7 @@
|
|
|
421
424
|
"repository": "1aboveio/ai",
|
|
422
425
|
"revision": "main"
|
|
423
426
|
},
|
|
424
|
-
"contentDigest": "
|
|
427
|
+
"contentDigest": "9dabf704a3ce6f2d6411e864dfec26d6bba39b4c2adf0c241bd6bbeb3d9c60e9",
|
|
425
428
|
"digestExcludes": []
|
|
426
429
|
},
|
|
427
430
|
{
|
|
@@ -434,7 +437,7 @@
|
|
|
434
437
|
"repository": "1aboveio/ai",
|
|
435
438
|
"revision": "main"
|
|
436
439
|
},
|
|
437
|
-
"contentDigest": "
|
|
440
|
+
"contentDigest": "e587ebc88561a7e5a7f3769cae12579b70186622d8539d6a5f0bd50dbdb0a4db",
|
|
438
441
|
"digestExcludes": []
|
|
439
442
|
},
|
|
440
443
|
{
|
|
@@ -447,7 +450,7 @@
|
|
|
447
450
|
"repository": "1aboveio/ai",
|
|
448
451
|
"revision": "main"
|
|
449
452
|
},
|
|
450
|
-
"contentDigest": "
|
|
453
|
+
"contentDigest": "27e961d02e4198203a293c7ce796ff69afa5050e48e3ce5d244e4ce4ea6cbc95",
|
|
451
454
|
"digestExcludes": []
|
|
452
455
|
},
|
|
453
456
|
{
|
|
@@ -460,7 +463,7 @@
|
|
|
460
463
|
"repository": "1aboveio/ai",
|
|
461
464
|
"revision": "main"
|
|
462
465
|
},
|
|
463
|
-
"contentDigest": "
|
|
466
|
+
"contentDigest": "d56baf340e463bf3eab4a0c4359b7cb7c9203b04d89a7df2030698961e8b790c",
|
|
464
467
|
"digestExcludes": []
|
|
465
468
|
},
|
|
466
469
|
{
|
|
@@ -473,7 +476,7 @@
|
|
|
473
476
|
"repository": "1aboveio/ai",
|
|
474
477
|
"revision": "main"
|
|
475
478
|
},
|
|
476
|
-
"contentDigest": "
|
|
479
|
+
"contentDigest": "ad914fc873e576057567e66bda39db28c16750c7813791413464d941d6377363",
|
|
477
480
|
"digestExcludes": []
|
|
478
481
|
},
|
|
479
482
|
{
|
|
@@ -486,7 +489,7 @@
|
|
|
486
489
|
"repository": "1aboveio/ai",
|
|
487
490
|
"revision": "main"
|
|
488
491
|
},
|
|
489
|
-
"contentDigest": "
|
|
492
|
+
"contentDigest": "d42ac22602cfbf083b23be9600ca204e2ab74c2faa42ca423e845c7107d08f39",
|
|
490
493
|
"digestExcludes": []
|
|
491
494
|
},
|
|
492
495
|
{
|
|
@@ -499,7 +502,20 @@
|
|
|
499
502
|
"repository": "1aboveio/ai",
|
|
500
503
|
"revision": "main"
|
|
501
504
|
},
|
|
502
|
-
"contentDigest": "
|
|
505
|
+
"contentDigest": "2ff8a29c0c20d4c1b0ff307abc7c47eff23fe8c34c9cdb9cf0cbcda929cac0c3",
|
|
506
|
+
"digestExcludes": []
|
|
507
|
+
},
|
|
508
|
+
{
|
|
509
|
+
"installName": "acceptance-design",
|
|
510
|
+
"ownership": "owned",
|
|
511
|
+
"sourcePath": "skills/engineering/acceptance-design",
|
|
512
|
+
"expectedSource": {
|
|
513
|
+
"id": "first-party",
|
|
514
|
+
"type": "first-party",
|
|
515
|
+
"repository": "1aboveio/ai",
|
|
516
|
+
"revision": "main"
|
|
517
|
+
},
|
|
518
|
+
"contentDigest": "8441d4116eadfa41ec67124d5d49ac0c5cd699a54ee69445a6a464358f34538c",
|
|
503
519
|
"digestExcludes": []
|
|
504
520
|
},
|
|
505
521
|
{
|
|
@@ -512,13 +528,13 @@
|
|
|
512
528
|
"repository": "1aboveio/ai",
|
|
513
529
|
"revision": "main"
|
|
514
530
|
},
|
|
515
|
-
"contentDigest": "
|
|
531
|
+
"contentDigest": "c715753e039cc3761cea2a8698e5a1cacdcb03f1fdd46b1003b6a6b29ecaa351",
|
|
516
532
|
"digestExcludes": [
|
|
517
533
|
"coherence/workflow.json"
|
|
518
534
|
]
|
|
519
535
|
}
|
|
520
536
|
],
|
|
521
|
-
"releaseIdentity": "
|
|
537
|
+
"releaseIdentity": "44f8567669f1c3dabe0ae51f7a8c202aa1edc6b465603b2d1dec8d080263dbf8",
|
|
522
538
|
"lifecycleAuthority": "native-skills-cli",
|
|
523
539
|
"repairRecipe": {
|
|
524
540
|
"id": "engineering-workflow-dependency-first",
|
|
@@ -581,6 +597,7 @@
|
|
|
581
597
|
"members": [
|
|
582
598
|
"harness-runtime",
|
|
583
599
|
"e2e-test",
|
|
600
|
+
"acceptance-design",
|
|
584
601
|
"ensure-coverage",
|
|
585
602
|
"rush-issues",
|
|
586
603
|
"resolve-issues",
|
|
@@ -595,11 +612,11 @@
|
|
|
595
612
|
"commands": [
|
|
596
613
|
{
|
|
597
614
|
"transport": "https",
|
|
598
|
-
"command": "npx skills@1.5.22 add 1aboveio/ai --global --agent universal claude-code --skill harness-runtime e2e-test ensure-coverage rush-issues resolve-issues rush-release resolve-release golden-path test-quality better-review engineering engineering-runtime && npm --prefix \"$(realpath \"$HOME/.agents/skills/engineering-runtime/scripts\")\" ci --ignore-scripts"
|
|
615
|
+
"command": "npx skills@1.5.22 add 1aboveio/ai --global --agent universal claude-code --skill harness-runtime e2e-test acceptance-design ensure-coverage rush-issues resolve-issues rush-release resolve-release golden-path test-quality better-review engineering engineering-runtime && npm --prefix \"$(realpath \"$HOME/.agents/skills/engineering-runtime/scripts\")\" ci --ignore-scripts"
|
|
599
616
|
},
|
|
600
617
|
{
|
|
601
618
|
"transport": "ssh",
|
|
602
|
-
"command": "npx skills@1.5.22 add git@github.com:1aboveio/ai.git --global --agent universal claude-code --skill harness-runtime e2e-test ensure-coverage rush-issues resolve-issues rush-release resolve-release golden-path test-quality better-review engineering engineering-runtime && npm --prefix \"$(realpath \"$HOME/.agents/skills/engineering-runtime/scripts\")\" ci --ignore-scripts"
|
|
619
|
+
"command": "npx skills@1.5.22 add git@github.com:1aboveio/ai.git --global --agent universal claude-code --skill harness-runtime e2e-test acceptance-design ensure-coverage rush-issues resolve-issues rush-release resolve-release golden-path test-quality better-review engineering engineering-runtime && npm --prefix \"$(realpath \"$HOME/.agents/skills/engineering-runtime/scripts\")\" ci --ignore-scripts"
|
|
603
620
|
}
|
|
604
621
|
],
|
|
605
622
|
"onFailure": {
|
|
@@ -17,6 +17,7 @@ export const WORKFLOW_OWNED_MEMBERS = deepFreeze([
|
|
|
17
17
|
'test-quality',
|
|
18
18
|
'better-review',
|
|
19
19
|
'engineering',
|
|
20
|
+
'acceptance-design',
|
|
20
21
|
'engineering-runtime',
|
|
21
22
|
]);
|
|
22
23
|
|
|
@@ -64,6 +65,7 @@ export const WORKFLOW_TRUSTED_DEPENDENCY_CLOSURES = deepFreeze([
|
|
|
64
65
|
'resolve-issues',
|
|
65
66
|
'golden-path',
|
|
66
67
|
'better-review',
|
|
68
|
+
'acceptance-design',
|
|
67
69
|
'engineering-runtime',
|
|
68
70
|
],
|
|
69
71
|
generatedIdentities: [],
|
|
@@ -77,6 +79,7 @@ export const WORKFLOW_TRUSTED_DEPENDENCY_CLOSURES = deepFreeze([
|
|
|
77
79
|
'resolve-issues',
|
|
78
80
|
'golden-path',
|
|
79
81
|
'better-review',
|
|
82
|
+
'acceptance-design',
|
|
80
83
|
'engineering-runtime',
|
|
81
84
|
],
|
|
82
85
|
generatedIdentities: [],
|
|
@@ -129,7 +132,9 @@ const externalArchiveLimits = 'SKILLS_DOWNLOAD_MAX_BYTES=33554432 SKILLS_EXTRACT
|
|
|
129
132
|
const mattMembersArgument = MATT_DEPENDENCY_MEMBERS.join(' ');
|
|
130
133
|
const firstPartyMembers = deepFreeze([
|
|
131
134
|
...HARNESS_RUNTIME_DEPENDENCY_MEMBERS,
|
|
132
|
-
|
|
135
|
+
'e2e-test',
|
|
136
|
+
'acceptance-design',
|
|
137
|
+
...WORKFLOW_OWNED_MEMBERS.filter((name) => !['e2e-test', 'acceptance-design'].includes(name)),
|
|
133
138
|
]);
|
|
134
139
|
const runtimeDependencyInstall = ' && npm --prefix "$(realpath "$HOME/.agents/skills/engineering-runtime/scripts")" ci --ignore-scripts';
|
|
135
140
|
const firstPartyInstallSuffix = `${nativeSkillsTarget} ${firstPartyMembers.join(' ')}${runtimeDependencyInstall}`;
|
|
@@ -2,7 +2,7 @@
|
|
|
2
2
|
name: ensure-coverage
|
|
3
3
|
description: "Define or audit behavior-first test criteria — ACs, required test levels, mock/integration/E2E policy — across three axes: breadth (Coverage Ledger), depth (over-mocking), presentation (perceivability of browser surfaces). NOT judging whether a single test is any good (test-quality), authoring browser tests (e2e-test), reviewing a PR (better-review), or delivering issues (resolve-issues)."
|
|
4
4
|
disable-model-invocation: true
|
|
5
|
-
release-version: 0.50.
|
|
5
|
+
release-version: 0.50.15
|
|
6
6
|
---
|
|
7
7
|
**Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
|
|
8
8
|
# Ensure Coverage
|
|
@@ -16,6 +16,8 @@ Read the relevant source and governing project guidance. When product behavior o
|
|
|
16
16
|
|
|
17
17
|
## Scope and proof
|
|
18
18
|
|
|
19
|
+
Use `acceptance-design` when defining criteria or deciding whether existing proof suffices. Apply its necessity and sufficiency checks before choosing test levels; this is part of scoping, not a separate review.
|
|
20
|
+
|
|
19
21
|
- Start from the issue's Acceptance Criteria, requirements elsewhere in the issue,
|
|
20
22
|
and later human corrections. Map each criterion to sufficient existing tests or
|
|
21
23
|
missing automation, its qualifying CI lane, and any human or physical-device
|
|
@@ -3,7 +3,7 @@ name: golden-path
|
|
|
3
3
|
description: "Golden-path E2E: the short list of user journeys whose failure blocks a release, kept in a repo as one contract (golden-paths.json) with a generated GOLDEN_PATHS.md and a generated GitHub Actions workflow, and run against a local build or a deployed URL for an ALIVE/DEAD verdict. Use to set golden paths up in a repo ('init golden paths', 'add golden-path CI'), to migrate an older smoke.manifest.json or a hand-built smoke setup ('audit', 'migrate smoke'), to add, change, or remove a golden path, to ask 'is the build alive?' or run them before a PR or release, or when a change touches a flow listed in GOLDEN_PATHS.md. NOT for writing the Playwright specs themselves (e2e-test), deciding what a change must prove (ensure-coverage), or general workflow YAML (github-actions)."
|
|
4
4
|
dependencies:
|
|
5
5
|
- e2e-test
|
|
6
|
-
release-version: 0.50.
|
|
6
|
+
release-version: 0.50.15
|
|
7
7
|
---
|
|
8
8
|
**Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
|
|
9
9
|
# Golden path
|
|
@@ -3,7 +3,7 @@ name: harness-runtime
|
|
|
3
3
|
description: Internal import-only library shared by first-party engineering packages. Not a workflow skill; never select or invoke it as a user capability.
|
|
4
4
|
disable-model-invocation: true
|
|
5
5
|
user-invocable: false
|
|
6
|
-
release-version: 0.50.
|
|
6
|
+
release-version: 0.50.15
|
|
7
7
|
---
|
|
8
8
|
**Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
|
|
9
9
|
# Harness Runtime
|
|
@@ -5,10 +5,11 @@ disable-model-invocation: true
|
|
|
5
5
|
metadata:
|
|
6
6
|
workflow-role: coordinator
|
|
7
7
|
dependencies:
|
|
8
|
+
- acceptance-design
|
|
8
9
|
- better-review
|
|
9
10
|
- golden-path
|
|
10
11
|
- harness-runtime
|
|
11
|
-
release-version: 0.50.
|
|
12
|
+
release-version: 0.50.15
|
|
12
13
|
---
|
|
13
14
|
**Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
|
|
14
15
|
# Resolve issues
|
|
@@ -129,8 +130,7 @@ Read each procedure right before its stage; never substitute your own.
|
|
|
129
130
|
|
|
130
131
|
## Acceptance criteria
|
|
131
132
|
|
|
132
|
-
|
|
133
|
-
Reuse or implement automated tests at the lowest sufficient level. Workers deliver behavior
|
|
133
|
+
Apply `acceptance-design` to the issue criteria, other requirements and later corrections. Preserve candidate-specific CI, review and merge checks. Reuse or implement automated tests at the lowest sufficient level. Workers deliver behavior
|
|
134
134
|
and tests, run focused local checks, and return with CI pending. CI qualifies the candidate;
|
|
135
135
|
the coordinator verifies results. Human or hardware criteria stay pending until their step passes.
|
|
136
136
|
|
|
@@ -4,7 +4,7 @@ description: "Slash/explicit-only (/resolve-release). Full GitHub Flow release f
|
|
|
4
4
|
disable-model-invocation: true
|
|
5
5
|
metadata:
|
|
6
6
|
workflow-role: coordinator
|
|
7
|
-
release-version: 0.50.
|
|
7
|
+
release-version: 0.50.15
|
|
8
8
|
---
|
|
9
9
|
**Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
|
|
10
10
|
# Resolve release
|
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: test-quality
|
|
3
3
|
description: "Seven principles for tests that catch real bugs, and an audit that reports weak, redundant, and not-coverage tests without fixing them. Use when writing, changing, or reviewing tests, or when asked whether tests are useful, redundant, over-mocked, flaky, only assert static text, or test config files, or asked to make a slow test suite faster without losing coverage, or when the user asks to write the testing conventions into a repo's CONTRIBUTING.md. NOT defining what a spec must prove (ensure-coverage) or authoring browser tests (e2e-test)."
|
|
4
|
-
release-version: 0.50.
|
|
4
|
+
release-version: 0.50.15
|
|
5
5
|
---
|
|
6
6
|
**Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
|
|
7
7
|
# Test Quality
|
|
@@ -25,6 +25,8 @@ A test is worth keeping when it fails for a real bug and stays green through a h
|
|
|
25
25
|
|
|
26
26
|
## Scope while writing
|
|
27
27
|
|
|
28
|
+
For tests intended to prove an acceptance criterion, use `acceptance-design` to choose the action and the observation that directly distinguishes pass from fail. Then apply the test-quality principles below.
|
|
29
|
+
|
|
28
30
|
Use these principles to judge the tests the task needs, not to start a suite-wide
|
|
29
31
|
cleanup. First identify the requested behavior or concrete regression and reuse
|
|
30
32
|
existing tests that prove it. Add focused assertions at the lowest level that
|