@1aboveio/engineering-skills 0.1.29 → 0.1.31
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/package.json +2 -2
- package/skills/better-review/SKILL.md +1 -1
- package/skills/e2e-test/SKILL.md +1 -1
- package/skills/engineering/SKILL.md +1 -1
- package/skills/engineering-runtime/SKILL.md +1 -1
- package/skills/engineering-runtime/coherence/workflow.json +13 -13
- package/skills/ensure-coverage/SKILL.md +1 -1
- package/skills/golden-path/SKILL.md +1 -1
- package/skills/harness-runtime/SKILL.md +1 -1
- package/skills/resolve-issues/SKILL.md +1 -1
- package/skills/resolve-release/SKILL.md +1 -1
- package/skills/resolve-release/references/prepared-metadata.md +16 -2
- package/skills/resolve-release/scripts/plan.mjs +92 -3
- package/skills/rush-issues/SKILL.md +1 -1
- package/skills/rush-release/SKILL.md +1 -1
- package/skills/test-quality/SKILL.md +1 -1
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@1aboveio/engineering-skills",
|
|
3
|
-
"version": "0.1.
|
|
3
|
+
"version": "0.1.31",
|
|
4
4
|
"description": "Issue-to-PR and release orchestrators, review, coverage, golden paths and test quality.",
|
|
5
5
|
"license": "MIT",
|
|
6
6
|
"repository": {
|
|
@@ -27,7 +27,7 @@
|
|
|
27
27
|
"id": "engineering",
|
|
28
28
|
"core": "@1aboveio/core-skills",
|
|
29
29
|
"coreSkills": [],
|
|
30
|
-
"digest": "
|
|
30
|
+
"digest": "3fdf56f81d43cb38b80e2f477cd1e1cd56a7634dd8e6f23633b5b76cb09f880c"
|
|
31
31
|
},
|
|
32
32
|
"publishConfig": {
|
|
33
33
|
"registry": "https://registry.npmjs.org/",
|
|
@@ -4,7 +4,7 @@ description: "Slash/explicit-only (/better-review). Single-agent adversarial rev
|
|
|
4
4
|
disable-model-invocation: true
|
|
5
5
|
dependencies:
|
|
6
6
|
- engineering-runtime
|
|
7
|
-
release-version: 0.50.
|
|
7
|
+
release-version: 0.50.11
|
|
8
8
|
---
|
|
9
9
|
**Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
|
|
10
10
|
# Better Review
|
package/skills/e2e-test/SKILL.md
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: e2e-test
|
|
3
3
|
description: "Playwright end-to-end guidance for affected browser journeys, render health and presentation checks, with route manifests and sweeps for broader audits. Use when browser routes or user flows ship or change, or a Playwright test flakes. NOT for non-browser tests, defining what to test (ensure-coverage), the curated ALIVE/DEAD golden-path gate (golden-path), or CI workflow YAML (github-actions)."
|
|
4
|
-
release-version: 0.50.
|
|
4
|
+
release-version: 0.50.11
|
|
5
5
|
---
|
|
6
6
|
**Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
|
|
7
7
|
# E2E Testing Standard
|
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: engineering
|
|
3
3
|
description: "Engineering conventions: feature-delivery priorities, focused verification and review, operational boundaries, and tracker routing. Standalone /engineering offers Global, Project, or Session setup and targeted resets for configured scopes; /engineering init keeps explicit project setup. Use when setting up AGENTS.md or CONTRIBUTING.md, saving or resetting engineering defaults, or before creating an engineering issue, spec, epic, ticket, or sub-issue on GitHub or Linear. Reads existing policy without writing during ordinary work. NOT the issue-to-PR workflow (resolve-issues), release execution (resolve-release), Git delivery (github-flow), or CI setup (github-actions)."
|
|
4
|
-
release-version: 0.50.
|
|
4
|
+
release-version: 0.50.11
|
|
5
5
|
---
|
|
6
6
|
**Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
|
|
7
7
|
# Engineering
|
|
@@ -3,7 +3,7 @@ name: engineering-runtime
|
|
|
3
3
|
description: Internal support package for shared Engineering Workflow executable behavior. Never select or invoke this package as a user capability.
|
|
4
4
|
disable-model-invocation: true
|
|
5
5
|
user-invocable: false
|
|
6
|
-
release-version: 0.50.
|
|
6
|
+
release-version: 0.50.11
|
|
7
7
|
---
|
|
8
8
|
**Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
|
|
9
9
|
# Engineering Runtime
|
|
@@ -369,7 +369,7 @@
|
|
|
369
369
|
"repository": "1aboveio/ai",
|
|
370
370
|
"revision": "main"
|
|
371
371
|
},
|
|
372
|
-
"contentDigest": "
|
|
372
|
+
"contentDigest": "216c97a744c770d44cf220560587d026a65b03317f3139832f5acf3b05f4d80b",
|
|
373
373
|
"digestExcludes": []
|
|
374
374
|
},
|
|
375
375
|
{
|
|
@@ -382,7 +382,7 @@
|
|
|
382
382
|
"repository": "1aboveio/ai",
|
|
383
383
|
"revision": "main"
|
|
384
384
|
},
|
|
385
|
-
"contentDigest": "
|
|
385
|
+
"contentDigest": "7f1bacc4f7ea586ad49f2ac4e9622ef6b97b7d4d6d23f7f10ba6bd92b32c8962",
|
|
386
386
|
"digestExcludes": []
|
|
387
387
|
},
|
|
388
388
|
{
|
|
@@ -395,7 +395,7 @@
|
|
|
395
395
|
"repository": "1aboveio/ai",
|
|
396
396
|
"revision": "main"
|
|
397
397
|
},
|
|
398
|
-
"contentDigest": "
|
|
398
|
+
"contentDigest": "f3fe342d6f8b18d287e847a42c64f508a77e82aeaea05591e574bd73dc0d6544",
|
|
399
399
|
"digestExcludes": []
|
|
400
400
|
},
|
|
401
401
|
{
|
|
@@ -408,7 +408,7 @@
|
|
|
408
408
|
"repository": "1aboveio/ai",
|
|
409
409
|
"revision": "main"
|
|
410
410
|
},
|
|
411
|
-
"contentDigest": "
|
|
411
|
+
"contentDigest": "d36db8e5305c2355c162bc7b6a359efaabce78deb87acc77018ebc924460d4db",
|
|
412
412
|
"digestExcludes": []
|
|
413
413
|
},
|
|
414
414
|
{
|
|
@@ -421,7 +421,7 @@
|
|
|
421
421
|
"repository": "1aboveio/ai",
|
|
422
422
|
"revision": "main"
|
|
423
423
|
},
|
|
424
|
-
"contentDigest": "
|
|
424
|
+
"contentDigest": "1e9cef5506ff70ca4a9495125badd3c906fc1c61aa7435022e7a9b31bb491df3",
|
|
425
425
|
"digestExcludes": []
|
|
426
426
|
},
|
|
427
427
|
{
|
|
@@ -434,7 +434,7 @@
|
|
|
434
434
|
"repository": "1aboveio/ai",
|
|
435
435
|
"revision": "main"
|
|
436
436
|
},
|
|
437
|
-
"contentDigest": "
|
|
437
|
+
"contentDigest": "53a323d1c5b8558ab78cbff853d627405088341477e8b03e4691489c735c8c2d",
|
|
438
438
|
"digestExcludes": []
|
|
439
439
|
},
|
|
440
440
|
{
|
|
@@ -447,7 +447,7 @@
|
|
|
447
447
|
"repository": "1aboveio/ai",
|
|
448
448
|
"revision": "main"
|
|
449
449
|
},
|
|
450
|
-
"contentDigest": "
|
|
450
|
+
"contentDigest": "d490bf9bf7793bb407ce17e1ff7a87052fc6480563754ce408f4ce3e87829e13",
|
|
451
451
|
"digestExcludes": []
|
|
452
452
|
},
|
|
453
453
|
{
|
|
@@ -460,7 +460,7 @@
|
|
|
460
460
|
"repository": "1aboveio/ai",
|
|
461
461
|
"revision": "main"
|
|
462
462
|
},
|
|
463
|
-
"contentDigest": "
|
|
463
|
+
"contentDigest": "f94b4375326223f14d67dcb41c1586d5de901e80ae5e94e9d558a69926bbba23",
|
|
464
464
|
"digestExcludes": []
|
|
465
465
|
},
|
|
466
466
|
{
|
|
@@ -473,7 +473,7 @@
|
|
|
473
473
|
"repository": "1aboveio/ai",
|
|
474
474
|
"revision": "main"
|
|
475
475
|
},
|
|
476
|
-
"contentDigest": "
|
|
476
|
+
"contentDigest": "4390f49714233fe929e4ee0892f17dadeb8fc742df8377e45fb32be01c289a79",
|
|
477
477
|
"digestExcludes": []
|
|
478
478
|
},
|
|
479
479
|
{
|
|
@@ -486,7 +486,7 @@
|
|
|
486
486
|
"repository": "1aboveio/ai",
|
|
487
487
|
"revision": "main"
|
|
488
488
|
},
|
|
489
|
-
"contentDigest": "
|
|
489
|
+
"contentDigest": "bf5b89eea487aee38233f618b7aba6bd487f21d4ae4700e515359b71cf2f18f3",
|
|
490
490
|
"digestExcludes": []
|
|
491
491
|
},
|
|
492
492
|
{
|
|
@@ -499,7 +499,7 @@
|
|
|
499
499
|
"repository": "1aboveio/ai",
|
|
500
500
|
"revision": "main"
|
|
501
501
|
},
|
|
502
|
-
"contentDigest": "
|
|
502
|
+
"contentDigest": "df4448e4093352de3bf00f259a47b901a1a33d6ad2283f3c486077dd8b4174dc",
|
|
503
503
|
"digestExcludes": []
|
|
504
504
|
},
|
|
505
505
|
{
|
|
@@ -512,13 +512,13 @@
|
|
|
512
512
|
"repository": "1aboveio/ai",
|
|
513
513
|
"revision": "main"
|
|
514
514
|
},
|
|
515
|
-
"contentDigest": "
|
|
515
|
+
"contentDigest": "6c391873e86e889a8f80fd095b75db1858c11067d07a58207d062ab504b9fa6a",
|
|
516
516
|
"digestExcludes": [
|
|
517
517
|
"coherence/workflow.json"
|
|
518
518
|
]
|
|
519
519
|
}
|
|
520
520
|
],
|
|
521
|
-
"releaseIdentity": "
|
|
521
|
+
"releaseIdentity": "492d371baa5970a01783a238bd2521f9815828016e89629594f599e8f7f93538",
|
|
522
522
|
"lifecycleAuthority": "native-skills-cli",
|
|
523
523
|
"repairRecipe": {
|
|
524
524
|
"id": "engineering-workflow-dependency-first",
|
|
@@ -2,7 +2,7 @@
|
|
|
2
2
|
name: ensure-coverage
|
|
3
3
|
description: "Define or audit behavior-first test criteria — ACs, required test levels, mock/integration/E2E policy — across three axes: breadth (Coverage Ledger), depth (over-mocking), presentation (perceivability of browser surfaces). NOT judging whether a single test is any good (test-quality), authoring browser tests (e2e-test), reviewing a PR (better-review), or delivering issues (resolve-issues)."
|
|
4
4
|
disable-model-invocation: true
|
|
5
|
-
release-version: 0.50.
|
|
5
|
+
release-version: 0.50.11
|
|
6
6
|
---
|
|
7
7
|
**Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
|
|
8
8
|
# Ensure Coverage
|
|
@@ -3,7 +3,7 @@ name: golden-path
|
|
|
3
3
|
description: "Golden-path E2E: the short list of user journeys whose failure blocks a release, kept in a repo as one contract (golden-paths.json) with a generated GOLDEN_PATHS.md and a generated GitHub Actions workflow, and run against a local build or a deployed URL for an ALIVE/DEAD verdict. Use to set golden paths up in a repo ('init golden paths', 'add golden-path CI'), to migrate an older smoke.manifest.json or a hand-built smoke setup ('audit', 'migrate smoke'), to add, change, or remove a golden path, to ask 'is the build alive?' or run them before a PR or release, or when a change touches a flow listed in GOLDEN_PATHS.md. NOT for writing the Playwright specs themselves (e2e-test), deciding what a change must prove (ensure-coverage), or general workflow YAML (github-actions)."
|
|
4
4
|
dependencies:
|
|
5
5
|
- e2e-test
|
|
6
|
-
release-version: 0.50.
|
|
6
|
+
release-version: 0.50.11
|
|
7
7
|
---
|
|
8
8
|
**Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
|
|
9
9
|
# Golden path
|
|
@@ -3,7 +3,7 @@ name: harness-runtime
|
|
|
3
3
|
description: Internal import-only library shared by first-party engineering packages. Not a workflow skill; never select or invoke it as a user capability.
|
|
4
4
|
disable-model-invocation: true
|
|
5
5
|
user-invocable: false
|
|
6
|
-
release-version: 0.50.
|
|
6
|
+
release-version: 0.50.11
|
|
7
7
|
---
|
|
8
8
|
**Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
|
|
9
9
|
# Harness Runtime
|
|
@@ -4,7 +4,7 @@ description: "Slash/explicit-only (/resolve-release). Full GitHub Flow release f
|
|
|
4
4
|
disable-model-invocation: true
|
|
5
5
|
metadata:
|
|
6
6
|
workflow-role: coordinator
|
|
7
|
-
release-version: 0.50.
|
|
7
|
+
release-version: 0.50.11
|
|
8
8
|
---
|
|
9
9
|
**Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
|
|
10
10
|
# Resolve release
|
|
@@ -117,7 +117,7 @@ The planner is read-only, apart from its stdout. It proves from real git objects
|
|
|
117
117
|
|
|
118
118
|
- the declared GitHub `origin` identity matches `repository` (canonical HTTPS,
|
|
119
119
|
SCP-style SSH or `ssh://git@github.com/` URL);
|
|
120
|
-
- the original single-parent cut changes only
|
|
120
|
+
- the original single-parent cut changes only supported version identities and
|
|
121
121
|
`CHANGELOG.md`, with no package scripts, dependency, lock dependency or other
|
|
122
122
|
non-version edits hidden in identity files;
|
|
123
123
|
- the cut is an ancestor of its merge and their whole trees are equal;
|
|
@@ -168,7 +168,21 @@ values, nonfinite numbers, integers outside the lossless JSON range and exceeded
|
|
|
168
168
|
bounds all refuse with sanitized acquisition/parser errors. No Python is invoked
|
|
169
169
|
for npm-only reuse, and normal create-cut planning and application are unchanged.
|
|
170
170
|
|
|
171
|
-
Identity files must be regular non-executable files.
|
|
171
|
+
Identity files must be regular non-executable files. Cloud Run RC reuse also supports
|
|
172
|
+
a coordinated shared-version pnpm workspace cut: root `pnpm-workspace.yaml` declares
|
|
173
|
+
the tracked member manifests, and every root/member version moves from one shared
|
|
174
|
+
parent version to the requested version. Literal package directories, `*`, `?`,
|
|
175
|
+
whole-segment `**` and `!` exclusions are supported; other pattern syntax and
|
|
176
|
+
positive patterns without tracked manifests refuse. The workspace declaration stays
|
|
177
|
+
byte-identical from parent through target, with the same manifest paths, package
|
|
178
|
+
names and `private` field presence/value. Every manifest must remain regular and
|
|
179
|
+
non-executable. The historical cut compares all JSON fields structurally with only
|
|
180
|
+
`version` removed; scripts, dependencies and all other fields must stay unchanged.
|
|
181
|
+
Undeclared changed manifests and rename pre-images remain outside the metadata cut.
|
|
182
|
+
Reviewed dependency changes after the cut remain allowed. This extension applies
|
|
183
|
+
only when a Cloud Run cut needs workspace manifests; root-only checks are unchanged.
|
|
184
|
+
Artifact-only, pre-tag npm and independently versioned workspace release routes gain
|
|
185
|
+
no new reuse capability.
|
|
172
186
|
Distribution-aware cuts (`skills/distribution/manifest.json`) have a wider
|
|
173
187
|
generated metadata surface and refuse reuse until a dedicated verifier exists;
|
|
174
188
|
normal distribution cuts are unchanged. `--dark-flags` refuses in reuse mode:
|
|
@@ -11,6 +11,7 @@ import { join } from 'node:path'
|
|
|
11
11
|
import { spawnSync } from 'node:child_process'
|
|
12
12
|
import { isDeepStrictEqual } from 'node:util'
|
|
13
13
|
import { isMainModule } from '../../engineering-runtime/scripts/main-module.mjs'
|
|
14
|
+
import { parseYamlMapping } from '../../engineering-runtime/scripts/yaml-mapping.mjs'
|
|
14
15
|
|
|
15
16
|
const PLAN_USAGE = 'plan.mjs --sha <sha> [--trunk main] [--json] [--strict] [--cloud-run] [--dark-flags <list.json>] [--prepared-metadata <file>]'
|
|
16
17
|
const SEMVER_RE = /^v?(\d+)\.(\d+)\.(\d+)$/
|
|
@@ -532,7 +533,71 @@ function identityWithoutVersion(text, path, python, npm = null) {
|
|
|
532
533
|
return json
|
|
533
534
|
}
|
|
534
535
|
|
|
535
|
-
|
|
536
|
+
// Deliberately support only literal paths, *, ?, and whole-segment **. Refuse
|
|
537
|
+
// other glob syntax rather than interpreting a pnpm declaration differently.
|
|
538
|
+
function workspacePattern(pattern) {
|
|
539
|
+
requirePrepared(typeof pattern === 'string' && pattern.length > 0, 'workspace patterns must be nonempty strings')
|
|
540
|
+
const exclude = pattern.startsWith('!')
|
|
541
|
+
const path = exclude ? pattern.slice(1) : pattern
|
|
542
|
+
requirePrepared(path === '.' || (path.split('/').every((part) => part && part !== '.' && part !== '..'
|
|
543
|
+
&& /^[A-Za-z0-9_@.*?-]+$/.test(part) && (!part.includes('**') || part === '**'))
|
|
544
|
+
&& !path.startsWith('/')), 'unsupported workspace package pattern')
|
|
545
|
+
const segments = path.split('/').map((part) => part === '**' ? '(?:[^/]+/)*'
|
|
546
|
+
: `${part.replace(/[.+]/g, '\\$&').replace(/\*/g, '[^/]*').replace(/\?/g, '[^/]')}/`)
|
|
547
|
+
return { exclude, path, match: new RegExp(`^${segments.join('')}$`) }
|
|
548
|
+
}
|
|
549
|
+
|
|
550
|
+
function preparedWorkspaceAt(sha, version, cwd) {
|
|
551
|
+
requireRegularFile(sha, 'pnpm-workspace.yaml', cwd)
|
|
552
|
+
const bytes = preparedBlobAt(sha, 'pnpm-workspace.yaml', cwd)
|
|
553
|
+
let declaration
|
|
554
|
+
try {
|
|
555
|
+
declaration = parseYamlMapping(new TextDecoder('utf-8', { fatal: true }).decode(bytes), 'pnpm-workspace.yaml')
|
|
556
|
+
} catch {
|
|
557
|
+
requirePrepared(false, 'pnpm-workspace.yaml inspection failed')
|
|
558
|
+
}
|
|
559
|
+
requirePrepared(Array.isArray(declaration.packages) && declaration.packages.length > 0, 'workspace packages must be a nonempty array')
|
|
560
|
+
const patterns = declaration.packages.map(workspacePattern)
|
|
561
|
+
requirePrepared(patterns.some((pattern) => !pattern.exclude), 'workspace needs a positive package pattern')
|
|
562
|
+
// Read only tracked Git paths, including nonregular entries so symlinks cannot
|
|
563
|
+
// silently disappear from expansion. NUL framing preserves arbitrary paths.
|
|
564
|
+
const tracked = git(['ls-tree', '-r', '--name-only', '-z', sha], cwd).split('\0').filter(Boolean)
|
|
565
|
+
const candidates = tracked.filter((path) => path.endsWith('/package.json'))
|
|
566
|
+
const matches = (pattern, path) => pattern.path === '.' ? path === 'package.json'
|
|
567
|
+
: pattern.match.test(`${path.slice(0, -'/package.json'.length)}/`)
|
|
568
|
+
for (const pattern of patterns.filter((item) => !item.exclude)) {
|
|
569
|
+
requirePrepared(pattern.path === '.' || candidates.some((path) => matches(pattern, path)), 'workspace pattern has no tracked package manifest')
|
|
570
|
+
}
|
|
571
|
+
const files = ['package.json', ...candidates.filter((path) => patterns.some((p) => !p.exclude && matches(p, path))
|
|
572
|
+
&& !patterns.some((p) => p.exclude && matches(p, path)))].sort()
|
|
573
|
+
requirePrepared(files.length > 1, 'shared-version workspace requires a tracked member')
|
|
574
|
+
const identities = new Map()
|
|
575
|
+
const names = new Set()
|
|
576
|
+
for (const path of files) {
|
|
577
|
+
requireRegularFile(sha, path, cwd)
|
|
578
|
+
const parsed = preparedJsonAt(sha, path, cwd)
|
|
579
|
+
const pkg = parsed.data
|
|
580
|
+
requirePrepared(typeof pkg.name === 'string' && pkg.name.trim().length > 0 && !names.has(pkg.name), 'workspace package names must be nonempty and unique')
|
|
581
|
+
names.add(pkg.name)
|
|
582
|
+
requireSafePreparedVersion(pkg.version, path)
|
|
583
|
+
version ??= pkg.version
|
|
584
|
+
requirePrepared(pkg.version === version, `workspace ${path} version must match shared version ${version}`)
|
|
585
|
+
identities.set(path, parsed)
|
|
586
|
+
}
|
|
587
|
+
return { bytes, files, identities, version }
|
|
588
|
+
}
|
|
589
|
+
|
|
590
|
+
function requireSameWorkspace(left, right) {
|
|
591
|
+
requirePrepared(left.bytes.equals(right.bytes) && isDeepStrictEqual(left.files, right.files), 'workspace topology changed after preparation')
|
|
592
|
+
for (const path of left.files) {
|
|
593
|
+
const oldPkg = left.identities.get(path).data
|
|
594
|
+
const newPkg = right.identities.get(path).data
|
|
595
|
+
requirePrepared(oldPkg.name === newPkg.name && Object.hasOwn(oldPkg, 'private') === Object.hasOwn(newPkg, 'private')
|
|
596
|
+
&& isDeepStrictEqual(oldPkg.private, newPkg.private), `workspace package identity changed: ${path}`)
|
|
597
|
+
}
|
|
598
|
+
}
|
|
599
|
+
|
|
600
|
+
function verifyMetadataOnlyCut(input, files, cwd, preTag = false, workspace = null) {
|
|
536
601
|
const { cutSha, version } = input
|
|
537
602
|
const parents = git(['rev-list', '--parents', '-n', '1', cutSha], cwd).trim().split(' ')
|
|
538
603
|
requirePrepared(parents.length === 2, 'metadata-only cut must have exactly one parent')
|
|
@@ -552,8 +617,19 @@ function verifyMetadataOnlyCut(input, files, cwd, preTag = false) {
|
|
|
552
617
|
? versionFromGitFiles(parent, files, cwd)
|
|
553
618
|
: previousPython?.project.version ?? versionFromGitFiles(parent, files, cwd)
|
|
554
619
|
requirePrepared(previousVersion !== version, 'metadata-only cut did not prepare a new version')
|
|
620
|
+
if (workspace) {
|
|
621
|
+
const previousWorkspace = preparedWorkspaceAt(parent, previousVersion, cwd)
|
|
622
|
+
requireSameWorkspace(previousWorkspace, workspace)
|
|
623
|
+
for (const path of workspace.files) {
|
|
624
|
+
const oldIdentity = structuredClone(previousWorkspace.identities.get(path).canonical)
|
|
625
|
+
const newIdentity = structuredClone(workspace.identities.get(path).canonical)
|
|
626
|
+
delete oldIdentity[1].version
|
|
627
|
+
delete newIdentity[1].version
|
|
628
|
+
requirePrepared(isDeepStrictEqual(oldIdentity, newIdentity), `original cut is not metadata-only: ${path} changes more than version identity`)
|
|
629
|
+
}
|
|
630
|
+
}
|
|
555
631
|
const changed = git(['diff', '--no-renames', '--name-only', '-z', parent, cutSha], cwd).split('\0').filter(Boolean)
|
|
556
|
-
requirePrepared(changed.includes('CHANGELOG.md') && changed.every((path) => path === 'CHANGELOG.md' || files.includes(path)), 'original cut is not metadata-only')
|
|
632
|
+
requirePrepared(changed.includes('CHANGELOG.md') && changed.every((path) => path === 'CHANGELOG.md' || files.includes(path) || workspace?.files.includes(path)), 'original cut is not metadata-only')
|
|
557
633
|
for (const path of files) {
|
|
558
634
|
const structured = path === 'pyproject.toml' || path === 'uv.lock'
|
|
559
635
|
|| (preTag && ['package.json', 'package-lock.json'].includes(path))
|
|
@@ -602,10 +678,23 @@ function planPreparedRelease({ sha, trunk, cloudRun, darkFlags, preparedMetadata
|
|
|
602
678
|
}
|
|
603
679
|
requirePrepared(git(['rev-parse', `${input.cutSha}^{tree}`], cwd) === git(['rev-parse', `${input.mergeSha}^{tree}`], cwd), 'cut and merge trees must be equal')
|
|
604
680
|
const files = preparedVersionFilesAt(input.cutSha, cwd)
|
|
681
|
+
const hasWorkspace = (commit) => Boolean(git(['ls-tree', commit, '--', 'pnpm-workspace.yaml'], cwd).trim())
|
|
682
|
+
const workspaceCut = hasWorkspace(input.cutSha)
|
|
683
|
+
// This capability is only for shared-version Cloud Run retries, never the
|
|
684
|
+
// independent-package dispatcher or the pre-tag npm publication route.
|
|
685
|
+
const needsWorkspace = workspaceCut && !preTag && cloudRun
|
|
686
|
+
&& git(['diff', '--no-renames', '--name-only', '-z', `${input.cutSha}^`, input.cutSha], cwd).split('\0')
|
|
687
|
+
.some((path) => path && path !== 'CHANGELOG.md' && !files.includes(path))
|
|
688
|
+
const workspace = needsWorkspace
|
|
689
|
+
? preparedWorkspaceAt(input.cutSha, input.version, cwd) : null
|
|
605
690
|
const pythonIdentities = []
|
|
606
691
|
let preparedPackageName
|
|
607
692
|
for (const commit of [input.cutSha, ...(preTag ? [previous.sourceSha] : []), sha]) {
|
|
608
693
|
requirePrepared(JSON.stringify(preparedVersionFilesAt(commit, cwd)) === JSON.stringify(files), 'root version file set changed after preparation')
|
|
694
|
+
if (workspace) {
|
|
695
|
+
requirePrepared(hasWorkspace(commit), 'workspace topology changed after preparation')
|
|
696
|
+
requireSameWorkspace(workspace, preparedWorkspaceAt(commit, input.version, cwd))
|
|
697
|
+
}
|
|
609
698
|
const npm = preTag ? preparedNpmAt(commit, files, input.version, cwd) : null
|
|
610
699
|
if (npm) {
|
|
611
700
|
preparedPackageName ??= npm.pkg.name
|
|
@@ -619,7 +708,7 @@ function planPreparedRelease({ sha, trunk, cloudRun, darkFlags, preparedMetadata
|
|
|
619
708
|
requirePrepared(targetPython.project.name === cutPython.project.name, 'pyproject.toml target project name differs from prepared identity')
|
|
620
709
|
requirePrepared(isDeepStrictEqual(targetPython.rootSource, cutPython.rootSource), 'uv.lock target root source mode differs from prepared identity')
|
|
621
710
|
}
|
|
622
|
-
verifyMetadataOnlyCut(input, files, cwd, preTag)
|
|
711
|
+
verifyMetadataOnlyCut(input, files, cwd, preTag, workspace)
|
|
623
712
|
const original = releaseSection(input.cutSha, input.version, cwd)
|
|
624
713
|
const prepared = releaseSection(sha, input.version, cwd)
|
|
625
714
|
const tag = `v${input.version}`
|
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: test-quality
|
|
3
3
|
description: "Seven principles for tests that catch real bugs, and an audit that reports weak, redundant, and not-coverage tests without fixing them. Use when writing, changing, or reviewing tests, or when asked whether tests are useful, redundant, over-mocked, flaky, only assert static text, or test config files, or asked to make a slow test suite faster without losing coverage, or when the user asks to write the testing conventions into a repo's CONTRIBUTING.md. NOT defining what a spec must prove (ensure-coverage) or authoring browser tests (e2e-test)."
|
|
4
|
-
release-version: 0.50.
|
|
4
|
+
release-version: 0.50.11
|
|
5
5
|
---
|
|
6
6
|
**Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
|
|
7
7
|
# Test Quality
|