@1aboveio/engineering-skills 0.1.17 → 0.1.18

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@1aboveio/engineering-skills",
3
- "version": "0.1.17",
3
+ "version": "0.1.18",
4
4
  "description": "Issue-to-PR and release orchestrators, review, coverage, golden paths and test quality.",
5
5
  "license": "MIT",
6
6
  "repository": {
@@ -27,7 +27,7 @@
27
27
  "id": "engineering",
28
28
  "core": "@1aboveio/core-skills",
29
29
  "coreSkills": [],
30
- "digest": "eae585fe9a49dc577ca68ba48e060176008f7a2a6cd0e1f48e1b9f60fd12072d"
30
+ "digest": "e5f4a3a821b2585ee5afdebed3ba737fc96365b1eb0727b5b98b607486f26a6d"
31
31
  },
32
32
  "publishConfig": {
33
33
  "registry": "https://registry.npmjs.org/",
@@ -4,7 +4,7 @@ description: "Slash/explicit-only (/better-review). Single-agent adversarial rev
4
4
  disable-model-invocation: true
5
5
  dependencies:
6
6
  - engineering-runtime
7
- release-version: 0.48.1
7
+ release-version: 0.49.0
8
8
  ---
9
9
  **Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
10
10
  # Better Review
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  name: e2e-test
3
3
  description: "Playwright end-to-end guidance for affected browser journeys, render health and presentation checks, with route manifests and sweeps for broader audits. Use when browser routes or user flows ship or change, or a Playwright test flakes. NOT for non-browser tests, defining what to test (ensure-coverage), the curated ALIVE/DEAD golden-path gate (golden-path), or CI workflow YAML (github-actions)."
4
- release-version: 0.48.1
4
+ release-version: 0.49.0
5
5
  ---
6
6
  **Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
7
7
  # E2E Testing Standard
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  name: engineering
3
3
  description: "Engineering conventions: feature-delivery priorities, focused verification and review, operational boundaries, and tracker routing. Standalone /engineering offers Global, Project, or Session setup and targeted resets for configured scopes; /engineering init keeps explicit project setup. Use when setting up AGENTS.md or CONTRIBUTING.md, saving or resetting engineering defaults, or before creating an engineering issue, spec, epic, ticket, or sub-issue on GitHub or Linear. Reads existing policy without writing during ordinary work. NOT the issue-to-PR workflow (resolve-issues), release execution (resolve-release), Git delivery (github-flow), or CI setup (github-actions)."
4
- release-version: 0.48.1
4
+ release-version: 0.49.0
5
5
  ---
6
6
  **Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
7
7
  # Engineering
@@ -3,7 +3,7 @@ name: engineering-runtime
3
3
  description: Internal support package for shared Engineering Workflow executable behavior. Never select or invoke this package as a user capability.
4
4
  disable-model-invocation: true
5
5
  user-invocable: false
6
- release-version: 0.48.1
6
+ release-version: 0.49.0
7
7
  ---
8
8
  **Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
9
9
  # Engineering Runtime
@@ -369,7 +369,7 @@
369
369
  "repository": "1aboveio/ai",
370
370
  "revision": "main"
371
371
  },
372
- "contentDigest": "0ee641d7c1c90df5d1ca4d4f516f3aec0236ae224f2cfdf5e69a8d0023d0224f",
372
+ "contentDigest": "65d5a8011e64fb3a49cb45bf8fdb066d21138faed67287421bcd17f10b0c7bc0",
373
373
  "digestExcludes": []
374
374
  },
375
375
  {
@@ -382,7 +382,7 @@
382
382
  "repository": "1aboveio/ai",
383
383
  "revision": "main"
384
384
  },
385
- "contentDigest": "b0c6b061b9d99a3fdf61ee41a3380986f8b0e6f687fc14158071ba5cfc4ad231",
385
+ "contentDigest": "b554ced1c8af517ed49ad3a0c6c2d2f5b2f74bb6e1313b7e56e00177e30bae7c",
386
386
  "digestExcludes": []
387
387
  },
388
388
  {
@@ -395,7 +395,7 @@
395
395
  "repository": "1aboveio/ai",
396
396
  "revision": "main"
397
397
  },
398
- "contentDigest": "00afe10ecfc7fb382a3c9ddf7cfb1264eeeb003e935c3fd8eee09af7f0e6dc4c",
398
+ "contentDigest": "8e35a14aea5d7e7b4830f7817438ce6a6eb7c5a6e9c31768aa76c4328e181115",
399
399
  "digestExcludes": []
400
400
  },
401
401
  {
@@ -408,7 +408,7 @@
408
408
  "repository": "1aboveio/ai",
409
409
  "revision": "main"
410
410
  },
411
- "contentDigest": "807efefc218519809541349ebc10358d37c5688d5d657fe2a58dc85e2a9aa055",
411
+ "contentDigest": "38150518fe71cd567eeee1c76cec15bcd4b0cd5cde9ef6f90748e462807b8b9f",
412
412
  "digestExcludes": []
413
413
  },
414
414
  {
@@ -421,7 +421,7 @@
421
421
  "repository": "1aboveio/ai",
422
422
  "revision": "main"
423
423
  },
424
- "contentDigest": "efb97f0e66dec6c2d6894a1feb128892f6974d9aa71c83a29acabf22852f2228",
424
+ "contentDigest": "a53c1f2212fd38fc464ea2b86ce5ed37f61052fc884a4873308bd158b33ee174",
425
425
  "digestExcludes": []
426
426
  },
427
427
  {
@@ -434,7 +434,7 @@
434
434
  "repository": "1aboveio/ai",
435
435
  "revision": "main"
436
436
  },
437
- "contentDigest": "a54c0d8d50bd9de11b98118072a87f1fefb1930e4936eae4ad1c8d369125e80b",
437
+ "contentDigest": "cc5d24bb0952a4c67bed48bc154fd3ef4115bd3162459411b0a71e48251fe342",
438
438
  "digestExcludes": []
439
439
  },
440
440
  {
@@ -447,7 +447,7 @@
447
447
  "repository": "1aboveio/ai",
448
448
  "revision": "main"
449
449
  },
450
- "contentDigest": "2700f926acbfc82dec992a81f42373f5ac03d8e6cdfd9288e447e72e4215ca11",
450
+ "contentDigest": "3579deef1765207f521b231bd1d21795c791f773f44c634830b0a301c42998f9",
451
451
  "digestExcludes": []
452
452
  },
453
453
  {
@@ -460,7 +460,7 @@
460
460
  "repository": "1aboveio/ai",
461
461
  "revision": "main"
462
462
  },
463
- "contentDigest": "a00c2848f686ee2d4775661f87c2569b4810480233f4a0649ca995f0bebdb2a8",
463
+ "contentDigest": "be5333b8c2dcd229e7caa395274a5e7695dc301a7ad855122d881d73cb99911d",
464
464
  "digestExcludes": []
465
465
  },
466
466
  {
@@ -473,7 +473,7 @@
473
473
  "repository": "1aboveio/ai",
474
474
  "revision": "main"
475
475
  },
476
- "contentDigest": "27b87c7ac54bfc217ffe5c68fae0a9d9b1dd8619286c470ca721200bb6962bd8",
476
+ "contentDigest": "36bd7b643df2a9217b297f5da084cfd9113f0d578a56721cb302b92f8b9f1aad",
477
477
  "digestExcludes": []
478
478
  },
479
479
  {
@@ -486,7 +486,7 @@
486
486
  "repository": "1aboveio/ai",
487
487
  "revision": "main"
488
488
  },
489
- "contentDigest": "a67d55dda1c9278b16d192efe28d2827d2a1010b7c14bde8bf3ac10ce78adf13",
489
+ "contentDigest": "6fe762cf05a852f4c52007106e29f606e8c716a29510f7c1d4abc3ec59b96442",
490
490
  "digestExcludes": []
491
491
  },
492
492
  {
@@ -499,7 +499,7 @@
499
499
  "repository": "1aboveio/ai",
500
500
  "revision": "main"
501
501
  },
502
- "contentDigest": "15626fe123fbf537b89af3cb34349430fc1c76c4ad04e8853f6e761c7f45db30",
502
+ "contentDigest": "f7286a2fe3a4f1c0d233f25fff89f5a46bb0e932d1b6f07b857b5b3e3a398d54",
503
503
  "digestExcludes": []
504
504
  },
505
505
  {
@@ -512,13 +512,13 @@
512
512
  "repository": "1aboveio/ai",
513
513
  "revision": "main"
514
514
  },
515
- "contentDigest": "1bdafd5f8149b4020319869ae83c17734cec9c2c52f7dc28d5c672985ca73111",
515
+ "contentDigest": "35d54af1d31fb8e0bd0e80929e807be0f8d4a342882897ba1e9bdc396e4e0db6",
516
516
  "digestExcludes": [
517
517
  "coherence/workflow.json"
518
518
  ]
519
519
  }
520
520
  ],
521
- "releaseIdentity": "446559a9feac423ab3c67e5b391ea300aeb1e5a80ec94a66a69062025e47a87a",
521
+ "releaseIdentity": "ea12741260694df094ae6fda1597a15df1e8f31a6db2069e38b8bc1cf13083f2",
522
522
  "lifecycleAuthority": "native-skills-cli",
523
523
  "repairRecipe": {
524
524
  "id": "engineering-workflow-dependency-first",
@@ -2,7 +2,7 @@
2
2
  name: ensure-coverage
3
3
  description: "Define or audit behavior-first test criteria — ACs, required test levels, mock/integration/E2E policy — across three axes: breadth (Coverage Ledger), depth (over-mocking), presentation (perceivability of browser surfaces). NOT judging whether a single test is any good (test-quality), authoring browser tests (e2e-test), reviewing a PR (better-review), or delivering issues (resolve-issues)."
4
4
  disable-model-invocation: true
5
- release-version: 0.48.1
5
+ release-version: 0.49.0
6
6
  ---
7
7
  **Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
8
8
  # Ensure Coverage
@@ -3,7 +3,7 @@ name: golden-path
3
3
  description: "Golden-path E2E: the short list of user journeys whose failure blocks a release, kept in a repo as one contract (golden-paths.json) with a generated GOLDEN_PATHS.md and a generated GitHub Actions workflow, and run against a local build or a deployed URL for an ALIVE/DEAD verdict. Use to set golden paths up in a repo ('init golden paths', 'add golden-path CI'), to migrate an older smoke.manifest.json or a hand-built smoke setup ('audit', 'migrate smoke'), to add, change, or remove a golden path, to ask 'is the build alive?' or run them before a PR or release, or when a change touches a flow listed in GOLDEN_PATHS.md. NOT for writing the Playwright specs themselves (e2e-test), deciding what a change must prove (ensure-coverage), or general workflow YAML (github-actions)."
4
4
  dependencies:
5
5
  - e2e-test
6
- release-version: 0.48.1
6
+ release-version: 0.49.0
7
7
  ---
8
8
  **Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
9
9
  # Golden path
@@ -3,7 +3,7 @@ name: harness-runtime
3
3
  description: Internal import-only library shared by first-party engineering packages. Not a workflow skill; never select or invoke it as a user capability.
4
4
  disable-model-invocation: true
5
5
  user-invocable: false
6
- release-version: 0.48.1
6
+ release-version: 0.49.0
7
7
  ---
8
8
  **Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
9
9
  # Harness Runtime
@@ -36,7 +36,8 @@
36
36
  // PI_AGENT_CATALOG_COMMAND JSON argv array: '["node","/abs/agent-catalog.mjs"]'
37
37
  // (preferred when arguments are needed), or a bare
38
38
  // executable token: 'pi-agent-catalog'.
39
- // default pi-agent-catalog on PATH.
39
+ // default pi-agent-catalog on PATH, then (Pi only) the
40
+ // catalog in Pi's installed npm packages on ENOENT.
40
41
  // A bare token cannot carry arguments — that is deliberate, so no quoting rule
41
42
  // sneaks shell semantics in. Nothing here runs npm/npx, resolves a sibling
42
43
  // checkout, or reads a registry.
@@ -48,8 +49,9 @@
48
49
  // install (`~/.agents/skills/{resolve-issues,harness-runtime}`). No path in this
49
50
  // file is relative to a source-domain layout.
50
51
  import { spawnSync } from 'node:child_process'
51
- import { readFileSync } from 'node:fs'
52
- import { resolve as resolvePath } from 'node:path'
52
+ import { readFileSync, statSync } from 'node:fs'
53
+ import { homedir } from 'node:os'
54
+ import { join, resolve as resolvePath } from 'node:path'
53
55
 
54
56
  export const AGENT_CATALOG_PROTOCOL_VERSION = 1
55
57
  export const DEFAULT_AGENT_CATALOG_COMMAND = 'pi-agent-catalog'
@@ -210,6 +212,27 @@ export function resolveCatalogCommand(env = process.env) {
210
212
  return parseCommandSpec(spec)
211
213
  }
212
214
 
215
+ function installedPiCatalogCommand(request, env) {
216
+ if (request.harness !== 'pi' || env?.[AGENT_CATALOG_COMMAND_ENV]?.trim()) return null
217
+ const configuredRoot = request.userRoot || env?.PI_CODING_AGENT_DIR || join(homedir(), '.pi', 'agent')
218
+ const root = configuredRoot === '~' ? homedir()
219
+ : configuredRoot.startsWith('~/') ? join(homedir(), configuredRoot.slice(2)) : configuredRoot
220
+ for (const entry of [
221
+ ['pi-better-harness', 'bin', 'pi-agent-catalog.mjs'],
222
+ ['pi-better-subagents', 'agent-catalog.mjs'],
223
+ ]) {
224
+ const script = resolvePath(root, 'npm', 'node_modules', ...entry)
225
+ try {
226
+ if (statSync(script).isFile()) {
227
+ return { executable: process.execPath, args: [script], source: 'pi-installed' }
228
+ }
229
+ } catch (error) {
230
+ if (error.code !== 'ENOENT' && error.code !== 'ENOTDIR') throw error
231
+ }
232
+ }
233
+ return null
234
+ }
235
+
213
236
  function normalizeAvailable(value, label = 'available') {
214
237
  if (value === undefined) return { ok: true, available: [] }
215
238
  if (!Array.isArray(value)) {
@@ -864,17 +887,27 @@ export function resolveAgentCatalog({
864
887
  }
865
888
  const commandResult = resolveCatalogCommand(env)
866
889
  if (!commandResult.ok) return commandResult
867
- const { command } = commandResult
890
+ let { command } = commandResult
891
+ const invoke = () => runner({
892
+ executable: command.executable,
893
+ args: command.args,
894
+ input: `${JSON.stringify(request)}\n`,
895
+ timeoutMs,
896
+ env,
897
+ })
868
898
 
869
899
  let run
870
900
  try {
871
- run = runner({
872
- executable: command.executable,
873
- args: command.args,
874
- input: `${JSON.stringify(request)}\n`,
875
- timeoutMs,
876
- env,
877
- })
901
+ run = invoke()
902
+ // Only a missing default command permits installed-package lookup. An
903
+ // explicit choice or a resolver that ran and failed stays authoritative.
904
+ if (run?.error?.code === 'ENOENT') {
905
+ const installed = installedPiCatalogCommand(request, env)
906
+ if (installed) {
907
+ command = installed
908
+ run = invoke()
909
+ }
910
+ }
878
911
  } catch (error) {
879
912
  return blocked(
880
913
  AGENT_CATALOG_BLOCK_CODES.COMMAND_UNAVAILABLE,
@@ -14,4 +14,4 @@ When no supported native question tool is advertised, concise free-text input is
14
14
 
15
15
  Model discovery and catalog persistence remain separate from question planning. Current-turn tool availability is never inferred from model or harness configuration. Source-tree imports outside `skills/engineering` are unsupported until an installation-aware adapter entrypoint exists; consumers must not copy the runtime to work around that boundary.
16
16
 
17
- `agent-catalog.mjs` is the consumer bridge to the harness-owned agent catalog: one versioned JSON request on stdin (`version`, `harness`, `cwd`, `available`, `foregroundModel`, `fallbackToForeground`, `launchCapabilities`, `hostPreferences`, `overrides`, `tiers`, …) and one JSON response on stdout with four worker slots. It resolves the resolver command from `PI_AGENT_CATALOG_COMMAND` (a JSON argv array, or one bare executable token) or defaults to `pi-agent-catalog` on PATH, runs it with no shell, bounds its output and runtime, and validates the response. Those host fields are validated and forwarded unchanged — nothing is inferred or completed here, so an unstated launch control or tier stays unstated. A missing, broken, or declining resolver is a reported block; the bridge never falls back to a skill-owned model ladder and never installs anything. `discover-models.mjs` and `model-catalog.mjs` remain for consumers that still import them and are no longer part of model-slot selection.
17
+ `agent-catalog.mjs` is the consumer bridge to the harness-owned agent catalog: one versioned JSON request on stdin (`version`, `harness`, `cwd`, `available`, `foregroundModel`, `fallbackToForeground`, `launchCapabilities`, `hostPreferences`, `overrides`, `tiers`, …) and one JSON response on stdout with four worker slots. It resolves the resolver command from `PI_AGENT_CATALOG_COMMAND` (a JSON argv array, or one bare executable token) or defaults to `pi-agent-catalog` on PATH. For Pi only, when that default command is missing (`ENOENT`), it checks the installed `pi-better-harness` then standalone `pi-better-subagents` catalog under `<agent-dir>/npm/node_modules` and invokes the first installed entrypoint through the current Node executable. The agent directory is the request's `userRoot`, then `PI_CODING_AGENT_DIR`, then `~/.pi/agent`. Explicit commands and resolvers that execute but fail remain authoritative; there is no project-checkout search or second resolver after a catalog failure. The bridge runs with no shell, bounds its output and runtime, and validates the response. Those host fields are validated and forwarded unchanged — nothing is inferred or completed here, so an unstated launch control or tier stays unstated. A missing, broken, or declining resolver is a reported block; the bridge never falls back to a skill-owned model ladder and never installs anything. `discover-models.mjs` and `model-catalog.mjs` remain for consumers that still import them and are no longer part of model-slot selection.
@@ -8,7 +8,7 @@ dependencies:
8
8
  - better-review
9
9
  - golden-path
10
10
  - harness-runtime
11
- release-version: 0.48.1
11
+ release-version: 0.49.0
12
12
  ---
13
13
  **Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
14
14
  # Resolve issues
@@ -4,7 +4,7 @@ description: "Slash/explicit-only (/resolve-release). Full GitHub Flow release f
4
4
  disable-model-invocation: true
5
5
  metadata:
6
6
  workflow-role: coordinator
7
- release-version: 0.48.1
7
+ release-version: 0.49.0
8
8
  ---
9
9
  **Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
10
10
  # Resolve release
@@ -6,7 +6,7 @@ metadata:
6
6
  workflow-role: coordinator
7
7
  dependencies:
8
8
  - resolve-issues
9
- release-version: 0.48.1
9
+ release-version: 0.49.0
10
10
  ---
11
11
  **Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
12
12
  # Rush issues (shortcut of resolve-issues)
@@ -6,7 +6,7 @@ metadata:
6
6
  workflow-role: coordinator
7
7
  dependencies:
8
8
  - resolve-release
9
- release-version: 0.48.1
9
+ release-version: 0.49.0
10
10
  ---
11
11
  **Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
12
12
  # Rush release (shortcut of resolve-release)
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  name: test-quality
3
3
  description: "Seven principles for tests that catch real bugs, and an audit that reports weak, redundant, and not-coverage tests without fixing them. Use when writing, changing, or reviewing tests, or when asked whether tests are useful, redundant, over-mocked, flaky, only assert static text, or test config files, or asked to make a slow test suite faster without losing coverage, or when the user asks to write the testing conventions into a repo's CONTRIBUTING.md. NOT defining what a spec must prove (ensure-coverage) or authoring browser tests (e2e-test)."
4
- release-version: 0.48.1
4
+ release-version: 0.49.0
5
5
  ---
6
6
  **Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
7
7
  # Test Quality