@1aboveio/engineering-skills 0.1.15 → 0.1.17

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (32) hide show
  1. package/package.json +2 -2
  2. package/skills/better-review/SKILL.md +1 -1
  3. package/skills/e2e-test/SKILL.md +1 -1
  4. package/skills/engineering/SKILL.md +1 -1
  5. package/skills/engineering-runtime/SKILL.md +1 -1
  6. package/skills/engineering-runtime/coherence/workflow.json +13 -13
  7. package/skills/ensure-coverage/SKILL.md +1 -1
  8. package/skills/golden-path/SKILL.md +1 -1
  9. package/skills/harness-runtime/SKILL.md +4 -3
  10. package/skills/harness-runtime/agent-catalog.mjs +929 -0
  11. package/skills/harness-runtime/contracts.md +2 -0
  12. package/skills/harness-runtime/references/model-catalog.md +7 -1
  13. package/skills/resolve-issues/SKILL.md +18 -13
  14. package/skills/resolve-issues/references/delivery-progress.md +2 -0
  15. package/skills/resolve-issues/references/expire.md +6 -3
  16. package/skills/resolve-issues/references/exploration.md +60 -18
  17. package/skills/resolve-issues/references/implementation.md +7 -2
  18. package/skills/resolve-issues/references/preflight.md +65 -31
  19. package/skills/resolve-issues/references/review.md +22 -9
  20. package/skills/resolve-issues/references/shared-modules.md +142 -20
  21. package/skills/resolve-issues/references/task-plan.md +62 -8
  22. package/skills/resolve-issues/scripts/findings-reuse.mjs +1 -1
  23. package/skills/resolve-issues/scripts/next-actions.mjs +7 -7
  24. package/skills/resolve-issues/scripts/plan-sync.mjs +1 -1
  25. package/skills/resolve-issues/scripts/preflight-models.mjs +382 -592
  26. package/skills/resolve-issues/scripts/size-check.mjs +6 -5
  27. package/skills/resolve-release/SKILL.md +1 -1
  28. package/skills/rush-issues/SKILL.md +4 -4
  29. package/skills/rush-release/SKILL.md +1 -1
  30. package/skills/test-quality/SKILL.md +1 -1
  31. package/skills/resolve-issues/scripts/discover-models.mjs +0 -9
  32. package/skills/resolve-issues/scripts/model-catalog.mjs +0 -9
@@ -30,7 +30,8 @@
30
30
  // (ok, warn, hold, stop, or exploration-unfinished); 2 for a bad plan or command.
31
31
  // `exploration-unfinished` (printed as `{ verdict, reason }`) means findings that are unreadable,
32
32
  // not version 2, or missing a planned unit, its `slice`, its `proof`, or its `estimatedLines`;
33
- // only the explorer fixes it. --exit-verdict restores the old exit codes for one release
33
+ // complete the preflight findings using exploration.md's owner routing.
34
+ // --exit-verdict restores the old exit codes for one release
34
35
  // (deprecated): 0 for ok/warn, 4 for hold, 1 for stop, 3 for exploration-unfinished.
35
36
 
36
37
  import { readFileSync } from 'node:fs'
@@ -78,7 +79,7 @@ export const FINDINGS_VERSION = 2
78
79
 
79
80
  export class SizeCheckError extends Error {}
80
81
 
81
- // Unfinished exploration: the explorer, not the orchestrator, fixes it.
82
+ // Unfinished assessment; keep the exported error and verdict compatible with saved runs.
82
83
  export class ExplorationUnfinished extends SizeCheckError {}
83
84
 
84
85
  function unitsOf(plan) {
@@ -262,9 +263,9 @@ function environmentChecks(units, byUnit) {
262
263
  // ---- The whole check ----
263
264
 
264
265
  // A unit counts as explored once its entry carries a valid `slice`, `proof`,
265
- // and `estimatedLines`; the explorer's scaffold (an empty entry per unit) does not pass.
266
+ // and `estimatedLines`; a scaffold (an empty entry per unit) does not pass.
266
267
  function findingsUnitsOf(findings, units) {
267
- const unfinished = (why) => new ExplorationUnfinished(`exploration unfinished: ${why}; continue the explorer`)
268
+ const unfinished = (why) => new ExplorationUnfinished(`exploration unfinished: ${why}; complete the preflight findings`)
268
269
  if (findings?.version !== FINDINGS_VERSION) throw unfinished(`findings version is ${JSON.stringify(findings?.version)}, expected ${FINDINGS_VERSION}`)
269
270
  const byUnit = findings.units
270
271
  if (!byUnit || typeof byUnit !== 'object' || Array.isArray(byUnit)) throw unfinished('findings has no units map')
@@ -481,7 +482,7 @@ if (isMainModule(import.meta.url)) {
481
482
  process.exitCode = opts.exitVerdict ? EXIT[result.verdict] : 0
482
483
  } catch (error) {
483
484
  if (error instanceof ExplorationUnfinished) {
484
- // Unfinished exploration is an answer (the explorer continues), not a failure of the script.
485
+ // Incomplete findings are an answer, not a failure of the script.
485
486
  process.stdout.write(`${JSON.stringify({ verdict: 'exploration-unfinished', reason: error.message }, null, 2)}\n`)
486
487
  process.exitCode = process.argv.includes('--exit-verdict') ? 3 : 0
487
488
  } else {
@@ -4,7 +4,7 @@ description: "Slash/explicit-only (/resolve-release). Full GitHub Flow release f
4
4
  disable-model-invocation: true
5
5
  metadata:
6
6
  workflow-role: coordinator
7
- release-version: 0.47.0
7
+ release-version: 0.48.1
8
8
  ---
9
9
  **Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
10
10
  # Resolve release
@@ -1,12 +1,12 @@
1
1
  ---
2
2
  name: rush-issues
3
- description: "Slash/explicit-only (/rush-issues). No-questions shortcut of /resolve-issues: drive an issue, epic, or feature spec to reviewed, green PRs, one per issue, and merge each (through the queue when there is one). Takes every preflight default (recommended implementer unless the invocation pins one, the default branch, autonomous merge with blocker fixes, full scheduler mode unless scheduler= says otherwise, the drafted plan) and asks nothing, even at preflight; invoking it is the authorization. Like resolve-issues, never blocks on the human: it takes the automatic answer (the recommendation, formed if none; filed splits) and defers what only a human can do (a looser required check, shared-environment changes, missing access) on its owning issue while the rest ships. Posts the dropbox, then completes the goal. Do not auto-select. NOT for choosing the implementer, target branch, supervised merge, or trimming a plan or moving units to later (resolve-issues), and NOT for release work (rush-release)."
3
+ description: "Slash/explicit-only (/rush-issues). No-questions shortcut of /resolve-issues: drive an issue, epic, or feature spec to reviewed, green PRs, one per issue, and merge each (through the queue when there is one). Takes every preflight default (the catalog's implementer slot unless the invocation pins one, the default branch, autonomous merge with blocker fixes, full scheduler mode unless scheduler= says otherwise, the drafted plan) and asks nothing, even at preflight; invoking it is the authorization. Like resolve-issues, never blocks on the human: it takes the automatic answer (the recommendation, formed if none; filed splits) and defers what only a human can do (a looser required check, shared-environment changes, missing access) on its owning issue while the rest ships. Posts the dropbox, then completes the goal. Do not auto-select. NOT for choosing the target branch, supervised merge, or trimming a plan or moving units to later (resolve-issues), and NOT for release work (rush-release)."
4
4
  disable-model-invocation: true
5
5
  metadata:
6
6
  workflow-role: coordinator
7
7
  dependencies:
8
8
  - resolve-issues
9
- release-version: 0.47.0
9
+ release-version: 0.48.1
10
10
  ---
11
11
  **Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
12
12
  # Rush issues (shortcut of resolve-issues)
@@ -21,8 +21,8 @@ CI.** Make the decisions that get there. `resolve-issues`'
21
21
  are guidelines, and every rule serves the goal rather than restricting you.
22
22
 
23
23
  `/rush-issues` runs the `resolve-issues` workflow in **shortcut mode**: the
24
- recommended implementer (or the one `implementer=<id[@effort]>` pins; the run
25
- stops if it is unavailable, never swapping in another), the repository's
24
+ resolved implementer fill (or the one `implementer=<id[@effort]>` pins; the run
25
+ stops if that pin is unavailable, never swapping in another), the repository's
26
26
  default branch, `autonomous` merge, the `full` scheduler mode (or the one
27
27
  `scheduler=narrow|off` names), and the drafted plan, with
28
28
  no questions at any point. Invoking it is the
@@ -6,7 +6,7 @@ metadata:
6
6
  workflow-role: coordinator
7
7
  dependencies:
8
8
  - resolve-release
9
- release-version: 0.47.0
9
+ release-version: 0.48.1
10
10
  ---
11
11
  **Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
12
12
  # Rush release (shortcut of resolve-release)
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  name: test-quality
3
3
  description: "Seven principles for tests that catch real bugs, and an audit that reports weak, redundant, and not-coverage tests without fixing them. Use when writing, changing, or reviewing tests, or when asked whether tests are useful, redundant, over-mocked, flaky, only assert static text, or test config files, or asked to make a slow test suite faster without losing coverage, or when the user asks to write the testing conventions into a repo's CONTRIBUTING.md. NOT defining what a spec must prove (ensure-coverage) or authoring browser tests (e2e-test)."
4
- release-version: 0.47.0
4
+ release-version: 0.48.1
5
5
  ---
6
6
  **Updates:** Once/session run `node <skill-base-dir>/release-check.mjs`.
7
7
  # Test Quality
@@ -1,9 +0,0 @@
1
- // Thin wrapper: canonical ownership lives in harness-runtime.
2
- export * from '../../harness-runtime/discover-models.mjs'
3
-
4
- import { runCli } from '../../harness-runtime/discover-models.mjs'
5
- import { isMainModule } from '../../engineering-runtime/scripts/main-module.mjs'
6
-
7
- if (isMainModule(import.meta.url)) {
8
- process.exit(runCli(process.argv.slice(2)))
9
- }
@@ -1,9 +0,0 @@
1
- // Thin wrapper: canonical ownership lives in harness-runtime.
2
- export * from '../../harness-runtime/model-catalog.mjs'
3
-
4
- import { runCli } from '../../harness-runtime/model-catalog.mjs'
5
- import { isMainModule } from '../../engineering-runtime/scripts/main-module.mjs'
6
-
7
- if (isMainModule(import.meta.url)) {
8
- process.exit(runCli(process.argv.slice(2)))
9
- }