@1024pix/pix-ui 14.8.1 → 15.0.2

package/.circleci/config.yml

@@ -1,5 +1,8 @@
 version: 2.1
 
+orbs:
+  browser-tools: circleci/browser-tools@1.3.0
+
 workflows:
   version: 2
   build-and-test:
@@ -13,8 +16,11 @@ workflows:
 jobs:
   build-and-test:
     docker:
-      - image: circleci/node:12.14.0-browsers
+      - image: cimg/node:16.14.0-browsers
     steps:
+      - run: sudo npm i -g npm@8.13.2
+      - browser-tools/install-chrome
+      - browser-tools/install-chromedriver
       - checkout
       - run: npm ci
       - run: npm run lint:js

package/.github/workflows/deploy-storybook.yml

@@ -1,7 +1,7 @@
 name: Deploy Pix UI Storybook
 
-on: 
-  workflow_dispatch: 
+on:
+  workflow_dispatch:
   push:
     tags:
       - '*'
@@ -10,12 +10,13 @@ jobs:
   deploy:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v1
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 16.14.0
+      - run: npm i -g npm@8.13.2
       - run: npm ci
       - name: Deploy storybook to Github Pages
         run: npm run deploy-storybook -- --ci
         env:
-          GH_TOKEN: 1024pix:${{ secrets.GITHUB_TOKEN }}
+          GH_TOKEN: 1024pix:${{ secrets.GITHUB_TOKEN }}

package/.nvmrc

@@ -1 +1 @@
-16.13.0
+16.14.0

package/CHANGELOG.md

@@ -1,5 +1,28 @@
 # Pix-UI Changelog
 
+## v15.0.2 (11/07/2022)
+
+
+### :building_construction: Tech
+- [#237](https://github.com/1024pix/pix-ui/pull/237) [TECH] Changer les pré-requis engine du package.json (PIX-5319)
+
+### :bug: Correction
+- [#236](https://github.com/1024pix/pix-ui/pull/236) [BUGFIX] Correction du déploiement de Storybook
+
+## v15.0.1 (08/07/2022)
+
+
+### :bug: Correction
+- [#234](https://github.com/1024pix/pix-ui/pull/234) [BUGFIX] Laisser les filtres à côté du label dans le FilterBanner (PIX-5301)
+- [#231](https://github.com/1024pix/pix-ui/pull/231) [BUGFIX] PixButton de type submit affiche un loader si @isLoading=true
+
+## v15.0.0 (05/07/2022)
+
+
+### :building_construction: Tech
+- [#229](https://github.com/1024pix/pix-ui/pull/229) [TECH] Retirer la taille par defaut du composant PixMultiSelect
+- [#224](https://github.com/1024pix/pix-ui/pull/224) [TECH] Fixer la version NodeJS à 16.14.0
+
 ## v14.8.1 (30/06/2022)
 
 

package/addon/components/pix-button.hbs

@@ -8,36 +8,23 @@
     {{yield}}
   </LinkTo>
 {{else}}
-  {{#if this.enableTriggerAction}}
-    <button
-      type={{this.type}}
-      class={{this.className}}
-      {{on "click" this.triggerAction}}
-      ...attributes
-      disabled={{this.isButtonLoadingOrDisabled}}
-      aria-disabled="{{this.ariaDisabled}}"
-    >
-      {{#if this.isLoading}}
-        <div class="loader loader--{{this.loadingColor}}">
-          <div class="bounce1"></div>
-          <div class="bounce2"></div>
-          <div class="bounce3"></div>
-        </div>
-        <span class="loader__not-visible-text">{{yield}}</span>
-      {{else}}
-        {{yield}}
-      {{/if}}
-    </button>
-  {{else}}
-    <button
-      type={{this.type}}
-      class={{this.className}}
-      ...attributes
-      disabled={{this.isButtonLoadingOrDisabled}}
-      aria-disabled="{{this.ariaDisabled}}"
-    >
+  <button
+    type={{this.type}}
+    class={{this.className}}
+    {{on "click" this.triggerAction}}
+    ...attributes
+    disabled={{this.isButtonLoadingOrDisabled}}
+    aria-disabled="{{this.ariaDisabled}}"
+  >
+    {{#if this.isLoading}}
+      <div class="loader loader--{{this.loadingColor}}">
+        <div class="bounce1"></div>
+        <div class="bounce2"></div>
+        <div class="bounce3"></div>
+      </div>
+      <span class="loader__not-visible-text">{{yield}}</span>
+    {{else}}
       {{yield}}
-    </button>
-  {{/if}}
-
+    {{/if}}
+  </button>
 {{/if}}

package/addon/components/pix-button.js

@@ -33,22 +33,17 @@ export default class PixButton extends PixButtonBase {
     return super.baseClassNames.join(' ');
   }
 
-  get enableTriggerAction() {
-    return !(this.type === 'submit' && !this.args.triggerAction);
-  }
-
   @action
   async triggerAction(params) {
+    if (this.type === 'submit' && !this.args.triggerAction) return;
+    if (!this.args.triggerAction) {
+      throw new Error('@triggerAction params is required for PixButton !');
+    }
     try {
       this.isTriggering = true;
       await this.args.triggerAction(params);
+    } finally {
       this.isTriggering = false;
-    } catch (e) {
-      this.isTriggering = false;
-      if (!this.args.triggerAction) {
-        throw new Error('@triggerAction params is required for PixButton !');
-      }
-      throw new Error(e);
     }
   }
 }

package/addon/styles/_pix-filter-banner.scss

@@ -23,6 +23,14 @@
     gap: $spacing-s;
   }
 
+  &__container-action {
+    display: flex;
+    flex-direction: column;
+    align-items: center;
+    border-top: 1px solid $pix-neutral-15;
+  }
+
+
   &__details {
     color: $pix-neutral-60;
     font-family: $font-roboto;
@@ -30,7 +38,6 @@
     padding: $spacing-xs 0 $spacing-xs 0;
     margin: 0;
     font-size: 0.875rem;
-    border-top: 1px solid $pix-neutral-15;
   }
 
   &__button {
@@ -44,7 +51,6 @@
 
 @include device-is('tablet') {
   .pix-filter-banner {
-    justify-content: space-between;
     align-items: center;
     flex-direction: row;
     gap: $spacing-m;
@@ -57,12 +63,13 @@
     &__container-filter {
       flex-direction: row;
       flex-wrap: wrap;
+      align-items: center;
+      flex-grow: 2;
     }
 
     &__container-action {
-      display: flex;
-      align-items: center;
-      justify-content: flex-end;
+      flex-direction: row;
+      border: none;
     }
 
     &__details {

package/addon/styles/_pix-multi-select.scss

@@ -1,8 +1,6 @@
 .pix-multi-select {
   display: inline-block;
   position: relative;
-  min-width: 250px;
-  width: 100%;
 
   &__label {
     @include label();
@@ -62,7 +60,6 @@
     color: $pix-neutral-30;
     right: 10px;
     top: calc(50% - 6px);
-    padding: 0 0 2px;
     position: absolute;
     pointer-events: none;
 

package/addon/styles/_pix-select.scss

@@ -55,8 +55,7 @@
     font-size: 11px;
     color: $pix-neutral-30;
     right: 10px;
-    top: calc(50% - 4px);
-    padding: 0 0 2px;
+    top: calc(50% - 6px);
     position: absolute;
     pointer-events: none;
   }

package/app/stories/pix-button.stories.js

@@ -42,13 +42,6 @@ Default.args = {
   size: 'big',
   backgroundColor: 'blue',
   label: 'Bouton',
-  triggerAction: () => {
-    return new Promise((resolve) => {
-      setTimeout(() => {
-        resolve();
-      }, 2000);
-    });
-  },
 };
 
 export const borders = Template.bind({});
@@ -124,10 +117,16 @@ loader.args = {
   label: 'Bouton avec loader au clic',
   backgroundColor: 'yellow',
   loadingColor: 'grey',
+  triggerAction: () => {
+    return new Promise((resolve) => {
+      setTimeout(() => {
+        resolve();
+      }, 2000);
+    });
+  },
   extraButtons: [
     {
       ...Default.args,
-      triggerAction: () => {},
       isLoading: true,
     },
   ],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@1024pix/pix-ui",
-  "version": "14.8.1",
+  "version": "15.0.2",
   "description": "Pix-UI is the implementation of Pix design principles and guidelines for its products.",
   "keywords": [
     "ember-addon"
@@ -8,7 +8,8 @@
   "license": "MIT",
   "author": "GIP Pix",
   "engines": {
-    "node": "^16.13.0"
+    "node": "16.14.0",
+    "npm": ">=8.3.1 <=8.13.2"
   },
   "ember": {
     "edition": "octane"
@@ -33,6 +34,7 @@
     "lint:hbs:fix": "npm run lint:hbs -- --fix",
     "lint:js": "eslint .",
     "lint:js:fix": "npm run lint:js -- --fix",
+    "preinstall": "npx check-engine",
     "start": "ember serve",
     "storybook": "ember build && ember serve & start-storybook -p 9001 -s dist",
     "test": "ember test",