@1024pix/pix-ui 14.0.0 → 14.2.0

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # Pix-UI Changelog
 
+## v14.2.0 (06/05/2022)
+
+
+### :coffee: Autre
+- [#216](https://github.com/1024pix/pix-ui/pull/216) A11Y: add role=img on the stars container + add aria-label
+
+## v14.1.1 (15/04/2022)
+
+
+### :bug: Correction
+- [#214](https://github.com/1024pix/pix-ui/pull/214) [BUGFIX] Ajouter  params à la méthode triggerAction à PixIconButton (PIX-4790)
+
+## v14.1.0 (12/04/2022)
+
+
+### :rocket: Amélioration
+- [#213](https://github.com/1024pix/pix-ui/pull/213) [FEATURE] Retirer l'option d'ajouter une icône dans le composant Pix Input (PIX-4766).
+
 ## v14.0.0 (12/04/2022)
 
 

package/addon/components/pix-icon-button.js

@@ -25,9 +25,9 @@ export default class PixIconButton extends Component {
   }
 
   @action
-  triggerAction() {
+  triggerAction(params) {
     if (this.args.triggerAction) {
-      this.args.triggerAction();
+      this.args.triggerAction(params);
     }
   }
 }

package/addon/components/pix-input.hbs

@@ -16,7 +16,7 @@
   <div class="pix-input__container">
     <input
       id={{this.id}}
-      class={{this.className}}
+      class={{if @errorMessage "pix-input__input--error"}}
       value={{@value}}
       aria-label={{this.ariaLabel}}
       aria-required="{{if @requiredLabel true false}}"
@@ -28,10 +28,6 @@
     {{#if @errorMessage}}
       <FaIcon @icon="times" class="pix-input__error-icon" />
     {{/if}}
-
-    {{#if @icon}}
-      <FaIcon @icon={{@icon}} class="pix-input__icon {{if @isIconLeft 'pix-input__icon--left'}}" />
-    {{/if}}
   </div>
 
   {{#if @errorMessage}}

package/addon/components/pix-input.js

@@ -10,14 +10,6 @@ export default class PixInput extends Component {
     return this.args.id;
   }
 
-  get className() {
-    const classNames = [];
-    this.args.errorMessage && classNames.push('pix-input__input--error');
-    this.args.icon && classNames.push('pix-input__input--icon');
-    this.args.isIconLeft && classNames.push('pix-input__input--icon-left');
-    return classNames.join(' ');
-  }
-
   get label() {
     if (!this.args.label && !this.args.ariaLabel) {
       throw new Error(ERROR_MESSAGE);

package/addon/components/pix-stars.hbs

@@ -1,7 +1,6 @@
-<div class={{this.pixStarsClass}} ...attributes>
-  <span class="sr-only">{{@alt}}</span>
+<div class={{this.pixStarsClass}} ...attributes role="img" aria-label={{@alt}}>
   {{#each this.stars as |star|}}
-    <svg class="pix-stars__{{star}}" data-test-status={{star}} viewBox="0 0 36 36">
+    <svg class="pix-stars__{{star}}" data-test-status={{star}} viewBox="0 0 36 36" role="img">
       <defs>
         <linearGradient id="pix-stars-default" x1="68.643%" y1="0%" x2="68.643%" y2="100%">
           <stop stop-color="#FEDC41" offset="0%"></stop>

package/addon/styles/_pix-input.scss

@@ -25,25 +25,6 @@
     position: relative;
   }
 
-  svg.pix-input__icon {
-    position: absolute;
-    bottom: 9px;
-    right: 6px;
-    color: $grey-25;
-    font-size: 1.125rem;
-    width: 18px;
-    height: 18px;
-
-    &--left {
-      left: 6px;
-    }
-  }
-
-  svg ~ svg.pix-input__icon {
-    right: calc(6px + 12px + 2px);
-    margin-right: 8px;
-  }
-
   svg.pix-input__error-icon {
     position: absolute;
     bottom: 10px;
@@ -84,17 +65,5 @@
       padding-right: 32px;
       @include formElementInError();
     }
-
-    &.pix-input__input--icon {
-      padding-right: 32px;
-    }
-
-    &.pix-input__input--icon.pix-input__input--icon-left {
-      padding-left: 32px;
-    }
-
-    &.pix-input__input--error.pix-input__input--icon:not(.pix-input__input--icon-left) {
-      padding-right: 32px;
-    }
   }
 }

package/app/stories/pix-input.stories.js

@@ -8,8 +8,6 @@ export const Template = (args) => {
         @label={{label}}
         @information={{information}}
         @errorMessage={{errorMessage}}
-        @icon={{icon}}
-        @isIconLeft={{isIconLeft}}
         placeholder='Jeanne, Pierre ...'
         @requiredLabel={{requiredLabel}}
         @ariaLabel={{ariaLabel}}
@@ -40,13 +38,6 @@ withErrorMessage.args = {
   errorMessage: "un message d'erreur",
 };
 
-export const withIcon = Template.bind({});
-withIcon.args = {
-  id: 'firstName',
-  label: 'Prénom',
-  icon: 'eye',
-};
-
 export const withRequiredLabel = Template.bind({});
 withRequiredLabel.args = {
   id: 'firstName',
@@ -91,23 +82,6 @@ export const argTypes = {
     type: { name: 'string', required: false },
     defaultValue: null,
   },
-  icon: {
-    name: 'icon',
-    description: "Affiche l'icône choisie à la fin de l'input",
-    type: { name: 'string', required: false },
-    defaultValue: null,
-  },
-  isIconLeft: {
-    name: 'isIconLeft',
-    description: "Permet d'afficher l'icône choisie sur la gauche",
-    type: { name: 'boolean', required: false },
-    control: { type: 'boolean' },
-    defaultValue: false,
-    table: {
-      type: { summary: 'boolean' },
-      defaultValue: { summary: 'false' },
-    },
-  },
   requiredLabel: {
     name: 'requiredLabel',
     description:

package/app/stories/pix-input.stories.mdx

@@ -39,12 +39,6 @@ Si vous utilisez le `PixInput` sans label alors il faut renseigner le paramètre
   <Story story={stories.withErrorMessage} height={130} />
 </Canvas>
 
-## With icon
-
-<Canvas>
-  <Story story={stories.withIcon} height={130} />
-</Canvas>
-
 ## With required label
 
 <Canvas>
@@ -59,8 +53,6 @@ Si vous utilisez le `PixInput` sans label alors il faut renseigner le paramètre
   @label='Prénom'
   @information='Complément du label'
   @errorMessage='Un message d`erreur'
-  @icon='eye'
-  @isIconLeft={{false}}
   @requiredLabel='Champ obligatoire'
 />
 ```

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@1024pix/pix-ui",
-  "version": "14.0.0",
+  "version": "14.2.0",
   "description": "Pix-UI is the implementation of Pix design principles and guidelines for its products.",
   "keywords": [
     "ember-addon"