@100mslive/roomkit-react 0.3.20-alpha.2 → 0.3.20-alpha.4

package/src/Prebuilt/components/HMSVideo/HMSVideo.jsx

@@ -1,28 +1,7 @@
-import React, { forwardRef, useEffect, useState } from 'react';
+import React, { forwardRef } from 'react';
 import { Flex } from '../../../Layout';
 
 export const HMSVideo = forwardRef(({ children, ...props }, videoRef) => {
-  const [width, setWidth] = useState('auto');
-
-  useEffect(() => {
-    const updatingVideoWidth = () => {
-      const videoEl = videoRef.current;
-      if (!videoEl) {
-        return;
-      }
-      if (videoEl.videoWidth > videoEl.videoHeight && width !== '100%') {
-        setWidth('100%');
-      }
-    };
-    const videoEl = videoRef.current;
-    if (!videoEl) {
-      return;
-    }
-    videoEl.addEventListener('loadedmetadata', updatingVideoWidth);
-    return () => {
-      videoEl.removeEventListener('loadedmetadata', updatingVideoWidth);
-    };
-  }, []);
   return (
     <Flex
       data-testid="hms-video"
@@ -32,8 +11,9 @@ export const HMSVideo = forwardRef(({ children, ...props }, videoRef) => {
         justifyContent: 'center',
         transition: 'all 0.3s ease-in-out',
         '@md': {
+          height: 'auto',
           '& video': {
-            height: props.isFullScreen ? '' : '$60 !important',
+            height: '$60 !important',
           },
         },
         '& video::cue': {
@@ -61,7 +41,7 @@ export const HMSVideo = forwardRef(({ children, ...props }, videoRef) => {
         style={{
           margin: '0 auto',
           objectFit: 'contain',
-          width: width,
+          width: 'auto',
           height: '100%',
           maxWidth: '100%',
         }}

package/src/Prebuilt/components/MoreSettings/ChangeNameContent.tsx

@@ -1,4 +1,4 @@
-import React, { useEffect, useRef } from 'react';
+import React from 'react';
 import { ChevronLeftIcon, CrossIcon } from '@100mslive/react-icons';
 import { Button } from '../../../Button';
 import { Input } from '../../../Input';
@@ -22,16 +22,6 @@ export const ChangeNameContent = ({
   onExit: () => void;
   onBackClick: () => void;
 }) => {
-  const inputRef = useRef<HTMLInputElement>(null);
-
-  useEffect(() => {
-    if (isMobile) {
-      setTimeout(() => {
-        inputRef.current?.focus();
-      }, 200);
-    }
-  }, [isMobile]);
-
   return (
     <form
       onSubmit={async e => {
@@ -63,10 +53,10 @@ export const ChangeNameContent = ({
       </Text>
       <Flex justify="center" align="center" css={{ my: '$8', w: '100%', '@md': { px: '$8' } }}>
         <Input
-          ref={inputRef}
           css={{ width: '100%', bg: '$surface_default' }}
           value={currentName}
-          type="text"
+          // Prevents popup from showing up on chrome mweb
+          type={isMobile ? 'search' : 'text'}
           onChange={e => {
             setCurrentName(e.target.value);
           }}

package/src/Prebuilt/components/MoreSettings/ChangeNameModal.tsx

@@ -58,7 +58,7 @@ export const ChangeNameModal = ({
   if (isMobile) {
     return (
       <Sheet.Root defaultOpen onOpenChange={onOpenChange}>
-        <Sheet.Content css={{ bg: '$surface_dim', p: '$8 0' }} onOpenAutoFocus={e => e.preventDefault()}>
+        <Sheet.Content css={{ bg: '$surface_dim', p: '$8 0' }}>
           <ChangeNameContent {...props} />
         </Sheet.Content>
       </Sheet.Root>

package/src/Prebuilt/components/Notifications/TrackUnmuteModal.tsx

@@ -44,7 +44,7 @@ export const TrackUnmuteModal = () => {
     <RequestDialog
       title={`Unmute your ${track.type}?`}
       onOpenChange={(value: boolean) => !value && setMuteNotification(null)}
-      body={`${peer?.name} is requesting you to unmute your ${track?.type}.`}
+      body={`${peer?.name}is requesting you to unmute your ${track?.type}.`}
       onAction={() => {
         hmsActions.setEnabledTrack(track.id, enabled);
         setMuteNotification(null);

package/src/Prebuilt/components/ScreenshareTile.tsx

@@ -16,6 +16,7 @@ import { config as cssConfig, useTheme } from '../../Theme';
 import { Video } from '../../Video';
 import { StyledVideoTile } from '../../VideoTile';
 import { LayoutModeSelector } from './LayoutModeSelector';
+// @ts-ignore: No implicit Any
 import { getVideoTileLabel } from './peerTileUtils';
 import { ScreenshareDisplay } from './ScreenshareDisplay';
 // @ts-ignore: No implicit Any
@@ -61,8 +62,7 @@ const Tile = ({ peerId, width = '100%', height = '100%' }: { peerId: string; wid
   const label = getVideoTileLabel({
     peerName: peer?.name,
     isLocal: false,
-    videoTrack: track,
-    audioTrack,
+    track,
   });
 
   return (

package/src/Prebuilt/components/Settings/SettingsModal.jsx

@@ -140,6 +140,7 @@ const MobileSettingModal = ({
           <Flex
             direction="column"
             css={{
+              px: '$8',
               pb: '$8',
               overflowY: 'auto',
             }}
@@ -158,7 +159,7 @@ const MobileSettingModal = ({
                     css={{
                       all: 'unset',
                       fontFamily: '$sans',
-                      p: '$10 $8',
+                      py: '$10',
                       display: 'flex',
                       alignItems: 'center',
                       fontSize: '$sm',

package/src/Prebuilt/components/TileMenu/TileMenu.tsx

@@ -1,7 +1,6 @@
 import React, { useState } from 'react';
 import { useMedia } from 'react-use';
 import {
-  HMSAudioTrack,
   HMSVideoTrack,
   selectLocalPeerID,
   selectPeerByID,
@@ -18,7 +17,6 @@ import { Text } from '../../../Text';
 import { config as cssConfig, useTheme } from '../../../Theme';
 import { StyledMenuTile } from '../../../TileMenu';
 import { ChangeNameModal } from '../MoreSettings/ChangeNameModal';
-import { getVideoTileLabel } from '../peerTileUtils';
 import { RoleChangeModal } from '../RoleChangeModal';
 import { TileMenuContent } from './TileMenuContent';
 import { useDropdownList } from '../hooks/useDropdownList';
@@ -54,8 +52,7 @@ const TileMenu = ({
   const isPrimaryVideoTrack = useHMSStore(selectVideoTrackByPeerID(peerID))?.id === videoTrackID;
   const showPinAction = !!(audioTrackID || (videoTrackID && isPrimaryVideoTrack));
 
-  const track = useHMSStore(selectTrackByID(videoTrackID)) as HMSVideoTrack | null;
-  const audioTrack = useHMSStore(selectTrackByID(audioTrackID)) as HMSAudioTrack | null;
+  const track = useHMSStore(selectTrackByID(videoTrackID)) as HMSVideoTrack;
   const hideSimulcastLayers = !track?.layerDefinitions?.length || track.degraded || !track.enabled;
   const isMobile = useMedia(cssConfig.media.md);
   const peer = useHMSStore(selectPeerByID(peerID));
@@ -64,19 +61,20 @@ const TileMenu = ({
   useDropdownList({ open, name: 'TileMenu' });
   const dragClassName = getDragClassName();
 
-  if (!peer || (!(removeOthers || toggleAudio || toggleVideo || setVolume || showPinAction) && hideSimulcastLayers)) {
+  if (!(removeOthers || toggleAudio || toggleVideo || setVolume || showPinAction) && hideSimulcastLayers) {
     return null;
   }
 
   const openNameChangeModal = () => setShowNameChangeModal(true);
   const openRoleChangeModal = () => setShowRoleChangeModal(true);
 
-  const props: React.ComponentPropsWithoutRef<typeof TileMenuContent> = {
+  const props = {
     isLocal,
     isScreenshare,
     audioTrackID,
     videoTrackID,
     peerID,
+    isPrimaryVideoTrack,
     showSpotlight,
     showPinAction,
     canMinimise,
@@ -113,7 +111,8 @@ const TileMenu = ({
               >
                 <Box>
                   <Text css={{ color: '$on_surface_high', fontWeight: '$semiBold' }}>
-                    {getVideoTileLabel({ peerName: peer?.name, isLocal, audioTrack, videoTrack: track })}
+                    {peer?.name}
+                    {isLocal ? ` (You)` : null}
                   </Text>
                   {peer?.roleName ? (
                     <Text variant="xs" css={{ color: '$on_surface_low', mt: '$2' }}>

package/src/Prebuilt/components/TileMenu/TileMenuContent.tsx

@@ -41,7 +41,7 @@ import { useSetAppDataByKey } from '../AppData/useUISettings';
 // @ts-ignore
 import { useDropdownSelection } from '../hooks/useDropdownSelection';
 import { getDragClassName } from './utils';
-import { APP_DATA, isIOS, REMOTE_STOP_SCREENSHARE_TYPE, SESSION_STORE_KEY } from '../../common/constants';
+import { APP_DATA, REMOTE_STOP_SCREENSHARE_TYPE, SESSION_STORE_KEY } from '../../common/constants';
 
 export const isSameTile = ({
   trackId,
@@ -317,7 +317,7 @@ export const TileMenuContent = ({
         </StyledMenuTile.ItemButton>
       ) : null}
 
-      {!isScreenshare && canChangeRole && roles.length > 1 ? (
+      {canChangeRole && roles.length > 1 ? (
         <StyledMenuTile.ItemButton
           className={dragClassName}
           css={spacingCSS}
@@ -332,7 +332,7 @@ export const TileMenuContent = ({
         </StyledMenuTile.ItemButton>
       ) : null}
 
-      {!isIOS && audioTrackID ? (
+      {audioTrackID ? (
         <StyledMenuTile.VolumeItem data-testid="participant_volume_slider" css={{ ...spacingCSS, mb: '$0' }}>
           <Flex align="center" gap={1}>
             <SpeakerIcon height={20} width={20} />

package/src/Prebuilt/components/VideoLayouts/EqualProminence.tsx

@@ -1,6 +1,5 @@
 import React, { useEffect, useState } from 'react';
 import { useMedia } from 'react-use';
-import { selectPeerCount, useHMSStore } from '@100mslive/react-sdk';
 import { PeopleAddIcon } from '@100mslive/react-icons';
 import { Flex } from '../../../Layout';
 import { config as cssConfig } from '../../../Theme';
@@ -18,7 +17,6 @@ export function EqualProminence({ isInsetEnabled = false, peers, onPageChange, o
   const isMobile = useMedia(cssConfig.media.md);
   let maxTileCount = useUISettings(UI_SETTINGS.maxTileCount);
   maxTileCount = isMobile ? Math.min(maxTileCount, 6) : maxTileCount;
-  const peerCount = useHMSStore(selectPeerCount);
   const pageList = usePagesWithTiles({
     peers,
     maxTileCount,
@@ -53,8 +51,8 @@ export function EqualProminence({ isInsetEnabled = false, peers, onPageChange, o
       )}
       {pageList.length === 0 ? (
         <WaitingView
-          title={peerCount <= 1 ? "You're the only one here" : 'Glad to have you here'}
-          subtitle={peerCount <= 1 ? 'Sit back and relax till others join' : ''}
+          title="You're the first to join"
+          subtitle="Sit back and relax till others join"
           icon={<PeopleAddIcon width="56px" height="56px" style={{ color: 'white' }} />}
         />
       ) : null}

package/src/Prebuilt/components/VideoTile.tsx

@@ -20,6 +20,7 @@ import { VideoTileStats } from '../../Stats';
 import { CSS } from '../../Theme';
 import { Video } from '../../Video';
 import { StyledVideoTile } from '../../VideoTile';
+// @ts-ignore: No implicit Any
 import { getVideoTileLabel } from './peerTileUtils';
 // @ts-ignore: No implicit Any
 import { useSetAppDataByKey, useUISettings } from './AppData/useUISettings';
@@ -100,9 +101,8 @@ const Tile = ({
   });
   const label = getVideoTileLabel({
     peerName,
+    track,
     isLocal,
-    videoTrack: track,
-    audioTrack,
   });
   const onHoverHandler = useCallback((event: React.MouseEvent) => {
     setIsMouseHovered(event.type === 'mouseenter');

package/src/Prebuilt/components/VirtualBackground/VBHandler.tsx

@@ -2,7 +2,7 @@
 // eslint-disable-next-line
 import { HMSVBPlugin, HMSVirtualBackgroundTypes } from '@100mslive/hms-virtual-background/hmsvbplugin';
 import { parsedUserAgent } from '@100mslive/react-sdk';
-import { isIOS, isSafari } from '../../common/constants';
+import { isSafari } from '../../common/constants';
 export class VBPlugin {
   private hmsPlugin?: HMSVBPlugin;
   private effectsPlugin?: any;
@@ -103,18 +103,6 @@ export class VBPlugin {
     this.hmsPlugin = undefined;
   };
 
-  isBlurSupported = () => {
-    if ((isSafari || isIOS) && this.hmsPlugin) {
-      return false;
-    }
-
-    if (this.effectsPlugin) {
-      return true;
-    }
-
-    return false;
-  };
-
   isEffectsSupported = () => {
     if (!isSafari) {
       return true;

package/src/Prebuilt/components/VirtualBackground/VBPicker.tsx

@@ -57,7 +57,6 @@ export const VBPicker = ({ backgroundMedia = [] }: { backgroundMedia: VirtualBac
   const background = useHMSStore(selectAppData(APP_DATA.background));
   const mediaList = backgroundMedia.map((media: VirtualBackgroundMedia) => media.url || '');
   const pluginLoadingRef = useRef(false);
-  const isBlurSupported = VBHandler?.isBlurSupported();
 
   const inPreview = roomState === HMSRoomState.Preview;
   // Hidden in preview as the effect will be visible in the preview tile
@@ -191,7 +190,7 @@ export const VBPicker = ({ backgroundMedia = [] }: { backgroundMedia: VirtualBac
                 await VBHandler?.setBlur(blurAmount);
                 hmsActions.setAppData(APP_DATA.background, HMSVirtualBackgroundTypes.BLUR);
               },
-              supported: isBlurSupported,
+              supported: isEffectsSupported && isEffectsEnabled,
             },
           ]}
           activeBackground={background}
@@ -199,7 +198,7 @@ export const VBPicker = ({ backgroundMedia = [] }: { backgroundMedia: VirtualBac
 
         {/* Slider */}
         <Flex direction="column" css={{ w: '100%', gap: '$8', mt: '$8' }}>
-          {background === HMSVirtualBackgroundTypes.BLUR && isBlurSupported ? (
+          {background === HMSVirtualBackgroundTypes.BLUR && isEffectsEnabled && effectsKey ? (
             <Box>
               <Text variant="sm" css={{ color: '$on_surface_high', fontWeight: '$semiBold', mb: '$4' }}>
                 Blur intensity

package/src/Prebuilt/components/{peerTileUtils.tsx → peerTileUtils.jsx}

@@ -1,8 +1,4 @@
-import { HMSAudioTrack, HMSVideoTrack } from '@100mslive/react-sdk';
-
 const PEER_NAME_PLACEHOLDER = 'peerName';
-
-// Map [isLocal, videoSource] to the label to be displayed.
 const labelMap = new Map([
   [[true, 'screen'].toString(), 'Your Screen'],
   [[true, 'regular'].toString(), `You (${PEER_NAME_PLACEHOLDER})`],
@@ -12,30 +8,19 @@ const labelMap = new Map([
   [[false, undefined].toString(), `${PEER_NAME_PLACEHOLDER}`],
 ]);
 
-export const getVideoTileLabel = ({
-  peerName,
-  isLocal,
-  videoTrack,
-  audioTrack,
-}: {
-  isLocal: boolean;
-  peerName?: string;
-  videoTrack?: HMSVideoTrack | null;
-  audioTrack?: HMSAudioTrack | null;
-}) => {
+export const getVideoTileLabel = ({ peerName, isLocal, track }) => {
   const isPeerPresent = peerName !== undefined;
-  if (!isPeerPresent || !videoTrack) {
+  if (!isPeerPresent || !track) {
     // for peers with only audio track
-    const label = labelMap.get([isLocal, undefined].toString());
-    return isPeerPresent && label ? label.replace(PEER_NAME_PLACEHOLDER, peerName) : '';
+    return isPeerPresent ? labelMap.get([isLocal, undefined].toString()).replace(PEER_NAME_PLACEHOLDER, peerName) : '';
   }
-  const isLocallyMuted = audioTrack?.volume === 0;
+  const isLocallyMuted = track.volume === 0;
   // Map [isLocal, videoSource] to the label to be displayed.
-  let label = labelMap.get([isLocal, videoTrack.source].toString());
+  let label = labelMap.get([isLocal, track.source].toString());
   if (label) {
     label = label.replace(PEER_NAME_PLACEHOLDER, peerName);
   } else {
-    label = `${peerName} ${videoTrack.source}`;
+    label = `${peerName} ${track.source}`;
   }
   // label = `${label}${track.degraded ? '(Degraded)' : ''}`;
   return `${label}${isLocallyMuted ? ' (Muted for you)' : ''}`;

package/src/Prebuilt/layouts/HLSView.jsx

@@ -485,6 +485,11 @@ const HLSView = () => {
       css={{
         flex: isLandscape ? '2 1 0' : '1 1 0',
         transition: 'all 0.3s ease-in-out',
+        '&:fullscreen': {
+          '& video': {
+            height: 'unset !important',
+          },
+        },
       }}
     >
       {hlsViewRef.current && (isMobile || isLandscape) && (
@@ -536,7 +541,6 @@ const HLSView = () => {
             onMouseMove={onHoverHandler}
             onMouseLeave={onHoverHandler}
             onClick={onClickHandler}
-            isFullScreen={isFullScreen}
             onDoubleClick={e => {
               onDoubleClickHandler(e);
             }}
@@ -724,7 +728,6 @@ const HLSView = () => {
                           selection={currentSelectedQuality}
                           onQualityChange={handleQuality}
                           isAuto={isUserSelectedAuto}
-                          containerRef={hlsViewRef.current}
                         />
                       ) : null}
                       {isFullScreenSupported ? (