@0xcraft/powershot 1.1.2 → 1.1.3

package/dist/report/markdown.js

@@ -1,4 +1,4 @@
-import { unavailableCoverage } from '#app/manifest.js';
+import { modeNote, noFindingsLabel, scopeLine, } from './summary.js';
 const MARK = { verified: '▣', judged: '▚' };
 /** Untrusted prose encoded as literal CommonMark text. */
 function text(s) {
@@ -51,6 +51,26 @@ function group(findings) {
         list.sort((a, b) => a.line - b.line);
     return out;
 }
+function runSummary(run) {
+    const out = [];
+    const scope = scopeLine(run);
+    const mode = modeNote(run, '`verify-only`');
+    const details = run.state === 'complete'
+        ? run.scopeDetails ?? []
+        : [...run.notLookedAt, ...(run.scopeDetails ?? [])];
+    if (scope)
+        out.push(scope, '');
+    if (mode)
+        out.push(mode, '');
+    if (details.length > 0) {
+        out.push('<details>', '<summary>' +
+            (run.state !== 'complete'
+                ? 'Why this is not a verdict'
+                : run.coverage === 'portable' ? 'Coverage details' : 'Review scope') +
+            '</summary>', '', ...details.map((detail) => '- ' + text(detail)), '', '</details>', '');
+    }
+    return out;
+}
 export function markdown(findings, run) {
     // "No findings" from a run that could not look is the one thing this must never
     // say on its own — the reader takes a comment at face value, and a red job beside
@@ -59,33 +79,25 @@ export function markdown(findings, run) {
     const banner = incomplete
         ? [
             '> [!WARNING]',
-            '> **This review is ' + text(run.state) + ' — not a verdict.** Something was not looked at:',
-            ...run.notLookedAt.slice(0, 8).map((f) => '> - ' + text(f)),
-            '',
-        ]
-        : [];
-    const portable = run?.state === 'complete' && run.coverage === 'portable';
-    const coverage = portable
-        ? [
-            '> [!NOTE]',
-            '> **Portable coverage.** Self-contained oracles ran; enriched semantic depth was unavailable:',
-            ...unavailableCoverage(run).map((reason) => '> - ' + text(reason)),
+            '> **This review is ' + text(run.state) + ' — not a verdict.** Some files or checks were not reviewed.',
             '',
         ]
         : [];
+    const summary = run ? runSummary(run) : [];
     if (findings.length === 0) {
         return [
-            '## PowerShot', '', ...banner, ...coverage,
+            '## PowerShot', '', ...banner,
             incomplete
                 ? 'No findings *from what it managed to review*.'
-                : portable ? 'No findings in portable coverage.' : 'No findings.',
-            '',
+                : run ? '✅ **' + noFindingsLabel(run) + '**' : 'No findings.',
+            '', ...summary,
         ].join('\n');
     }
     const verified = findings.filter((f) => f.class === 'verified').length;
     const judged = findings.length - verified;
-    const out = ['## PowerShot', '', ...banner, ...coverage];
+    const out = ['## PowerShot', '', ...banner];
     out.push('**' + verified + ' verified** (deterministic, 0 tokens) · **' + judged + ' judged** (agent)', '');
+    out.push(...summary);
     for (const [file, list] of group(findings)) {
         out.push('### `' + path(file) + '`', '');
         for (const f of list) {

package/dist/report/summary.js

@@ -0,0 +1,103 @@
+function plural(count, singular, pluralForm = singular + 's') {
+    return count + ' ' + (count === 1 ? singular : pluralForm);
+}
+function capabilityName(capability) {
+    return {
+        types: 'type information',
+        references: 'a reference graph',
+        'python-types': 'Python type information',
+        base: 'a base revision',
+        syntax: 'a syntax tree',
+    }[capability] ?? capability;
+}
+function naturalList(values, conjunction = 'and') {
+    if (values.length < 2)
+        return values[0] ?? '';
+    if (values.length === 2)
+        return values[0] + ' ' + conjunction + ' ' + values[1];
+    return values.slice(0, -1).join(', ') + ', ' + conjunction + ' ' + values.at(-1);
+}
+function scopeDetails(record) {
+    const details = [];
+    const selected = (record.files ?? []).filter((file) => file.disposition === 'selected');
+    const unavailableGroups = new Map();
+    for (const file of selected) {
+        if (!file.unavailable?.length)
+            continue;
+        const order = ['types', 'references', 'python-types', 'base', 'syntax'];
+        const capabilities = [...new Set(file.unavailable)].sort((left, right) => {
+            const leftRank = order.indexOf(left);
+            const rightRank = order.indexOf(right);
+            return (leftRank === -1 ? order.length : leftRank) - (rightRank === -1 ? order.length : rightRank) ||
+                left.localeCompare(right);
+        });
+        const key = capabilities.join('\0');
+        const group = unavailableGroups.get(key) ?? { capabilities, count: 0 };
+        group.count++;
+        unavailableGroups.set(key, group);
+    }
+    for (const group of unavailableGroups.values()) {
+        const capabilities = naturalList(group.capabilities.map(capabilityName));
+        details.push(plural(group.count, 'reviewed file') + ' lacked ' + capabilities + '.');
+    }
+    const unavailableChecks = record.checks?.unavailable ?? [];
+    if (unavailableChecks.length > 0) {
+        const shown = unavailableChecks.slice(0, 8).map((check) => check.check);
+        const requirements = [...new Set(unavailableChecks.flatMap((check) => check.missing.split(/,\s*/)))]
+            .map(capabilityName);
+        details.push(plural(unavailableChecks.length, 'check') + ' requiring ' + naturalList(requirements, 'or') +
+            ' did not run: ' + shown.join(', ') +
+            (unavailableChecks.length > shown.length ? ', and ' + (unavailableChecks.length - shown.length) + ' more' : '') + '.');
+    }
+    const waived = new Map();
+    for (const file of record.files ?? []) {
+        if (file.disposition !== 'waived')
+            continue;
+        const reason = file.reason ?? 'unspecified reason';
+        waived.set(reason, (waived.get(reason) ?? 0) + 1);
+    }
+    for (const [reason, count] of waived) {
+        details.push(plural(count, 'changed file') + ' not reviewed: ' + reason + '.');
+    }
+    return details;
+}
+export function summarizeRun(record) {
+    const hasFiles = record.files !== undefined;
+    const hasChecks = record.checks?.ran !== undefined;
+    return {
+        state: record.state,
+        notLookedAt: [...record.notLookedAt],
+        coverage: record.coverage,
+        verifyOnly: record.engine?.verifyOnly,
+        minSeverity: record.engine?.minSeverity,
+        filesReviewed: hasFiles
+            ? record.files.filter((file) => file.disposition === 'selected').length
+            : undefined,
+        deterministicChecks: hasChecks ? new Set(record.checks.ran).size : undefined,
+        scopeDetails: scopeDetails(record),
+    };
+}
+export function noFindingsLabel(summary) {
+    const threshold = summary.minSeverity === undefined || summary.minSeverity === 'info'
+        ? ''
+        : summary.minSeverity === 'critical'
+            ? 'critical '
+            : summary.minSeverity + '-or-higher ';
+    const origin = summary.verifyOnly === true ? 'deterministic ' : '';
+    return 'No ' + threshold + origin + 'findings';
+}
+export function scopeLine(summary) {
+    const parts = [];
+    if (summary.filesReviewed !== undefined)
+        parts.push(plural(summary.filesReviewed, 'file') + ' reviewed');
+    if (summary.deterministicChecks !== undefined) {
+        parts.push(plural(summary.deterministicChecks, 'deterministic check'));
+    }
+    if (summary.coverage !== undefined)
+        parts.push(summary.coverage + ' coverage');
+    return parts.length > 0 ? parts.join(' · ') : undefined;
+}
+export function modeNote(summary, verifyOnly = 'verify-only') {
+    return summary.verifyOnly === true ? 'Model review was disabled (' + verifyOnly + ').' : undefined;
+}
+//# sourceMappingURL=summary.js.map

package/dist/report/terminal.js

@@ -1,5 +1,6 @@
 import { bold, brightRed, dim, gray, red, steel, yellow } from './ansi.js';
 import { highlight, isJsx } from './highlight.js';
+import { modeNote, noFindingsLabel, scopeLine } from './summary.js';
 const SEVERITY_COLOR = {
     critical: brightRed,
     high: red,
@@ -106,17 +107,22 @@ export function terminal(findings, opts) {
     out.push(' ' + bold('PowerShot') + dim('  ·  ' + opts.subtitle));
     out.push(rule);
     const incomplete = opts.state !== 'complete';
-    const portable = !incomplete && opts.coverage === 'portable';
+    const scope = scopeLine(opts);
+    const mode = modeNote(opts);
     if (findings.length === 0) {
         out.push('', incomplete
             ? ' ' + yellow('!') + '  No findings — but this review is ' + opts.state + ', not a verdict.'
-            : ' ' + steel('✔') + (portable ? '  No findings in portable coverage.' : '  No findings.'));
+            : ' ' + steel('✔') + '  ' + noFindingsLabel(opts) + '.');
         for (const reason of opts.notLookedAt)
             out.push(dim('    ' + reason));
-        if (portable) {
-            out.push(dim('    Portable coverage: self-contained oracles ran; enriched semantic depth was unavailable.'));
-            for (const reason of opts.unavailableCoverage ?? [])
-                out.push(dim('    ' + reason));
+        if (scope)
+            out.push(dim('    ' + scope));
+        if (mode)
+            out.push(dim('    ' + mode));
+        if ((opts.scopeDetails?.length ?? 0) > 0) {
+            out.push(dim('    ' + (opts.coverage === 'portable' ? 'Coverage details:' : 'Review scope:')));
+            for (const detail of opts.scopeDetails)
+                out.push(dim('      - ' + detail));
         }
         out.push('');
         return out.join('\n');
@@ -152,11 +158,12 @@ export function terminal(findings, opts) {
         for (const reason of opts.notLookedAt)
             out.push(dim('   ' + reason));
     }
-    else if (portable) {
-        out.push(' ' + steel('◇ portable coverage') + dim(' · enriched semantic depth was unavailable'));
-        for (const reason of opts.unavailableCoverage ?? [])
-            out.push(dim('   ' + reason));
-    }
+    if (scope)
+        out.push(' ' + steel('◇ ') + dim(scope));
+    if (mode)
+        out.push(dim('   ' + mode));
+    for (const detail of opts.scopeDetails ?? [])
+        out.push(dim('   ' + detail));
     out.push('');
     return out.join('\n');
 }

package/dist/report/viewer.js

@@ -1,20 +1,30 @@
+import { modeNote, noFindingsLabel, scopeLine } from './summary.js';
 const escape = (s) => s.replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/>/g, '&gt;').replace(/"/g, '&quot;');
 export function viewer(findings, meta) {
     const verified = findings.filter((f) => f.class === 'verified').length;
     const incomplete = meta.state !== 'complete';
-    const portable = !incomplete && meta.coverage === 'portable';
+    const scope = scopeLine(meta);
+    const mode = modeNote(meta);
     const warning = incomplete
         ? '<div class="warning"><strong>This review is ' + escape(meta.state) + ' — not a verdict.</strong>' +
             (meta.notLookedAt.length > 0
                 ? '<ul>' + meta.notLookedAt.map((reason) => '<li>' + escape(reason) + '</li>').join('') + '</ul>'
                 : '') + '</div>'
         : '';
-    const coverage = portable
-        ? '<div class="coverage"><strong>Portable coverage.</strong> Self-contained oracles ran; enriched semantic depth was unavailable.' +
-            ((meta.unavailableCoverage?.length ?? 0) > 0
-                ? '<ul>' + meta.unavailableCoverage.map((reason) => '<li>' + escape(reason) + '</li>').join('') + '</ul>'
+    const context = scope || mode || (meta.scopeDetails?.length ?? 0) > 0
+        ? '<div class="coverage">' +
+            (scope ? '<strong>' + escape(scope) + '</strong>' : '') +
+            (mode ? '<p>' + escape(mode) + '</p>' : '') +
+            ((meta.scopeDetails?.length ?? 0) > 0
+                ? '<details><summary>' + (meta.coverage === 'portable' ? 'Coverage details' : 'Review scope') + '</summary><ul>' +
+                    meta.scopeDetails.map((detail) => '<li>' + escape(detail) + '</li>').join('') +
+                    '</ul></details>'
                 : '') + '</div>'
         : '';
+    const verdict = findings.length === 0
+        ? '<p class="none">' +
+            (incomplete ? 'No findings from what completed.' : escape(noFindingsLabel(meta)) + '.') + '</p>'
+        : '';
     const rows = findings
         .map((f) => {
         const frame = f.frame
@@ -91,16 +101,15 @@ export function viewer(findings, meta) {
   <p class="meta">${escape(meta.target)} · ${escape(meta.started.slice(0, 19).replace('T', ' '))} · session ${escape(meta.id)}<br>
     ${findings.length} finding(s) — ${verified} verified, ${findings.length - verified} judged</p>
   ${warning}
-  ${coverage}
+  ${verdict}
+  ${context}
   <div class="bar">
     <button data-filter="all" aria-pressed="true">all</button>
     <button data-filter="verified" aria-pressed="false">verified</button>
     <button data-filter="judged" aria-pressed="false">judged</button>
     <button id="show-away" aria-pressed="false">show put away</button>
   </div>
-  ${findings.length === 0
-        ? '<p class="none">' + (incomplete ? 'No findings from what completed.' : portable ? 'No findings in portable coverage.' : 'No findings.') + '</p>'
-        : rows}
+  ${findings.length === 0 ? '' : rows}
 </div>
 <script>
   // Putting a finding away is per-reader and per-browser on purpose: this page is a