5htp-core 0.3.7-1 → 0.3.7-3

package/package.json

@@ -1,7 +1,7 @@
 {
 	"name": "5htp-core",
 	"description": "Convenient TypeScript framework designed for Performance and Productivity.",
-	"version": "0.3.7-1",
+	"version": "0.3.7-3",
 	"author": "Gaetan Le Gac (https://github.com/gaetanlegac)",
 	"repository": "git://github.com/gaetanlegac/5htp-core.git",
 	"license": "MIT",

package/src/server/app/index.ts

@@ -96,16 +96,20 @@ export class Application<
         // Application itself doesnt have configuration
         // Configuration must be handled by application services
         super(self, {}, {}, self);
-
-        // We can't pass this in super so we assign here
-        this.parent = this;
-        this.app = this;
-
+        
         // Handle unhandled crash
+        this.on('error', e => this.unhandledRejection(e));
+        
         process.on('unhandledRejection', (error: any, promise: any) => {
+            console.log("unhandledRejection");
             // We don't log the error here because it's the role of the app to decidehiw to log errors
             this.runHook('error', error);
         });
+
+        // We can't pass this in super so we assign here
+        this.parent = this;
+        this.app = this;
+        
     }
 
     /*----------------------------------
@@ -126,12 +130,8 @@ export class Application<
 
         console.log("Build date", BUILD_DATE);
         console.log("Core version", CORE_VERSION);
-        console.log(`5HTP Core`, process.env.npm_package_version);
         const startTime = Date.now();
 
-        // Handle errors & crashs
-        this.on('error', e => this.Console.createBugReport(e))
-
         console.info(`[boot] Start services`);
         await this.startServices();
         this.debug && console.info(`[boot] Services are ready`);
@@ -147,13 +147,6 @@ export class Application<
     public async ready() {
 
 
-    }
-
-    // Default error handler
-    public async reportBug( bug: ServerBug ) {
-
-        console.error( bug.error );
-
     }
 
     public async shutdown() {
@@ -208,6 +201,35 @@ export class Application<
                 unused.join(', '));
     }
 
+    /*----------------------------------
+    - ERROR HANDLING
+    ----------------------------------*/
+    private async unhandledRejection(rejection: Error) {
+        if (this.Console) {
+            try {
+
+                this.Console.createBugReport(rejection);
+
+            } catch (consoleError) {
+                console.error(
+                    "Unhandled rejection", rejection, 
+                    "Failed to transmiss the previous error to console:", consoleError
+                );
+                process.exit(1);
+            }
+        } else {
+            console.error("Unhandled rejection", rejection);
+            process.exit(1);
+        }
+    }
+
+    // Default error handler
+    public async reportBug( bug: ServerBug ) {
+
+        console.error( bug.error );
+
+    }
+
 }
 
 export default Application

package/src/server/app/service/index.ts

@@ -144,6 +144,7 @@ export default abstract class Service<
     // this.use immediatly instanciate the subservice for few reasons:
     // - The subservice instance can be accesses from another service in the constructor, no matter the order of loading of the services
     // - Consistency: the subserviuce proprties shouldn't be assogned to two different values according depending on the app lifecycle
+    // Don't throw errors here since process.on('unhandledRejection') has not been configurated at this step (constructor ran after properties initialization)
     public use<
         TInstalledServices extends this["app"]["servicesContainer"]["allServices"],
         TServiceId extends keyof TInstalledServices,
@@ -172,8 +173,10 @@ export default abstract class Service<
         if (registered === undefined) { 
             if (serviceUseOptions.optional)
                 return undefined;
-            else
-                throw new Error(`Unable to use service "${serviceId}": This one hasn't been setup.`);
+            else {
+                console.error(`Unable to use service "${serviceId}": This one hasn't been setup.`);
+                process.exit(1);
+            }
         }
 
         // Bind subservices
@@ -198,10 +201,11 @@ export default abstract class Service<
             ServiceClass = registered.metas.class().default;
         } catch (error) {
             console.error("Failed to get the class of the", registered.metas.id, "service:", error);
-            process.exit();
+            process.exit(1);
         }
 
         // Create class instance
+        this.config.debug && console.log(`[app] Instanciate service`, registered.metas.id);
         let service;
         try {
             service = new ServiceClass(
@@ -212,21 +216,23 @@ export default abstract class Service<
             )
         } catch (error) {
             console.error("Failed to instanciate class of the", registered.metas.id, "service:", error);
-            process.exit();
+            process.exit(1);
         }
 
         // Hande custom instance getter (ex: SQL callable class)
+        this.config.debug && console.log(`[app] Get service instance for`, registered.metas.id);
         let serviceInstance;
         try {
             serviceInstance = service.getServiceInstance();
         } catch (error) {
             console.error("Failed to get service instance for the ", registered.metas.id, "service:", error);
-            process.exit();
+            process.exit(1);
         }
 
         // Bind his own metas
         service.metas = registered.metas;
         ServicesContainer.allServices[ registered.metas.id ] = serviceInstance;
+        this.config.debug && console.log(`[app] Service`, registered.metas.id, 'Loaded');
 
         return serviceInstance;
     }
@@ -270,7 +276,7 @@ export default abstract class Service<
             await service.started.catch(e => {
                 console.error("Catched error while starting service " + serviceScope, e);
                 if (this.app.env.profile === 'prod')
-                    process.exit();
+                    process.exit(1);
                 else
                     throw e;
             })

package/src/server/services/console/index.ts

@@ -134,8 +134,13 @@ export default class Console extends Service<Config, Hooks, Application, Service
     /*----------------------------------
     - LIFECYCLE
     ----------------------------------*/
+    /*
+        WARN: This service should depend on the less services as possible, and be usable ASAP.
+            So bug reports can be sent at any state of the app, includoing thre most early
+    */
+    public constructor( parent: Application, config: Config, subservices: {}, app: Application ) {
 
-    protected async start() {
+        super(parent, config, subservices, app);
 
         const origLog = console.log
 
@@ -201,13 +206,10 @@ export default class Console extends Service<Config, Hooks, Application, Service
         setInterval(() => this.clean(), 10000);
     }
 
-    public async ready() {
-
-    }
-
-    public async shutdown() {
-
-    }
+    // Avoid to use lifecycle functions
+    protected async start() {}
+    public async ready() {}
+    public async shutdown() {}
 
     /*----------------------------------
     - LOGS FORMATTING