5-phase-workflow 2.0.5 → 2.0.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "5-phase-workflow",
-  "version": "2.0.5",
+  "version": "2.0.6",
   "description": "A dev-workflow for Claude Code and Codex",
   "bin": {
     "foifi": "bin/install.js"

package/src/commands/5/address-review-findings.md

@@ -42,9 +42,12 @@ This is the stable entrypoint after `/5:review`.
    - Invoke `/5:apply-review-findings {feature} --decisions .5/features/{feature}/review-decisions-{timestamp}.json` to apply approved local fixes.
 3. GitHub mode or user-approved PR handling:
    - Invoke `/5:triage-pr-comments {feature}` to fetch and classify compact PR comments.
+   - Parse the `---PR-TRIAGE---` block. If triage succeeded, continue even when there are zero actionable comments because duplicate, declined, or deferred comments may still need replies.
    - Ask the user for decisions on actionable/manual comments.
    - Invoke `/5:apply-review-findings {feature} --pr-approved` for approved PR fixes.
    - Invoke `/5:reply-pr-comments {feature}` to post PR replies.
+   - Parse the `---PR-REPLIES---` block and include `POSTED`, `FAILED`, and `ERRORS` in the review summary.
+   - Do not proceed to final output in GitHub mode until `/5:reply-pr-comments` has either posted replies or returned an explicit `---PR-REPLIES---` failure/partial result. Reply failures are non-fatal, but silent omission of the reply step is not allowed.
 4. Run post-fix verification. This is mandatory after any approved fix is applied.
    - Read `.5/config.json`, project run skills, and common project manifests such as `package.json`, `Makefile`, `pyproject.toml`, `Cargo.toml`, and Gradle files only as needed to identify configured commands.
    - Run every available configured command in these categories: `build`, `test`, `e2e`/`test:e2e`, and `lint`.
@@ -91,6 +94,7 @@ Review findings addressed: {yes/no}
 
 Local findings: {summary}
 PR comments: {summary}
+PR replies: {posted/failed/skipped with reason}
 Post-fix verification: {passed/failed}
 Build: {passed/failed/skipped}
 Tests: {passed/failed/skipped}

package/src/commands/5/commit.md

@@ -1,7 +1,7 @@
 ---
 name: 5:commit
 description: Create a git commit using the configured commit message template from .5/config.json.
-allowed-tools: Bash, Read, AskUserQuestion
+allowed-tools: Bash, AskUserQuestion
 user-invocable: true
 model: haiku
 argument-hint: [short-description]
@@ -17,12 +17,11 @@ You do NOT modify files. You do NOT stage unrelated changes. After reporting the
 ## Inputs
 
 - Optional short description from the command argument.
-- Configuration from `.5/config.json`:
-  - `ticket.pattern`
-  - `ticket.extractFromBranch`
-  - `git.commitMessage.pattern` (default: `{ticket-id} {short-description}`)
 
 Current branch: !`git branch --show-current 2>/dev/null || echo ""`
+Commit message pattern: !`node -e "try{const c=JSON.parse(require('fs').readFileSync('.5/config.json','utf8'));console.log(c?.git?.commitMessage?.pattern||'{ticket-id} {short-description}')}catch(e){console.log('{ticket-id} {short-description}')}" 2>/dev/null`
+Ticket pattern: !`node -e "try{const c=JSON.parse(require('fs').readFileSync('.5/config.json','utf8'));const p=c?.ticket?.pattern;console.log(p!=null?p:'(none)')}catch(e){console.log('(none)')}" 2>/dev/null`
+Extract ticket from branch: !`node -e "try{const c=JSON.parse(require('fs').readFileSync('.5/config.json','utf8'));console.log(c?.ticket?.extractFromBranch!==false)}catch(e){console.log(true)}" 2>/dev/null`
 
 ## Step 1: Inspect Changes
 
@@ -47,17 +46,15 @@ git diff --cached --name-only
 
 If nothing is staged, tell the user "No staged changes to commit." and stop.
 
-## Step 2: Load Commit Template
+## Step 2: Resolve Ticket ID
 
-Read `.5/config.json` if it exists.
+Use the injected values from the Inputs section:
 
-Determine:
+- `pattern` = injected commit message pattern.
+- `ticketPattern` = injected ticket pattern (`(none)` means no pattern configured).
+- `extractFromBranch` = injected extract-ticket-from-branch flag.
 
-1. `pattern` = `git.commitMessage.pattern`, defaulting to `{ticket-id} {short-description}`.
-2. `ticketPattern` = `ticket.pattern`, defaulting to null.
-3. `extractFromBranch` = `ticket.extractFromBranch`, defaulting to true.
-
-If `extractFromBranch` is true and `ticketPattern` is set, match `ticketPattern` against the current branch to get `{ticket-id}`. If no ticket is found, use an empty string.
+If `extractFromBranch` is true and `ticketPattern` is not `(none)`, match `ticketPattern` against the injected current branch to get `{ticket-id}`. If no match, use an empty string.
 
 ## Step 3: Get Short Description
 
@@ -86,11 +83,10 @@ Apply the configured pattern:
 Build a commit body from the staged diff when useful:
 
 - Include 1-5 bullet points summarizing meaningful changes.
+- If you know the reason for the change, for example based on the chat history, include the reason in the body.
 - Skip the body for very small or self-explanatory commits.
 - Do not include raw diff excerpts.
 
-Show the final commit message and ask for confirmation before committing.
-
 ## Step 5: Commit
 
 Create the commit using the final subject and optional body.

package/src/commands/5/reply-pr-comments.md

@@ -20,17 +20,19 @@ You are a PR Reply Poster. You post concise replies from recorded decisions and
 
 ## Process
 
-1. Read decisions and skip comments categorized as `skip`.
-2. Resolve `{owner}`, `{repo}`, and PR number.
-3. Build concise reply text:
+1. Read `.5/features/{feature}/pr-comment-decisions.json`. If it is missing or invalid, end with `STATUS: failed`, `POSTED: 0`, and a compact error. Do not claim success.
+2. Skip only comments categorized as `skip`.
+3. Resolve `{owner}`, `{repo}`, and PR number.
+4. Build concise reply text:
    - `fix`: `Applied fix: {description}. Will be included in the next push.` plus optional note.
    - `wont_fix`: `Reviewed - not addressing: {user_note or "will handle separately"}`
    - `wait`: `Noted for later: {user_note or "deferring for now"}`
    - `duplicate`: `Covered by local review findings - {local_decision}`
-4. Post replies:
+5. Post replies:
    - Inline: `gh api repos/{owner}/{repo}/pulls/{number}/comments/{comment_id}/replies --method POST --field body="{reply text}"`
    - General: `gh api repos/{owner}/{repo}/issues/{number}/comments --method POST --field body="{reply text}"`
-5. Log failures and continue. Do not abort for reply failures.
+6. Log individual post failures and continue. Do not abort for reply failures.
+7. If there are no non-skip decisions, return `STATUS: success`, `POSTED: 0`, `FAILED: 0`, and `ERRORS: none; no replyable decisions`.
 
 ## Output
 

package/src/templates/workflow/REVIEW-SUMMARY.md

@@ -38,6 +38,13 @@
 
 - {file-path} ({N} fixes applied)
 
+## PR Comment Replies
+
+- **Posted:** {N}
+- **Failed:** {N}
+- **Skipped:** {N} - {reason}
+- **Errors:** {none-or-summary}
+
 ## Post-Fix Verification
 
 - **Build:** {passed/failed/skipped} - `{command-or-none}` - {one-line summary}