5-phase-workflow 2.0.1 → 2.0.4

package/README.md

@@ -93,6 +93,7 @@ Verification runs at the end of `/5:implement` and records concise results in `s
 | `/5:split` / `$5-split` | Split an existing plan into smaller linked plans for separate implementation |
 | `/5:implement` / `$5-implement` | Derive `state.json`, execute steps with agents, and verify inline |
 | `/5:review` / `$5-review` | Review code changes and save findings |
+| `/5:commit` / `$5-commit` | Create a git commit using the configured commit message template |
 | `/5:address-review-findings` / `$5-address-review-findings` | Decide on review findings interactively, then apply approved fixes and PR comments |
 | `/5:reconfigure` / `$5-reconfigure` | Refresh docs, index, skills, and rules |
 | `/5:update` / `$5-update` | Upgrade installed workflow files |

package/bin/install.js

@@ -393,7 +393,8 @@ function getWorkflowManagedFiles() {
     skills: [
       'configure-docs-index',
       'configure-skills',
-      'generate-readme'
+      'generate-readme',
+      'use-index'
     ],
 
     // Hooks: specific hook files
@@ -881,11 +882,25 @@ function writeVersionJson(dataDir, isGlobal, version) {
   const runtimeVersions = Object.values(runtimes).map(r => r.packageVersion).filter(Boolean);
   const minVersion = runtimeVersions.reduce((min, v) => compareVersions(v, min) < 0 ? v : min, version);
 
+  // Backfill configuredAt from config.json mtime for projects that predate the field
+  let configuredAt = existing.configuredAt;
+  let configuredAtCommit = existing.configuredAtCommit;
+  if (!configuredAt) {
+    const configFile = path.join(dataDir, 'config.json');
+    if (fs.existsSync(configFile)) {
+      try {
+        configuredAt = fs.statSync(configFile).mtime.toISOString();
+      } catch (e) {}
+    }
+  }
+
   const versionData = {
     packageVersion: minVersion,
     installedAt: existing.installedAt || now,
     lastUpdated: now,
     installationType: existing.installationType || (isGlobal ? 'global' : 'local'),
+    ...(configuredAt && { configuredAt }),
+    ...(configuredAtCommit && { configuredAtCommit }),
     manifest: runtimes[activeRuntime].manifest,
     runtimes
   };
@@ -1011,6 +1026,7 @@ function showCommandsHelp(isGlobal) {
     log.info('  $5-split                     - Split plan into smaller plans');
     log.info('  $5-implement                 - Execute implementation + verification');
     log.info('  $5-review                    - Code review');
+    log.info('  $5-commit                    - Create a templated git commit');
     log.info('  $5-address-review-findings   - Decide review findings & PR comments');
     log.info('  $5-configure                 - Interactive project setup');
     log.info('  $5-reconfigure               - Refresh docs/skills (no Q&A)');
@@ -1023,6 +1039,7 @@ function showCommandsHelp(isGlobal) {
     log.info('  /5:split                     - Split plan into smaller plans');
     log.info('  /5:implement                 - Execute implementation + verification');
     log.info('  /5:review                    - Code review');
+    log.info('  /5:commit                    - Create a templated git commit');
     log.info('  /5:address-review-findings   - Decide review findings & PR comments');
     log.info('  /5:configure                 - Interactive project setup');
     log.info('  /5:reconfigure               - Refresh docs/skills (no Q&A)');

package/docs/workflow-guide.md

@@ -178,6 +178,7 @@ v2.0.0 removes old commands during upgrade:
 | `/5:discuss-feature` | Refine existing plan |
 | `/5:implement` | Implement and verify |
 | `/5:review` | Review changes |
+| `/5:commit` | Create a templated git commit |
 | `/5:address-review-findings` | Apply approved findings |
 | `/5:configure` | Create project config and CONFIGURE plan |
 | `/5:reconfigure` | Refresh generated project context |

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "5-phase-workflow",
-  "version": "2.0.1",
+  "version": "2.0.4",
   "description": "A dev-workflow for Claude Code and Codex",
   "bin": {
     "foifi": "bin/install.js"

package/src/commands/5/address-review-findings.md

@@ -45,7 +45,14 @@ This is the stable entrypoint after `/5:review`.
    - Ask the user for decisions on actionable/manual comments.
    - Invoke `/5:apply-review-findings {feature} --pr-approved` for approved PR fixes.
    - Invoke `/5:reply-pr-comments {feature}` to post PR replies.
-4. Run configured build/test/lint skills if available, or the narrowest configured commands.
+4. Run post-fix verification. This is mandatory after any approved fix is applied.
+   - Read `.5/config.json`, project run skills, and common project manifests such as `package.json`, `Makefile`, `pyproject.toml`, `Cargo.toml`, and Gradle files only as needed to identify configured commands.
+   - Run every available configured command in these categories: `build`, `test`, `e2e`/`test:e2e`, and `lint`.
+   - Prefer generated run skills when present (`run-build`, `run-tests`, `run-lint`, and any e2e/test-e2e variant). Otherwise run the exact configured command from `.5/config.json` or the project manifest.
+   - Do not skip a category because another category passed. Skip only when no command exists or the command is explicitly configured as `none`; record the reason.
+   - If any command fails, continue running remaining independent categories so the user gets a complete verification picture.
+   - Do not claim the review findings are fully addressed unless every discovered post-fix verification command passes or is explicitly skipped because no command exists.
+   - Store compact results for each category in the summary: command, status (`passed`, `failed`, or `skipped`), and a one-line reason.
 5. Write `.5/features/{feature}/review-summary-{YYYYMMDD-HHmmss}.md` using `.claude/templates/workflow/REVIEW-SUMMARY.md`.
 
 Keep all intermediate summaries compact. Do not paste raw diffs, raw PR JSON, or command logs unless a failure needs exact evidence.
@@ -80,11 +87,14 @@ Allowed `decision` values are `fix`, `wont_fix`, and `wait`.
 Output:
 
 ```text
-Review findings addressed.
+Review findings addressed: {yes/no}
 
 Local findings: {summary}
 PR comments: {summary}
+Post-fix verification: {passed/failed}
 Build: {passed/failed/skipped}
 Tests: {passed/failed/skipped}
+E2E: {passed/failed/skipped}
+Lint: {passed/failed/skipped}
 Summary saved at .5/features/{feature}/review-summary-{timestamp}.md
 ```

package/src/commands/5/analyze-feature.md

@@ -30,7 +30,7 @@ Do NOT proceed until you have a clear understanding of what to analyze.
 
 1. Derive a short kebab-case name from the analysis subject (e.g., `user-auth`, `order-processing`, `payment-integration`). This becomes the filename: `{name}-analysis.md`.
 
-2. Identify the relevant modules and layers to analyze. If `.5/index/` exists, read the index files for a quick structural overview. Otherwise, use Glob to understand the project layout.
+2. Identify the relevant modules and layers to analyze. Invoke the `use-index` skill for a quick structural overview. The skill will rebuild the index if stale; fall back to Glob only if the index is missing.
 
 3. Use Glob and Grep to locate the relevant source files. Search for key classes, interfaces, functions, and types related to the analysis subject.
 

package/src/commands/5/commit.md

@@ -0,0 +1,116 @@
+---
+name: 5:commit
+description: Create a git commit using the configured commit message template from .5/config.json.
+allowed-tools: Bash, Read, AskUserQuestion
+user-invocable: true
+model: haiku
+argument-hint: [short-description]
+---
+
+<role>
+You are a Commit Assistant. You create exactly one git commit using the project's configured commit message template.
+You do NOT modify files. You do NOT stage unrelated changes. After reporting the commit result, you are DONE.
+</role>
+
+# Commit
+
+## Inputs
+
+- Optional short description from the command argument.
+- Configuration from `.5/config.json`:
+  - `ticket.pattern`
+  - `ticket.extractFromBranch`
+  - `git.commitMessage.pattern` (default: `{ticket-id} {short-description}`)
+
+Current branch: !`git branch --show-current 2>/dev/null || echo ""`
+
+## Step 1: Inspect Changes
+
+Run:
+
+```bash
+git status --short
+```
+
+If there are no changed files, tell the user "No changes to commit." and stop.
+
+If there are staged changes, ask whether to commit the currently staged changes or adjust the staged set.
+
+If there are unstaged or untracked changes, show a concise file list and ask which files should be included. Stage only the selected files with explicit paths. Never use `git add .` or `git add -A`.
+
+After staging, run:
+
+```bash
+git diff --cached --stat
+git diff --cached --name-only
+```
+
+If nothing is staged, tell the user "No staged changes to commit." and stop.
+
+## Step 2: Load Commit Template
+
+Read `.5/config.json` if it exists.
+
+Determine:
+
+1. `pattern` = `git.commitMessage.pattern`, defaulting to `{ticket-id} {short-description}`.
+2. `ticketPattern` = `ticket.pattern`, defaulting to null.
+3. `extractFromBranch` = `ticket.extractFromBranch`, defaulting to true.
+
+If `extractFromBranch` is true and `ticketPattern` is set, match `ticketPattern` against the current branch to get `{ticket-id}`. If no ticket is found, use an empty string.
+
+## Step 3: Get Short Description
+
+If the user provided a command argument, use it as `{short-description}`.
+
+Otherwise propose a short description from the staged file names and diff stat, then ask the user to confirm or replace it.
+
+Keep `{short-description}`:
+
+- Lowercase unless the project pattern clearly uses another style.
+- Under 72 characters when possible.
+- Written as an imperative or concise noun phrase, matching existing project commits if obvious.
+
+## Step 4: Build Commit Message
+
+Apply the configured pattern:
+
+- Replace `{ticket-id}` with the extracted ticket ID or an empty string.
+- Replace `{short-description}` with the confirmed short description.
+- Trim redundant whitespace.
+- If `{ticket-id}` is empty, remove empty conventional wrappers such as `()` and tidy punctuation:
+  - `feat({ticket-id}): {short-description}` -> `feat: {short-description}`
+  - `{ticket-id}: {short-description}` -> `{short-description}`
+  - `{ticket-id} {short-description}` -> `{short-description}`
+
+Build a commit body from the staged diff when useful:
+
+- Include 1-5 bullet points summarizing meaningful changes.
+- Skip the body for very small or self-explanatory commits.
+- Do not include raw diff excerpts.
+
+Show the final commit message and ask for confirmation before committing.
+
+## Step 5: Commit
+
+Create the commit using the final subject and optional body.
+
+Use a command form that preserves newlines, for example:
+
+```bash
+git commit -m "{subject}" -m "{body}"
+```
+
+If there is no body:
+
+```bash
+git commit -m "{subject}"
+```
+
+After committing, run:
+
+```bash
+git rev-parse --short HEAD
+```
+
+Report the commit SHA and subject.

package/src/commands/5/configure.md

@@ -403,7 +403,7 @@ Analyze the codebase and generate focused documentation capturing only non-deriv
 - Fill `{PROJECT_DOCUMENTATION_LINKS}` with whichever `.5/` documentation files were created
 - Fill `{CODEBASE_INDEX_LINKS}` with `.5/index/README.md`, generated index files, and `.5/index/rebuild-index.sh`
 - Fill `{CUSTOM_DOCUMENTATION}` with preserved user-authored sections under `## Custom Documentation`; remove the placeholder if there is no custom content
-- Preserve static template sections exactly as written, including skill usage, workflow rules, coding guidelines, simplicity, testing, surgical changes, goal-driven execution, and index freshness
+- Preserve static template sections exactly as written, including skill usage, commit messages, workflow rules, coding guidelines, simplicity, testing, surgical changes, goal-driven execution, and index freshness
 
 **Create CLAUDE.md shim:**
 - Contains only `@AGENTS.md` (Claude Code include syntax)

package/src/commands/5/discuss-feature.md

@@ -111,7 +111,7 @@ Use `multiSelect: false` to get single focus area initially.
 
 Based on the user's focus area, explore the codebase if needed:
 
-**Index shortcut:** Before spawning Explore agents or running Glob/Grep, check if `.5/index/` exists. If it does, read `.5/index/README.md` first for the generation timestamp — if fresh (under 1 day old), read the relevant index files (e.g., modules.md for scope changes, routes.md for API discussions, models.md for data model questions) to quickly gather context and skip broad scanning. If outdated, inform the user they can run `.5/index/rebuild-index.sh` to refresh it. If `.5/index/` does not exist, inform the user they can run `/5:reconfigure` to generate it. In both missing/outdated cases, fall back to Glob/Grep or Explore agents for exploration.
+**Index shortcut:** Before spawning Explore agents or running Glob/Grep, invoke the `use-index` skill to quickly orient in the codebase using the generated index.
 
 **For technical constraint discussions:**
 - Search for similar implementations

package/src/commands/5/plan.md

@@ -79,6 +79,8 @@ Do not ask technical follow-ups yet.
 
 ## Step 3: Explore Codebase
 
+If `.5/index/` exists, check the `Generated:` timestamp in `.5/index/README.md`. If the index is more than one day old, run `.5/index/rebuild-index.sh` to refresh it before spawning the Explore agent.
+
 Spawn one Explore agent. In Codex, use `agent_type: explorer`, `model: gpt-5.4-mini`, and `reasoning_effort: low`.
 
 ```text
@@ -88,7 +90,7 @@ Feature description:
 {feature description}
 
 Tasks:
-1. If `.5/index/` exists, read `.5/index/README.md` first. Use only relevant fresh index files; do not rescan broad project structure. If stale, note it and fall back to targeted Grep/Glob.
+1. If `.5/index/` exists, read `.claude/skills/use-index/SKILL.md` and follow its guidance to select and read relevant index files. Skip broad project scanning. If the index is missing, fall back to targeted Grep/Glob and note it in the report.
 2. Identify relevant modules, existing patterns, and likely target files.
 3. Find at most 3 similar implementations and reusable helpers.
 4. Identify test framework, test file conventions, and the narrowest relevant build/test commands.

package/src/hooks/check-reconfig.js

@@ -38,11 +38,19 @@ function checkReconfigure(workspaceDir) {
     process.exit(0);
   }
 
-  const { configuredAt, configuredAtCommit } = versionData;
+  let { configuredAt, configuredAtCommit } = versionData;
 
-  // No configure data yet - skip (user hasn't run /5:configure)
+  // Fall back to config.json mtime when configuredAt was never recorded
   if (!configuredAt) {
-    process.exit(0);
+    const configFile = path.join(workspaceDir, '.5', 'config.json');
+    if (!fs.existsSync(configFile)) {
+      process.exit(0);
+    }
+    try {
+      configuredAt = fs.statSync(configFile).mtime.toISOString();
+    } catch (e) {
+      process.exit(0);
+    }
   }
 
   // Calculate days elapsed

package/src/hooks/statusline.js

@@ -1,6 +1,6 @@
 #!/usr/bin/env node
 // Claude Code Statusline
-// Shows: model | folder | branch | off-peak | 5hr-usage | cost | context | reset-time
+// Shows: model | folder | branch | 5hr-usage | cost | context | reset-time
 
 const fs = require('fs');
 const path = require('path');
@@ -37,17 +37,6 @@ process.stdin.on('end', () => {
       parts.push(`\x1b[32m🌿 ${branch}\x1b[0m`);
     }
 
-    // 🚀 Off-peak indicator (weekdays before 5 AM or after 11 AM PT; all weekends)
-    // PT = UTC-8 (PST) or UTC-7 (PDT). Use UTC-7 as approximation (covers PDT/PST conservatively).
-    const nowUtc = new Date();
-    const ptHour = (nowUtc.getUTCHours() - 7 + 24) % 24; // approximate PT
-    const ptDay = new Date(nowUtc.getTime() - 7 * 3600 * 1000).getUTCDay(); // 0=Sun,6=Sat
-    const isWeekend = ptDay === 0 || ptDay === 6;
-    const isPeak = !isWeekend && ptHour >= 5 && ptHour < 11;
-    if (!isPeak) {
-      parts.push('\x1b[32m🚀 off-peak\x1b[0m');
-    }
-
     // ⚡ 5-hour session usage
     const fiveHrUsed = data.rate_limits?.five_hour?.used_percentage;
     if (fiveHrUsed != null) {

package/src/skills/configure-docs-index/SKILL.md

@@ -151,7 +151,7 @@ Placeholder mapping:
 - `{CODEBASE_INDEX_LINKS}` → links to `.5/index/README.md`, generated index files, and `.5/index/rebuild-index.sh`
 - `{CUSTOM_DOCUMENTATION}` → preserved user-authored sections under `## Custom Documentation`; remove the placeholder entirely if there is no custom content
 
-Preserve the static template sections exactly as written, including skill usage, workflow rules, coding guidelines, simplicity, testing, surgical changes, goal-driven execution, and index freshness.
+Preserve the static template sections exactly as written, including skill usage, commit messages, workflow rules, coding guidelines, simplicity, testing, surgical changes, goal-driven execution, and index freshness.
 
 ### A5. Migrate and Preserve Existing Content
 

package/src/skills/use-index/SKILL.md

@@ -0,0 +1,49 @@
+---
+name: use-index
+description: Navigate the .5/index/ codebase index to quickly identify target files and understand project structure. Use before running broad Glob/Grep scans when you need to find where a feature lives, where new code should go, which routes exist, or what the data model looks like.
+allowed-tools: Read, Bash
+user-invocable: false
+---
+
+# Use Index
+
+Use `.5/index/` to orient in the codebase quickly before resorting to broad file scans.
+
+## Step 1: Check existence
+
+```bash
+ls .5/index/ 2>/dev/null
+```
+
+If the directory is missing or empty, inform the user they can run `/5:reconfigure` to generate it, then fall back to Glob/Grep.
+
+## Step 2: Read the manifest
+
+Read `.5/index/README.md`. It lists every generated index file, its purpose, and the generation timestamp.
+
+## Step 3: Check freshness
+
+Look for the `Generated:` timestamp in README.md.
+
+- **Fresh (≤ 1 day):** proceed with the index.
+- **Stale (> 1 day):** run `.5/index/rebuild-index.sh` to rebuild it, then proceed with the refreshed index.
+
+## Step 4: Read only the relevant file(s)
+
+Pick the file that matches the task. Skip unrelated ones.
+
+| Task | File |
+|------|------|
+| Where does new code go / what modules exist? | `modules.md` |
+| API surface, HTTP routes, or handlers | `routes.md` |
+| Data models, schemas, or migrations | `models.md` |
+| Shared helpers, utilities, or exported functions | `libraries.md` |
+| Build, run, test, or dev-workflow commands | `commands.md` |
+
+## Step 5: Interpret entries
+
+Each file has compact entries — path plus a short descriptor (HTTP method, exported name, key field, etc.). Use them to identify target files directly. Do not read the full index file if a handful of entries answer the question.
+
+## Step 6: Fall back gracefully
+
+If a file is too sparse or an area is missing from the index, note the gap and fall back to a targeted Grep/Glob for that area only. Do not re-scan sections already covered by a fresh index entry.

package/src/templates/AGENTS.md

@@ -12,6 +12,10 @@ Before implementing changes, always check the available skills for relevant impl
 
 Use skills to understand project-specific workflows, commands, testing expectations, and implementation conventions before editing code.
 
+## Commit Messages
+
+Use the `/5:commit` command or `$5-commit` skill when creating commits. It reads `.5/config.json` and applies the configured `git.commitMessage.pattern`, including ticket IDs from branch names when configured.
+
 ## Workflow Rules
 
 When running `/5:` workflow commands, follow the command instructions exactly as written.
@@ -87,8 +91,6 @@ Strong success criteria let you loop independently. Weak criteria ("make it work
 
 {CODEBASE_INDEX_LINKS}
 
-## Index Freshness
-
-If the codebase index files are more than one day old, regenerate them by running `.5/index/rebuild-index.sh` before relying on them.
+Use the `use-index` skill before running broad Glob/Grep scans. It handles freshness checks, file selection by task type, and fallback strategies. If index files are more than one day old, regenerate them by running `.5/index/rebuild-index.sh` before relying on them.
 
 {CUSTOM_DOCUMENTATION}

package/src/templates/workflow/REVIEW-SUMMARY.md

@@ -37,4 +37,10 @@
 ## Files Modified
 
 - {file-path} ({N} fixes applied)
-- {file-path} ({N} fixes applied)
+
+## Post-Fix Verification
+
+- **Build:** {passed/failed/skipped} - `{command-or-none}` - {one-line summary}
+- **Tests:** {passed/failed/skipped} - `{command-or-none}` - {one-line summary}
+- **E2E:** {passed/failed/skipped} - `{command-or-none}` - {one-line summary}
+- **Lint:** {passed/failed/skipped} - `{command-or-none}` - {one-line summary}