5-phase-workflow 1.0.1 → 1.1.0

package/src/commands/5/verify-implementation.md

@@ -24,17 +24,32 @@ This skill provides comprehensive verification of a completed feature implementa
 
 ### Step 1: Load Implementation Plan
 
-Read the implementation plan from `.5/{feature-name}/plan.md` where `{feature-name}` is the argument provided by the user.
+Read the implementation plan from `.5/{feature-name}/plan/` where `{feature-name}` is the argument provided by the user.
 
-**Error Handling:** If the plan file is missing or unreadable:
+**Error Handling:** If the plan directory is missing:
 - Return fail status immediately
-- Display clear error message: "Error: Implementation plan not found at `.5/{feature-name}/plan.md`. Please run /plan-implementation first."
+- Display clear error message: "Error: Implementation plan not found at `.5/{feature-name}/plan/`. Please run /5:plan-implementation first."
 - Do not proceed to Step 2
 
-Extract:
-- Component checklist (all expected files)
-- Affected modules
-- Test modules
+**Load metadata:**
+- Read `.5/{feature-name}/plan/meta.md`
+- Parse YAML frontmatter for basic plan info
+
+**Load verification config:**
+- Read `.5/{feature-name}/plan/verification.md`
+- Extract:
+  - `build_command`
+  - `test_command`
+  - Expected New Files list
+  - Expected Modified Files list
+  - Build Targets list
+  - Test Modules list
+
+**Load component checklist (aggregate from all step files):**
+- For each step (1 to total_steps from meta.md):
+  - Read `.5/{feature-name}/plan/step-{N}.md`
+  - Extract "Expected Outputs" section (files created/modified)
+- Build comprehensive expected files list to pass to verification-agent
 
 ### Step 2: Spawn verification-agent
 
@@ -52,15 +67,20 @@ Task tool call:
     ## Your Task
 
     Feature Name: {feature-name}
-    Implementation Plan Path: .5/{feature-name}/plan.md
+    Implementation Plan Path: .5/{feature-name}/plan/
     Expected Files:
     - {path/to/file1.ext}
     - {path/to/file2.ext}
+    (aggregated from all step files in Step 1)
     Affected Modules:
     - {module-path-1}
     - {module-path-2}
+    (from verification.md)
     Test Modules:
     - {module-path-for-tests}
+    (from verification.md)
+    Build Command: {from verification.md}
+    Test Command: {from verification.md}
 ```
 
 ### Step 3: Process Agent Results
@@ -132,7 +152,10 @@ All checks completed successfully:
 
 Verification report: .5/{feature-name}/verification.md
 
-Ready to commit and create pull request!
+Next steps:
+1. Commit your changes (recommended before code review)
+2. Run `/clear` to reset context
+3. Run `/5:review-code` for CodeRabbit review
 ```
 
 **If PASSED WITH WARNINGS:**
@@ -152,7 +175,10 @@ See warnings in verification report:
 
 You may address warnings before committing, but they don't block completion.
 
-Ready to commit!
+Next steps:
+1. Commit your changes (recommended before code review)
+2. Run `/clear` to reset context
+3. Run `/5:review-code` for CodeRabbit review
 ```
 
 **If FAILED:**
@@ -191,9 +217,10 @@ It's recommended to commit changes before running CodeRabbit review (/review-cod
 - Create commit using the standard commit message format below
 - Stage all relevant files
 - Create commit with proper message format
+- After committing, tell user: "Changes committed. Next steps: Run `/clear` followed by `/5:review-code` for CodeRabbit review."
 
 **If user selects "No":**
-- Tell user: "You can commit the changes manually when ready. After committing, run `/review-code` for CodeRabbit review."
+- Tell user: "You can commit the changes manually when ready. After committing, run `/clear` followed by `/5:review-code` for CodeRabbit review."
 
 #### Commit Message Format
 
@@ -232,8 +259,11 @@ EOF
 
 ## Instructions Summary
 
-1. **Load implementation plan** from `.5/{feature-name}/plan.md`
-2. **Spawn verification-agent** with expected files, modules, and test modules
+1. **Load implementation plan** from `.5/{feature-name}/plan/`:
+   - Read meta.md for plan metadata
+   - Read verification.md for build/test config and targets
+   - Aggregate expected files from all step-N.md files
+2. **Spawn verification-agent** with aggregated expected files, modules, and test modules
 3. **Process agent results** - extract status, report, and structured data
 4. **Save verification report** to state directory
 5. **Update state file** with verification results

package/src/hooks/check-updates.js

@@ -0,0 +1,105 @@
+#!/usr/bin/env node
+
+const fs = require('fs');
+const path = require('path');
+
+// Read stdin (Claude Code passes JSON)
+let inputData = '';
+process.stdin.on('data', (chunk) => {
+  inputData += chunk;
+});
+
+process.stdin.on('end', () => {
+  try {
+    // Parse hook input (contains workspace info)
+    const hookData = JSON.parse(inputData);
+    const workspaceDir = hookData.workingDirectory || process.cwd();
+
+    checkForUpdates(workspaceDir);
+  } catch (e) {
+    // Silent failure - don't block on errors
+    process.exit(0);
+  }
+});
+
+function checkForUpdates(workspaceDir) {
+  const versionFile = path.join(workspaceDir, '.claude', '.5', 'version.json');
+
+  // Check if version.json exists
+  if (!fs.existsSync(versionFile)) {
+    // Not installed or legacy install - skip
+    process.exit(0);
+  }
+
+  let versionData;
+  try {
+    versionData = JSON.parse(fs.readFileSync(versionFile, 'utf8'));
+  } catch (e) {
+    // Corrupted file - skip
+    process.exit(0);
+  }
+
+  // Check if we should run (daily frequency)
+  const now = Date.now();
+  const lastCheck = versionData.updateCheckLastRun
+    ? new Date(versionData.updateCheckLastRun).getTime()
+    : 0;
+  const frequency = (versionData.updateCheckFrequency || 86400) * 1000; // Convert to ms
+
+  if (now - lastCheck < frequency) {
+    // Checked recently, skip
+    process.exit(0);
+  }
+
+  // Update last check time
+  versionData.updateCheckLastRun = new Date().toISOString();
+  fs.writeFileSync(versionFile, JSON.stringify(versionData, null, 2));
+
+  // Compare versions
+  const installed = versionData.installedVersion;
+  const packageVersion = getPackageVersion(workspaceDir);
+
+  if (!packageVersion || installed === packageVersion) {
+    // No update available
+    process.exit(0);
+  }
+
+  // Check if update is available (installed < package)
+  if (compareVersions(installed, packageVersion) < 0) {
+    // Show update notification
+    console.log(`\n\x1b[34mℹ\x1b[0m Update available: ${installed} → ${packageVersion}`);
+    console.log(`  Run: \x1b[1mnpx 5-phase-workflow --upgrade\x1b[0m\n`);
+  }
+
+  process.exit(0);
+}
+
+// Get package version from local package.json
+function getPackageVersion(workspaceDir) {
+  // Try to find package.json in node_modules/5-phase-workflow
+  const pkgPath = path.join(workspaceDir, 'node_modules', '5-phase-workflow', 'package.json');
+
+  if (fs.existsSync(pkgPath)) {
+    try {
+      const pkg = JSON.parse(fs.readFileSync(pkgPath, 'utf8'));
+      return pkg.version;
+    } catch (e) {
+      return null;
+    }
+  }
+
+  return null;
+}
+
+// Compare semver versions
+function compareVersions(v1, v2) {
+  const parts1 = v1.split('.').map(Number);
+  const parts2 = v2.split('.').map(Number);
+
+  for (let i = 0; i < 3; i++) {
+    if (parts1[i] > parts2[i]) return 1;
+    if (parts1[i] < parts2[i]) return -1;
+  }
+
+  return 0;
+}

package/src/settings.json

@@ -2,5 +2,8 @@
   "statusLine": {
     "type": "command",
     "command": "node .claude/hooks/statusline.js"
+  },
+  "hooks": {
+    "onCommandStart": "node .claude/hooks/check-updates.js"
   }
 }