4runr-os 2.0.27 → 2.0.31

package/dist/ui/v3/commands/commandEngine.js

@@ -2020,7 +2020,7 @@ async function handleDebug(ctx, args) {
                     ts: Date.now(),
                     tag: 'ERR',
                     level: 'ERROR',
-                    msg: 'Usage: debug <ui|geo|resize|resize-test|resize-trace|dump-layout|listeners|stdout>',
+                    msg: 'Usage: debug <ui|geo|resize|resize-test|resize-torture|resize-trace|dump-layout|listeners|stdout>',
                 }],
         };
     }
@@ -2363,6 +2363,272 @@ async function handleDebug(ctx, args) {
             ];
             return { events };
         }
+        else if (subcommand === 'resize-torture' || subcommand === 'torture') {
+            // Resize torture test - comprehensive widget duplication detection
+            const { getUIRuntime } = await import('../ui/uiRuntime.js');
+            const runtime = getUIRuntime();
+            const screen = runtime.screen;
+            const widgets = runtime.widgets;
+            // Get current dimensions
+            const { getTerminalGeometry } = await import('../tui/geometry.js');
+            const geo = getTerminalGeometry(screen);
+            // Count all widgets recursively
+            function countWidgets(node, depth = 0) {
+                const result = { total: 0, byType: {}, byId: {} };
+                if (!node)
+                    return result;
+                result.total = 1;
+                // Track by type
+                const type = node.type || 'unknown';
+                result.byType[type] = (result.byType[type] || 0) + 1;
+                // Track by ID (if available)
+                const id = node.options?.id || node._id || 'no-id';
+                result.byId[id] = (result.byId[id] || 0) + 1;
+                // Recursively count children
+                if (node.children && Array.isArray(node.children)) {
+                    for (const child of node.children) {
+                        const childResult = countWidgets(child, depth + 1);
+                        result.total += childResult.total;
+                        // Merge byType
+                        for (const [t, count] of Object.entries(childResult.byType)) {
+                            result.byType[t] = (result.byType[t] || 0) + count;
+                        }
+                        // Merge byId
+                        for (const [i, count] of Object.entries(childResult.byId)) {
+                            result.byId[i] = (result.byId[i] || 0) + count;
+                        }
+                    }
+                }
+                return result;
+            }
+            const widgetStats = countWidgets(screen);
+            // Check for duplicates
+            const duplicateTypes = [];
+            for (const [type, count] of Object.entries(widgetStats.byType)) {
+                if (count > 1 && type !== 'box' && type !== 'text' && type !== 'line') {
+                    duplicateTypes.push(`${type}=${count}`);
+                }
+            }
+            const duplicateIds = [];
+            for (const [id, count] of Object.entries(widgetStats.byId)) {
+                if (count > 1 && id !== 'no-id') {
+                    duplicateIds.push(`${id}=${count}`);
+                }
+            }
+            // Count specific widgets
+            const postureCount = widgetStats.byType['box'] || 0; // Approximate
+            const commandLineCount = screen.children.filter((w) => w === widgets.commandLine).length;
+            // Get resize stats
+            const resizeStats = debugUtils.getResizeStats();
+            const events = [
+                cmdEvent,
+                {
+                    id: `dbg-torture-1-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'INFO',
+                    msg: `=== RESIZE TORTURE TEST ===`,
+                },
+                {
+                    id: `dbg-torture-2-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'INFO',
+                    msg: `Instructions: Toggle fullscreen ↔ windowed 10 times, then run this again.`,
+                },
+                {
+                    id: `dbg-torture-3-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'INFO',
+                    msg: ``,
+                },
+                {
+                    id: `dbg-torture-4-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'INFO',
+                    msg: `Current terminal: ${geo.cols}x${geo.rows} (source: ${geo.source})`,
+                },
+                {
+                    id: `dbg-torture-5-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'INFO',
+                    msg: ``,
+                },
+                {
+                    id: `dbg-torture-6-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'INFO',
+                    msg: `--- Widget Counts ---`,
+                },
+                {
+                    id: `dbg-torture-7-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'INFO',
+                    msg: `Total widgets: ${widgetStats.total} (should be stable ~8-15)`,
+                },
+                {
+                    id: `dbg-torture-8-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'INFO',
+                    msg: `Screen.children: ${screen.children.length}`,
+                },
+                {
+                    id: `dbg-torture-9-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'INFO',
+                    msg: `Command line instances: ${commandLineCount} (must be 1)`,
+                },
+                {
+                    id: `dbg-torture-10-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'INFO',
+                    msg: ``,
+                },
+                {
+                    id: `dbg-torture-11-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'INFO',
+                    msg: `--- Widget Types ---`,
+                },
+            ];
+            // Add widget type counts
+            for (const [type, count] of Object.entries(widgetStats.byType)) {
+                events.push({
+                    id: `dbg-torture-type-${type}-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'INFO',
+                    msg: `  ${type}: ${count}`,
+                });
+            }
+            events.push({
+                id: `dbg-torture-12-${Date.now()}`,
+                ts: Date.now(),
+                tag: 'DBG',
+                level: 'INFO',
+                msg: ``,
+            });
+            events.push({
+                id: `dbg-torture-13-${Date.now()}`,
+                ts: Date.now(),
+                tag: 'DBG',
+                level: 'INFO',
+                msg: `--- Resize Stats ---`,
+            });
+            events.push({
+                id: `dbg-torture-14-${Date.now()}`,
+                ts: Date.now(),
+                tag: 'DBG',
+                level: 'INFO',
+                msg: `Resize events: ${resizeStats.eventCount}`,
+            });
+            events.push({
+                id: `dbg-torture-15-${Date.now()}`,
+                ts: Date.now(),
+                tag: 'DBG',
+                level: 'INFO',
+                msg: `Resize applies: ${resizeStats.applyCount}`,
+            });
+            events.push({
+                id: `dbg-torture-16-${Date.now()}`,
+                ts: Date.now(),
+                tag: 'DBG',
+                level: 'INFO',
+                msg: `UI rebuilds: ${resizeStats.uiRebuildCount || 0} (must be 0)`,
+            });
+            events.push({
+                id: `dbg-torture-17-${Date.now()}`,
+                ts: Date.now(),
+                tag: 'DBG',
+                level: 'INFO',
+                msg: ``,
+            });
+            events.push({
+                id: `dbg-torture-18-${Date.now()}`,
+                ts: Date.now(),
+                tag: 'DBG',
+                level: duplicateTypes.length > 0 ? 'ERROR' : 'INFO',
+                msg: `--- Duplication Check ---`,
+            });
+            if (duplicateTypes.length > 0) {
+                events.push({
+                    id: `dbg-torture-19-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'ERROR',
+                    msg: `⚠ FAIL: Duplicate widget types detected: ${duplicateTypes.join(', ')}`,
+                });
+            }
+            else {
+                events.push({
+                    id: `dbg-torture-19-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'INFO',
+                    msg: `✓ PASS: No duplicate widget types`,
+                });
+            }
+            if (commandLineCount > 1) {
+                events.push({
+                    id: `dbg-torture-20-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'ERROR',
+                    msg: `⚠ FAIL: Multiple command lines (${commandLineCount})`,
+                });
+            }
+            else {
+                events.push({
+                    id: `dbg-torture-20-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'INFO',
+                    msg: `✓ PASS: Single command line`,
+                });
+            }
+            if ((resizeStats.uiRebuildCount || 0) > 0) {
+                events.push({
+                    id: `dbg-torture-21-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'ERROR',
+                    msg: `⚠ FAIL: UI was rebuilt ${resizeStats.uiRebuildCount} times (should be 0)`,
+                });
+            }
+            else {
+                events.push({
+                    id: `dbg-torture-21-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'INFO',
+                    msg: `✓ PASS: No UI rebuilds`,
+                });
+            }
+            events.push({
+                id: `dbg-torture-22-${Date.now()}`,
+                ts: Date.now(),
+                tag: 'DBG',
+                level: 'INFO',
+                msg: ``,
+            });
+            events.push({
+                id: `dbg-torture-23-${Date.now()}`,
+                ts: Date.now(),
+                tag: 'DBG',
+                level: 'INFO',
+                msg: `=== END TORTURE TEST ===`,
+            });
+            return { events };
+        }
         else if (subcommand === 'resize-trace' || subcommand === 'trace-resize') {
             // Resize trace mode toggle
             const { setResizeTraceEnabled, getResizeTraceEnabled } = await import('../ui/phase1RuntimeClean.js');
@@ -2477,7 +2743,11 @@ async function handleDebug(ctx, args) {
             const stdoutRows = process.stdout.rows ?? 'N/A';
             const stderrCols = process.stderr.columns ?? 'N/A';
             const stderrRows = process.stderr.rows ?? 'N/A';
-            // Compute layout to get metadata
+            // Get actual geometry being used (authoritative source)
+            const { getTerminalGeometry, getTerminalSize } = await import('../tui/geometry.js');
+            const actualSize = getTerminalSize(screen);
+            const actualGeo = getTerminalGeometry(screen);
+            // Compute layout to get metadata (pass fresh screen to use current geometry)
             const layoutResult = computePhase1Layout(screen.width ?? 80, screen.height ?? 24, screen);
             const events = [
                 cmdEvent,
@@ -2551,60 +2821,122 @@ async function handleDebug(ctx, args) {
                     level: 'INFO',
                     msg: `  process.stderr.rows: ${stderrRows}`,
                 },
+                {
+                    id: `dbg-fullscreen-11-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'INFO',
+                    msg: ``,
+                },
+                {
+                    id: `dbg-fullscreen-12-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'INFO',
+                    msg: `C. GEOMETRY USED (authoritative):`,
+                },
+                {
+                    id: `dbg-fullscreen-13-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'INFO',
+                    msg: `  getTerminalSize() source: ${actualSize.source}`,
+                },
+                {
+                    id: `dbg-fullscreen-14-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'INFO',
+                    msg: `  getTerminalSize() cols: ${actualSize.cols}`,
+                },
+                {
+                    id: `dbg-fullscreen-15-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'INFO',
+                    msg: `  getTerminalSize() rows: ${actualSize.rows}`,
+                },
+                {
+                    id: `dbg-fullscreen-16-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'INFO',
+                    msg: `  getTerminalGeometry() safeCols: ${actualGeo.safeCols}`,
+                },
+                {
+                    id: `dbg-fullscreen-17-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'INFO',
+                    msg: `  getTerminalGeometry() safeRows: ${actualGeo.safeRows}`,
+                },
+                {
+                    id: `dbg-fullscreen-18-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'INFO',
+                    msg: `  Terminal mode: ${actualGeo.mode}`,
+                },
             ];
             // Add layout metadata if available
             if (layoutResult.ok && layoutResult.metadata) {
                 const m = layoutResult.metadata;
                 events.push({
-                    id: `dbg-fullscreen-11-${Date.now()}`,
+                    id: `dbg-fullscreen-19-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'DBG',
+                    level: 'INFO',
+                    msg: ``,
+                }, {
+                    id: `dbg-fullscreen-20-${Date.now()}`,
                     ts: Date.now(),
                     tag: 'DBG',
                     level: 'INFO',
                     msg: `B. LAYOUT METADATA (what layout is using):`,
                 }, {
-                    id: `dbg-fullscreen-12-${Date.now()}`,
+                    id: `dbg-fullscreen-21-${Date.now()}`,
                     ts: Date.now(),
                     tag: 'DBG',
                     level: 'INFO',
-                    msg: `  layout.colsUsed: ${m.colsUsed}`,
+                    msg: `  layout.colsUsed: ${m.colsUsed} (should match safeCols or be close)`,
                 }, {
-                    id: `dbg-fullscreen-13-${Date.now()}`,
+                    id: `dbg-fullscreen-22-${Date.now()}`,
                     ts: Date.now(),
                     tag: 'DBG',
                     level: 'INFO',
-                    msg: `  layout.rowsUsed: ${m.rowsUsed}`,
+                    msg: `  layout.rowsUsed: ${m.rowsUsed} (should match safeRows or be close)`,
                 }, {
-                    id: `dbg-fullscreen-14-${Date.now()}`,
+                    id: `dbg-fullscreen-23-${Date.now()}`,
                     ts: Date.now(),
                     tag: 'DBG',
                     level: 'INFO',
                     msg: `  layout.availableWidth: ${m.availableWidth}`,
                 }, {
-                    id: `dbg-fullscreen-15-${Date.now()}`,
+                    id: `dbg-fullscreen-24-${Date.now()}`,
                     ts: Date.now(),
                     tag: 'DBG',
                     level: 'INFO',
                     msg: `  layout.availableHeight: ${m.availableHeight}`,
                 }, {
-                    id: `dbg-fullscreen-16-${Date.now()}`,
+                    id: `dbg-fullscreen-25-${Date.now()}`,
                     ts: Date.now(),
                     tag: 'DBG',
                     level: 'INFO',
                     msg: `  layout.gutters: ${m.gutters}`,
                 }, {
-                    id: `dbg-fullscreen-17-${Date.now()}`,
+                    id: `dbg-fullscreen-26-${Date.now()}`,
                     ts: Date.now(),
                     tag: 'DBG',
                     level: 'INFO',
-                    msg: `  layout.margins: ${m.margins}`,
+                    msg: `  layout.margins: ${m.margins} (browser=${actualGeo.mode === 'browser' ? 'yes' : 'no'})`,
                 }, {
-                    id: `dbg-fullscreen-18-${Date.now()}`,
+                    id: `dbg-fullscreen-27-${Date.now()}`,
                     ts: Date.now(),
                     tag: 'DBG',
                     level: 'INFO',
                     msg: `  layout.minCols: ${m.minCols}`,
                 }, {
-                    id: `dbg-fullscreen-19-${Date.now()}`,
+                    id: `dbg-fullscreen-28-${Date.now()}`,
                     ts: Date.now(),
                     tag: 'DBG',
                     level: 'INFO',
@@ -2613,13 +2945,39 @@ async function handleDebug(ctx, args) {
             }
             else {
                 events.push({
-                    id: `dbg-fullscreen-11-${Date.now()}`,
+                    id: `dbg-fullscreen-19-${Date.now()}`,
+                    ts: Date.now(),
+                    tag: 'ERR',
+                    level: 'ERROR',
+                    msg: ``,
+                }, {
+                    id: `dbg-fullscreen-20-${Date.now()}`,
                     ts: Date.now(),
                     tag: 'ERR',
                     level: 'ERROR',
                     msg: `B. LAYOUT ERROR: ${layoutResult.errorMessage || 'Layout computation failed'}`,
                 });
             }
+            // Add diagnostic summary
+            events.push({
+                id: `dbg-fullscreen-summary-${Date.now()}`,
+                ts: Date.now(),
+                tag: 'DBG',
+                level: 'INFO',
+                msg: ``,
+            }, {
+                id: `dbg-fullscreen-summary2-${Date.now()}`,
+                ts: Date.now(),
+                tag: 'DBG',
+                level: 'INFO',
+                msg: `DIAGNOSTIC: If cols/rows DON'T change in fullscreen → Windows Terminal settings (font/padding).`,
+            }, {
+                id: `dbg-fullscreen-summary3-${Date.now()}`,
+                ts: Date.now(),
+                tag: 'DBG',
+                level: 'INFO',
+                msg: `If cols/rows DO change but colsUsed stays small → layout clamping bug (check code).`,
+            });
             events.push({
                 id: `dbg-fullscreen-end-${Date.now()}`,
                 ts: Date.now(),
@@ -2662,7 +3020,7 @@ async function handleDebug(ctx, args) {
                         ts: Date.now(),
                         tag: 'ERR',
                         level: 'ERROR',
-                        msg: `Unknown debug subcommand: ${subcommand} (try: ui, geo, resize, resize-test, resize-trace, dump-layout, fullscreen, listeners, stdout)`,
+                        msg: `Unknown debug subcommand: ${subcommand} (try: ui, geo, resize, resize-test, resize-torture, resize-trace, dump-layout, fullscreen, listeners, stdout)`,
                     }],
             };
         }