zypper-upgraderepo 1.8.1 → 1.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d116f5a4bc48c8b1da11927d247371609f1e4c8677f28639b1c116443291c572
-  data.tar.gz: 9e2453092548ec2c01d07470ccbc7f0a25e6453dff4562f01875c84cab88372c
+  metadata.gz: 32ebc8e9633b6f8316573b56759c1044bd9db702cd4a2289508665420935e054
+  data.tar.gz: 89effc0e8a22e7f1019a2ac29337e5882b518f1c0de9dc7844b72cac0fa36608
 SHA512:
-  metadata.gz: e4ffc00d5bea5c8db5c08462484e05828cb39a8bd872c968aa4df94f2d090d54002819e263b1a073727d0ac72c9a8f07c8c7c155eedbb0776ba601affa7ea1c0
-  data.tar.gz: cf3c277471a5f2e90ff213cc0bd0017da3a766d22b6e9ba9b0dcfaf0decc7154fa13697111219bf24a7211b7e70e7a1974c578903037f1254470ad75479b5d3e
+  metadata.gz: 36dcbddb43e6ec7ede6aace2f03f2ed2be72c0e870c54252cbeec70c0715daf91d88bd3868e9936b3f60d77ced08df655987428fcc13bb15d3fc094913e8ee47
+  data.tar.gz: 10bb399234182d2705e9e498891d67c3727a5f4de68ef40166451e3e9dfd4275cb3fe788fa83254917172f18baf7921d5909c7331a659c9d7e4104ed066f6ebf

data/.rubocop.yml

@@ -0,0 +1,80 @@
+AllCops:
+  TargetRubyVersion: 2.5
+  NewCops: enable
+  SuggestExtensions: false
+
+Style/ClassVars:
+  Enabled: false
+
+Style/StringLiterals:
+  Enabled: true
+  EnforcedStyle: double_quotes
+
+Style/StringLiteralsInInterpolation:
+  Enabled: true
+  EnforcedStyle: double_quotes
+
+Layout/LineLength:
+  Max: 120
+
+Naming/FileName:
+  Enabled: false
+
+Metrics/MethodLength:
+  Enabled: false
+
+Metrics/AbcSize:
+  Enabled: false
+
+Lint/DuplicateBranch:
+  Enabled: false
+
+Metrics/ClassLength:
+  Enabled: true
+  Exclude:
+  - './lib/**/cli.rb'
+  - './lib/**/repository.rb'
+  - './lib/**/upgraderepo.rb'
+
+Metrics/BlockLength:
+  Enabled: true
+  Exclude:
+  - '*.gemspec'
+  - './lib/**/cli.rb'
+  - './lib/**/repository.rb'
+  - './spec/**/*'
+
+Metrics/PerceivedComplexity:
+  Enabled: true
+  Exclude:
+  - './lib/**/upgraderepo.rb'
+  - './lib/**/repository.rb'
+  - './lib/**/view.rb'
+  - './lib/**/traversable.rb'
+
+Metrics/CyclomaticComplexity:
+  Enabled: true
+  Exclude:
+  - './lib/**/upgraderepo.rb'
+  - './lib/**/repository.rb'
+  - './lib/**/view.rb'
+  - './lib/**/traversable.rb'
+
+Lint/UriEscapeUnescape:
+  Enabled: false
+
+Lint/UnusedMethodArgument:
+  Enabled: true
+  Exclude:
+  - './lib/**/local.rb'
+
+Style/MixinUsage:
+  Enabled: true
+  Exclude:
+  - './spec/**/*'
+
+Style/FrozenStringLiteralComment:
+  Enabled: true
+  Exclude:
+  - './bin/*'
+  - './exe/*'

data/Gemfile

@@ -1,6 +1,18 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org"
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in zypper-upgraderepo.gemspec
 gemspec
+
+gem "rake", "~> 13.0"
+
+gem "rspec", "~> 3.0"
+
+gem "rubocop", "~> 1.21"
+
+gem "rubocop-rake", "~> 0.6.0"
+
+gem "rubocop-rspec", "~> 2.18"

data/Gemfile.lock

@@ -1,30 +1,63 @@
 PATH
   remote: .
   specs:
-    zypper-upgraderepo (1.8.0)
+    zypper-upgraderepo (1.10.0)
       iniparse
       minitar
 
 GEM
   remote: https://rubygems.org/
   specs:
-    diff-lcs (1.5.0)
+    ast (2.4.2)
+    diff-lcs (1.5.1)
     iniparse (1.5.0)
+    json (2.7.2)
     minitar (0.9)
-    rake (13.0.6)
-    rspec (3.12.0)
-      rspec-core (~> 3.12.0)
-      rspec-expectations (~> 3.12.0)
-      rspec-mocks (~> 3.12.0)
-    rspec-core (3.12.0)
-      rspec-support (~> 3.12.0)
-    rspec-expectations (3.12.2)
+    parallel (1.24.0)
+    parser (3.3.2.0)
+      ast (~> 2.4.1)
+      racc
+    racc (1.8.0)
+    rainbow (3.1.1)
+    rake (13.2.1)
+    regexp_parser (2.9.2)
+    rexml (3.3.0)
+      strscan
+    rspec (3.13.0)
+      rspec-core (~> 3.13.0)
+      rspec-expectations (~> 3.13.0)
+      rspec-mocks (~> 3.13.0)
+    rspec-core (3.13.0)
+      rspec-support (~> 3.13.0)
+    rspec-expectations (3.13.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.12.0)
-    rspec-mocks (3.12.3)
+      rspec-support (~> 3.13.0)
+    rspec-mocks (3.13.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.12.0)
-    rspec-support (3.12.0)
+      rspec-support (~> 3.13.0)
+    rspec-support (3.13.1)
+    rubocop (1.50.2)
+      json (~> 2.3)
+      parallel (~> 1.10)
+      parser (>= 3.2.0.0)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.28.0, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.30.0)
+      parser (>= 3.2.1.0)
+    rubocop-capybara (2.18.0)
+      rubocop (~> 1.41)
+    rubocop-rake (0.6.0)
+      rubocop (~> 1.0)
+    rubocop-rspec (2.20.0)
+      rubocop (~> 1.33)
+      rubocop-capybara (~> 2.17)
+    ruby-progressbar (1.13.0)
+    strscan (3.1.0)
+    unicode-display_width (2.5.0)
 
 PLATFORMS
   ruby
@@ -33,6 +66,9 @@ DEPENDENCIES
   bundler (~> 2.0)
   rake (~> 13.0)
   rspec (~> 3.0)
+  rubocop (~> 1.21)
+  rubocop-rake (~> 0.6.0)
+  rubocop-rspec (~> 2.18)
   zypper-upgraderepo!
 
 BUNDLED WITH

data/README.md

@@ -6,6 +6,9 @@ when possible.
 
 It can be also be installed as Zypper plugin using the [Zypper Upgraderepo Plugin][zypper_upgraderepo_plugin].
 
+[![Ruby](https://github.com/fabiomux/zypper-upgraderepo/actions/workflows/main.yml/badge.svg)][wf_main]
+[![Gem Version](https://badge.fury.io/rb/zypper-upgraderepo.svg)][gem_version]
+
 ## Installation
 
 There are a couple of options to install this application.
@@ -69,3 +72,5 @@ More info is available at:
 [project_page]: https://freeaptitude.altervista.org/projects/zypper-upgraderepo.html "Zypper-Upgraderepo project page"
 [zypper_upgraderepo_wiki]: https://github.com/fabiomux/zypper-upgraderepo/wiki "Zypper-Upgraderepo wiki page on GitHub"
 [upgrading_with_zypper]: https://freeaptitude.altervista.org/articles/upgrading-opensuse-with-zypper.html "Upgrading openSUSE with Zypper"
+[wf_main]: https://github.com/fabiomux/zypper-upgraderepo/actions/workflows/main.yml
+[gem_version]: https://badge.fury.io/rb/zypper-upgraderepo

data/Rakefile

@@ -1,6 +1,12 @@
+# frozen_string_literal: true
+
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+require "rubocop/rake_task"
+
+RuboCop::RakeTask.new
+
+task default: %i[spec rubocop]

data/lib/zypper/upgraderepo/cli.rb

@@ -1,25 +1,33 @@
-require 'optparse'
-require 'ostruct'
-require 'zypper/upgraderepo'
-require 'zypper/upgraderepo/version'
+# frozen_string_literal: true
 
-module Zypper
+require "optparse"
+require "zypper/upgraderepo"
+require "zypper/upgraderepo/version"
 
+module Zypper
   module Upgraderepo
-
+    CliOptions = Struct.new(
+      :operation, :backup_path, :only_enabled, :alias, :name, :hint,
+      :overrides, :version, :sorting_by, :view, :only_repo, :timeout,
+      :exit_on_fail, :overrides_filename, :only_invalid, :only_protocols,
+      :allow_unstable
+    )
+
+    #
+    # Parsing the input data.
+    #
     class OptParseMain
-
-      def self.parse(args)
-        options = OpenStruct.new
+      def self.parse(_args)
+        options = CliOptions.new
         options.operation = :check_current
-        options.backup_path = ENV['HOME']
+        options.backup_path = Dir.home
         options.only_enabled = false
         options.alias = true
         options.name = true
         options.hint = true
         options.overrides = {}
         options.version = nil
-        options.sort_by = :alias
+        options.sorting_by = :alias
         options.view = :table
         options.only_repo = nil
         options.timeout = 10.0
@@ -30,187 +38,197 @@ module Zypper
         options.allow_unstable = false
 
         opt_parser = OptionParser.new do |opt|
+          opt.banner = if ENV["ZYPPER_UPGRADEREPO"]
+                         "Usage: zypper upgraderepo [OPTIONS] [OPERATION]"
+                       else
+                         "Usage: upgraderepo [OPTIONS] [OPERATION]"
+                       end
 
-          if ENV['ZYPPER_UPGRADEREPO']
-            opt.banner = 'Usage: zypper upgraderepo [OPTIONS] [OPERATION]'
-          else
-            opt.banner = 'Usage: upgraderepo [OPTIONS] [OPERATION]'
-          end
-
-          opt.separator ''
-          opt.separator 'Operations:'
+          opt.separator ""
+          opt.separator "Operations:"
 
-          opt.on('-b', '--backup <PATH>', 'Create a Tar backup of all the repositories under PATH') do |o|
+          opt.on("-b", "--backup <PATH>", "Create a Tar backup of all the repositories under PATH") do |o|
             options.operation = :backup
             options.only_enabled = false
             options.backup_path = o
           end
 
-          opt.on('-c', '--check-current', 'Check the repositories for the current version (Default)') do |o|
+          opt.on("-c", "--check-current", "Check the repositories for the current version (Default)") do |_o|
             options.operation = :check_current
           end
 
-          opt.on('-n', '--check-next', 'Check the repositories for the next version') do |o|
+          opt.on("-n", "--check-next", "Check the repositories for the next version") do |_o|
             options.operation = :check_next
           end
 
-          opt.on('-C', '--check-for <VERSION>', 'Check for a custom VERSION') do |v|
+          opt.on("-C", "--check-for <VERSION>", "Check for a custom VERSION") do |v|
             options.version = v
             options.operation = :check_for
           end
 
-          opt.on('-l', '--check-last', 'Check the repositories for the last version') do |o|
+          opt.on("-l", "--check-last", "Check the repositories for the last version") do |_o|
             options.operation = :check_last
           end
 
-          opt.on('-R', '--reset', 'Reset the repositories to the current OS version.') do |v|
+          opt.on("-R", "--reset", "Reset the repositories to the current OS version.") do |_v|
             options.operation = :reset
           end
 
-          opt.on('-t', '--update', 'Update the repositories to the current OS version') do |v|
+          opt.on("-t", "--update", "Update the repositories to the current OS version") do |_v|
             options.operation = :update
           end
 
-          opt.on('-u', '--upgrade', 'Upgrade to the next version available') do |o|
+          opt.on("-u", "--upgrade", "Upgrade to the next version available") do |_o|
             options.operation = :upgrade_to_next
           end
 
-          opt.on('-U', '--upgrade-to <VERSION>', 'Upgrade to a specific VERSION') do |v|
+          opt.on("-U", "--upgrade-to <VERSION>", "Upgrade to a specific VERSION") do |v|
             options.version = v
             options.operation = :upgrade_to
           end
 
-          opt.on('-L', '--upgrade-to-last', 'Upgrade to the last version available') do |o|
+          opt.on("-L", "--upgrade-to-last", "Upgrade to the last version available") do |_o|
             options.operation = :upgrade_to_last
           end
 
-          opt.on('-s', '--status', 'Prints the version status of the current and available releases') do |o|
+          opt.on("-s", "--status", "Prints the version status of the current and available releases") do |_o|
             options.operation = :status
           end
 
-          opt.separator ''
-          opt.separator 'Options:'
+          opt.on("-d", "--duplicates", "Detect the duplicates comparing the URL addresses") do |_o|
+            options.operation = :duplicates
+          end
 
-          opt.on('--allow-unstable', 'Consider the unstable version as a valid release version') do |o|
+          opt.on("-z", "--unused", "Prints the unused repositories with zero packages installed") do |_o|
+            options.operation = :unused
+          end
+
+          opt.separator ""
+          opt.separator "Options:"
+
+          opt.on("--allow-unstable", "Consider the unstable version as a valid release version") do |_o|
             options.allow_unstable = true
           end
 
-          opt.on('--no-name', 'Don\'t upgrade the name') do |o|
+          opt.on("--no-name", "Don't upgrade the name") do |_o|
             options.name = false
           end
 
-          opt.on('--no-alias', 'Don\'t upgrade the alias') do |o|
+          opt.on("--no-alias", "Don't upgrade the alias") do |_o|
             options.alias = false
           end
 
-          opt.on('--no-hint', 'Don\'t find a working URL when the current is invalid') do |o|
+          opt.on("--no-hint", "Don't find a working URL when the current is not valid") do |_o|
             options.hint = false
           end
 
-          opt.on('--override-url <NUMBER>,<URL>', Array, 'Overwrite the repository NUMBER with URL') do |r|
+          opt.on("--override-url <NUMBER>,<URL>", Array, "Overwrite the repository NUMBER with URL") do |r|
             options.overrides[r[0].to_i] = r[1]
           end
 
-          opt.on('--load-overrides <FILENAME>', 'Check the URLs in the exported FILENAME') do |f|
+          opt.on("--load-overrides <FILENAME>", "Load the repositories' overrides from FILENAME") do |f|
             options.overrides_filename = f
           end
 
-          opt.on('--exit-on-fail', 'Exit with error when a repository upgrade check fails') do |o|
+          opt.on("--exit-on-fail", "Exit with error when a repository upgrade check fails") do |_o|
             options.exit_on_fail = true
           end
 
-          opt.on('--timeout <SECONDS>', "Adjust the waiting SECONDS used to catch an HTTP Timeout Error (Default: #{options.timeout})") do |o|
+          opt.on("--timeout <SECONDS>",
+                 "Adjust the waiting SECONDS used to catch an HTTP Timeout Error (Default: #{options.timeout})") do |o|
             options.timeout = o.to_f
           end
 
-          opt.separator ''
-          opt.separator 'Filter options:'
+          opt.separator ""
+          opt.separator "Filter options:"
 
-          opt.on('--only-enabled', 'Include only the enabled repositories') do |o|
+          opt.on("--only-enabled", "Include only the enabled repositories") do |_o|
             options.only_enabled = true
           end
 
-          opt.on('--only-repo <NUMBER|NAME|@ALIAS|#URL|&ANY>[,NUMBER2|NAME2|@ALIAS2|#URL2|&ANY2,...]', 'Include only the repositories specified by a NUMBER or a string matching the NAME, @ALIAS, #URL, or &ANY of them') do |o|
-            options.only_repo = o.split(',')
+          opt.on("--only-repo <NUMBER|NAME|@ALIAS|#URL|&ANY>[,NUMBER2|NAME2|@ALIAS2|#URL2|&ANY2,...]",
+                 "Include only the repositories specified by a NUMBER or a string matching the NAME, " \
+                 "@ALIAS, #URL, or &ANY of them") do |o|
+            options.only_repo = o.split(",")
           end
 
-          opt.on('--only-invalid', 'Show only invalid repositories') do |o|
+          opt.on("--only-invalid", "Show only invalid repositories") do |_o|
             options.only_invalid = true
           end
 
-          opt.on('--only-protocols <PROTOCOL>[,<PROTOCOL2>,...]', Array, "Show only from protocols (supported: #{Request.protocols.join(',')})") do |o|
+          opt.on("--only-protocols <PROTOCOL>[,<PROTOCOL2>,...]", Array,
+                 "Show only from protocols (supported: #{Request.protocols.join(",")})") do |o|
             options.only_protocols = o
           end
 
-          opt.separator ''
-          opt.separator 'View options:'
+          opt.separator ""
+          opt.separator "View options:"
 
-          opt.on('--sort-by-alias', 'Sort repositories by alias (Default)') do |o|
-            options.sort_by = :alias
+          opt.on("--sort-by-alias", "Sort the repositories by alias (Default)") do |_o|
+            options.sorting_by = :alias
           end
 
-          opt.on('--sort-by-name', 'Sort repositories by name') do |o|
-            options.sort_by = :name
+          opt.on("--sort-by-name", "Sort the repositories by name") do |_o|
+            options.sorting_by = :name
           end
 
-          opt.on('--sort-by-priority', 'Sort repositories by priority') do |o|
-            options.sort_by = :priority
+          opt.on("--sort-by-priority", "Sort the repositories by priority") do |_o|
+            options.sorting_by = :priority
           end
 
-          opt.on('--ini', 'Output the result as INI format') do |o|
+          opt.on("--ini", "Output the result in the INI format") do |_o|
             options.view = :ini
           end
 
-          opt.on('--quiet', 'Quiet mode, show only error messages') do |o|
+          opt.on("--quiet", "Quiet mode, show only error messages") do |_o|
             options.view = :quiet
           end
 
-          opt.on('--report', 'View the data as report') do |o|
+          opt.on("--report", "View the data as a report") do |_o|
             options.view = :report
           end
 
-          opt.on('--solved', 'Output as INI with the suggestions for the invalid repositories applied') do |o|
+          opt.on("--solved", "Output as INI and the URLs' suggestions applied") do |_o|
             options.view = :solved
           end
 
-          unless ENV['ZYPPER_UPGRADEREPO']
-            opt.separator ''
-            opt.separator 'Other:'
+          unless ENV["ZYPPER_UPGRADEREPO"]
+            opt.separator ""
+            opt.separator "Other:"
 
-            opt.on_tail('-h', '--help', 'Show this message') do |o|
+            opt.on_tail("-h", "--help", "Show this message") do |_o|
               puts opt
               exit
             end
 
-            opt.on_tail('-v', '--version', 'Show version') do |o|
+            opt.on_tail("-v", "--version", "Show the version") do |_o|
               puts VERSION
               exit
             end
           end
-
         end
 
         if ARGV.empty?
-          puts opt_parser; exit
+          puts opt_parser
+          exit
         else
           opt_parser.parse!(ARGV)
         end
 
         options
       end
-
     end
 
-
+    #
+    # Interface class to run the application.
+    #
     class CLI
       def self.start
-        begin
-          options = OptParseMain.parse(ARGV)
-          Upgraderepo::Builder.new(options).send(options.operation)
-         rescue => e
-           Messages.error e
-           exit e.error_code
-         end
+        options = OptParseMain.parse(ARGV)
+        Upgraderepo::Builder.new(options).send(options.operation)
+      rescue StandardError => e
+        Messages.error e
+        exit e.error_code
       end
     end
   end

data/lib/zypper/upgraderepo/os_release.rb

@@ -1,25 +1,29 @@
-require 'iniparse'
+# frozen_string_literal: true
+
+require "iniparse"
 
 module Zypper
   module Upgraderepo
-
-
+    #
+    # Detect the current and next release.
+    #
     class OsRelease
-
       attr_reader :custom, :unstable
 
-      OS_VERSIONS = ['13.1', '13.2', '42.1', '42.2', '42.3', '15.0', '15.1', '15.2', '15.3', '15.4', '15.5']
+      OS_VERSIONS = ["13.1", "13.2",
+                     "42.1", "42.2", "42.3",
+                     "15.0", "15.1", "15.2", "15.3", "15.4", "15.5", "15.6"].freeze
 
-      UNSTABLE_VERSION = '15.6'
+      UNSTABLE_VERSION = "16.0"
 
-      OS_RELEASE_FILE = '/etc/os-release'
+      OS_RELEASE_FILE = "/etc/os-release"
 
-      SUSE_RELEASE_FILE = '/etc/SuSE-release'
+      SUSE_RELEASE_FILE = "/etc/SuSE-release"
 
       def initialize(options)
-
         if options.allow_unstable
           raise NoUnstableVersionAvailable if UNSTABLE_VERSION.empty?
+
           OS_VERSIONS << UNSTABLE_VERSION
           @unstable = true
         end
@@ -32,12 +36,12 @@ module Zypper
                   raise ReleaseFileNotFound
                 end
         @release = IniParse.parse(File.read(fname))
-        @current_idx = OS_VERSIONS.index(@release['__anonymous__']['VERSION'].delete('"'))
+        @current_idx = OS_VERSIONS.index(@release["__anonymous__"]["VERSION"].delete('"'))
 
-        if options.version
-          raise InvalidVersion, options.version unless OS_VERSIONS.include?(options.version)
-          @custom = options.version
-        end
+        return unless options.version
+        raise InvalidVersion, options.version unless OS_VERSIONS.include?(options.version)
+
+        @custom = options.version
       end
 
       def current
@@ -49,23 +53,19 @@ module Zypper
       end
 
       def next
-        unless last?
-          OS_VERSIONS[@current_idx.next]
-        else
-          nil
-        end
+        return if last?
+
+        OS_VERSIONS[@current_idx.next]
       end
 
       def previous
-        unless first?
-          OS_VERSIONS[@current_idx.pred]
-        else
-          nil
-        end
+        return if first?
+
+        OS_VERSIONS[@current_idx.pred]
       end
 
       def fullname
-        @release['__anonymous__']['PRETTY_NAME'].gsub(/"/, '')
+        @release["__anonymous__"]["PRETTY_NAME"].gsub(/"/, "")
       end
 
       def seniority
@@ -73,7 +73,7 @@ module Zypper
       end
 
       def newer
-        if seniority > 0
+        if seniority.positive?
           OS_VERSIONS[@current_idx.next..-1]
         else
           []
@@ -85,7 +85,7 @@ module Zypper
       end
 
       def first?
-        @current_idx == 0
+        @current_idx.zero?
       end
 
       def valid?(version)
@@ -96,7 +96,5 @@ module Zypper
         OS_VERSIONS.index(version) == @current_idx
       end
     end
-
-
   end
 end