zuora_rest_client 1.1.4 → 1.1.5

data/fixtures/vcr_cassettes/zuora/update_account_success.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: put
-    uri: https://rest.zuora.com/v1/accounts/2c92a0fc5d8298f6015da36b14df1d04
+    uri: https://rest.zuora.com/v1/accounts/2c92a0fc636cad92016375070a0e3b22
     body:
       encoding: UTF-8
       string: '{"batch":"Batch2"}'
@@ -14,7 +14,7 @@ http_interactions:
       Accept-Encoding:
       - gzip,deflate
       Date:
-      - Wed, 02 Aug 2017 14:48:10 GMT
+      - Fri, 18 May 2018 20:53:06 GMT
       Content-Type:
       - application/json
       Apiaccesskeyid:
@@ -28,22 +28,28 @@ http_interactions:
     headers:
       Content-Type:
       - application/json;charset=utf-8
+      Content-Security-Policy-Report-Only:
+      - media-src 'none'; img-src 'self' *.zuora.com; object-src *.zuora.com; script-src
+        'unsafe-inline' 'unsafe-eval' 'self' https://api.tcell.io/; manifest-src 'none';
+        style-src 'unsafe-inline' 'self'; font-src 'self'; child-src 'none'; frame-src
+        'none'; connect-src 'self' https://api.tcell.io/ https://input.tcell.io/;
+        report-uri https://input.tcell.io/csp/e14f749ededb34ed6f61ee047073e7d5c02428ea31e0b1249ed5bdb2d99decec?tid=88c09fe3-c5cf-43ca-b135-133ede4800d4
       Server:
       - Zuora App
-      X-Request-Id:
-      - b6509090-8d62-4d09-ad0c-c3cabd849040
+      Zuora-Request-Id:
+      - 2a168ab2-6970-4d9b-b7ab-26a7de5ac5c9
       X-Kong-Upstream-Latency:
-      - '94'
+      - '70'
       X-Kong-Proxy-Latency:
       - '0'
       Expires:
-      - Wed, 02 Aug 2017 14:48:10 GMT
+      - Fri, 18 May 2018 20:53:06 GMT
       Cache-Control:
       - max-age=0, no-cache, no-store
       Pragma:
       - no-cache
       Date:
-      - Wed, 02 Aug 2017 14:48:10 GMT
+      - Fri, 18 May 2018 20:53:06 GMT
       Content-Length:
       - '22'
       Connection:
@@ -57,10 +63,10 @@ http_interactions:
           "success" : true
         }
     http_version: 
-  recorded_at: Wed, 02 Aug 2017 14:48:10 GMT
+  recorded_at: Fri, 18 May 2018 20:53:06 GMT
 - request:
     method: get
-    uri: https://rest.zuora.com/v1/accounts/2c92a0fc5d8298f6015da36b14df1d04
+    uri: https://rest.zuora.com/v1/accounts/2c92a0fc636cad92016375070a0e3b22
     body:
       encoding: UTF-8
       string: ''
@@ -72,7 +78,7 @@ http_interactions:
       Accept-Encoding:
       - gzip,deflate
       Date:
-      - Wed, 02 Aug 2017 14:48:10 GMT
+      - Fri, 18 May 2018 20:53:06 GMT
       Content-Type:
       - application/json
       Apiaccesskeyid:
@@ -86,24 +92,30 @@ http_interactions:
     headers:
       Content-Type:
       - application/json;charset=utf-8
+      Content-Security-Policy-Report-Only:
+      - media-src 'none'; img-src 'self' *.zuora.com; object-src *.zuora.com; script-src
+        'unsafe-inline' 'unsafe-eval' 'self' https://api.tcell.io/; manifest-src 'none';
+        style-src 'unsafe-inline' 'self'; font-src 'self'; child-src 'none'; frame-src
+        'none'; connect-src 'self' https://api.tcell.io/ https://input.tcell.io/;
+        report-uri https://input.tcell.io/csp/e14f749ededb34ed6f61ee047073e7d5c02428ea31e0b1249ed5bdb2d99decec?tid=fcad505f-f11b-42a5-a3dc-7ba58cecf924
       Server:
       - Zuora App
-      X-Request-Id:
-      - 58ba0d7d-92a9-4d9d-882f-7526f4009e8b
+      Zuora-Request-Id:
+      - e5e3f867-e66e-45cf-b061-1f6eae78ef00
       X-Kong-Upstream-Latency:
-      - '61'
+      - '67'
       X-Kong-Proxy-Latency:
       - '0'
       Expires:
-      - Wed, 02 Aug 2017 14:48:10 GMT
+      - Fri, 18 May 2018 20:53:06 GMT
       Cache-Control:
       - max-age=0, no-cache, no-store
       Pragma:
       - no-cache
       Date:
-      - Wed, 02 Aug 2017 14:48:10 GMT
+      - Fri, 18 May 2018 20:53:06 GMT
       Content-Length:
-      - '2305'
+      - '2376'
       Connection:
       - keep-alive
       Set-Cookie:
@@ -113,9 +125,9 @@ http_interactions:
       string: |-
         {
           "basicInfo" : {
-            "id" : "2c92a0fc5d8298f6015da36b14df1d04",
+            "id" : "2c92a0fc636cad92016375070a0e3b22",
             "name" : "Test Account",
-            "accountNumber" : "Z00324067",
+            "accountNumber" : "Z00324103",
             "notes" : null,
             "status" : "Active",
             "crmId" : null,
@@ -136,9 +148,12 @@ http_interactions:
             "TestAccountField__c" : null,
             "SuppressDunning__c" : null,
             "ACHVerificationCode__c" : null,
+            "CCemail__c" : null,
             "publisher__c" : null,
             "DellAffinityNo__c" : null,
-            "ACHVerificationTimestamp__c" : null
+            "ACHVerificationTimestamp__c" : null,
+            "salesRep" : null,
+            "parentId" : null
           },
           "billingAndPayment" : {
             "billCycleDay" : 15,
@@ -203,5 +218,5 @@ http_interactions:
           "success" : true
         }
     http_version: 
-  recorded_at: Wed, 02 Aug 2017 14:48:10 GMT
+  recorded_at: Fri, 18 May 2018 20:53:06 GMT
 recorded_with: VCR 3.0.3

data/lib/zuora_rest_client/connection.rb

@@ -10,6 +10,9 @@ require 'net/http'
 require 'addressable/uri'
 
 module ZuoraRestClient
+
+  class ConnectionError < StandardError; end
+
   class Connection
 
     DEFAULT_OPTIONS = {
@@ -66,8 +69,12 @@ module ZuoraRestClient
           request[header_key] = header_value
         end
         http.request request do |response|
-          response.read_body do |chunk|
-            destination_io.write chunk
+          if response.kind_of? Net::HTTPSuccess
+            response.read_body do |chunk|
+              destination_io.write chunk
+            end
+          else
+            raise ConnectionError.new("Error: #{response.code} - #{response.message}")
           end
         end
       end
@@ -144,17 +151,21 @@ module ZuoraRestClient
     end
 
     def process_response(response)
-      if response.headers['Content-Type'].to_s.start_with?('application/json')
-        object = MultiJson.load(response.body)
-        if object.is_a? Array
-          object.map { |item| Result.new(item, recurse_over_arrays: true) }
+      if response.success? || response.status == 404
+        if response.headers['Content-Type'].to_s.start_with?('application/json')
+          object = MultiJson.load(response.body)
+          if object.is_a? Array
+            object.map { |item| Result.new(item, recurse_over_arrays: true) }
+          else
+            Result.new(object, recurse_over_arrays: true)
+          end
+        elsif response.headers['Content-Type'].to_s.start_with?('text/xml')
+          Result.new(Nori.new.parse(response.body), recurse_over_arrays: true)
         else
-          Result.new(object, recurse_over_arrays: true)
+          response
         end
-      elsif response.headers['Content-Type'].to_s.start_with?('text/xml')
-        Result.new(Nori.new.parse(response.body), recurse_over_arrays: true)
       else
-        response
+        raise ConnectionError.new("Error: #{response.status} - #{response.reason_phrase}")
       end
     end
 

data/lib/zuora_rest_client/version.rb

@@ -1,3 +1,3 @@
 module ZuoraRestClient
-  VERSION = '1.1.4'
+  VERSION = '1.1.5'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: zuora_rest_client
 version: !ruby/object:Gem::Version
-  version: 1.1.4
+  version: 1.1.5
 platform: ruby
 authors:
 - David Massad
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-04-10 00:00:00.000000000 Z
+date: 2018-05-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler