zuora_connect 2.0.60t → 2.0.60u

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d7eee2d7cabce6128892afac88428f3c7f77a3318e244bd3becdf521716d0a25
-  data.tar.gz: 12c07009df449c54d70bec094e16594f0a3ecdb251c59ffed230d64787939cfb
+  metadata.gz: 92a983cff8e7ff831929da9496cbb34e728f2033e79135c8bb76fa604bd33e71
+  data.tar.gz: 67170a20afb4fee284cc402484e5770b47422ebbeb7652dca39ceab862ca4d20
 SHA512:
-  metadata.gz: a45196b2a77449c349e1e1fe4b9853d08e35da763327e2f74134cee20f4ee4af9311a4298b048b937d1d4f5056e047f0db503f57b3b36f2335a963fe4e1f3336
-  data.tar.gz: d3d14ec18ce3da9ad27776cf2c79ed3b7f9aafa88c331f3a0efa9a2075258cf438e3dd469c50ba1e4d0e46d339ec0ba895632535ab9644dd8cf4a29513d77f7d
+  metadata.gz: cb814342311b45d90903a72fff8d7bb9d313b91fb89346e99039276af4aae03ed538841215c9737ebc237d80a3584f3955c6e30e48a8e0c322ba7c7fd145ad78
+  data.tar.gz: 8f3d002f881cc6403baaae4f00bb88c8fff0f063c4a6290f4ad2c02c49361afe037717c6a55823a1834a9b29e3f16f11b2339211b992f83c42042133ebe33c55

data/app/models/zuora_connect/app_instance_base.rb

@@ -25,6 +25,8 @@ module ZuoraConnect
     CATALOG_LOOKUP_CACHE_TIME_KEY = 'CatalogCachedAt'
     CATALOG_LOOKUP_TTL = 60.seconds
     CATALOG_LOOKUP_CACHE_RESULT_KEY = 'CatalogCache'
+    TIMEZONE_LOG_RATE_LIMIT_KEY = 'TimezoneLoggedAt'
+    TIMEZONE_LOG_PERIOD = 4.hours
     IGNORED_LOCALS = ['fr', 'ja', 'es', 'zh', 'de']
     INTERNAL_HOSTS = []
     LOGIN_TENANT_DESTINATION = 'target_login'
@@ -245,48 +247,7 @@ module ZuoraConnect
         ZuoraConnect.logger.error(ex) if !IGNORED_LOCALS.include?(ex.locale.to_s.downcase)
       end
 
-      begin
-        sql = <<-eos
-          SELECT zuora_users.zuora_identity_response 
-          FROM "#{self.id}".zuora_users 
-          ORDER BY zuora_users.updated_at DESC 
-          LIMIT 1;
-        eos
-        user = ActiveRecord::Base.connection.execute(sql).to_a.first
-
-        if user.present?
-          zuora_identity_response = JSON.parse(user.fetch('zuora_identity_response', '{}'))
-          self.user_timezone = zuora_identity_response.values.first&.dig('timeZone')
-        end
-      rescue => ex
-        Rails.logger.error('Failed to get users while setting app instance timezone', ex)
-      end
-
-      if self.user_timezone.present?
-        # connect instance which has a custom timezone
-        if !self.auto_deployed? && (
-          ActiveSupport::TimeZone[self.task_data.dig('user_settings', 'timezone') || '']&.utc_offset !=
-            ActiveSupport::TimeZone[self.user_timezone]&.utc_offset
-        )
-          if self.environment == 'Production'
-            ZuoraConnect.logger.error(
-              "Instance and user timezones are different. User has '#{self.user_timezone}' and " \
-              "instance has '#{self.task_data.dig('user_settings', 'timezone')}'",
-              app_instance_id: self.id
-            )
-          end
-          self.user_timezone = nil
-          Time.zone = self.timezone
-        else
-          begin
-            Time.zone = self.user_timezone
-          rescue ArgumentError
-            Time.zone = self.timezone
-          end
-        end
-      else
-        Time.zone = self.timezone
-      end
+      self.set_timezone
 
       if self.task_data.present?
         tenants = self.task_data.fetch('tenant_ids', [])
@@ -319,6 +280,67 @@ module ZuoraConnect
       end
     end
 
+    def set_timezone(timezone: self.timezone, type: :default)
+      if timezone.blank?
+        timezone = self.timezone
+      end
+
+      if type == :default
+        Time.zone = timezone
+      elsif type == :user
+        begin
+          sql = <<-eos
+            SELECT zuora_users.zuora_identity_response 
+            FROM "#{self.id}".zuora_users 
+            ORDER BY zuora_users.updated_at DESC 
+            LIMIT 1;
+          eos
+          user = ActiveRecord::Base.connection.execute(sql).to_a.first
+
+          if user.present?
+            zuora_identity_response = JSON.parse(user.fetch('zuora_identity_response', '{}'))
+            self.user_timezone = zuora_identity_response.values.first&.dig('timeZone')
+          else
+            Rails.logger.error('Cannot find any user to set the timezone', app_instance_id: self.id)
+          end
+        rescue => ex
+          Rails.logger.error('There is an error while getting timezone users', ex)
+        end
+
+        if self.user_timezone.present?
+          # connect instance which has a custom timezone
+          if !self.auto_deployed? && (
+            ActiveSupport::TimeZone[self.task_data.dig('user_settings', 'timezone') || '']&.utc_offset !=
+              ActiveSupport::TimeZone[self.user_timezone]&.utc_offset
+          )
+            if self.environment == 'Production' &&
+              (Redis.current.hget(TIMEZONE_LOG_RATE_LIMIT_KEY, self.id).to_i + TIMEZONE_LOG_PERIOD.to_i) <= Time.now.to_i
+              ZuoraConnect.logger.error(
+                "Instance and user timezones are different. User has '#{self.user_timezone}' and " \
+                "instance has '#{self.task_data.dig('user_settings', 'timezone')}'",
+                app_instance_id: self.id
+              )
+              Redis.current.hset(TIMEZONE_LOG_RATE_LIMIT_KEY, self.id, Time.now.to_i)
+            end
+            self.user_timezone = nil
+            Time.zone = timezone
+          else
+            begin
+              Time.zone = self.user_timezone
+            rescue ArgumentError
+              Rails.logger.error('Malformed user timezone', app_instance_id: self.id)
+              Time.zone = timezone
+            end
+          end
+        else
+          Time.zone = timezone
+        end
+      end
+    rescue => e
+      Rails.logger.error('Malformed timezone used', e, app_instance_id: self.id)
+      Time.zone = self.timezone
+    end
+
     def auto_deployed?
       self.id >= 25000000
     end

data/lib/zuora_connect/controllers/helpers.rb

@@ -138,12 +138,8 @@ module ZuoraConnect
             end
             ZuoraConnect.logger.error(ex) if !ZuoraConnect::AppInstance::IGNORED_LOCALS.include?(ex.locale.to_s.downcase)
           end
-          begin
-            if @appinstance.user_timezone.blank?
-              Time.zone = session["#{@appinstance.id}::user::timezone"] ? session["#{@appinstance.id}::user::timezone"] : @appinstance.timezone
-            end
-          rescue
-            ZuoraConnect.logger.error(ex)
+          if @appinstance.user_timezone.blank?
+            @appinstance.set_timezone(timezone: session["#{@appinstance.id}::user::timezone"], type: :default)
           end
         end
       rescue ZuoraConnect::Exceptions::InvalidCredentialSet => ex

data/lib/zuora_connect/version.rb

@@ -1,3 +1,3 @@
 module ZuoraConnect
-  VERSION = "2.0.60t"
+  VERSION = "2.0.60u"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: zuora_connect
 version: !ruby/object:Gem::Version
-  version: 2.0.60t
+  version: 2.0.60u
 platform: ruby
 authors:
 - Connect Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-11-16 00:00:00.000000000 Z
+date: 2020-11-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: apartment