zuora_connect 2.0.60q → 2.0.60v

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3a9478b4c078e02402f100894a54bac2b08c1a89465e83ec55cb9f1bbe3f5dff
-  data.tar.gz: e0d5c40113abe3b72ef867ca59f620ce19dc1dee778a7e4e531aedae68a6812c
+  metadata.gz: be544177acd9fb2c32ff1e1924980726c9b68ee3d8461e5f1721e5333f9ef60e
+  data.tar.gz: 15951349ed0a7064eff31fbb79d63585bc69a64408c0065993575925f01eb493
 SHA512:
-  metadata.gz: 2c8392e166c5bad4c990c00344476adec37e7dff8176865202a8fedc47e853222197fc2837dd5ea780b96c7fbb92922bcb482206079d376c29c1fadee90a18d9
-  data.tar.gz: 66a9558d6ba34f591a82d1c1f5a92d8930fffde9258afc142e7dd68abbffbfbfdf830bbb2576cfe01e74bef6248ce2bc65b347c16cd08d434b69328fcc407c0b
+  metadata.gz: c43e5c4d523ced8219b069aca21d3273d001ca2816be985dbca23827a3203bf415f9b77423056d226ad2cb8cdaff2442e36831d2e1833350ee2e5b5791fc9665
+  data.tar.gz: 72672400172011e402715935ee443594461b73d43ba15bd51c9b4f00061bd1d485aa22ec46f0fe181857cad49a109bdd65d7e31ced60f22c9678f381ff4cde5c

data/app/models/zuora_connect/app_instance_base.rb

@@ -25,6 +25,8 @@ module ZuoraConnect
     CATALOG_LOOKUP_CACHE_TIME_KEY = 'CatalogCachedAt'
     CATALOG_LOOKUP_TTL = 60.seconds
     CATALOG_LOOKUP_CACHE_RESULT_KEY = 'CatalogCache'
+    TIMEZONE_LOG_RATE_LIMIT_KEY = 'TimezoneLoggedAt'
+    TIMEZONE_LOG_PERIOD = 4.hours
     IGNORED_LOCALS = ['fr', 'ja', 'es', 'zh', 'de']
     INTERNAL_HOSTS = []
     LOGIN_TENANT_DESTINATION = 'target_login'
@@ -245,48 +247,7 @@ module ZuoraConnect
         ZuoraConnect.logger.error(ex) if !IGNORED_LOCALS.include?(ex.locale.to_s.downcase)
       end
 
-      begin
-        sql = <<-eos
-          SELECT zuora_users.zuora_identity_response 
-          FROM "#{self.id}".zuora_users 
-          ORDER BY zuora_users.updated_at DESC 
-          LIMIT 1;
-        eos
-        user = ActiveRecord::Base.connection.execute(sql).to_a.first
-
-        if user.present?
-          zuora_identity_response = JSON.parse(user.fetch('zuora_identity_response', '{}'))
-          self.user_timezone = zuora_identity_response.values.first&.dig('timeZone')
-        end
-      rescue => ex
-        Rails.logger.error('Failed to get users while setting app instance timezone', ex)
-      end
-
-      if self.user_timezone.present?
-        # connect instance which has a custom timezone
-        if !self.auto_deployed? && (
-          ActiveSupport::TimeZone[self.task_data.dig('user_settings', 'timezone') || '']&.utc_offset !=
-            ActiveSupport::TimeZone[self.user_timezone]&.utc_offset
-        )
-          if self.environment == 'Production'
-            ZuoraConnect.logger.error(
-              "Instance and user timezones are different. User has '#{self.user_timezone}' and " \
-              "instance has '#{self.task_data.dig('user_settings', 'timezone')}'",
-              app_instance_id: self.id
-            )
-          end
-          self.user_timezone = nil
-          Time.zone = self.timezone
-        else
-          begin
-            Time.zone = self.user_timezone
-          rescue ArgumentError
-            Time.zone = self.timezone
-          end
-        end
-      else
-        Time.zone = self.timezone
-      end
+      self.set_timezone
 
       if self.task_data.present?
         tenants = self.task_data.fetch('tenant_ids', [])
@@ -319,6 +280,70 @@ module ZuoraConnect
       end
     end
 
+    def set_timezone(timezone: self.timezone, type: :default)
+      if timezone.blank?
+        timezone = self.timezone
+      end
+
+      if type == :default
+        Time.zone = timezone
+      elsif type == :user
+        begin
+          sql = <<-eos
+            SELECT zuora_users.zuora_identity_response 
+            FROM "#{self.id}".zuora_users 
+            ORDER BY zuora_users.updated_at DESC 
+            LIMIT 1;
+          eos
+          user = ActiveRecord::Base.connection.execute(sql).to_a.first
+
+          if user.present?
+            zuora_identity_response = JSON.parse(user.fetch('zuora_identity_response', '{}'))
+            self.user_timezone = zuora_identity_response.values.first&.dig('timeZone')
+          else
+            if (Redis.current.hget(TIMEZONE_LOG_RATE_LIMIT_KEY, self.id).to_i + TIMEZONE_LOG_PERIOD.to_i) <= Time.now.to_i
+              Rails.logger.error('Cannot find any user to set the timezone', app_instance_id: self.id)
+              Redis.current.hset(TIMEZONE_LOG_RATE_LIMIT_KEY, self.id, Time.now.to_i)
+            end
+          end
+        rescue => ex
+          Rails.logger.error('There is an error while getting timezone users', ex)
+        end
+
+        if self.user_timezone.present?
+          # connect instance which has a custom timezone
+          if !self.auto_deployed? && (
+            ActiveSupport::TimeZone[self.task_data.dig('user_settings', 'timezone') || '']&.utc_offset !=
+              ActiveSupport::TimeZone[self.user_timezone]&.utc_offset
+          )
+            if self.environment == 'Production' &&
+              (Redis.current.hget(TIMEZONE_LOG_RATE_LIMIT_KEY, self.id).to_i + TIMEZONE_LOG_PERIOD.to_i) <= Time.now.to_i
+              ZuoraConnect.logger.error(
+                "Instance and user timezones are different. User has '#{self.user_timezone}' and " \
+                "instance has '#{self.task_data.dig('user_settings', 'timezone')}'",
+                app_instance_id: self.id
+              )
+              Redis.current.hset(TIMEZONE_LOG_RATE_LIMIT_KEY, self.id, Time.now.to_i)
+            end
+            self.user_timezone = nil
+            Time.zone = timezone
+          else
+            begin
+              Time.zone = self.user_timezone
+            rescue ArgumentError
+              Rails.logger.error('Malformed user timezone', app_instance_id: self.id)
+              Time.zone = timezone
+            end
+          end
+        else
+          Time.zone = timezone
+        end
+      end
+    rescue => e
+      Rails.logger.error('Malformed timezone used', e, app_instance_id: self.id)
+      Time.zone = self.timezone
+    end
+
     def auto_deployed?
       self.id >= 25000000
     end

data/config/initializers/prometheus.rb

@@ -33,6 +33,8 @@ if defined? Prometheus
             file.write(Prometheus::Client::Formats::Text.marshal(@registry))
           end
         end
+      rescue
+        # Ignored
       end
     end
 

data/lib/zuora_connect/controllers/helpers.rb

@@ -138,12 +138,8 @@ module ZuoraConnect
             end
             ZuoraConnect.logger.error(ex) if !ZuoraConnect::AppInstance::IGNORED_LOCALS.include?(ex.locale.to_s.downcase)
           end
-          begin
-            if @appinstance.user_timezone.blank?
-              Time.zone = session["#{@appinstance.id}::user::timezone"] ? session["#{@appinstance.id}::user::timezone"] : @appinstance.timezone
-            end
-          rescue
-            ZuoraConnect.logger.error(ex)
+          if @appinstance.user_timezone.blank?
+            @appinstance.set_timezone(timezone: session["#{@appinstance.id}::user::timezone"], type: :default)
           end
         end
       rescue ZuoraConnect::Exceptions::InvalidCredentialSet => ex

data/lib/zuora_connect/version.rb

@@ -1,3 +1,3 @@
 module ZuoraConnect
-  VERSION = "2.0.60q"
+  VERSION = "2.0.60v"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: zuora_connect
 version: !ruby/object:Gem::Version
-  version: 2.0.60q
+  version: 2.0.60v
 platform: ruby
 authors:
 - Connect Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-11-12 00:00:00.000000000 Z
+date: 2020-11-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: apartment