zuora-ruby 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 851d0abfff60f962e9325f3f2640b98e26757c9c
-  data.tar.gz: f45b66d5be58bef7ee808bb850d4ac3fd3a95990
+  metadata.gz: 950ce323c45a5ab88835cbac0ad94ca051f2fb77
+  data.tar.gz: ff96b5ebcb72b7ee90f8a7c00589c147ac44f11d
 SHA512:
-  metadata.gz: 98234b223c83ab68a662eb5dfd48f5fd827e69375cb142d101dc0570538212a674fbe9961710671644cee8494b14ab42e1b2b122c0bf22094a1a9fd54721626d
-  data.tar.gz: 1221da190beb70589a3260e0af9797d48f8b603a58e60ada3d5b6d4c803d3869c3761a540323fafb9376697a8121ff19a9e6a9647605eadfe17f2b61119dec1b
+  metadata.gz: 8151ec6316d825d64e65076c09fd49d619b23817ae224425f313e2695952da9df728a32bb92f6b1508c1ec4252ad651d8184d281a5cc11e11c974a6b0ce76dea
+  data.tar.gz: eee910a1f52b9bbea3e548e8f9ad49ab7d11da191571350b595c8c70c81b51ec21e45729334d28c1242f3fc1e7382a9a756c52051d5762111d7c35e46e15061a

data/.ruby-gemset

@@ -0,0 +1 @@
+zuora-ruby

data/.ruby-version

@@ -1 +1 @@
-ruby-2.2.3
+ruby-2.3.1

data/.travis.yml

@@ -0,0 +1,10 @@
+sudo: required
+dist: trusty
+language: ruby
+cache: bundler
+rvm:
+  - 2.3.1
+
+script:
+  - bundle exec rspec
+  - bundle exec rubocop

data/README.md

@@ -1,6 +1,5 @@
-[![Circle CI](https://circleci.com/gh/contactually/zuora-ruby.svg?style=shield&circle-token=808be5d625e91e331bedb37a2fe94412bb3bc15e)](https://circleci.com/gh/contactually/zuora-ruby)
-[![Code Climate](https://codeclimate.com/repos/5706a3fb4f15bd726100652d/badges/4e4615baaec76fd16535/gpa.svg)](https://codeclimate.com/repos/569444dfa3d810003a00313f/feed)
-[![Test Coverage](https://codeclimate.com/repos/5706a3fb4f15bd726100652d/badges/4e4615baaec76fd16535/coverage.svg)](https://codeclimate.com/repos/569444dfa3d810003a00313f/coverage)
+[![Build Status](https://travis-ci.org/contactually/zuora-ruby.svg?branch=master)](https://travis-ci.org/contactually/zuora-ruby)
+[![Code Climate](https://codeclimate.com/github/contactually/zuora-ruby/badges/gpa.svg)](https://codeclimate.com/github/contactually/zuora-ruby)
 
 # Zuora SOAP and REST API Client
 

data/lib/zuora.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 
 # Dependencies
 require 'faraday'

data/lib/zuora/calls/subscribe.rb

@@ -8,6 +8,7 @@ module Zuora
       property :subscribe_options
       property :subscription
       property :rate_plan
+      property :rate_plan_charge
 
       SIMPLE_OBJECTS = [:account, :payment_method, :bill_to_contact].freeze
 
@@ -50,6 +51,9 @@ module Zuora
           build_object(builder, :Subscription, subscription)
           builder[:api].RatePlanData do
             build_object(builder, :RatePlan, rate_plan)
+            builder[:api].RatePlanChargeData do
+              build_object(builder, :RatePlanCharge, rate_plan_charge)
+            end
           end
         end
       end

data/lib/zuora/errors.rb

@@ -1,6 +1,8 @@
 module Zuora
   module Errors
-    class InvalidValue < StandardError
+    GenericError = Class.new(StandardError)
+
+    class InvalidValue < GenericError
       attr_reader :response
 
       def initialize(msg = nil, response = nil)
@@ -9,10 +11,10 @@ module Zuora
       end
     end
 
-    class InvalidCredentials < StandardError
+    class InvalidCredentials < GenericError
     end
 
-    class SoapConnectionError < StandardError
+    class SoapConnectionError < GenericError
     end
   end
 end

data/lib/zuora/rest.rb

@@ -1,13 +1,14 @@
+# frozen_string_literal: true
 module Zuora
   module Rest
     API_URL = 'https://api.zuora.com/rest/v1/'.freeze
     SANDBOX_URL = 'https://apisandbox-api.zuora.com/rest/v1/'.freeze
 
     # Unable to connect. Check username / password
-    ConnectionError = Class.new StandardError
+    ConnectionError = Class.new Errors::GenericError
 
     # Non-success response
-    class ErrorResponse < StandardError
+    class ErrorResponse < Errors::GenericError
       attr_reader :response
 
       def initialize(message = nil, response = nil)

data/lib/zuora/rest/client.rb

@@ -88,8 +88,20 @@ module Zuora
       # @throw [ErrorResponse] if unsuccessful
       # @return [Faraday::Response]
       def fail_or_response(response)
-        success = response.body['success'] && response.status == 200
-        fail(ErrorResponse.new('Non-200', response)) unless success
+        if response.status != 200
+          fail(ErrorResponse.new("HTTP Status #{response.status}", response))
+        elsif !response.body['success']
+          errors = 'Not successful.'
+
+          if response.body['reasons']
+            reasons = response.body['reasons'].map do |reason|
+              "Error #{reason['code']}: #{reason['message']}"
+            end
+            errors += ' ' + reasons.join(', ')
+          end
+
+          fail(ErrorResponse.new(errors, response))
+        end
         response
       end
 
@@ -109,12 +121,16 @@ module Zuora
         request.url url
         request.headers['Content-Type'] = 'application/json'
         request.headers['Cookie'] = @auth_cookie
+
+        if ENV['ZUORA_API_VERSION'].present?
+          request.headers['zuora-version'] = ENV['ZUORA_API_VERSION']
+        end
       end
 
       # @param [String] url
       # @return [Faraday::Client]
       def connection(url)
-        Faraday.new(url, ssl: { verify: false }) do |conn|
+        Faraday.new(url, ssl: { verify: true }) do |conn|
           conn.request :json
           conn.response :json, content_type: /\bjson$/
           conn.use :instrumentation

data/lib/zuora/soap/client.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Zuora
   module Soap
     class Client
@@ -126,7 +127,7 @@ module Zuora
       # Initializes a connection using api_url
       # @return [Faraday::Connection]
       def connection
-        Faraday.new(api_url, ssl: { verify: false }) do |conn|
+        Faraday.new(api_url, ssl: { verify: true }) do |conn|
           conn.adapter Faraday.default_adapter
         end
       end

data/lib/zuora/utils/envelope.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Zuora
   module Utils
     module Envelope

data/lib/zuora/version.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Zuora
-  VERSION = '0.5.0'.freeze
+  VERSION = '0.6.0'.freeze
 end

data/zuora_ruby.gemspec

@@ -47,6 +47,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec-its'
   spec.add_development_dependency 'rspec_junit_formatter', '0.2.2'
   spec.add_development_dependency 'rubocop', '0.36.0'
-  spec.add_development_dependency 'webmock'
+  spec.add_development_dependency 'webmock', '~> 1.22'
   spec.add_development_dependency 'vcr'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: zuora-ruby
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Contactually Engineering
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-05-12 00:00:00.000000000 Z
+date: 2017-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -238,16 +238,16 @@ dependencies:
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.22'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.22'
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
@@ -274,7 +274,9 @@ files:
 - ".hound.yml"
 - ".rspec"
 - ".rubocop.yml"
+- ".ruby-gemset"
 - ".ruby-version"
+- ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt
@@ -282,7 +284,6 @@ files:
 - Rakefile
 - bin/console
 - bin/setup
-- circle.yml
 - lib/utils/schema_model.rb
 - lib/zuora.rb
 - lib/zuora/calls/amend.rb
@@ -329,9 +330,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: A Ruby wrapper for Zuora API.
 test_files: []
-has_rdoc: 

data/circle.yml

@@ -1,3 +0,0 @@
-test:
-  post:
-    - bundle exec rubocop