zuck 2.1.0 → 3.0.0

data/spec/lib/zuck/facebook/ad_interest_spec.rb

@@ -11,7 +11,7 @@ describe Zuck::AdInterest do
 
   it "finds the best interest when no keyword with # is available" do
     VCR.use_cassette('ad_interest_search_moviepilot') do
-      Zuck::AdInterest.best_guess(graph, 'moviepilot')[:name].should == 'moviepilot horror'
+      Zuck::AdInterest.best_guess(graph, 'moviepilot')[:name].should == 'Moviepilot'
     end
   end
 

data/spec/lib/zuck/facebook/targeting_spec_spec.rb

@@ -1,13 +1,13 @@
 require 'spec_helper'
 
 describe Zuck::TargetingSpec do
-  let(:ad_account){ "2ijdsfoij" }
-  let(:graph){ mock('koala') }
+  let(:ad_account) { "2ijdsfoij" }
+  let(:graph) { mock('koala') }
 
   describe "validating interests" do
 
-    let(:valid_interest_result){  [{"name" => "foo", "valid" => true }] }
-    let(:invalid_interest_result){  [] }
+    let(:valid_interest_result) { [{"name" => "foo", "valid" => true}] }
+    let(:invalid_interest_result) { [] }
 
 
     it "acknowledges valid interests" do
@@ -28,43 +28,43 @@ describe Zuck::TargetingSpec do
 
   describe "options given in spec" do
     it "accepts male as gender" do
-      expect{
+      expect {
         Zuck::TargetingSpec.new(graph, ad_account, geo_locations: {countries: ['US']}, interests: [{id: '123', name: 'foo'}], gender: 'male')
       }.to_not raise_error
     end
 
     it "accepts male as gender for young people" do
-      expect{
+      expect {
         Zuck::TargetingSpec.new(graph, ad_account, geo_locations: {countries: ['US']}, interests: [{id: '123', name: 'foo'}], gender: 'male', age_class: 'young')
       }.to_not raise_error
     end
 
     it "accepts male as gender for old people" do
-      expect{
+      expect {
         Zuck::TargetingSpec.new(graph, ad_account, geo_locations: {countries: ['US']}, interests: [{id: '123', name: 'foo'}], gender: 'male', age_class: 'old')
       }.to_not raise_error
     end
 
     it "accepts without gender" do
-      expect{
+      expect {
         Zuck::TargetingSpec.new(graph, ad_account, geo_locations: {countries: ['US']}, interests: [{id: '123', name: 'foo'}])
       }.to_not raise_error
     end
 
     it "accepts single keyword" do
-      expect{
+      expect {
         Zuck::TargetingSpec.new(graph, ad_account, geo_locations: {countries: ['US']}, interest: 'foo')
       }.to_not raise_error
     end
 
     it "does not accept invalid genders" do
-      expect{
+      expect {
         Zuck::TargetingSpec.new(graph, ad_account, geo_locations: {countries: ['US']}, interests: [{id: '123', name: 'foo'}], gender: 'gemale')
       }.to raise_error("Gender can only be male or female")
     end
 
     it "does not accept invalid countries" do
-      expect{
+      expect {
         z = Zuck::TargetingSpec.new(graph, ad_account, geo_locations: {countries: ['XX']}, interests: [{id: '123', name: 'foo'}], gender: 'female')
         z.send(:validate_spec)
       }.to raise_error('Invalid countrie(s): ["XX"]')
@@ -72,7 +72,7 @@ describe Zuck::TargetingSpec do
 
 
     it "does not accept targetings with neither :interests nor :connections" do
-      expect{
+      expect {
         ts = Zuck::TargetingSpec.new(graph, ad_account, geo_locations: {countries: ['US']}, gender: 'female')
         ts.fetch_reach
       }.to raise_error("Need to set :interests or :connections")
@@ -80,14 +80,14 @@ describe Zuck::TargetingSpec do
   end
 
   describe "fetching reach" do
-    let(:graph){ Koala::Facebook::API.new('CAAEvJ5vzhl8BAPGZCZCPL4FxryEHXGxPCuCGeqe3PEWIjhIvJ00HB8PPpokFmUkemvmEUHirqdNMc7zIDLSTVnX6jTQjAgSlzcYrAYJRQ32fr6RM5ZAnKPdgFEwN5tgvswatXZAI4vu7ZBAQexRl9MU0CpwW7JDDBZAGo5XDrCKrBxkUUWJUvh') }
-    let(:ad_account){ 'act_1384977038406122' }
+    let(:graph) { Koala::Facebook::API.new(test_access_token) }
+    let(:ad_account) { test_account_id }
 
     it "bugs out when trying to use an invalid interest" do
       VCR.use_cassette('reach_for_invalid_interest') do
-        spec = {geo_locations: {countries: ['us']}, interests: ['Eminem', 'invalidsssssssssssssss'] }
+        spec = {geo_locations: {countries: ['us']}, interests: ['Eminem', 'invalidsssssssssssssss']}
         ts = Zuck::TargetingSpec.new(graph, ad_account, spec)
-        expect{
+        expect {
           ts.validate_interests
         }.to raise_error(Zuck::InvalidKeywordError, 'invalidsssssssssssssss')
       end
@@ -95,19 +95,23 @@ describe Zuck::TargetingSpec do
 
     it "works without gender or age" do
       VCR.use_cassette('reach_for_valid_keywords') do
-        spec = {geo_locations: {countries: ['us']}, interests: [{id: '6003135347608', name: 'Eminem'}, {id: '6003504886186', name: 'Sting (musician)'}] }
+        spec = {geo_locations: {countries: ['us']}, interests: [{id: '6003135347608', name: 'Eminem'}, {id: '6003504886186', name: 'Sting (musician)'}]}
         ts = Zuck::TargetingSpec.new(graph, ad_account, spec)
-        reach = ts.fetch_reach
-        reach[:users].should == 37_00_0000
+        explain_error {
+          reach = ts.fetch_reach
+          reach[:users].should == 31_00_0000
+        }
       end
     end
 
     it "works with gender and age" do
       VCR.use_cassette('reach_for_valid_keywords_male_young') do
-        spec = {geo_locations: {countries: ['us']}, interests: [{id: '6003504886186', name: 'Sting (musician)'}], gender: :female, age_class: :young }
+        spec = {geo_locations: {countries: ['us']}, interests: [{id: '6003504886186', name: 'Sting (musician)'}], gender: :female, age_class: :young}
         ts = Zuck::TargetingSpec.new(graph, ad_account, spec)
-        reach = ts.fetch_reach
-        reach[:users].should == 16_000
+        explain_error {
+          reach = ts.fetch_reach
+          reach[:users].should == 63_000
+        }
       end
     end
 
@@ -122,9 +126,9 @@ describe Zuck::TargetingSpec do
   end
 
   describe "Batch processing" do
-    let(:graph){ Koala::Facebook::API.new(test_access_token) }
-    let(:ad_account){ 'act_10150585630710217' }
-    let(:spec_mock){ mock(fetch_reach: {some: :data}) }
+    let(:graph) { Koala::Facebook::API.new(test_access_token) }
+    let(:ad_account) { test_account_id }
+    let(:spec_mock) { mock(fetch_reach: {some: :data}) }
 
     it "fetches each reach" do
       requests = [{some: :thing}] * 51

data/spec/lib/zuck_spec.rb

@@ -9,7 +9,7 @@ describe Zuck::FbObject do
 
 
   let(:graph)      { Zuck.graph                                     }
-  let(:account_id) { "act_367106653"                                }
+  let(:account_id) { test_account_id                                }
   let(:account)    { Zuck::AdAccount.new(graph,  {id: account_id})  }
 
   describe "talking to facebook" do
@@ -52,8 +52,9 @@ describe Zuck::FbObject do
       it "an ad set" do
         VCR.use_cassette('create_ad_set') do
           o = {
-              bid_type: 'CPC',
-              bid_info: "{'CLICKS': 1}",
+              bid_amount: 1,
+              billing_event: 'IMPRESSIONS',
+              optimization_goal: 'REACH',
               name: 'bloody ad set',
               campaign_status: 'PAUSED',
               daily_budget: 100,
@@ -88,13 +89,14 @@ describe Zuck::FbObject do
           o = {
               name: "Rap like me",
               # targeting: '{"geo_locations": {"countries":["US"]}}',
-              objective: 'WEBSITE_CLICKS',
+              # objective: 'WEBSITE_CLICKS',
+              bid_amount: 5,
               creative: '{"creative_id": '+creative.id+'}'
           }
           explain_error {
             group = set.create_ad_group(o)
             group.name.should == "Rap like me"
-            group['bid_type'].should == 'CPC'
+            group['bid_type'].should == 'ABSOLUTE_OCPM'
           }
         end
       end
@@ -193,7 +195,9 @@ describe Zuck::FbObject do
 
       it "a creative" do
         VCR.use_cassette('delete_creative') do
-          creative.destroy.should be_true
+          explain_error {
+            creative.destroy.should be_true
+          }
         end
       end
 
@@ -203,6 +207,7 @@ describe Zuck::FbObject do
           act_campaign.destroy.should be_true
         end
       end
+
     end
   end
 end

data/spec/spec_helper.rb

@@ -28,6 +28,8 @@ RSpec.configure do |config|
 
   # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
 
+  # enable if you have issues with the api and need to see queries directly
+  # Koala::Utils.level = Logger::DEBUG
 end
 
 module TestResponseExtensions
@@ -41,7 +43,11 @@ module TestResponseExtensions
 end
 
 def test_access_token
-  @test_access_token ||= File.read("test_access_token")
+  @test_access_token ||= File.read("test_access_token").split("|")[1]
+end
+
+def test_account_id
+  @test_account_id ||= File.read("test_access_token").split("|")[0]
 end
 
 def explain_error(&block)

data/test_access_token

@@ -1 +1 @@
-FAKEACCESSTOKEN
+act_367106653|DUMMY_TOKEN

data/zuck.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: zuck 2.1.0 ruby lib
+# stub: zuck 3.0.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "zuck"
-  s.version = "2.1.0"
+  s.version = "3.0.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Jannis Hermanns"]
-  s.date = "2015-04-15"
+  s.date = "2015-09-22"
   s.description = "This gem allows to easily access facebook's ads api in ruby. See https://developers.facebook.com/docs/reference/ads-api/"
   s.email = "jannis@gmail.com"
   s.extra_rdoc_files = [
@@ -19,7 +19,7 @@ Gem::Specification.new do |s|
     "README.markdown"
   ]
   s.files = [
-    ".rvmrc",
+    ".ruby-version",
     ".travis.yml",
     ".yardopts",
     "CHANGELOG.markdown",

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: zuck
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 3.0.0
 platform: ruby
 authors:
 - Jannis Hermanns
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-15 00:00:00.000000000 Z
+date: 2015-09-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rvm
@@ -284,7 +284,7 @@ extra_rdoc_files:
 - LICENSE.txt
 - README.markdown
 files:
-- .rvmrc
+- .ruby-version
 - .travis.yml
 - .yardopts
 - CHANGELOG.markdown

data/.rvmrc

@@ -1 +0,0 @@
-rvm --create use ruby-1.9.3@zuck