zuck 2.0.0 → 2.1.0

data/spec/lib/zuck_spec.rb

@@ -2,56 +2,121 @@ require 'spec_helper'
 
 describe Zuck::FbObject do
 
-  before(:all) do
+  before(:all) {
+    puts "Koala version: #{Koala.config.api_version}"
     Zuck.graph = Koala::Facebook::API.new(test_access_token)
-  end
+  }
 
-  let(:graph)   { Zuck.graph                                                  }
-  let(:account) { Zuck::AdAccount.new(graph,  {id: "act_10150585630710217"})  }
-  let(:campaign){ Zuck::AdCampaign.new(graph, {id: "6021499361751"}, account) }
-  let(:group)   { Zuck::AdGroup.new(graph,    {id: "6010889169151"}, campaign)}
-  let(:creative){ Zuck::AdCreative.new(graph, {id: "6021396606151"}, group)   }
-  let(:set)     { Zuck::AdSet.new(graph,      {id: "6021525283751"}, account)   }
 
+  let(:graph)      { Zuck.graph                                     }
+  let(:account_id) { "act_367106653"                                }
+  let(:account)    { Zuck::AdAccount.new(graph,  {id: account_id})  }
 
-  describe "read only objects" do
-    it "can't be created" do
-      expect{
-        Zuck::AdCreative.create(:x, {}, :y)
-      }.to raise_error(Zuck::Error::ReadOnly)
-    end
+  describe "talking to facebook" do
+    act_campaign = nil
+    campaign = nil
+    creative = nil
+    group = nil
+    set = nil
 
-    it "can't be saved" do
-      expect{
-        creative.save
-      }.to raise_error(Zuck::Error::ReadOnly)
-    end
+    context "creating" do
 
-    it "can't be destroyed" do
-      expect{
-        creative.destroy
-      }.to raise_error(Zuck::Error::ReadOnly)
+      it "an ad campaign via an existing ad account" do
+        VCR.use_cassette('create_ad_campaign') do
+          o = {
+              daily_budget: 1000,
+              name: "bloody campaign (via account)"
+          }
+          explain_error {
+            act_campaign = account.create_ad_campaign(o)
+            act_campaign.name.should == "bloody campaign (via account)"
+          }
+        end
+      end
+
+
+      it "an ad campaign" do
+        VCR.use_cassette('create_ad_campaign') do
+          o = {
+              objective: 'NONE',
+              name: "bloody campaign",
+              campaign_group_status: 'PAUSED'
+          }
+          explain_error {
+            campaign = Zuck::AdCampaign.create(graph, o, account)
+            campaign.name.should == "bloody campaign"
+          }
+        end
+      end
+
+      it "an ad set" do
+        VCR.use_cassette('create_ad_set') do
+          o = {
+              bid_type: 'CPC',
+              bid_info: "{'CLICKS': 1}",
+              name: 'bloody ad set',
+              campaign_status: 'PAUSED',
+              daily_budget: 100,
+              targeting: "{'geo_locations':{'countries':['US','GB']}}",
+              campaign_group_id: campaign.id
+          }
+          explain_error {
+            set = Zuck::AdSet.create(graph, o, account)
+            set.name.should == 'bloody ad set'
+          }
+        end
+      end
+
+      it "a creative by uploading an image" do
+        VCR.use_cassette('create a creative') do
+          o =  {
+              title: 'bloody title',
+              body: 'bloody body',
+              object_url: 'http://moviepilot.com/',
+              image_url: 'http://images-cdn.moviepilot.com/image/upload/c_fill,h_246,w_470/v1427727623/moviepilot.jpg'
+          }
+          explain_error {
+            creative = Zuck::AdCreative.create(graph, o, account)
+            creative.id.should_not == nil
+          }
+        end
+      end
+
+
+      it "an ad group via an existing ad campaign" do
+        VCR.use_cassette('create_ad_group') do
+          o = {
+              name: "Rap like me",
+              # targeting: '{"geo_locations": {"countries":["US"]}}',
+              objective: 'WEBSITE_CLICKS',
+              creative: '{"creative_id": '+creative.id+'}'
+          }
+          explain_error {
+            group = set.create_ad_group(o)
+            group.name.should == "Rap like me"
+            group['bid_type'].should == 'CPC'
+          }
+        end
+      end
     end
-  end
 
-  describe "talking to facebook" do
     context "reading" do
 
       it "a list of ad accounts" do
         VCR.use_cassette('list_of_ad_accounts') do
-          Zuck::AdAccount.all.should have(2).items
+          Zuck::AdAccount.all.should have_at_least(1).items
         end
       end
 
       it "a list of ad campaigns" do
         VCR.use_cassette('list_of_ad_campaigns') do
-          account.ad_campaigns.should have(24).items
+          account.ad_campaigns.should have_at_least(2).items
         end
       end
 
       it "a list of ad groups" do
         VCR.use_cassette('list_of_ad_groups') do
-          campaign.ad_groups.should have(4).item
+          campaign.ad_groups.should have_at_least(1).item
         end
       end
 
@@ -65,7 +130,7 @@ describe Zuck::FbObject do
         g = graph
         Zuck::AdAccount.should_receive(:all).and_return([account])
         VCR.use_cassette('list_of_all_ad_creatives_of_account') do
-          Zuck::AdCreative.all(g).should have(13).items
+          Zuck::AdCreative.all(g).should have_at_least(1).items
         end
       end
 
@@ -73,97 +138,71 @@ describe Zuck::FbObject do
 
         it "campaign with the correct type" do
           VCR.use_cassette('a_single_campaign') do
-            c = Zuck::AdCampaign.find(6021496142951, graph)
+            c = Zuck::AdCampaign.find(campaign.id, graph)
+            c.buying_type.should == "AUCTION"
           end
         end
 
         it "account with the correct type" do
           VCR.use_cassette('a_single_account') do
-            c = Zuck::AdAccount.find('act_10150585630710217', graph)
+            c = Zuck::AdAccount.find(account_id, graph)
+            c.account_id.should == account_id[4..-1]
+            c.account_status.should == 1
           end
         end
 
         it "when expecting an ad group but the id belongs to a campaign" do
           VCR.use_cassette('a_single_group') do
             expect{
-              c = Zuck::AdGroup.find(6010889111951, graph)
+              Zuck::AdGroup.find(campaign.id, graph)
             }.to raise_error(Koala::Facebook::ClientError)
           end
         end
 
         it "and saving it" do
           VCR.use_cassette('find_a_single_group_and_update_it') do
-            group = Zuck::AdGroup.find(6021525861551, graph)
-            group.name = "My old name"
-            group.save
-            group.name.should == "My old name"
-            group.name = "My new name"
-            group.save
-            group.name.should == "My new name"
-            group.reload
-            group.name.should == "My new name"
+            explain_error {
+              found_group = Zuck::AdGroup.find(group.id, graph)
+              found_group.name = "My old name"
+              found_group.save
+              found_group.name.should == "My old name"
+              found_group.name = "My new name"
+              found_group.save
+              found_group.name.should == "My new name"
+              found_group.reload
+              found_group.name.should == "My new name"
+            }
           end
         end
 
       end
     end
 
-
-    context "creating" do
-      it "an ad set" do
-        VCR.use_cassette('create_ad_set') do
-          o = {
-            name: 'test ad set',
-            campaign_status: 'PAUSED',
-            daily_budget: 100,
-            targeting: "{'geo_locations':{'countries':['US','GB']}}",
-            campaign_group_id: campaign.id
-          }
-          ad_set = Zuck::AdSet.create(graph, o, account)
-          ad_set.name.should == 'test ad set'
-        end
-      end
-
-      it "an ad campaign" do
-        VCR.use_cassette('create_ad_campaign') do
-          o = {objective: 'NONE', name: "bloody", campaign_group_status: 'PAUSED' }
-          campaign = Zuck::AdCampaign.create(graph, o, account)
-          campaign.name.should == "bloody"
+    context "deleting" do
+      it "an ad group" do
+        VCR.use_cassette('delete_ad_group') do
+          group.destroy.should be_true
         end
       end
 
-      it "an ad campaign via an existing ad account" do
-        VCR.use_cassette('create_ad_campaign') do
-          o = {daily_budget: 1000, name: "bloody" }
-          campaign = account.create_ad_campaign(o)
-          campaign.name.should == "bloody"
+      it "an ad set" do
+        VCR.use_cassette('delete_ad_set') do
+          set.destroy.should be_true
         end
       end
 
-      it "an ad group via an existing ad campaign" do
-        VCR.use_cassette('create_ad_group') do
-          o = {
-            bid_type: 'CPC',
-            bid_info: '{"CLICKS": 1}',
-            name: "Rap like me",
-            targeting: '{"geo_locations": {"countries":["US"]}}',
-            objective: 'WEBSITE_CLICKS',
-            creative: '{"creative_id": "6021396606151"}'
-          }
-          group = set.create_ad_group(o)
-          group.name.should == "Rap like me"
-          group.bid_type.should == 'CPC'
+      it "a creative" do
+        VCR.use_cassette('delete_creative') do
+          creative.destroy.should be_true
         end
       end
-    end
 
-    context "deleting" do
-      it "an ad group" do
-        VCR.use_cassette('delete_ad_group') do
-          group.destroy.should be_true
+      it "a campaign" do
+        VCR.use_cassette('delete_campaign') do
+          campaign.destroy.should be_true
+          act_campaign.destroy.should be_true
         end
       end
     end
-
   end
 end

data/spec/spec_helper.rb

@@ -44,4 +44,18 @@ def test_access_token
   @test_access_token ||= File.read("test_access_token")
 end
 
+def explain_error(&block)
+  raise "missing code block" unless block_given?
+
+  begin
+    block.call
+  rescue Koala::Facebook::APIError => e
+    puts "=== Facebook API Error ===================================="
+    body = JSON.parse e.response_body
+    body['error'].each { |k, v| printf("%-20s %s\n", k+":", v) }
+    puts "==========================================================="
+    raise e
+  end
+end
+
 require File.expand_path("../../lib/zuck", __FILE__)

data/test_access_token

@@ -1 +1 @@
-CAAEvJ5vzhl8BAICOwypV5nYnYWXhBq1eskHA7rKyrz9fXcAvKRXDWVZAaG7FpQ21qTXeCtGZCR7iu1dtZCqZCZBZCQbefKrMOnZAibDZAiQKiX0s22PgtKuCoQK4LDVimREnqkGdoLMyB4zgT3A6ZAU7pn6wc2mTzZBWVbkr71bZBJKjhyeb4V58TkMsUbN9SQer3ZCRRtWTxqNFTUwHuv51RoVsI7LNw0mCr5gZD
+FAKEACCESSTOKEN

data/zuck.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: zuck 2.0.0 ruby lib
+# stub: zuck 2.1.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "zuck"
-  s.version = "2.0.0"
+  s.version = "2.1.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Jannis Hermanns"]
-  s.date = "2015-01-09"
+  s.date = "2015-04-15"
   s.description = "This gem allows to easily access facebook's ads api in ruby. See https://developers.facebook.com/docs/reference/ads-api/"
   s.email = "jannis@gmail.com"
   s.extra_rdoc_files = [
@@ -55,10 +55,14 @@ Gem::Specification.new do |s|
     "spec/fixtures/ad_interest_search_disney.yml",
     "spec/fixtures/ad_interest_search_moviepilot.yml",
     "spec/fixtures/ad_interest_search_nonexistant.yml",
+    "spec/fixtures/create_a_creative.yml",
     "spec/fixtures/create_ad_campaign.yml",
     "spec/fixtures/create_ad_group.yml",
     "spec/fixtures/create_ad_set.yml",
     "spec/fixtures/delete_ad_group.yml",
+    "spec/fixtures/delete_ad_set.yml",
+    "spec/fixtures/delete_campaign.yml",
+    "spec/fixtures/delete_creative.yml",
     "spec/fixtures/find_a_single_group_and_update_it.yml",
     "spec/fixtures/list_of_ad_accounts.yml",
     "spec/fixtures/list_of_ad_campaigns.yml",