zoom_rb 0.8.2 → 0.8.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4721f6d74fda716d1e2ddd654d86b1609c421b415186db4277424fb3d52242af
-  data.tar.gz: cf96f9fc938c62b9bd453232f2dc8030506d628a9dc6d302a607c7553edcf353
+  metadata.gz: bd9fe92ebc72fd492f6890397894dfefcfa3c64746ad990e45d5340a63223259
+  data.tar.gz: eef68d55a7a1b23a673047be9dfebb1b0f279471bf5e3555519239372003c2cd
 SHA512:
-  metadata.gz: 1a8ccb722f1dd4cc279d4da8751ef799649d06bd7b0d0eb0ca8b57f8012f96d095097187d39b6fc8a2a558072fb27c81fe8ffe2d5781bbf3c12bbb8bc4e096ee
-  data.tar.gz: 409d4446a67bdc8c67b0d178fe3ba470a0fdbaa965b5c5b5e87b0bf951108255585e0ff82e49b85e98d386951d711fd174f47fbeb281c7dc8e25cf7f2adb2478
+  metadata.gz: dda8ac35bc3c0270ee060757fed7ab1c2201d7a29ab637a28e75241c7ee682619b2dea933cf30d58dbf27657f942a1e6580953d755cbc3fcd09a05ba9038b169
+  data.tar.gz: b03116f19de68a63a0e436858ba700ef8b16956f6065eae6bf9e575833ac1ff97340fe8d705d905e8bcb72d0b0ad13269084461d13603ec3651974b98db060b7

data/.circleci/config.yml

@@ -5,6 +5,8 @@
 version: 2
 jobs:
   build:
+    environment:
+      CC_TEST_REPORTER_ID: c6c77975186cfe10e41d9548e9b4a4648f87b56cdbb70bd3896a5a58abf08421
     docker:
       # specify the version you desire here
        - image: circleci/ruby:2.5.1-node-browsers

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    zoom_rb (0.8.1)
+    zoom_rb (0.8.3)
       httparty (~> 0.13)
       json (>= 1.8)
       jwt
@@ -29,7 +29,7 @@ GEM
     method_source (0.9.0)
     multi_xml (0.6.0)
     parallel (1.12.1)
-    parser (2.5.1.2)
+    parser (2.5.3.0)
       ast (~> 2.4.0)
     powerpack (0.1.2)
     pry (0.11.3)
@@ -43,7 +43,7 @@ GEM
       rspec-mocks (~> 3.8.0)
     rspec-core (3.8.0)
       rspec-support (~> 3.8.0)
-    rspec-expectations (3.8.1)
+    rspec-expectations (3.8.2)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.8.0)
     rspec-mocks (3.8.0)
@@ -52,16 +52,16 @@ GEM
     rspec-support (3.8.0)
     rspec_junit_formatter (0.4.1)
       rspec-core (>= 2, < 4, != 2.12.0)
-    rubocop (0.58.2)
+    rubocop (0.60.0)
       jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
       parser (>= 2.5, != 2.5.1.1)
       powerpack (~> 0.1)
       rainbow (>= 2.2.2, < 4.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (~> 1.0, >= 1.0.1)
-    rubocop-rspec (1.29.0)
-      rubocop (>= 0.58.0)
+      unicode-display_width (~> 1.4.0)
+    rubocop-rspec (1.30.1)
+      rubocop (>= 0.60.0)
     ruby-progressbar (1.10.0)
     safe_yaml (1.0.4)
     simplecov (0.16.1)
@@ -88,4 +88,4 @@ DEPENDENCIES
   zoom_rb!
 
 BUNDLED WITH
-   1.16.1
+   1.17.1

data/lib/zoom/actions/meeting.rb

@@ -5,10 +5,10 @@ module Zoom
     module Meeting
       # Create a meeting on Zoom, return the created meeting URL
       def meeting_create(*args)
-        options = Utils.extract_options!(args)
-        Utils.require_params(%i[host_id topic type], options)
-        Utils.process_datetime_params!(:start_time, options)
-        Utils.parse_response self.class.post('/meeting/create', query: options)
+        params = Zoom::Params.new(Utils.extract_options!(args))
+        params.require(%i[user_id])
+        Utils.process_datetime_params!(:start_time, params)
+        Utils.parse_response self.class.post("/users/#{params[:user_id]}/meetings", body: params.except(:user_id).to_json, query: { access_token: access_token })
       end
 
       # Delete a meeting on Zoom, return the deleted meeting ID.

data/lib/zoom/actions/user.rb

@@ -12,8 +12,11 @@ module Zoom
 
       def user_create(*args)
         params = Zoom::Params.new(Utils.extract_options!(args))
-        params.require(%i[email type first_name last_name password])
-        Utils.parse_response self.class.post('/users', body: { action: 'create', user_info: params }.to_json, query: { access_token: access_token })
+        require_param_keys = %i[action email type]
+        require_param_keys.append(:password) if params[:action] == 'autoCreate'
+        params.require(require_param_keys)
+        params.permit_value(:action, Zoom::Constants::USER_CREATE_TYPES.keys)
+        Utils.parse_response self.class.post('/users', body: { action: params[:action], user_info: params.except(:action) }.to_json, query: { access_token: access_token })
       end
 
       def user_get(*args)

data/lib/zoom/actions/webinar.rb

@@ -89,7 +89,7 @@ module Zoom
               .permit(%i[occurrence_ids address city country zip state phone
                          industry org job_title purchasing_time_frame role_in_purchase_process
                          no_of_employees comments custom_questions])
-        Utils.parse_response self.class.post("/webinars/#{params[:id]}/registrants", body: params.except(:id, :occurrence_ids), query: params.slice(:occurrence_ids).merge(access_token: access_token))
+        Utils.parse_response self.class.post("/webinars/#{params[:id]}/registrants", body: params.except(:id, :occurrence_ids).to_json, query: params.slice(:occurrence_ids).merge(access_token: access_token))
       end
 
       def webinar_registrants_status_update(*args)

data/lib/zoom/constants.rb

@@ -92,5 +92,12 @@ module Zoom
                    'pro' => 2,
                    'corp' => 3
                   }.freeze # no default
+
+    USER_CREATE_TYPES = {
+                          'create' => 'User will get an email sent from Zoom. There is a confirmation link in this email. User will then need to click this link to activate their account to the Zoom service. The user can set or change their password in Zoom.',
+                          'custCreate' => 'This action is provided for enterprise customer who has a managed domain. This feature is disabled by default because of the security risk involved in creating a user who does not belong to your domain without notifying the user.',
+                          'autoCreate' => 'This action is provided for API partner only. User created in this way has no password and is not able to log into the Zoom web site or client.',
+                          'ssoCreate' => 'This action is provided for enabled “Pre-provisioning SSO User” option. User created in this way has no password. If it is not a basic user, will generate a Personal Vanity URL using user name (no domain) of the provisioning email. If user name or pmi is invalid or occupied, will use random number/random personal vanity URL.'
+                       }.freeze # no default
   end
 end

data/lib/zoom/error.rb

@@ -6,4 +6,5 @@ module Zoom
   class NotImplemented < StandardError; end
   class ParameterMissing < StandardError; end
   class ParameterNotPermitted < StandardError; end
+  class ParameterValueNotPermitted < StandardError; end
 end

data/lib/zoom/params.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-require 'pry'
+
 module Zoom
   class Params < SimpleDelegator
     # delegate :keys, :key?, :has_key?, :values, :has_value?, :value?, :empty?,
@@ -60,5 +60,12 @@ module Zoom
         array << k if self[k].nil?
       end
     end
+
+    def permit_value(key, values)
+      value = @parameters[key]
+      if !values.include?(value)
+        raise Zoom::ParameterValueNotPermitted, "#{key}: #{value}"
+      end
+    end
   end
 end

data/spec/fixtures/error/user_not_exist.json

@@ -0,0 +1,4 @@
+{
+  "code": 1001,
+  "message": "User not exist: foo"
+}

data/spec/fixtures/meeting/create.json

@@ -1,24 +1,29 @@
 {
   "uuid": "unique_id",
   "id": "123456789",
-  "start_url": "https://zoom.us/s/123456789?zak=xxxxxx",
-  "join_url": "https://zoom.us/j/123456789",
-  "created_at": "2012-11-25T12:00:00Z",
-  "host_id": "ufR93M2pRyy8ePFN92dttq",
+  "host_id": "8MheRP7ZT-2hDySevBj5Gg",
   "topic": "Foo",
   "type": 2,
-  "option_jbh": false,
-  "option_start_type": "video",
-  "start_time": "2012-11-25T12:00:00Z",
-  "duration": 30,
+  "start_time": "2018-10-09T05:49:21Z",
+  "duration": 60,
   "timezone": "America/Los_Angeles",
-  "password": "123",
-  "h323_password": "123456",
-  "option_host_video": false,
-  "option_participants_video": false,
-  "option_audio": "both",
-  "option_enforce_login": false,
-  "option_enforce_login_domains ": "",
-  "option_alternative_hosts": "",
-  "status": 0
+  "created_at": "2018-10-09T05:49:21Z",
+  "start_url": "https://zoom.us/s/123456789?zak=xxxxxx",
+  "join_url": "https://zoom.us/j/123456789",
+  "settings": {
+    "host_video": false,
+    "participant_video": false,
+    "cn_meeting": false,
+    "in_meeting": false,
+    "join_before_host": true,
+    "mute_upon_entry": false,
+    "watermark": false,
+    "use_pmi": false,
+    "approval_type": 2,
+    "audio": "both",
+    "auto_recording": "none",
+    "enforce_login": false,
+    "enforce_login_domains": "",
+    "alternative_hosts": ""
+  }
 }

data/spec/lib/zoom/actions/meeting/create_spec.rb

@@ -2,65 +2,62 @@
 
 require 'spec_helper'
 
-xdescribe Zoom::Actions::Meeting do
+describe Zoom::Actions::Meeting do
   let(:zc) { zoom_client }
-  let(:args) { { host_id: 'ufR93M2pRyy8ePFN92dttq', type: 2, topic: 'Foo' } }
+  let(:args) { { user_id: 'ufR93M2pRyy8ePFN92dttq', type: 2, topic: 'Foo' } }
   let(:response) { zc.meeting_create(args) }
 
-  xdescribe '#meeting_create action' do
-    before :each do
-      stub_request(
-        :post,
-        zoom_url('/meeting/create')
-      ).to_return(body: json_response('meeting','create'))
-    end
-
-    it "requires a 'host_id' argument" do
-      expect {
-        zc.meeting_create(filter_key(args, :host_id))
-      }.to raise_error(ArgumentError)
-    end
-
-    it "requires a 'topic' argument" do
-      expect {
-        zc.meeting_create(filter_key(args, :topic))
-      }.to raise_error(ArgumentError)
-    end
-
-    it "requires a 'type' argument" do
-      expect {
-        zc.meeting_create(filter_key(args, :type))
-      }.to raise_error(ArgumentError)
-    end
-
-    it 'returns a hash' do
-      expect(response).to be_kind_of(Hash)
-    end
-
-    it 'returns the set params' do
-      expect(response['host_id']).to eq(args[:host_id])
-      expect(response['type']).to eq(args[:type])
-      expect(response['topic']).to eq(args[:topic])
-    end
-
-    it "returns 'start_url' and 'join_url'" do
-      expect(response['start_url']).to_not be_nil
-      expect(response['join_url']).to_not be_nil
-    end
-  end
-
-  xdescribe '#meeting_create! action' do
-    before :each do
-      stub_request(
-        :post,
-        zoom_url('/meeting/create')
-      ).to_return(body: json_response('error'))
-    end
-
-    it 'raises Zoom::Error exception' do
-      expect {
-        zc.meeting_create!(args)
-      }.to raise_error(Zoom::Error)
+  describe '#meeting_create action' do
+    context 'with 201 response' do
+      before :each do
+        stub_request(
+          :post,
+          zoom_url("/users/#{args[:user_id]}/meetings")
+        ).to_return(status: 201,
+                    body: json_response('meeting','create'),
+                    headers: {"Content-Type"=> "application/json"})
+      end
+
+      it "requires user_id param" do
+        expect {
+          zc.meeting_create(filter_key(args, :user_id))
+        }.to raise_error(Zoom::ParameterMissing, [:user_id].to_s)
+      end
+
+      it "requires user_id param" do
+        expect {
+          zc.meeting_create(args)
+        }.not_to raise_error
+      end
+
+      it 'returns a hash' do
+        expect(response).to be_kind_of(Hash)
+      end
+
+      it 'returns the set params' do
+        expect(response['type']).to eq(args[:type])
+        expect(response['topic']).to eq(args[:topic])
+      end
+
+      it "returns 'start_url' and 'join_url'" do
+        expect(response['start_url']).to_not be_nil
+        expect(response['join_url']).to_not be_nil
+      end
+    end
+
+    context 'with 404 response' do
+      before :each do
+        stub_request(
+          :post,
+          zoom_url("/users/#{args[:user_id]}/meetings")
+        ).to_return(status: 404,
+                    body: json_response('error', 'user_not_exist'),
+                    headers: {"Content-Type"=> "application/json"})
+      end
+
+      it 'raises an error' do
+        expect { response }.to raise_error(Zoom::Error)
+      end
     end
   end
 end

data/spec/lib/zoom/actions/user/create_spec.rb

@@ -5,7 +5,8 @@ require 'spec_helper'
 describe Zoom::Actions::User do
   let(:zc) { zoom_client }
   let(:args) do
-    { email: 'foo@bar.com',
+    { action: 'create',
+      email: 'foo@bar.com',
       first_name: 'Zoomie',
       last_name: 'Userton',
       type: 1,
@@ -23,23 +24,49 @@ describe Zoom::Actions::User do
                     headers: {"Content-Type"=> "application/json"})
       end
 
-      it 'requires email param' do
-        expect { zc.user_create(filter_key(args, :email)) }.to raise_error(Zoom::ParameterMissing, [:email].to_s)
+      it 'requires action param' do
+        expect { zc.user_create(filter_key(args, :action)) }.to raise_error(Zoom::ParameterMissing, [:action].to_s)
+      end
+
+      it 'does not raise an error when action is create' do
+        args[:action] = 'create'
+        expect { zc.user_create(args) }.not_to raise_error
+      end
+
+      it 'does not raise an error when action is custCreate' do
+        args[:action] = 'custCreate'
+        expect { zc.user_create(args) }.not_to raise_error
+      end
+
+      it 'does not raise an error when action is autoCreate' do
+        args[:action] = 'autoCreate'
+        expect { zc.user_create(args) }.not_to raise_error
       end
 
-      it 'requires first_name param' do
-        expect { zc.user_create(filter_key(args, :first_name)) }.to raise_error(Zoom::ParameterMissing, [:first_name].to_s)
+      it 'does not raise an error when action is ssoCreate' do
+        args[:action] = 'ssoCreate'
+        expect { zc.user_create(args) }.not_to raise_error
       end
 
-      it 'requires last_name param' do
-        expect { zc.user_create(filter_key(args, :last_name)) }.to raise_error(Zoom::ParameterMissing, [:last_name].to_s)
+      it 'requires valid action' do
+        args[:action] = 'baz'
+        expect { zc.user_create(args) }.to raise_error(Zoom::ParameterValueNotPermitted, "#{:action.to_s}: #{args[:action].to_s}")
+      end
+
+      it 'requires email param' do
+        expect { zc.user_create(filter_key(args, :email)) }.to raise_error(Zoom::ParameterMissing, [:email].to_s)
       end
 
       it 'requires type param' do
         expect { zc.user_create(filter_key(args, :type)) }.to raise_error(Zoom::ParameterMissing, [:type].to_s)
       end
 
-      it 'requires password param' do
+      it 'does not require password param when action is not autoCreate' do
+        expect { zc.user_create(filter_key(args, :password)) }.not_to raise_error
+      end
+
+      it 'requires password param when action is autoCreate' do
+        args[:action] = 'autoCreate'
         expect { zc.user_create(filter_key(args, :password)) }.to raise_error(Zoom::ParameterMissing, [:password].to_s)
       end
 

data/spec/lib/zoom/params_spec.rb

@@ -65,4 +65,17 @@ RSpec.describe Zoom::Params do
       end
     end
   end
-end
+
+  describe '#permit_value' do
+    let(:params) { Zoom::Params.new(foo: :bar, baz: :bang) }
+    let(:values) { %i(bar baz) }
+
+    it 'does not raise an error when required value are present in values' do
+      expect { params.permit_value(:foo, values) }.not_to raise_error
+    end
+
+    it 'does raise an error when required keys are missing' do
+      expect { params.permit_value(:baz, values) }.to raise_error(Zoom::ParameterValueNotPermitted, "#{:baz.to_s}: #{:bang.to_s}")
+    end
+  end
+end

data/zoom_rb.gemspec

@@ -3,15 +3,15 @@
 Gem::Specification.new do |gem|
 
   gem.add_dependency 'httparty', '~> 0.13'
-  gem.add_dependency 'json', '>= 1.8'
-  gem.add_dependency 'jwt'
+  gem.add_dependency 'json', '~> 2.1'
+  gem.add_dependency 'jwt', '~> 2.1'
 
-  gem.add_development_dependency 'pry'
-  gem.add_development_dependency 'hint-rubocop_style'
-  gem.add_development_dependency 'rspec'
-  gem.add_development_dependency 'rspec_junit_formatter'
-  gem.add_development_dependency 'simplecov'
-  gem.add_development_dependency 'webmock'
+  gem.add_development_dependency 'pry', '~> 0'
+  gem.add_development_dependency 'hint-rubocop_style', '~> 0'
+  gem.add_development_dependency 'rspec', '~> 3.8'
+  gem.add_development_dependency 'rspec_junit_formatter', '~> 0.4.1'
+  gem.add_development_dependency 'simplecov', '~> 0.16.1'
+  gem.add_development_dependency 'webmock', '~> 3.4'
 
   gem.authors       = ['Kyle Boe']
   gem.email         = ['kyle@boe.codes']
@@ -25,5 +25,5 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.name          = 'zoom_rb'
   gem.require_paths = ['lib']
-  gem.version       = '0.8.2'
+  gem.version       = '0.8.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: zoom_rb
 version: !ruby/object:Gem::Version
-  version: 0.8.2
+  version: 0.8.3
 platform: ruby
 authors:
 - Kyle Boe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-03 00:00:00.000000000 Z
+date: 2018-11-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -28,114 +28,114 @@ dependencies:
   name: json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: '2.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: '2.1'
 - !ruby/object:Gem::Dependency
   name: jwt
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.1'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: hint-rubocop_style
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.8'
 - !ruby/object:Gem::Dependency
   name: rspec_junit_formatter
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.4.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.4.1
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.16.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.16.1
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.4'
 description: A Ruby API wrapper for zoom.us API
 email:
 - kyle@boe.codes
@@ -173,6 +173,7 @@ files:
 - spec/fixtures/chat/list.json
 - spec/fixtures/error/already_exists.json
 - spec/fixtures/error/not_found.json
+- spec/fixtures/error/user_not_exist.json
 - spec/fixtures/error/validation.json
 - spec/fixtures/mc_recording_list.json
 - spec/fixtures/meeting/create.json
@@ -344,6 +345,7 @@ test_files:
 - spec/fixtures/chat/list.json
 - spec/fixtures/error/already_exists.json
 - spec/fixtures/error/not_found.json
+- spec/fixtures/error/user_not_exist.json
 - spec/fixtures/error/validation.json
 - spec/fixtures/mc_recording_list.json
 - spec/fixtures/meeting/create.json