zookeeper 1.2.1 → 1.2.2

data/CHANGELOG

@@ -1,3 +1,13 @@
+v1.2.2 avoid race while waiting for connection
+
+  * There was a possible race in CZookeeper#wait_until_connected where if we
+    couldn't connect to the port specified (localhost:28271) then we wound up
+    burning 100% CPU and spinning. This solution fixes that by hooking into the
+    event delivery and keeping track of what the current state is. When there's
+    a change, we use a ConditionVariable to wake up threads that were waiting
+    until the connection was connected. Additionally, we now respect the
+    timeout parameter again.
+
 v1.2.1 simplify assert_open
 
   * The client methods were all calling assert_open before performing an

data/ext/c_zookeeper.rb

@@ -70,7 +70,10 @@ class CZookeeper
     @running_cond = @mutex.new_cond
 
     # used to signal we've received the connected event
-    @connected_cond = @mutex.new_cond
+    @state_cond = @mutex.new_cond
+
+    # the current state of the connection
+    @state = ZOO_CLOSED_STATE
 
     @pipe_read, @pipe_write = IO.pipe
     
@@ -167,12 +170,13 @@ class CZookeeper
   # if timeout is nil, we never time out, and wait forever for CONNECTED state
   #
   def wait_until_connected(timeout=10)
-    # this begin/ensure/end style is recommended by tarceri
-    # no need to create a context for every mutex grab
 
-    wait_until_running(timeout)
+    return false unless wait_until_running(timeout)
+
+    @mutex.synchronize do
+      @state_cond.wait(timeout) unless (@state == ZOO_CONNECTED_STATE)
+    end
 
-    Thread.pass until connected? or is_unrecoverable
     connected?
   end
 
@@ -222,13 +226,10 @@ class CZookeeper
     #
     # returns true if we're running, false if we timed out
     def wait_until_running(timeout=5) 
-      @mutex.lock
-      begin
+      @mutex.synchronize do
         return true if @_running
         @running_cond.wait(timeout)
         !!@_running
-      ensure
-        @mutex.unlock rescue nil
       end
     end
 
@@ -286,11 +287,17 @@ class CZookeeper
       while hash = zkrb_get_next_event_st()
         logger.debug { "#{self.class}##{__method__} got #{hash.inspect} " }
 
-        # notify when we get this event so we know we're connected
-        if hash.values_at(:req_id, :type, :state) == CONNECTED_EVENT_VALUES[1..2]
-          notify_connected!
-        end
+        if (hash[:req_id] == ZKRB_GLOBAL_CB_REQ) && (hash[:type] == -1)
+          ev_state = hash[:state]
 
+          if @state != ev_state
+            @mutex.synchronize do
+              @state = ev_state
+              @state_cond.broadcast
+            end
+          end
+        end
+        
         cntn = @reg.in_flight.delete(hash[:req_id])
 
         if cntn and not cntn.user_callback?     # this is one of "our" continuations 
@@ -307,14 +314,11 @@ class CZookeeper
     def event_thread_await_running
       logger.debug { "event_thread waiting until running: #{@_running}" }
 
-      @mutex.lock
-      begin
+      @mutex.synchronize do
         @running_cond.wait_until { @_running or @_shutting_down }
         logger.debug { "event_thread running: #{@_running}" }
 
         raise ShuttingDownException if @_shutting_down
-      ensure
-        @mutex.unlock rescue nil
       end
     end
 
@@ -329,22 +333,16 @@ class CZookeeper
     def zkc_set_running_and_notify!
       logger.debug { "#{self.class}##{__method__}" }
 
-      @mutex.lock
-      begin
+      @mutex.synchronize do
         @_running = true
         @running_cond.broadcast
-      ensure
-        @mutex.unlock rescue nil
       end
     end
 
-    def notify_connected!
-      @mutex.lock
-      begin
-        @connected_cond.broadcast
-      ensure
-        @mutex.unlock rescue nil
-      end
-    end
+#     def notify_state_change!
+#       @mutex.synchronize do
+#         @state_cond.broadcast
+#       end
+#     end
 end
 end

data/java/java_base.rb

@@ -405,7 +405,7 @@ class JavaBase
 
   def assert_open
     # XXX don't know how to check for valid session state!
-    raise ZookeeperException::NotConnected unless connected?
+    raise NotConnected unless connected?
   end
 
   # set the watcher object/proc that will receive all global events (such as session/state events)

data/lib/zookeeper/version.rb

@@ -1,4 +1,4 @@
 module Zookeeper
-  VERSION = '1.2.1'
+  VERSION = '1.2.2'
   DRIVER_VERSION = '3.3.5'
 end

data/spec/spec_helper.rb

@@ -51,3 +51,11 @@ RSpec.configure do |config|
   end
 end
 
+require 'pp'
+
+if RUBY_VERSION == '1.9.3'
+  trap('USR1') do
+    threads = Thread.list.map { |th| th.backtrace }
+    pp threads
+  end
+end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: zookeeper
 version: !ruby/object:Gem::Version 
-  hash: 29
+  hash: 27
   prerelease: 
   segments: 
   - 1
   - 2
-  - 1
-  version: 1.2.1
+  - 2
+  version: 1.2.2
 platform: ruby
 authors: 
 - Phillip Pearson