zonebie-info 0.0.7 → 0.0.8

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    N2U2ZWJkNjBmZDE4YzYyN2RiZGM2Nzc0ZGFlZjExNGJiZGExZDhiNg==
+    YTk2ZDA5NjQwYjc5ZjAxYmVkYjlkNDQ1YjVhMWVhZmRhZDQzZjFmYQ==
   data.tar.gz: !binary |-
-    YzIxYTk0ZjZiMDQxMjM3OTM1YTRkNGEzNTQ5NDcwM2YxYzQzMmI1Yg==
+    M2M4NmM5NWI0ZjVjZjcwODgyNGNlZGVhY2RkM2NlZjM5MTMxZGU2OA==
 SHA512:
   metadata.gz: !binary |-
-    NTM3ZjNiOTI2NDYxYzdlNjdjNWEwOWZlN2EyOWZkMmM2OGMyMmU4M2RhYmVj
-    MDMwMzYyNWYwZTcyZjJlYjg3MmVlMzBiM2ZlOTMzNzY3Y2VhMDY2MDkxOGZl
-    ZGU0OTkyOTExM2M5NmNmODlmYzhmODI0ZDljYzQ3OTM4NmNlZTc=
+    MjViYjE2NmExYWVjNGJiNmQxNzgyOTdmOTAxOGRiN2JkN2YzOTVjOTYyMTgw
+    OTYzYTBmYjg0YzBlZjY4MWMwYThjNDk1ZDE5MWY3YWZlMTMwOTMzOTlkYjY4
+    ZGZhNjY3NzUwYTBkMWIzMzg5Njc1YWI1YmJkNTk0YzI5NzMxOWU=
   data.tar.gz: !binary |-
-    YzBhNTcxZjZmNDRlMzhmYjJiNmQxNDdjZWQ3MmVmZDJmMjg0NDQ0NmRkMTA2
-    N2RkMGI4NjBmYTI0MWNmMGQ4OWMzYTgzMDcyNGEwN2E0NjY3NjU5OGY5NzY1
-    NjJhZThiZjY0YjY2MDIwZjEwZWVkYmE3NjgyNDAyNDI1ODAzNWM=
+    ODk5MTllYTk2ZTEwODI4ZDMxOWVmNzdmNmJiNTE4NTBiODgxNmZmNzgyMmE3
+    NjZjOWI1YmY5NzA4MzNiM2QzMmFiMzI3YmM5ODllOTA1YzRjMmIyODY2Mzdi
+    OTYxYzUxYTBlY2NiYzQ2OTYzZTM4N2UwNzY4OTkwYzhlZjhkOTA=

data/lib/zonebie/info/version.rb

@@ -1,5 +1,5 @@
 module Zonebie
   module Info
-    VERSION = '0.0.7'
+    VERSION = '0.0.8'
   end
 end

data/lib/zonebie/info.rb

@@ -1,5 +1,6 @@
 require 'zonebie'
 require 'wikipedia'
+require 'byebug'
 
 module Zonebie
   class << self
@@ -15,11 +16,14 @@ module Zonebie
     end
 
     def print_timezone_info
-      case @request
-      when nil
+      if @request.nil?
         $stderr.puts '', 'Please set the ZONEBIE_INFO environment variable to load data from Wikipedia'
       else
-        $stdout.puts '', @request.join.value
+        if @request.alive?
+          $stderr.puts '', 'Wikipedia download did not complete in time, please check your network connection and try again later'
+        else
+          $stdout.puts '', @request.join.value
+        end
       end
     end
 

data/spec/integration/info_spec.rb

@@ -21,6 +21,7 @@ describe '#print_timezone_info' do
   end
 
   it 'prints info about the time zone to stdout' do
+    sleep 0.01
     Zonebie.print_timezone_info
     out.rewind
     expect(out.read).to eq expected

data/spec/zonebie/info_spec.rb

@@ -64,8 +64,29 @@ describe Zonebie do
       end
     end
 
+    context 'when the request has not completed in time' do
+      let(:message) do
+        'Wikipedia download did not complete in time, please check your network connection and try again later'
+      end
+      let(:t) { Thread.new { sleep 1000 } }
+
+      before do
+        Zonebie.instance_variable_set('@request', t)
+        $stderr = out
+      end
+
+      after do
+        $stderr = STDERR
+      end
+      it 'informs the user the request did not finish in time' do
+        Zonebie.print_timezone_info
+        out.rewind
+        expect(out.read).to eq "\n#{message}\n"
+      end
+    end
+
     context 'when the request succeeds' do
-      let(:t) { Thread.new { 'hello' } }
+      let!(:t) { Thread.new { 'hello' } }
 
       before do
         Zonebie.instance_variable_set '@request', t
@@ -77,6 +98,7 @@ describe Zonebie do
       end
 
       it 'prints the info from wikipedia' do
+        sleep 0.001 # Allow the thread to complete
         Zonebie.print_timezone_info
         out.rewind
         expect(out.read).to eq "\nhello\n"

data/zonebie-info.gemspec

@@ -21,4 +21,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'rspec', '~> 3.0', '>= 3.0.0'
   gem.add_development_dependency 'rubocop', '~> 0.34', '>= 0.34.1'
   gem.add_development_dependency 'simplecov', '~> 0.10', '>= 0.10.0'
+  gem.add_development_dependency 'byebug'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: zonebie-info
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors:
 - Tom Bowden
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-14 00:00:00.000000000 Z
+date: 2015-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: zonebie
@@ -150,6 +150,20 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: 0.10.0
+- !ruby/object:Gem::Dependency
+  name: byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Downloads the first paragraph from wikipedia about the randomly set timezone
 email:
 - tom.b1992@gmail.com