zold 0.15.0 → 0.16.0

data/lib/zold/commands/routines/reconnect.rb

@@ -47,6 +47,7 @@ module Zold
         score = @farm.best[0]
         args << "--ignore-node=#{score.host}:#{score.port}" if score
         cmd.run(args + ['defaults']) unless @opts['routine-immediately']
+        return if @opts['routine-immediately'] && @remotes.all.empty?
         cmd.run(args + ['trim'])
         cmd.run(args + ['select'])
         cmd.run(args + ['update'] + (@opts['never-reboot'] ? [] : ['--reboot']))

data/lib/zold/copies.rb

@@ -22,10 +22,12 @@
 
 require 'time'
 require 'csv'
+require 'futex'
 require 'backtrace'
 require_relative 'log'
 require_relative 'size'
 require_relative 'wallet'
+require_relative 'dir_items'
 
 # The list of copies.
 # Author:: Yegor Bugayenko (yegor256@gmail.com)
@@ -38,15 +40,12 @@ module Zold
     EXT = '.zc'
 
     def initialize(dir, log: Log::Quiet.new)
-      raise 'Dir can\'t be nil' if dir.nil?
       @dir = dir
-      raise 'Log can\'t be nil' if log.nil?
       @log = log
-      @mutex = Mutex.new
     end
 
     def root
-      File.join(@dir, '..')
+      File.expand_path(File.join(@dir, '..'))
     end
 
     def to_s
@@ -54,7 +53,7 @@ module Zold
     end
 
     def clean
-      @mutex.synchronize do
+      Futex.new(file, log: @log).open do
         list = load
         list.reject! { |s| s[:time] < Time.now - 24 * 60 * 60 }
         save(list)
@@ -74,7 +73,7 @@ module Zold
             wallet.refurbish
             raise "Invalid protocol #{wallet.protocol} in #{file}" unless wallet.protocol == Zold::PROTOCOL
           rescue StandardError => e
-            File.delete(file)
+            FileUtils.rm_rf(file)
             @log.debug("Copy at #{f} deleted: #{Backtrace.new(e)}")
             deleted += 1
           end
@@ -84,7 +83,7 @@ module Zold
     end
 
     def remove(host, port)
-      @mutex.synchronize do
+      Futex.new(file, log: @log).open do
         save(load.reject { |s| s[:host] == host && s[:port] == port })
       end
     end
@@ -98,21 +97,21 @@ module Zold
       raise "Time must be in the past: #{time}" if time > Time.now
       raise 'Score must be Integer' unless score.is_a?(Integer)
       raise "Score can't be negative: #{score}" if score.negative?
-      @mutex.synchronize do
+      Futex.new(file, log: @log).open do
         FileUtils.mkdir_p(@dir)
         list = load
         target = list.find do |s|
           f = File.join(@dir, "#{s[:name]}#{Copies::EXT}")
-          File.exist?(f) && File.read(f) == content
+          File.exist?(f) && IO.read(f) == content
         end
         if target.nil?
-          max = Dir.new(@dir)
+          max = DirItems.new(@dir).fetch
             .select { |f| File.basename(f, Copies::EXT) =~ /^[0-9]+$/ }
             .map(&:to_i)
             .max
           max = 0 if max.nil?
           name = (max + 1).to_s
-          File.write(File.join(@dir, "#{name}#{Copies::EXT}"), content)
+          IO.write(File.join(@dir, "#{name}#{Copies::EXT}"), content)
         else
           name = target[:name]
         end
@@ -130,7 +129,7 @@ module Zold
     end
 
     def all
-      @mutex.synchronize do
+      Futex.new(file, log: @log).open do
         load.group_by { |s| s[:name] }.map do |name, scores|
           {
             name: name,
@@ -160,7 +159,7 @@ module Zold
     private
 
     def save(list)
-      File.write(
+      IO.write(
         file,
         list.map do |r|
           [
@@ -173,7 +172,7 @@ module Zold
     end
 
     def files
-      Dir.new(@dir).select { |f| File.basename(f, Copies::EXT) =~ /^[0-9]+$/ }
+      DirItems.new(@dir).fetch.select { |f| File.basename(f, Copies::EXT) =~ /^[0-9]+$/ }
     end
 
     def file

data/lib/zold/dir_items.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+# Copyright (c) 2018 Yegor Bugayenko
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the 'Software'), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in all
+# copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+# SOFTWARE.
+
+# Items in a directory.
+#
+# We need this class because Dir.new() from Ruby is blocking. It doesn't
+# allow to write and read to any files in a directory, while listing it.
+# More: https://stackoverflow.com/questions/52987672/
+#
+# Author:: Yegor Bugayenko (yegor256@gmail.com)
+# Copyright:: Copyright (c) 2018 Yegor Bugayenko
+# License:: MIT
+module Zold
+  # Items in a dir
+  class DirItems
+    def initialize(dir)
+      @dir = dir
+    end
+
+    def fetch(recursive: true)
+      txt = `find #{@dir} #{recursive ? '' : '-maxdepth 1'} -type f -print 2>/dev/null`
+      txt.nil? ? [] : txt.strip.split(' ').map { |f| f[(@dir.length + 1)..-1] }
+    end
+  end
+end

data/lib/zold/head.rb

@@ -39,7 +39,7 @@ module Zold
 
     def fetch
       raise "Wallet file '#{@file}' is absent" unless File.exist?(@file)
-      lines = File.read(@file).split(/\n/)
+      lines = IO.read(@file).split(/\n/)
       raise "Not enough lines in #{@file}, just #{lines.count}" if lines.count < 4
       lines.take(4)
     end

data/lib/zold/key.rb

@@ -37,7 +37,7 @@ module Zold
         unless file.nil?
           path = File.expand_path(file)
           raise "Can't find RSA key at #{file} (#{path})" unless File.exist?(path)
-          return File.read(path)
+          return IO.read(path)
         end
         unless text.nil?
           return text if text.start_with?('-----')
@@ -77,7 +77,7 @@ module Zold
       text = @body.call.strip
       unless text.start_with?('-----BEGIN')
         Tempfile.open do |f|
-          File.write(f.path, text)
+          IO.write(f.path, text)
           text = `ssh-keygen -f #{f.path} -e -m pem`
         end
       end

data/lib/zold/log.rb

@@ -54,6 +54,7 @@ module Zold
       end
 
       def debug(msg)
+        return unless debug?
         @mutex.synchronize do
           @log.debug(msg)
         end
@@ -64,6 +65,7 @@ module Zold
       end
 
       def info(msg)
+        return unless info?
         @mutex.synchronize do
           @log.info(msg)
         end

data/lib/zold/node/async_entrance.rb

@@ -21,11 +21,13 @@
 # SOFTWARE.
 
 require 'concurrent'
+require 'futex'
 require_relative '../log'
 require_relative '../age'
 require_relative '../size'
 require_relative '../id'
 require_relative '../verbose_thread'
+require_relative '../dir_items'
 
 # The async entrance of the web front.
 # Author:: Yegor Bugayenko (yegor256@gmail.com)
@@ -35,29 +37,25 @@ module Zold
   # The entrance
   class AsyncEntrance
     # How many threads to use for processing
-    THREADS = Concurrent.processor_count * 8
+    THREADS = [Concurrent.processor_count, 4].max
 
     # Queue length
     MAX_QUEUE = Concurrent.processor_count * 64
 
     def initialize(entrance, dir, log: Log::Quiet.new)
-      raise 'Entrance can\'t be nil' if entrance.nil?
       @entrance = entrance
-      raise 'Directory can\'t be nil' if dir.nil?
-      raise 'Directory must be of type String' unless dir.is_a?(String)
       @dir = dir
-      raise 'Log can\'t be nil' if log.nil?
       @log = log
       @mutex = Mutex.new
     end
 
     def to_json
+      opts = queue
       json = {
-        'queue': queue.count,
+        'queue': opts.count,
         'pool.length': @pool.length,
         'pool.running': @pool.running?
       }
-      opts = queue
       json['queue_age'] = opts.empty? ? 0 : Time.now - File.mtime(File.join(@dir, opts[0]))
       @entrance.to_json.merge(json)
     end
@@ -66,7 +64,9 @@ module Zold
       @entrance.start do
         FileUtils.mkdir_p(@dir)
         @pool = Concurrent::FixedThreadPool.new(
-          AsyncEntrance::THREADS, max_queue: AsyncEntrance::MAX_QUEUE, fallback_policy: :abort
+          AsyncEntrance::THREADS,
+          max_queue: AsyncEntrance::MAX_QUEUE,
+          fallback_policy: :abort
         )
         AsyncEntrance::THREADS.times do |t|
           @pool.post do
@@ -80,14 +80,21 @@ module Zold
         end
         begin
           yield(self)
+          cycle = 0
+          until queue.empty?
+            @log.info("Stopping async entrance, #{queue.count} still in the queue (cycle=#{cycle})...")
+            cycle += 1
+            raise "Can't wait for async entrance to stop for so long" if cycle > 10
+            sleep 1
+          end
         ensure
           @log.info("Stopping async entrance, pool length is #{@pool.length}, queue length is #{@pool.queue_length}")
           @pool.shutdown
           if @pool.wait_for_termination(10)
-            @log.info('Async entrance terminated peacefully')
+            @log.info("Async entrance terminated peacefully with #{queue.count} wallets left in the queue")
           else
             @pool.kill
-            @log.info('Async entrance was killed')
+            @log.info("Async entrance was killed, #{queue.count} wallets left in the queue")
           end
         end
       end
@@ -96,36 +103,39 @@ module Zold
     # Always returns an array with a single ID of the pushed wallet
     def push(id, body)
       raise "Queue is too long (#{queue.count} wallets), try again later" if queue.count > AsyncEntrance::MAX_QUEUE
-      @mutex.synchronize do
-        File.write(File.join(@dir, id.to_s), body)
+      start = Time.now
+      Futex.new(file(id), log: @log).open do |f|
+        IO.write(f, body)
       end
+      @log.debug("Added #{id}/#{Size.new(body.length)} to the queue at pos.#{queue.count} \
+in #{Age.new(start, limit: 0.05)}")
       [id]
     end
 
     private
 
     def take
-      id = ''
-      body = ''
-      @mutex.synchronize do
-        opts = queue
-        unless opts.empty?
-          file = File.join(@dir, opts[0])
-          id = opts[0]
-          body = File.read(file)
-          File.delete(file)
-        end
-      end
-      return if id.empty? || body.empty?
       start = Time.now
+      opts = queue
+      return if opts.empty?
+      id = opts[0]
+      body = Futex.new(file(id), log: @log).open do |f|
+        b = File.exist?(f) ? IO.read(f) : ''
+        FileUtils.rm_f(f)
+        b
+      end
+      return if body.empty?
       @entrance.push(Id.new(id), body)
-      @log.debug("Pushed #{id}/#{Size.new(body.length)} to #{@entrance.class.name} in #{Age.new(start)}")
+      @log.debug("Pushed #{id}/#{Size.new(body.length)} to #{@entrance.class.name} \
+in #{Age.new(start, limit: 0.1)} (#{queue.count} still in the queue)")
     end
 
     def queue
-      Dir.new(@dir)
-        .select { |f| f =~ /^[0-9a-f]{16}$/ }
-        .sort_by { |f| File.mtime(File.join(@dir, f)) }
+      DirItems.new(@dir).fetch.select { |f| f =~ /^[0-9a-f]{16}$/ }
+    end
+
+    def file(id)
+      File.join(@dir, id.to_s)
     end
   end
 end

data/lib/zold/node/entrance.rb

@@ -25,6 +25,7 @@ require_relative '../log'
 require_relative '../remotes'
 require_relative '../copies'
 require_relative '../tax'
+require_relative '../age'
 require_relative '../commands/clean'
 require_relative '../commands/merge'
 require_relative '../commands/fetch'
@@ -38,19 +39,11 @@ module Zold
   # The entrance
   class Entrance
     def initialize(wallets, remotes, copies, address, log: Log::Quiet.new, network: 'test')
-      raise 'Wallets can\'t be nil' if wallets.nil?
-      raise 'Wallets must implement the contract of Wallets: method #find is required' unless wallets.respond_to?(:find)
       @wallets = wallets
-      raise 'Remotes can\'t be nil' if remotes.nil?
-      raise "Remotes must be of type Remotes: #{remotes.class.name}" unless remotes.is_a?(Remotes)
       @remotes = remotes
-      raise 'Copies can\'t be nil' if copies.nil?
       @copies = copies
-      raise 'Address can\'t be nil' if address.nil?
       @address = address
-      raise 'Log can\'t be nil' if log.nil?
       @log = log
-      raise 'Network can\'t be nil' if network.nil?
       @network = network
       @history = []
       @speed = []
@@ -88,12 +81,12 @@ module Zold
       ).run(['merge', id.to_s])
       Clean.new(wallets: @wallets, copies: copies.root, log: @log).run(['clean', id.to_s])
       copies.remove(localhost, Remotes::PORT)
-      sec = (Time.now - start).round(2)
       if modified.empty?
-        @log.info("Accepted #{id} in #{sec}s and not modified anything")
+        @log.info("Accepted #{id} in #{Age.new(start, limit: 1)} and not modified anything")
       else
-        @log.info("Accepted #{id} in #{sec}s and modified #{modified.join(', ')}")
+        @log.info("Accepted #{id} in #{Age.new(start, limit: 1)} and modified #{modified.join(', ')}")
       end
+      sec = (Time.now - start).round(2)
       @mutex.synchronize do
         @history.shift if @history.length >= 16
         @speed.shift if @speed.length >= 64

data/lib/zold/node/farm.rb

@@ -23,6 +23,7 @@
 require 'time'
 require 'open3'
 require 'backtrace'
+require 'futex'
 require_relative '../log'
 require_relative '../score'
 require_relative '../age'
@@ -48,7 +49,6 @@ module Zold
       @invoice = invoice
       @pipeline = Queue.new
       @threads = []
-      @mutex = Mutex.new
     end
 
     def best
@@ -127,14 +127,14 @@ module Zold
     def finish(thread)
       start = Time.now
       @alive = false
-      @log.info("Attempting to terminate the thread \"#{thread.name}\"...")
+      @log.info("Attempting to terminate the thread \"#{thread.name}\" of the farm...")
       loop do
         delay = Time.now - start
         if thread.join(0.1)
           @log.info("Thread \"#{thread.name}\" finished in #{Age.new(start)}")
           break
         end
-        if delay > 10
+        if delay > 1
           thread.exit
           @log.error("Thread \"#{thread.name}\" forcefully terminated after #{Age.new(start)}")
         end
@@ -220,9 +220,9 @@ module Zold
     def save(threads, list = [])
       scores = load + list
       period = 24 * 60 * 60 / [threads, 1].max
-      @mutex.synchronize do
-        File.write(
-          @cache,
+      Futex.new(@cache, log: @log).open do |f|
+        IO.write(
+          f,
           scores.select(&:valid?)
             .reject(&:expired?)
             .sort_by(&:value)
@@ -237,9 +237,9 @@ module Zold
     end
 
     def load
-      @mutex.synchronize do
-        if File.exist?(@cache)
-          File.read(@cache).split(/\n/)
+      Futex.new(@cache, log: @log).open do |f|
+        if File.exist?(f)
+          IO.read(f).split(/\n/)
             .map { |t| parse_score_line(t) }
             .reject(&:zero?)
         else

data/lib/zold/node/front.rb

@@ -55,7 +55,7 @@ module Zold
       set :suppress_messages, true
       set :start, Time.now
       set :lock, false
-      set :show_exceptions, false
+      set :show_exceptions, true
       set :server, :puma
       set :log, nil? # to be injected at node.rb
       set :trace, nil? # to be injected at node.rb
@@ -68,6 +68,7 @@ module Zold
       set :nohup_log, false # to be injected at node.rb
       set :home, nil? # to be injected at node.rb
       set :logging, true # to be injected at node.rb
+      set :logger, nil? # to be injected at node.rb
       set :address, nil? # to be injected at node.rb
       set :farm, nil? # to be injected at node.rb
       set :metronome, nil? # to be injected at node.rb
@@ -121,7 +122,7 @@ while #{settings.address} is in '#{settings.network}'"
       headers[Http::PROTOCOL_HEADER] = settings.protocol.to_s
       headers['Access-Control-Allow-Origin'] = '*'
       headers[Http::SCORE_HEADER] = score.reduced(16).to_s
-      headers['X-Zold-Thread'] = Thread.current.name
+      headers['X-Zold-Thread'] = Thread.current.name.to_s
       headers['X-Zold-Milliseconds'] = ((Time.now - @start) * 1000).round.to_s
     end
 
@@ -155,7 +156,7 @@ while #{settings.address} is in '#{settings.network}'"
       raise "Log not found at #{settings.nohup_log}" unless File.exist?(settings.nohup_log)
       response.headers['Content-Type'] = 'text/plain'
       response.headers['Content-Disposition'] = "attachment; filename='#{File.basename(settings.nohup_log)}'"
-      File.read(settings.nohup_log)
+      IO.read(settings.nohup_log)
     end
 
     get '/favicon.ico' do
@@ -177,12 +178,12 @@ while #{settings.address} is in '#{settings.network}'"
         protocol: settings.protocol,
         score: score.to_h,
         pid: Process.pid,
-        cpus: Concurrent.processor_count,
+        cpus: Cachy.cache(:a_cpus) { Concurrent.processor_count },
         memory: GetProcessMem.new.bytes.to_i,
         platform: RUBY_PLATFORM,
-        load: Usagewatch.uw_load.to_f,
+        load: Cachy.cache(:a_load, expires_in: 5 * 60) { Usagewatch.uw_load.to_f },
         threads: "#{Thread.list.select { |t| t.status == 'run' }.count}/#{Thread.list.count}",
-        wallets: Cachy.cache(:a_key, expires_in: 5 * 60) { settings.wallets.all.count },
+        wallets: Cachy.cache(:a_wallets, expires_in: 5 * 60) { settings.wallets.all.count },
         remotes: settings.remotes.all.count,
         nscore: settings.remotes.all.map { |r| r[:score] }.inject(&:+) || 0,
         farm: settings.farm.to_json,
@@ -196,7 +197,7 @@ while #{settings.address} is in '#{settings.network}'"
     get %r{/wallet/(?<id>[A-Fa-f0-9]{16})} do
       error 404 if settings.disable_fetch
       id = Id.new(params[:id])
-      settings.wallets.find(id) do |wallet|
+      copy_of(id) do |wallet|
         error 404 unless wallet.exists?
         content_type 'application/json'
         JSON.pretty_generate(
@@ -219,7 +220,7 @@ while #{settings.address} is in '#{settings.network}'"
     get %r{/wallet/(?<id>[A-Fa-f0-9]{16}).json} do
       error 404 if settings.disable_fetch
       id = Id.new(params[:id])
-      settings.wallets.find(id) do |wallet|
+      copy_of(id) do |wallet|
         error 404 unless wallet.exists?
         content_type 'application/json'
         JSON.pretty_generate(
@@ -241,7 +242,7 @@ while #{settings.address} is in '#{settings.network}'"
     get %r{/wallet/(?<id>[A-Fa-f0-9]{16})/balance} do
       error 404 if settings.disable_fetch
       id = Id.new(params[:id])
-      settings.wallets.find(id) do |wallet|
+      copy_of(id) do |wallet|
         error 404 unless wallet.exists?
         content_type 'text/plain'
         wallet.balance.to_i.to_s
@@ -251,7 +252,7 @@ while #{settings.address} is in '#{settings.network}'"
     get %r{/wallet/(?<id>[A-Fa-f0-9]{16})/key} do
       error 404 if settings.disable_fetch
       id = Id.new(params[:id])
-      settings.wallets.find(id) do |wallet|
+      copy_of(id) do |wallet|
         error 404 unless wallet.exists?
         content_type 'text/plain'
         wallet.key.to_pub
@@ -261,7 +262,7 @@ while #{settings.address} is in '#{settings.network}'"
     get %r{/wallet/(?<id>[A-Fa-f0-9]{16})/mtime} do
       error 404 if settings.disable_fetch
       id = Id.new(params[:id])
-      settings.wallets.find(id) do |wallet|
+      copy_of(id) do |wallet|
         error 404 unless wallet.exists?
         content_type 'text/plain'
         wallet.mtime.utc.iso8601.to_s
@@ -271,7 +272,7 @@ while #{settings.address} is in '#{settings.network}'"
     get %r{/wallet/(?<id>[A-Fa-f0-9]{16})/digest} do
       error 404 if settings.disable_fetch
       id = Id.new(params[:id])
-      settings.wallets.find(id) do |wallet|
+      copy_of(id) do |wallet|
         error 404 unless wallet.exists?
         content_type 'text/plain'
         wallet.digest
@@ -281,7 +282,7 @@ while #{settings.address} is in '#{settings.network}'"
     get %r{/wallet/(?<id>[A-Fa-f0-9]{16})\.txt} do
       error 404 if settings.disable_fetch
       id = Id.new(params[:id])
-      settings.wallets.find(id) do |wallet|
+      copy_of(id) do |wallet|
         error 404 unless wallet.exists?
         content_type 'text/plain'
         [
@@ -305,17 +306,17 @@ while #{settings.address} is in '#{settings.network}'"
     get %r{/wallet/(?<id>[A-Fa-f0-9]{16})\.bin} do
       error 404 if settings.disable_fetch
       id = Id.new(params[:id])
-      settings.wallets.find(id) do |wallet|
+      copy_of(id) do |wallet|
         error 404 unless wallet.exists?
         content_type 'text/plain'
-        File.read(wallet.path)
+        IO.read(wallet.path)
       end
     end
 
     get %r{/wallet/(?<id>[A-Fa-f0-9]{16})/copies} do
       error 404 if settings.disable_fetch
       id = Id.new(params[:id])
-      settings.wallets.find(id) do |wallet|
+      copy_of(id) do |wallet|
         error 404 unless wallet.exists?
         content_type 'text/plain'
         copies = Copies.new(File.join(settings.copies, id))
@@ -335,12 +336,12 @@ while #{settings.address} is in '#{settings.network}'"
       error 404 if settings.disable_fetch
       id = Id.new(params[:id])
       name = params[:name]
-      settings.wallets.find(id) do |wallet|
+      copy_of(id) do |wallet|
         error 404 unless wallet.exists?
         copy = Copies.new(File.join(settings.copies, id)).all.find { |c| c[:name] == name }
         error 404 if copy.nil?
         content_type 'text/plain'
-        File.read(copy[:path])
+        IO.read(copy[:path])
       end
     end
 
@@ -383,12 +384,15 @@ while #{settings.address} is in '#{settings.network}'"
 
     get '/threads' do
       content_type 'text/plain'
-      Thread.list.map do |t|
-        [
-          "#{t.name}: status=#{t.status}; alive=#{t.alive?}",
-          t.backtrace.nil? ? 'NO BACKTRACE' : "  #{t.backtrace.join("\n  ")}"
-        ].join("\n")
-      end.join("\n\n")
+      [
+        "Total threads: #{Thread.list.count}",
+        Thread.list.map do |t|
+          [
+            "#{t.name}: status=#{t.status}; alive=#{t.alive?}",
+            t.backtrace.nil? ? 'NO BACKTRACE' : "  #{t.backtrace.join("\n  ")}"
+          ].join("\n")
+        end
+      ].flatten.join("\n\n")
     end
 
     not_found do
@@ -421,9 +425,20 @@ while #{settings.address} is in '#{settings.network}'"
     end
 
     def score
-      best = settings.farm.best
+      best = Cachy.cache(:a_score, expires_in: 60) { settings.farm.best }
       raise 'Score is empty, there is something wrong with the Farm!' if best.empty?
       best[0]
     end
+
+    def copy_of(id)
+      Tempfile.open([id.to_s, Wallet::EXT]) do |f|
+        settings.wallets.find(id) do |wallet|
+          IO.write(f, IO.read(wallet.path)) if File.exist?(wallet.path)
+        end
+        path = f.path
+        f.delete if File.size(f.path).zero?
+        yield Wallet.new(path)
+      end
+    end
   end
 end