zm-ruby-client 3.0.1 → 3.1.0

data/lib/zm/client/cluster/cluster_config.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'yaml'
-
 module Zm
   module Client
     # class config for cluster connection
@@ -11,7 +9,8 @@ module Zm
       attr_reader :zimbra_admin_url, :zimbra_public_url
       attr_writer :logger, :colorize_logging
       attr_accessor :zimbra_admin_login, :zimbra_admin_password,
-                    :domains, :zimbra_version, :log_path, :timeout
+                    :domains, :zimbra_version, :log_path, :timeout,
+                    :ssl_verify, :ssl_ca_file, :ssl_ca_path
 
       def initialize(parameters = nil)
         @domains = []
@@ -20,6 +19,7 @@ module Zm
         @log_level = Logger::INFO
         @colorize_logging = false
         @timeout = 300
+        @ssl_verify = false
 
         init_from_parameters(parameters)
 
@@ -27,11 +27,11 @@ module Zm
       end
 
       def cache
-        @cache = Zm::Support::Cache.registered_storage[cache_store_key]
-                                   .new(**cache_store_options)
-                                   .tap do |store|
-                                     store.logger = logger
-                                   end
+        @cache ||= Zm::Support::Cache.storage(cache_store_key)
+                                     .new(**cache_store_options)
+                                     .tap do |store|
+                                       store.logger = logger
+                                     end
       end
 
       def cache_store_key
@@ -47,14 +47,13 @@ module Zm
       end
 
       def cache_store=(options)
-        store_key = options.shift
-        store_options = options.last
-        store_class = Zm::Support::Cache.registered_storage[store_key]
+        store_key, store_options = options
+        store_options ||= {}
+        store_class = Zm::Support::Cache.storage(store_key)
 
-        unless store_class || store_class.test_required_options(store_options)
-          raise ClusterConfigError, 'invalid cache_store'
-        end
+        raise ClusterConfigError, 'invalid cache_store' unless store_class&.valid_options?(store_options)
 
+        @cache = nil
         @cache_store = [store_key, store_options]
       end
 
@@ -78,6 +77,7 @@ module Zm
       end
 
       def init_from_yml(file_config_path)
+        require 'yaml'
         YAML.safe_load_file(file_config_path, symbolize_names: true)
       end
 
@@ -101,9 +101,29 @@ module Zm
           @timeout = p_timeout.to_i
         end
 
+        init_ssl_from_parameters(parameters)
+
         init_domains_from_parameters(parameters)
       end
 
+      def init_ssl_from_parameters(parameters)
+        @ssl_verify = parameters.delete(:ssl_verify) == true if parameters.key?(:ssl_verify)
+        @ssl_ca_file = parameters.delete(:ssl_ca_file) if parameters.key?(:ssl_ca_file)
+        @ssl_ca_path = parameters.delete(:ssl_ca_path) if parameters.key?(:ssl_ca_path)
+      end
+
+      def ssl_options
+        return Zm::Connector::SSL_VERIFY_NONE unless @ssl_verify
+
+        {
+          verify: true,
+          verify_hostname: true,
+          verify_mode: OpenSSL::SSL::VERIFY_PEER,
+          ca_file: @ssl_ca_file,
+          ca_path: @ssl_ca_path
+        }.compact
+      end
+
       def init_domains_from_parameters(parameters)
         if (config_domains = parameters.delete(:domains))
           @domains = config_domains.map do |h|
@@ -167,7 +187,7 @@ module Zm
       end
 
       def zimbra_attributes_path
-        @zimbra_attributes_path ||= "#{File.dirname(__FILE__)}../../../modules/common/zimbra-attrs.csv"
+        @zimbra_attributes_path ||= File.expand_path('../../modules/common/zimbra-attrs.csv', __dir__)
       end
 
       def zimbra_attributes_path=(path)

data/lib/zm/client/contact/contact.rb

@@ -2,12 +2,14 @@
 
 module Zm
   module Client
-    # class account tag
+    # class account Contact
     class Contact < Base::Object
-      include BelongsToFolder
-      include BelongsToTag
-      include RequestMethodsMailbox
+      include Zm::Utils::BelongsToFolder
+      include Zm::Utils::BelongsToTag
+      include SoapRequest::RequestMethodsMailbox
       include MailboxItemConcern
+      extend Zm::Relationship
+      has_jsns_builder
 
       GROUP_PATTERN = 'group'
 
@@ -19,11 +21,11 @@ module Zm
                     :maidenName, :middleName, :mobilePhone, :namePrefix, :nameSuffix, :nickname, :notes,
                     :otherCity, :otherCountry, :otherFax, :otherPhone, :otherPostalCode, :otherState,
                     :otherStreet, :otherURL, :pager, :workCity, :workCountry, :workFax, :workPhone,
-                    :workPostalCode, :workState, :workStreet, :workURL, :image, :name, :type,
+                    :workPostalCode, :workState, :workStreet, :workURL, :image, :name, :type, :fileAs,
                     :tn, :shared_account_id, :shared_folder_account_id
 
       def initialize(parent)
-        @l = FolderDefault::CONTACTS.id
+        self.l = FolderDefault::CONTACTS.id
         @shared_account_id = nil
         @shared_folder_account_id = nil
         super
@@ -60,13 +62,13 @@ module Zm
         raise NotImplementedError
       end
 
-      private
-
-      def jsns_builder
-        return @jsns_builder if defined? @jsns_builder
-
-        @jsns_builder = ContactJsnsBuilder.new(self)
-      end
+      # private
+      #
+      # def jsns_builder
+      #   return @jsns_builder if defined? @jsns_builder
+      #
+      #   @jsns_builder = ContactJsnsBuilder.new(self)
+      # end
     end
   end
 end

data/lib/zm/client/contact/contact_jsns_builder.rb

@@ -3,8 +3,11 @@
 module Zm
   module Client
     # class for account contact jsns builder
-    class ContactJsnsBuilder < BaseAccountJsnsBuilder
-      EXCLUDE_INSTANCE_VARIABLE_KEYS = %i[@id @name @parent @l @type @tn @jsns_builder].freeze
+    class ContactJsnsBuilder < Base::BaseAccountJsnsBuilder
+      EXCLUDE_INSTANCE_VARIABLE_KEYS = %i[
+        @id @name @parent @l @type @tn @jsns_builder @updated @token @tags @folder
+        @shared_account_id @shared_folder_account_id
+      ].freeze
 
       def to_jsns
         jsns = {
@@ -14,7 +17,7 @@ module Zm
           }
         }
 
-        SoapElement.mail(SoapMailConstants::CREATE_CONTACT_REQUEST).add_attributes(jsns)
+        SoapRequest::SoapElement.mail(SoapRequest::SoapMailConstants::CREATE_CONTACT_REQUEST).add_attributes(jsns)
       end
 
       def to_update
@@ -25,18 +28,18 @@ module Zm
           }
         }
 
-        SoapElement.mail(SoapMailConstants::MODIFY_CONTACT_REQUEST).add_attributes(jsns)
+        SoapRequest::SoapElement.mail(SoapRequest::SoapMailConstants::MODIFY_CONTACT_REQUEST).add_attributes(jsns)
       end
 
       def to_patch(hash)
         jsns = {
           cn: {
             id: @item.id,
-            a: hash.map(&Utils::A_ARRAY_PROC).flatten(1).map(&Utils::A_NODE_PROC)
+            a: hash.flat_map(&Utils::A_ARRAY_PROC).map(&Utils::A_NODE_PROC)
           }
         }
 
-        SoapElement.mail(SoapMailConstants::MODIFY_CONTACT_REQUEST).add_attributes(jsns)
+        SoapRequest::SoapElement.mail(SoapRequest::SoapMailConstants::MODIFY_CONTACT_REQUEST).add_attributes(jsns)
       end
 
       def instance_variables_array(zcs_attrs)

data/lib/zm/client/contact/contact_jsns_initializer.rb

@@ -22,7 +22,7 @@ module Zm
           end
 
           if item.group?
-            item.extend(GroupContact)
+            item.extend(Zm::Client::ModGroupContact)
             init_members_from_json(json[:m], item)
           end
 
@@ -48,7 +48,7 @@ module Zm
         def init_members_from_json(m, item)
           return if m.nil?
 
-          item.members.all = m.map { |m| Zm::Client::ConcatMember.new(m[:type], m[:value]) }
+          item.members.all = m.map { |m| Zm::Client::ContactMember.new(m[:type], m[:value]) }
         end
       end
     end

data/lib/zm/client/contact/contact_member.rb

@@ -2,8 +2,8 @@
 
 module Zm
   module Client
-    class ConcatMember
-      include Zm::Inspector
+    class ContactMember
+      include Zm::Utils::Inspector
 
       INTERNAL = 'C'
       FREE     = 'I'
@@ -22,7 +22,7 @@ module Zm
 
         if !value_int.zero?
           @value = value_int
-        elsif Zm::Client::Regex::SHARED_CONTACT.match(value)
+        elsif Zm::Utils::Regex::SHARED_CONTACT.match(value)
           part_value = value.split(':')
           @shared_account_id = part_value.first
           @value = part_value.last.to_i

data/lib/zm/client/contact/contact_members_collection.rb

@@ -11,7 +11,7 @@ module Zm
       end
 
       def add(new_member)
-        return false unless new_member.is_a?(Zm::Client::ConcatMember)
+        return false unless new_member.is_a?(Zm::Client::ContactMember)
 
         current_member = @all.find { |m| m.type == new_member.type && m.value == new_member.value }
 
@@ -21,7 +21,7 @@ module Zm
           return true
         end
 
-        if current_member.op == Zm::Client::ConcatMember::DEL
+        if current_member.op == Zm::Client::ContactMember::DEL
           current_member.add!
           return true
         end
@@ -30,7 +30,7 @@ module Zm
       end
 
       def remove(new_member)
-        return false unless new_member.is_a?(Zm::Client::ConcatMember)
+        return false unless new_member.is_a?(Zm::Client::ContactMember)
 
         current_member = @all.find { |m| m.type == new_member.type && m.value == new_member.value }
         return false if current_member.nil?

data/lib/zm/client/contact/contacts_builder.rb

@@ -3,7 +3,7 @@
 module Zm
   module Client
     # class factory [contacts]
-    class ContactBuilder < Base::ObjectsBuilder
+    class ContactsBuilder < Base::ObjectsBuilder
       def initialize(parent, json)
         super
         @json_item_key = :cn

data/lib/zm/client/contact/contacts_collection.rb

@@ -7,8 +7,8 @@ module Zm
       def initialize(parent)
         super
         @child_class = Contact
-        @builder_class = ContactBuilder
-        @type = SoapConstants::CONTACT
+        @builder_class = ContactsBuilder
+        @type = SoapRequest::SoapConstants::CONTACT
         @folder_ids = [FolderDefault::CONTACTS.id]
       end
     end

data/lib/zm/client/contact/group_contact_jsns_builder.rb

@@ -3,20 +3,18 @@
 module Zm
   module Client
     # class for account contact jsns builder
-    class GroupContactJsnsBuilder < BaseAccountJsnsBuilder
-      EXCLUDE_INSTANCE_VARIABLE_KEYS = %i[@id @name @parent @l @type @tn @jsns_builder].freeze
-
+    class GroupContactJsnsBuilder < Base::BaseAccountJsnsBuilder
       def to_jsns
-        {
+        jsns = {
           cn: {
             a: instance_variables_array.map(&Utils::A_NODE_PROC),
-            l: @item.folder_id || Zm::Client::FolderDefault::CONTACTS.id,
-            m: members_node
+            l: @item.l || Zm::Client::FolderDefault::CONTACTS.id,
+            m: new_members_node
           }
         }
 
-        SoapElement.mail(SoapMailConstants::CREATE_CONTACT_REQUEST)
-                   .add_attributes(jsns)
+        SoapRequest::SoapElement.mail(SoapRequest::SoapMailConstants::CREATE_CONTACT_REQUEST)
+                                .add_attributes(jsns)
       end
 
       def to_update
@@ -28,24 +26,30 @@ module Zm
           }
         }
 
-        SoapElement.mail(SoapMailConstants::MODIFY_CONTACT_REQUEST)
-                   .add_attributes(jsns)
+        SoapRequest::SoapElement.mail(SoapRequest::SoapMailConstants::MODIFY_CONTACT_REQUEST)
+                                .add_attributes(jsns)
       end
 
       def to_patch(hash)
-        {
+        jsns = {
           cn: {
             id: @item.id,
-            a: hash.map(&Utils::A_ARRAY_PROC).flatten(1).map(&Utils::A_NODE_PROC)
+            a: hash.flat_map(&Utils::A_ARRAY_PROC).map(&Utils::A_NODE_PROC)
           }
         }
 
-        SoapElement.mail(SoapMailConstants::MODIFY_CONTACT_REQUEST)
-                   .add_attributes(jsns)
+        SoapRequest::SoapElement.mail(SoapRequest::SoapMailConstants::MODIFY_CONTACT_REQUEST)
+                                .add_attributes(jsns)
       end
 
       alias to_create to_jsns
 
+      def new_members_node
+        @item.members.all.reject { |m| m.op == ContactMember::DEL }.map do |m|
+          { type: m.type, value: m.value }
+        end
+      end
+
       def members_node
         @item.members.all.reject(&:current?).map do |m|
           { type: m.type, value: m.value, op: m.op }

data/lib/zm/client/contact/mod_group_contact.rb

@@ -1,15 +1,19 @@
 # frozen_string_literal: true
 
-module GroupContact
-  def members
-    return @members if defined? @members
+module Zm
+  module Client
+    module ModGroupContact
+      def members
+        return @members if defined? @members
 
-    @members = Zm::Client::ContactMembersCollection.new(self)
-  end
+        @members = Zm::Client::ContactMembersCollection.new(self)
+      end
 
-  def jsns_builder
-    return @jsns_builder if defined? @jsns_builder
+      def jsns_builder
+        return @jsns_builder if defined? @jsns_builder
 
-    @jsns_builder = Zm::Client::GroupContactJsnsBuilder.new(self)
+        @jsns_builder = Zm::Client::GroupContactJsnsBuilder.new(self)
+      end
+    end
   end
 end

data/lib/zm/client/cos/cos.rb

@@ -4,7 +4,10 @@ module Zm
   module Client
     # objectClass: zimbraCos
     class Cos < Base::Object
-      include HasSoapAdminConnector
+      extend Relationship
+      has_jsns_builder
+
+      include Zm::Utils::HasSoapAdminConnector
 
       def modify!
         sac.invoke(build_modify)
@@ -15,16 +18,21 @@ module Zm
         jsns_builder.to_update
       end
 
-      def update!(hash)
+      def update!(hash = nil, update_attributes: true, **attrs)
+        hash = hash.nil? ? attrs : hash.merge(attrs)
         return false if hash.delete_if { |k, v| v.nil? || !respond_to?(k) }.empty?
 
         do_update!(hash)
 
+        do_update_attributes(hash) if update_attributes
+
+        @updated = true
+      end
+
+      def do_update_attributes(hash)
         hash.each do |key, value|
           update_attribute(key, value)
         end
-
-        true
       end
 
       def create!
@@ -54,38 +62,14 @@ module Zm
         jsns_builder.to_copy(new_name)
       end
 
-      def servers
-        return @servers if defined? @servers
-
-        @servers = CosServersCollection.new(self)
-      end
-
-      def domains
-        return if @id.nil?
-
-        return @domains if defined? @domains
-
-        @domains = CosDomainsCollection.new(self)
-      end
-
-      def accounts
-        return if @id.nil?
-
-        return @accounts if defined? @accounts
-
-        @accounts = CosAccountsCollection.new(self)
-      end
+      has_many :servers, klass: :'Zm::Client::CosServersCollection'
+      has_many :domains, klass: :'Zm::Client::CosDomainsCollection'
+      has_many :accounts, klass: :'Zm::Client::CosAccountsCollection'
 
       def attrs_write
         @parent.zimbra_attributes.all_cos_attrs_writable_names
       end
 
-      def jsns_builder
-        return @jsns_builder if defined? @jsns_builder
-
-        @jsns_builder = CosJsnsBuilder.new(self)
-      end
-
       private
 
       def do_update!(hash)

data/lib/zm/client/cos/cos_jsns_builder.rb

@@ -9,14 +9,14 @@ module Zm
       end
 
       def to_create
-        soap_request = SoapElement.admin(SoapAdminConstants::CREATE_COS_REQUEST)
-        node_cos = SoapElement.create(SoapConstants::NAME).add_content(@item.name)
+        soap_request = SoapRequest::SoapElement.admin(Zm::SoapRequest::SoapAdminConstants::CREATE_COS_REQUEST)
+        node_cos = SoapRequest::SoapElement.create(SoapRequest::SoapConstants::NAME).add_content(@item.name)
         soap_request.add_node(node_cos)
 
         attrs_only_set_h.each do |key, values|
           values.each do |value|
-            node_attr = SoapElement.create(SoapConstants::A)
-                                   .add_attribute(SoapConstants::N, key)
+            node_attr = SoapRequest::SoapElement.create(SoapRequest::SoapConstants::A)
+                                   .add_attribute(SoapRequest::SoapConstants::N, key)
                                    .add_content(value)
             soap_request.add_node(node_attr)
           end
@@ -26,15 +26,15 @@ module Zm
       end
 
       def to_update
-        soap_request = SoapElement.admin(SoapAdminConstants::MODIFY_COS_REQUEST)
-        node_cos = SoapElement.create(SoapConstants::ID)
+        soap_request = SoapRequest::SoapElement.admin(Zm::SoapRequest::SoapAdminConstants::MODIFY_COS_REQUEST)
+        node_cos = SoapRequest::SoapElement.create(SoapRequest::SoapConstants::ID)
                               .add_content(@item.id)
         soap_request.add_node(node_cos)
 
         attrs_only_set_h.each do |key, values|
           values.each do |value|
-            node_attr = SoapElement.create(SoapConstants::A)
-                                   .add_attribute(SoapConstants::N, key)
+            node_attr = SoapRequest::SoapElement.create(SoapRequest::SoapConstants::A)
+                                   .add_attribute(SoapRequest::SoapConstants::N, key)
                                    .add_content(value)
             soap_request.add_node(node_attr)
           end
@@ -44,16 +44,16 @@ module Zm
       end
 
       def to_patch(hash)
-        soap_request = SoapElement.admin(SoapAdminConstants::MODIFY_COS_REQUEST)
-        node_cos = SoapElement.create(SoapConstants::ID)
+        soap_request = SoapRequest::SoapElement.admin(Zm::SoapRequest::SoapAdminConstants::MODIFY_COS_REQUEST)
+        node_cos = SoapRequest::SoapElement.create(SoapRequest::SoapConstants::ID)
                               .add_content(@item.id)
         soap_request.add_node(node_cos)
 
         hash.each do |key, values|
           values = [values] unless values.is_a?(Array)
           values.each do |value|
-            node_attr = SoapElement.create(SoapConstants::A)
-                                   .add_attribute(SoapConstants::N, key)
+            node_attr = SoapRequest::SoapElement.create(SoapRequest::SoapConstants::A)
+                                   .add_attribute(SoapRequest::SoapConstants::N, key)
                                    .add_content(value)
             soap_request.add_node(node_attr)
           end
@@ -63,20 +63,20 @@ module Zm
       end
 
       def to_copy(new_name)
-        soap_request = SoapElement.admin(SoapAdminConstants::COPY_COS_REQUEST)
-        node_name = SoapElement.create(SoapConstants::NAME)
+        soap_request = SoapRequest::SoapElement.admin(Zm::SoapRequest::SoapAdminConstants::COPY_COS_REQUEST)
+        node_name = SoapRequest::SoapElement.create(SoapRequest::SoapConstants::NAME)
                                .add_content(new_name)
 
         if @item.id
-          node_cos = SoapElement.create(SoapConstants::COS)
-                                .add_attribute(SoapConstants::BY, SoapConstants::ID)
+          node_cos = SoapRequest::SoapElement.create(SoapRequest::SoapConstants::COS)
+                                .add_attribute(SoapRequest::SoapConstants::BY, SoapRequest::SoapConstants::ID)
                                 .add_content(@item.id)
         elsif @item.name
-          node_cos = SoapElement.create(SoapConstants::COS)
-                                .add_attribute(SoapConstants::BY, SoapConstants::NAME)
+          node_cos = SoapRequest::SoapElement.create(SoapRequest::SoapConstants::COS)
+                                .add_attribute(SoapRequest::SoapConstants::BY, SoapRequest::SoapConstants::NAME)
                                 .add_content(@item.name)
         else
-          raise Zm::Client::ZmError, 'id or name attributes are required to clone cos'
+          raise Zm::Error::ZmError, 'id or name attributes are required to clone cos'
         end
 
         soap_request.add_node(node_name)
@@ -85,8 +85,8 @@ module Zm
       end
 
       def to_delete
-        SoapElement.admin(SoapAdminConstants::DELETE_COS_REQUEST).add_node(
-          SoapElement.create(SoapConstants::ID).add_content(@item.id)
+        SoapRequest::SoapElement.admin(Zm::SoapRequest::SoapAdminConstants::DELETE_COS_REQUEST).add_node(
+          SoapRequest::SoapElement.create(SoapRequest::SoapConstants::ID).add_content(@item.id)
         )
       end
 

data/lib/zm/client/cos/coses_collection.rb

@@ -7,17 +7,17 @@ module Zm
       def initialize(parent)
         @child_class = Cos
         @builder_class = CosesBuilder
-        @search_type = SearchType::COS
+        @search_type = :coses
         super
       end
 
       def find_by!(hash)
-        soap_request = SoapElement.admin(SoapAdminConstants::GET_COS_REQUEST)
-        node_cos = SoapElement.create(SoapConstants::COS)
-                              .add_attribute(SoapConstants::BY, hash.keys.first)
+        soap_request = SoapRequest::SoapElement.admin(Zm::SoapRequest::SoapAdminConstants::GET_COS_REQUEST)
+        node_cos = SoapRequest::SoapElement.create(SoapRequest::SoapConstants::COS)
+                              .add_attribute(SoapRequest::SoapConstants::BY, hash.keys.first)
                               .add_content(hash.values.first)
         soap_request.add_node(node_cos)
-        soap_request.add_attribute(SoapConstants::ATTRS, attrs_comma)
+        soap_request.add_attribute(SoapRequest::SoapConstants::ATTRS, attrs_comma)
         entry = sac.invoke(soap_request)[:GetCosResponse][:cos].first
 
         reset_query_params
@@ -33,7 +33,12 @@ module Zm
 
       def reset_query_params
         super
-        @attrs = SearchType::Attributes::COS.dup
+        @attrs = %w[
+          cn
+          description
+          zimbraMailHostPool
+          zimbraMailQuota
+        ]
       end
     end
   end

data/lib/zm/client/datasource/datasource.rb

@@ -4,7 +4,9 @@ module Zm
   module Client
     # class account data source
     class DataSource < Base::Object
-      include RequestMethodsMailbox
+      include SoapRequest::RequestMethodsMailbox
+      extend Relationship
+      has_jsns_builder
 
       TYPES = %i[cal caldav yab gal imap pop3 rss unknown].freeze
 
@@ -49,14 +51,6 @@ module Zm
       def build_rename(*args)
         raise NotImplementedError
       end
-
-      private
-
-      def jsns_builder
-        return @jsns_builder if defined? @jsns_builder
-
-        @jsns_builder = DataSourceJsnsBuilder.new(self)
-      end
     end
   end
 end

data/lib/zm/client/datasource/datasource_jsns_builder.rb

@@ -15,15 +15,15 @@ module Zm
 
         attrs.compact!
 
-        soap_request = SoapElement.mail(SoapMailConstants::MODIFY_DATA_SOURCE_REQUEST)
-        node_action = SoapElement.create(@item.type).add_attributes(attrs)
+        soap_request = SoapRequest::SoapElement.mail(SoapRequest::SoapMailConstants::MODIFY_DATA_SOURCE_REQUEST)
+        node_action = SoapRequest::SoapElement.create(@item.type).add_attributes(attrs)
         soap_request.add_node(node_action)
         soap_request
       end
 
       def to_delete
-        soap_request = SoapElement.mail(SoapMailConstants::DELETE_DATA_SOURCE_REQUEST)
-        node_action = SoapElement.create(@item.type).add_attributes(id: @item.id)
+        soap_request = SoapRequest::SoapElement.mail(SoapRequest::SoapMailConstants::DELETE_DATA_SOURCE_REQUEST)
+        node_action = SoapRequest::SoapElement.create(@item.type).add_attributes(id: @item.id)
         soap_request.add_node(node_action)
         soap_request
       end

data/lib/zm/client/datasource/datasources_builder.rb

@@ -3,7 +3,7 @@
 module Zm
   module Client
     # class factory [datasources]
-    class DataSourceBuilder < Base::ObjectsBuilder
+    class DataSourcesBuilder < Base::ObjectsBuilder
       def make
         return [] if json_items.nil?