zipkin-tracer 0.29.1 → 0.30.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0f48284c20b1d1377110cb94a3f61f8e242869c9e4c029097d664351af9e1969
-  data.tar.gz: ae64fe7cbf4c23fbbadf28dd5661582446032dfd2bfcf53bda7a096f0d18465b
+  metadata.gz: b3baf1dff1d2fa511cec7a66a040c4e817bb100d4e8984834d0471f8a1118d51
+  data.tar.gz: b2047d302ad9d4c50f265c33f640a03d02a6223379707c8146995667812dc023
 SHA512:
-  metadata.gz: 92eb06e30a0602fc08f499c6088decc6608a6009b14e232f74a5142824c47803905c03fb0b7643fdd756b656b1a47094aacd4c2a9b7a2e47c3b1c370fe0ddffd
-  data.tar.gz: df64ae864cc61accfd51ac4e71cff367a09e854ae46a181af098e2297b6e46a2ebd835dc445b0723bebf97acbba7171100a70a53b2abb4283c512375f41a14b6
+  metadata.gz: 9bfaaf722dcdad67fcb795db85cbaac6ab5b6234e76569d17982098ec38059e9d7f9fb5167ed0c0e177ff9857d987dbe68ab780e8dbfef0fc18e220dbb784664
+  data.tar.gz: 8ddb0aba5a360756b11015aea6d13949a14d4653de0123664f7e7264c8e67655544cea722002d098358bef67e476be7ecdc6747a214b93886fdab9a76828997d

data/lib/zipkin-tracer/excon/zipkin-tracer.rb

@@ -80,12 +80,14 @@ module ZipkinTracer
     end
 
     def trace!(datum, trace_id)
+      method = datum[:method].to_s
       url_string = Excon::Utils::request_uri(datum)
       url = URI(url_string)
       service_name = service_name(datum, url.host)
 
-      span = Trace.tracer.start_span(trace_id, datum[:method].to_s.downcase)
+      span = Trace.tracer.start_span(trace_id, method.downcase)
       # annotate with method (GET/POST/etc.) and uri path
+      span.record_tag(Trace::BinaryAnnotation::METHOD, method.upcase, Trace::BinaryAnnotation::Type::STRING, local_endpoint)
       span.record_tag(Trace::BinaryAnnotation::PATH, url.path, Trace::BinaryAnnotation::Type::STRING, local_endpoint)
       span.record_tag(Trace::BinaryAnnotation::SERVER_ADDRESS, SERVER_ADDRESS_SPECIAL_VALUE, Trace::BinaryAnnotation::Type::BOOL, remote_endpoint(url, service_name))
       span.record(Trace::Annotation::CLIENT_SEND, local_endpoint)

data/lib/zipkin-tracer/faraday/zipkin-tracer.rb

@@ -44,12 +44,14 @@ module ZipkinTracer
     def trace!(env, trace_id)
       response = nil
       # handle either a URI object (passed by Faraday v0.8.x in testing), or something string-izable
+      method = env[:method].to_s
       url = env[:url].respond_to?(:host) ? env[:url] : URI.parse(env[:url].to_s)
       local_endpoint = Trace.default_endpoint # The rack middleware set this up for us.
       remote_endpoint = Trace::Endpoint.remote_endpoint(url, @service_name, local_endpoint.ip_format) # The endpoint we are calling.
-      Trace.tracer.with_new_span(trace_id, env[:method].to_s.downcase) do |span|
+      Trace.tracer.with_new_span(trace_id, method.downcase) do |span|
         @span = span # So we can record on exceptions
         # annotate with method (GET/POST/etc.) and uri path
+        span.record_tag(Trace::BinaryAnnotation::METHOD, method.upcase, Trace::BinaryAnnotation::Type::STRING, local_endpoint)
         span.record_tag(Trace::BinaryAnnotation::PATH, url.path, Trace::BinaryAnnotation::Type::STRING, local_endpoint)
         span.record_tag(Trace::BinaryAnnotation::SERVER_ADDRESS, SERVER_ADDRESS_SPECIAL_VALUE, Trace::BinaryAnnotation::Type::BOOL, remote_endpoint)
         span.record(Trace::Annotation::CLIENT_SEND, local_endpoint)

data/lib/zipkin-tracer/trace.rb

@@ -151,6 +151,7 @@ module Trace
   class BinaryAnnotation
     SERVER_ADDRESS = 'sa'.freeze
     URI = 'http.uri'.freeze
+    METHOD = 'http.method'.freeze
     PATH = 'http.path'.freeze
     STATUS = 'http.status'.freeze
     LOCAL_COMPONENT = 'lc'.freeze

data/lib/zipkin-tracer/version.rb

@@ -1,3 +1,3 @@
 module ZipkinTracer
-  VERSION = '0.29.1'.freeze
+  VERSION = '0.30.0'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zipkin-tracer
 version: !ruby/object:Gem::Version
-  version: 0.29.1
+  version: 0.30.0
 platform: ruby
 authors:
 - Franklin Hu
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-15 00:00:00.000000000 Z
+date: 2018-12-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday