zipdatev 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 16ae34c9ade5ebebaf3ec979f10d8816b5ab871f68aa06070051ca9b41d2b4c0
-  data.tar.gz: ef6f9b9345a13d8b2fc1aff5a0e67d7d932a4a244cdbc384a2b79fceb25267f8
+  metadata.gz: 7e98150333d568e203ad3f8bea658bdfed75a411d116ec79e17de683a320c14e
+  data.tar.gz: feebaad2cd0de26f16f5d09e1049776a68549618d93fff64f37042ad13f3bb38
 SHA512:
-  metadata.gz: b47bb6b5874e07f1a0a85e3a0f6ad4b28e39124bdf78c322e3772584ea04f3c6f924c5ea5f5b2c3f9ca206245de1fcb86e126188021806b9808ec0dc6a64819d
-  data.tar.gz: d691a9ee6263c1cbb54aa8679df7caac69e70c4b7e53db18b3831b5a0395fdecc134f4b6ac0f10bbb26319b37ec6ab61f9bdceb0296953f030916bca1c492c1a
+  metadata.gz: e62f20679ffcc4ab682a7b376944bac39850c15d319e04befbaecf47cb3e2a3305ea40ac07c371a9ddec42f3414a648952c03d63255f8f49b5bbf171d22c59bb
+  data.tar.gz: b8c49308ff909e730adb7a2ea664030dfcc501cf8d8179dbea9f9dc0722abb28c0a2b07e25fe0a4b05dbc29f0378510daf4180a22c74b0015ec3a00b6b98cad4

data/lib/zipdatev/invoice.rb

@@ -45,7 +45,7 @@ module ZipDatev
   #     discount_payment_date_2: Date.new(2023, 1, 22),
   #     due_date: Date.new(2023, 1, 26)
   #   )
-  # rubocop:disable Metrics/ClassLength
+  # rubocop:disable-next Metrics/ClassLength
   class Invoice
     include ActiveModel::Model
     include ActiveModel::Attributes
@@ -344,5 +344,4 @@ module ZipDatev
       attributes.compact.transform_keys(&:to_sym)
     end
   end
-  # rubocop:enable Metrics/ClassLength
 end

data/lib/zipdatev/validators/consolidation_validator.rb

@@ -16,6 +16,10 @@ module ZipDatev
     # @example Apply to Invoice
     #   validates_with ConsolidationValidator
     class ConsolidationValidator < ActiveModel::Validator
+      # Validates consolidation rules for multi-line invoices.
+      #
+      # @param record [Invoice] The invoice record to validate
+      # @return [void]
       def validate(record)
         # Only validate if there are line items
         return unless record.respond_to?(:multi_line?) && record.multi_line?

data/lib/zipdatev/validators/date_range_validator.rb

@@ -14,9 +14,17 @@ require "date"
 # @example Allow nil values
 #   validates :due_date, date_range: true, allow_nil: true
 class DateRangeValidator < ActiveModel::EachValidator
+  # Minimum date accepted by DATEV (matches SQL Server datetime lower bound)
   MIN_DATE = Date.new(1753, 1, 1)
+  # Maximum date accepted by DATEV
   MAX_DATE = Date.new(9999, 12, 31)
 
+  # Validates that the date value falls within the DATEV-allowed range.
+  #
+  # @param record [Object] The model record being validated
+  # @param attribute [Symbol] The attribute name being validated
+  # @param value [Date] The date value to validate
+  # @return [void]
   def validate_each(record, attribute, value)
     return if value.nil?
 

data/lib/zipdatev/validators/decimal_precision_validator.rb

@@ -17,6 +17,12 @@ require "bigdecimal"
 # @example Allow nil values
 #   validates :tax, decimal_precision: { places: 2 }, allow_nil: true
 class DecimalPrecisionValidator < ActiveModel::EachValidator
+  # Validates that the decimal value has exactly the required number of decimal places.
+  #
+  # @param record [Object] The model record being validated
+  # @param attribute [Symbol] The attribute name being validated
+  # @param value [BigDecimal, Numeric] The decimal value to validate
+  # @return [void]
   def validate_each(record, attribute, value)
     return if value.nil?
 

data/lib/zipdatev/validators/discount_dates_validator.rb

@@ -6,16 +6,23 @@ module ZipDatev
   module Validators
     # Validates the chronological ordering of discount-related dates.
     #
-    # DATEV requires discount dates to be in a specific order:
+    # Discount dates must be in a specific order:
     # 1. invoice date < discount_payment_date
     # 2. discount_payment_date < discount_payment_date_2
-    # 3. discount_payment_date_2 < due_date
+    # 3. last discount date (discount_payment_date_2, else discount_payment_date) <= due_date
+    #
+    # The due date may equal the last discount date to support "discount only"
+    # terms (e.g. "7 Tage 3 % Skonto") where both fall on the same day.
     #
     # Also validates that delivery_date is not after invoice date.
     #
     # @example Apply to Invoice or LineItem
     #   validates_with ZipDatev::Validators::DiscountDatesValidator
     class DiscountDatesValidator < ActiveModel::Validator
+      # Validates the chronological ordering of discount-related dates.
+      #
+      # @param record [Invoice, LineItem] The record to validate
+      # @return [void]
       def validate(record)
         validate_delivery_date(record)
         validate_dates_after_invoice(record)
@@ -63,9 +70,9 @@ module ZipDatev
         discount_2 = record.discount_payment_date_2
         discount_1 = record.discount_payment_date
 
-        if discount_2 && discount_2 >= due_date
+        if discount_2 && discount_2 > due_date
           record.errors.add(:due_date, "must be after discount_payment_date_2")
-        elsif discount_1 && !discount_2 && discount_1 >= due_date
+        elsif discount_1 && !discount_2 && discount_1 > due_date
           record.errors.add(:due_date, "must be after discount_payment_date")
         end
       end

data/lib/zipdatev/validators/payment_conditions_validator.rb

@@ -19,6 +19,7 @@ module ZipDatev
     # @example Apply to Invoice or LineItem
     #   validates_with PaymentConditionsValidator
     class PaymentConditionsValidator < ActiveModel::Validator
+      # Manual discount fields that are mutually exclusive with payment_conditions_id
       DISCOUNT_FIELDS = %i[
         discount_amount
         discount_percentage
@@ -29,6 +30,10 @@ module ZipDatev
         due_date
       ].freeze
 
+      # Validates that payment_conditions_id and manual discount fields are mutually exclusive.
+      #
+      # @param record [Invoice, LineItem] The record to validate
+      # @return [void]
       def validate(record)
         return unless record.payment_conditions_id
 

data/lib/zipdatev/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ZipDatev
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zipdatev
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Dexter Team