zipdatev 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0b14ed5e1f68c6aae3b564a967bc36dd5ff0d4fdec083d682452161ceb565bcd
-  data.tar.gz: 6c98b7e93719825e69ef0c0483134a256c864fbb734978cc5102f4b7272b82fe
+  metadata.gz: d6ce4539843ac8f2840887a89f59845cd0be78851e3716319542599dd49277ba
+  data.tar.gz: 4585e899c3328ce71283cc56f617b1bb5e5bb60d95dab358a5e730f52a263810
 SHA512:
-  metadata.gz: ff15c712b6e8661f54f28b5ac32f9d575e160d5973e8c43dd2330bebe174c1b430457ad20f6d8695e39c79299f87f6937cfcc81142416cc07ac09105ea443ea2
-  data.tar.gz: 8b9ff68c49b67c4059797ccc73bd68bc66a28299cafae8ad8b5b18a16f9634f85ee2b404cf5c58bade0ab42df38d2ef1314513dd7e34169f4320bb4a650d2126
+  metadata.gz: bc7772d543e0fab287ec9123946a95f0785512320f5d90916d7d1e64419f4b4547633e68e02c755fe8fefee22eb7c99e6603bf0ef1d5513552dc184b043738c0
+  data.tar.gz: 37f4b06a40a5ba78d4a14d6f0dd5a1d2dbdd506db055fa3cbcc9fb92b51747d565caa216bb557eb84f30e56225d680cdfcea36ccacbee631a237a298f808eb97

data/lib/zipdatev/constants.rb

@@ -71,6 +71,10 @@ module ZipDatev
       ZA ZM ZW
     ].freeze
 
+    # Pattern for GUID/UUID: 8-4-4-4-12 hex digits (RFC 4122)
+    # From XSD p10037: [0-9A-Fa-f]{8}-[0-9A-Fa-f]{4}-[0-9A-Fa-f]{4}-[0-9A-Fa-f]{4}-[0-9A-Fa-f]{12}
+    GUID_PATTERN = /\A[0-9A-Fa-f]{8}-[0-9A-Fa-f]{4}-[0-9A-Fa-f]{4}-[0-9A-Fa-f]{4}-[0-9A-Fa-f]{12}\z/
+
     # Pattern for invoice ID: alphanumeric + $%&*+-/
     # From XSD p10040: [a-zA-Z0-9$%&*+-/]{0,36}
     INVOICE_ID_PATTERN = %r{\A[a-zA-Z0-9$%&*+\-/]{0,36}\z}

data/lib/zipdatev/document.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "active_model"
+require_relative "constants"
 
 module ZipDatev
   # Represents a document entry in the DATEV package.
@@ -20,19 +21,21 @@ module ZipDatev
     include ActiveModel::Model
     include ActiveModel::Validations
 
-    attr_accessor :invoice, :attachments, :invoice_month, :folder_name, :repository
+    attr_accessor :invoice, :attachments, :invoice_month, :folder_name, :repository, :guid
 
     # Validations
     validates :invoice, presence: true
     validate :invoice_must_be_valid
     validate :attachments_must_exist
+    validate :guid_must_be_valid_format
 
-    def initialize(invoice: nil, attachments: [], invoice_month: nil, folder_name: nil, repository: nil)
+    def initialize(invoice: nil, attachments: [], invoice_month: nil, folder_name: nil, repository: nil, guid: nil)
       @invoice = invoice
       @attachments = attachments || []
       @invoice_month = invoice_month
       @folder_name = folder_name
       @repository = repository
+      @guid = guid
     end
 
     private
@@ -56,5 +59,12 @@ module ZipDatev
         errors.add(:attachments, "file not found: #{path}")
       end
     end
+
+    def guid_must_be_valid_format
+      return if guid.blank?
+      return if guid.match?(Constants::GUID_PATTERN)
+
+      errors.add(:guid, "must be a valid GUID (RFC 4122 format: xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx)")
+    end
   end
 end

data/lib/zipdatev/generators/base.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require "bigdecimal"
 require "nokogiri"
 require "active_support/core_ext/string/inflections"
 
@@ -82,13 +83,19 @@ module ZipDatev
 
       # Format a decimal value for XML output with specified precision
       #
+      # Uses BigDecimal's string representation to avoid floating point artifacts
+      # from format()/sprintf(), which implicitly convert BigDecimal to Float.
+      #
       # @param value [BigDecimal, Numeric, nil] The value to format
       # @param precision [Integer] Number of decimal places (default: 2)
       # @return [String, nil] Formatted decimal string or nil if value is nil
       def format_decimal(value, precision: 2)
         return nil if value.nil?
 
-        format("%.#{precision}f", value)
+        decimal = value.is_a?(BigDecimal) ? value : BigDecimal(value.to_s)
+        str = decimal.round(precision).to_s("F")
+        integer_part, fractional_part = str.split(".")
+        "#{integer_part}.#{(fractional_part || "").ljust(precision, "0")}"
       end
 
       # Convert a Ruby snake_case symbol to XML camelCase element name

data/lib/zipdatev/generators/document_xml.rb

@@ -79,7 +79,10 @@ module ZipDatev
 
       # Generate a document element for a single document
       def generate_document(xml, document)
-        xml.document do
+        attrs = {}
+        attrs["guid"] = document.guid if document.guid.present?
+
+        xml.document(attrs) do
           # Generate ledger extension (accountsPayableLedger)
           generate_ledger_extension(xml, document)
 

data/lib/zipdatev/package.rb

@@ -47,14 +47,16 @@ module ZipDatev
     # @param invoice_month [String] Invoice month in "YYYY-MM" format
     # @param folder_name [String] Folder name for filing
     # @param repository [Repository, nil] Optional repository structure
+    # @param guid [String, nil] Optional GUID (RFC 4122) for the document element
     # @return [Document] The created document
-    def add_document(invoice:, attachments: [], invoice_month: nil, folder_name: nil, repository: nil)
+    def add_document(invoice:, attachments: [], invoice_month: nil, folder_name: nil, repository: nil, guid: nil)
       document = Document.new(
         invoice: invoice,
         attachments: attachments,
         invoice_month: invoice_month,
         folder_name: folder_name,
-        repository: repository
+        repository: repository,
+        guid: guid
       )
       @documents << document
       document

data/lib/zipdatev/validators/consolidation_validator.rb

@@ -62,7 +62,7 @@ module ZipDatev
 
         record.errors.add(
           :base,
-          "All line items must have the same date, found: #{dates.map(&:to_s).join(", ")}"
+          "All line items must have the same date, found: #{dates.join(", ")}"
         )
       end
     end

data/lib/zipdatev/validators/decimal_precision_validator.rb

@@ -36,9 +36,9 @@ class DecimalPrecisionValidator < ActiveModel::EachValidator
     # Convert to BigDecimal for consistent handling
     decimal = value.is_a?(BigDecimal) ? value : BigDecimal(value.to_s)
 
-    # Use string representation to check decimal places
-    # Format with many decimal places to avoid rounding
-    str = format("%.#{places + 10}f", decimal)
+    # Use BigDecimal's string representation to avoid floating point artifacts
+    # BigDecimal#to_s("F") returns a fixed-point string like "12691.72"
+    str = decimal.to_s("F")
     parts = str.split(".")
 
     return places.zero? if parts.length == 1

data/lib/zipdatev/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ZipDatev
-  VERSION = "0.1.0"
+  VERSION = "0.1.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zipdatev
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - Dexter Team