zip_tricks 4.4.2 → 4.5.0

data/testing/support.rb

@@ -1,16 +1,19 @@
+# frozen_string_literal: true
+
 require 'rubygems'
 require 'bundler'
 Bundler.setup
 require_relative '../lib/zip_tricks'
 require 'terminal-table'
 
-$war_and_peace = File.open(__dir__ + '/in/war-and-peace.txt', 'rb'){|f| f.read }.freeze
+$war_and_peace = File.open(__dir__ + '/in/war-and-peace.txt', 'rb', &:read).freeze
 $war_and_peace_crc = Zlib.crc32($war_and_peace)
 
-$image_file     = File.open(__dir__ + '/in/VTYL8830.jpg', 'rb'){|f| f.read }.freeze
+$image_file     = File.open(__dir__ + '/in/VTYL8830.jpg', 'rb', &:read).freeze
 $image_file_crc = Zlib.crc32($image_file)
 
-class BigEntry < Struct.new(:crc32, :size, :iterations)
+# Rubocop: convention: Missing top-level class documentation comment.
+BigEntry = Struct.new(:crc32, :size, :iterations) do
   def write_to(io)
     iterations.times { io << $war_and_peace }
   end
@@ -21,7 +24,7 @@ def generate_big_entry(desired_minimum_size)
   crc_stream = ZipTricks::StreamCRC32.new
   repeats.times { crc_stream << $war_and_peace }
   entry_size = $war_and_peace.bytesize * repeats
-  raise "Ooops" if entry_size < desired_minimum_size
+  raise 'Ooops' if entry_size < desired_minimum_size
   BigEntry.new(crc_stream.to_i, entry_size, repeats)
 end
 
@@ -32,15 +35,16 @@ $test_descs = []
 $builder_threads = []
 at_exit { $builder_threads.map(&:join) }
 
+# Rubocop:  convention: Assignment Branch Condition size for build_test is too high. [23.35/15]
 def build_test(test_description)
   $tests_performed += 1
 
-  test_file_base = test_description.downcase.gsub(/\-/, '').gsub(/[\s\:]+/, '_')
-  filename = '%02d-%s.zip' % [$tests_performed, test_file_base]
+  test_file_base = test_description.downcase.delete('-').gsub(/[\s\:]+/, '_')
+  filename = format('%02d-%s.zip', $tests_performed, test_file_base)
 
-  puts 'Test %02d: %s' % [$tests_performed, test_description]
+  puts format('Test %02d: %s', $tests_performed, test_description)
   puts filename
-  puts ""
+  puts ''
 
   $test_descs << TestDesc.new(test_description, filename)
   $builder_threads << Thread.new do
@@ -54,23 +58,24 @@ def build_test(test_description)
 end
 
 # For quickly disabling them by prepending "x" (like RSpec)
-def xbuild_test(*)
-end
+def xbuild_test(*); end
 
 # Prints a text file that you can then fill in
+# Rubocop:  convention: Assignment Branch Condition size for prepare_test_protocol
+#           is too high. [18.47/15]
 def prepare_test_protocol
   File.open(__dir__ + '/test-report.txt', 'wb') do |f|
     platforms = [
-      "OSX 10.11 - Archive Utility (builtin)",
-      "OSX - The Unarchiver 3.10",
-      "Windows7 x64 - Builtin Explorer ZIP opener",
-      "Windows7 x64 - 7Zip 9.20",
+      'OSX 10.11 - Archive Utility (builtin)',
+      'OSX - The Unarchiver 3.10',
+      'Windows7 x64 - Builtin Explorer ZIP opener',
+      'Windows7 x64 - 7Zip 9.20'
     ]
     platforms.each do |platform_name|
       f.puts ''
-      table = Terminal::Table.new title: platform_name, headings: ['Test', 'Outcome']
+      table = Terminal::Table.new title: platform_name, headings: %w[Test Outcome]
       $test_descs.each_with_index do |desc, i|
-        test_name = [desc.filename, '%s' % desc.title].join("\n")
+        test_name = [desc.filename, format('%s', desc.title)].join("\n")
         outcome = ' ' * 64
         table << [test_name, outcome]
         table << :separator if i < ($test_descs.length - 1)

data/testing/test-report.txt

@@ -0,0 +1,28 @@
+
++-------------------+-------------------+
+| OSX 10.11 - Archive Utility (builtin) |
++-------------------+-------------------+
+| Test              | Outcome           |
++-------------------+-------------------+
++-------------------+-------------------+
+
++-------------+-------------+
+| OSX - The Unarchiver 3.10 |
++-------------+-------------+
+| Test        | Outcome     |
++-------------+-------------+
++-------------+-------------+
+
++----------------------+---------------------+
+| Windows7 x64 - Builtin Explorer ZIP opener |
++----------------------+---------------------+
+| Test                 | Outcome             |
++----------------------+---------------------+
++----------------------+---------------------+
+
++-------------+------------+
+| Windows7 x64 - 7Zip 9.20 |
++-------------+------------+
+| Test        | Outcome    |
++-------------+------------+
++-------------+------------+

data/zip_tricks.gemspec

@@ -1,44 +1,46 @@
 # coding: utf-8
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'zip_tricks/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "zip_tricks"
-  spec.version       = ZipTricks::VERSION
-  spec.authors       = ["Julik Tarkhanov"]
-  spec.email         = ["me@julik.nl"]
+  spec.name           = 'zip_tricks'
+  spec.version        = ZipTricks::VERSION
+  spec.authors        = ['Julik Tarkhanov']
+  spec.email          = ['me@julik.nl']
 
-  spec.summary = 'Stream out ZIP files from Ruby'
-  spec.description = 'Stream out ZIP files from Ruby'
-  spec.homepage      = "http://github.com/wetransfer/zip_tricks"
+  spec.summary        = 'Stream out ZIP files from Ruby'
+  spec.description    = 'Stream out ZIP files from Ruby'
+  spec.homepage       = 'http://github.com/wetransfer/zip_tricks'
 
-  # Prevent pushing this gem to RubyGems.org. To allow pushes either set the 'allowed_push_host'
-  # to allow pushing to a single host or delete this section to allow pushing to any host.
+  # Prevent pushing this gem to RubyGems.org.
+  # To allow pushes either set the 'allowed_push_host'
+  # To allow pushing to a single host or delete this section to allow pushing to any host.
   if spec.respond_to?(:metadata)
-    spec.metadata['allowed_push_host'] = "https://rubygems.org"
+    spec.metadata['allowed_push_host'] = 'https://rubygems.org'
   else
-    raise "RubyGems 2.0 or newer is required to protect against " \
-      "public gem pushes."
+    raise 'RubyGems 2.0 or newer is required to protect against ' \
+      'public gem pushes.'
   end
 
-  spec.files         = `git ls-files -z`.split("\x0").reject do |f|
+  spec.files = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
   end
-  spec.bindir        = "exe"
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
+  spec.bindir         = 'exe'
+  spec.executables    = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.require_paths  = ['lib']
 
-  spec.add_development_dependency "bundler", "~> 1"
+  spec.add_development_dependency 'bundler', '~> 1'
   spec.add_development_dependency 'rubyzip', '~> 1.1'
   spec.add_development_dependency 'terminal-table'
   spec.add_development_dependency 'range_utils'
-  
+
   spec.add_development_dependency 'rack', '~> 1.6' # For Jeweler
-  spec.add_development_dependency 'rake', '~> 10.4'
-  spec.add_development_dependency "rspec", "~> 3"
+  spec.add_development_dependency 'rake', '~> 12.2'
+  spec.add_development_dependency 'rspec', '~> 3'
   spec.add_development_dependency 'complexity_assert'
   spec.add_development_dependency 'coderay'
-  spec.add_development_dependency "yard", "~> 0.9"
-  
+  spec.add_development_dependency 'yard', '~> 0.9'
+  spec.add_development_dependency 'rubocop', '0.51.0' # No conforming to arbitrary rules that _change_ underneath you
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: zip_tricks
 version: !ruby/object:Gem::Version
-  version: 4.4.2
+  version: 4.5.0
 platform: ruby
 authors:
 - Julik Tarkhanov
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-08-29 00:00:00.000000000 Z
+date: 2017-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.4'
+        version: '12.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.4'
+        version: '12.2'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -150,6 +150,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.9'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.51.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.51.0
 description: Stream out ZIP files from Ruby
 email:
 - me@julik.nl
@@ -157,9 +171,12 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".codeclimate.yml"
 - ".document"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".travis.yml"
 - ".yardopts"
 - CHANGELOG.md
@@ -201,6 +218,7 @@ files:
 - testing/test-report-2016-07-28.txt
 - testing/test-report-2016-12-12.txt
 - testing/test-report-2017-04-2.txt
+- testing/test-report.txt
 - zip_tricks.gemspec
 homepage: http://github.com/wetransfer/zip_tricks
 licenses: []
@@ -222,7 +240,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Stream out ZIP files from Ruby