zilverline-mt940 1.0 → 2.0

data/lib/mt940_structured/parsers/structured_description_parser.rb

@@ -0,0 +1,12 @@
+module MT940Structured::Parsers
+  module StructuredDescriptionParser
+    def parse_description_after_tag(description_parts, tag)
+      description_start_index = description_parts.index { |part| part == tag }
+      if description_start_index
+        description_parts[description_start_index + 1].strip
+      else
+        ''
+      end
+    end
+  end
+end

data/lib/mt940_structured/parsers/tridios/parser.rb

@@ -0,0 +1,14 @@
+module MT940Structured::Parsers::Triodos
+  class Parser < MT940Structured::Parsers::Base
+    def initialize
+      super "Triodos", TransactionParsers.new
+    end
+  end
+
+  class TransactionParsers
+    def for_format(_)
+      TransactionParser.new
+    end
+  end
+
+end

data/lib/mt940_structured/parsers/tridios/transaction_parser.rb

@@ -0,0 +1,23 @@
+module MT940Structured::Parsers::Triodos
+  class TransactionParser
+    include MT940Structured::Parsers::DateParser
+    include MT940Structured::Parsers::DefaultLine61Parser
+
+    def get_regex_for_line_61
+      /^:61:(\d{6})(C|D)(\d+),(\d{0,2})/
+    end
+
+    def enrich_transaction(transaction, line_86)
+      if line_86.match(/^:86:\s?(.*)\Z/m)
+        temp_description = $1.gsub(/\n/, ' ').gsub(/>\d{2}/, '').strip
+        if temp_description.match(/^\d+(\d{9})(.*)$/)
+          transaction.contra_account = $1.rjust(9, '000000000')
+          transaction.description = $2.strip
+        else
+          transaction.description = temp_description
+        end
+      end
+
+    end
+  end
+end

data/lib/mt940_structured/parsers/tridios/triodos.rb

@@ -0,0 +1,5 @@
+module MT940Structured::Parsers::Triodos
+end
+
+require_relative 'transaction_parser'
+require_relative 'parser'

data/spec/fixtures/ing/eu_incasso.txt

@@ -0,0 +1,17 @@
+0000 01INGBNL2AXXXX00001
+0000 01INGBNL2AXXXX00001
+940 00
+:20:MPBZ
+:25:0001234567
+:28C:000
+:60F:C131231EUR1000,00
+:61:131231D50,00NIC MARF
+:86:Europese Incasso, doorlopend NL58INGB0000003000 INGBNL2A JAAPJAAP
+ FIETS PAPIER QWDFDFGGASDFGDSFGS NV NL10XXX100020000000 SEPA 01000
+00000000 000000000000-AAAA12345678 Premie xxxxxxxxxxxxxxxxxxxxxxx
+:62F:C131231EUR950,00
+:64:C131231EUR950,00
+:65:C131231EUR950,00
+:86:D000046C000017D10000,18C20000,00
+-XXX
+

data/spec/fixtures/ing/eu_incasso_foreign_transaction.txt

@@ -0,0 +1,17 @@
+0000 01INGBNL2AXXXX00001
+0000 01INGBNL2AXXXX00001
+940 00
+:20:MPBZ
+:25:0001234567
+:28C:000
+:60F:C131231EUR1000,00
+:61:131231D050,97NIC MARF
+:86:Europese Incasso, doorlopend BB123456789876567898 CITIATWX Google
+ Ireland Limited GB40G01SDDCITI00000011091334 SEPA 9087653421 NL0
+001MKXD ADWORDS:3455667788:NL0001MKXD
+:62F:C131231EUR950,00
+:64:C131231EUR950,00
+:65:C131231EUR950,00
+:86:D000046C000017D10000,18C20000,00
+-XXX
+

data/spec/fixtures/ing/failing.txt

@@ -0,0 +1,18 @@
+0000 01INGBNL2AXXXX00001
+0000 01INGBNL2AXXXX00001
+940 00
+:20:MPBZ
+:25:0001234567
+:28C:000
+:60F:C131231EUR1000,00
+:61:140122D50,00NIC MARF
+:86:Europese Incasso, doorlopend NL80RABO0123456789 RABONL2U BOB NL72
+BOB998877665544 SEPA BOB213654789387485940392049 1234567898765432
+ Kenmerk: 3333.1111.2222.3333 Omschrijving: 987654321 01-01-2012
+  3 MND 9878878787 Servicecontract
+:62F:C131231EUR950,00
+:64:C131231EUR950,00
+:65:C131231EUR950,00
+:86:D000046C000017D10000,18C20000,00
+-XXX
+

data/spec/mt940_abnamro_spec.rb

@@ -1,11 +1,11 @@
 require_relative 'spec_helper'
 
-describe "MT940::Base" do
+describe MT940Structured::Parser do
 
-  context 'classis mt940' do
+  context 'classic mt940' do
     before :each do
       @file_name = File.dirname(__FILE__) + '/fixtures/abnamro.txt'
-      @bank_statements = MT940::Base.parse_mt940(@file_name)["517852257"]
+      @bank_statements = MT940Structured::Parser.parse_mt940(@file_name)["517852257"]
       @transactions = @bank_statements.flat_map(&:transactions)
       @transaction = @transactions.first
     end
@@ -67,10 +67,11 @@ describe "MT940::Base" do
       end
     end
   end
+
   context 'sepa mt940' do
     before :each do
       @file_name = File.dirname(__FILE__) + '/fixtures/abnamro_structured.txt'
-      @bank_statements = MT940::Base.parse_mt940(@file_name)["123212321"]
+      @bank_statements = MT940Structured::Parser.parse_mt940(@file_name)["123212321"]
       @transactions = @bank_statements.flat_map(&:transactions)
     end
 
@@ -88,6 +89,15 @@ describe "MT940::Base" do
       @bank_statements.last.new_balance.date.should == Date.new(2014, 1, 27)
     end
 
+    context 'nonref' do
+      let(:transaction) { @transactions.first }
+
+      it 'has a NONREF when contraaccount is unknown' do
+        transaction.contra_account.should == 'NONREF'
+      end
+
+    end
+
     context 'Transaction' do
 
       let(:transaction) { @transactions[1] }
@@ -131,7 +141,7 @@ describe "MT940::Base" do
       end
 
       it 'have the correct description in case of a regular bank' do
-        transaction.description.should == "SAVINGS 3798473"
+        transaction.description.should == "SAVINGS"
       end
 
       it 'have a date' do
@@ -171,7 +181,7 @@ describe "MT940::Base" do
       end
 
       it 'have the correct description in case of a regular bank' do
-        transaction.description.should == %Q{4851430136 0030000 735822580 NS E-TICKET(S)KENMERK: 26-01-2014 18:14 003000 0735822580}
+        transaction.description.should == %Q{4851430136 0030000 735822580 NS E-TICKET(S) KENMERK: 26-01-2014 18:14 003000 0735822580}
       end
 
       it 'have a date' do
@@ -240,5 +250,7 @@ describe "MT940::Base" do
       end
 
     end
+
+    pending 'SEPA INCASSO ALGEMEEN DOORLOPEND'
   end
 end

data/spec/mt940_ing_spec.rb

@@ -5,7 +5,7 @@ describe "ING" do
   context 'old mt940' do
     before :each do
       @file_name = File.dirname(__FILE__) + '/fixtures/ing.txt'
-      @bank_statements = MT940::Base.parse_mt940(@file_name)["1234567"]
+      @bank_statements = MT940Structured::Parser.parse_mt940(@file_name)["1234567"]
       @transactions = @bank_statements.flat_map(&:transactions)
       @transaction = @transactions.first
     end
@@ -66,7 +66,7 @@ describe "ING" do
 
     before :each do
       @file_name = File.dirname(__FILE__) + '/fixtures/ing_structured.txt'
-      @bank_statements = MT940::Base.parse_mt940(@file_name)["1234567"]
+      @bank_statements = MT940Structured::Parser.parse_mt940(@file_name)["1234567"]
       @transactions = @bank_statements.flat_map(&:transactions)
       @transaction = @transactions.first
     end
@@ -224,4 +224,80 @@ describe "ING" do
       end
     end
   end
+
+  context 'europese incasso' do
+    before :each do
+      @file_name = File.dirname(__FILE__) + '/fixtures/ing/eu_incasso.txt'
+      @bank_statements = MT940Structured::Parser.parse_mt940(@file_name)["1234567"]
+      @transactions = @bank_statements.flat_map(&:transactions)
+      @transaction = @transactions.first
+    end
+
+    it 'has a description' do
+      @transaction.description.should == 'NL10XXX100020000000 01000 00000000 000000000000-AAAA12345678 Premie xxxxxxxxxxxxxxxxxxxxxxx'
+    end
+
+    it 'has a contra account' do
+      @transaction.contra_account.should == "3000"
+    end
+
+    it 'has a contra account iban' do
+      @transaction.contra_account_iban.should == "NL58INGB0000003000"
+    end
+
+    it 'has a contra account owner' do
+      @transaction.contra_account_owner.should == "JAAPJAAP FIETS PAPIER QWDFDFGGASDFGDSFGS NV"
+    end
+  end
+
+  context 'foreign transaction' do
+    before :each do
+      @file_name = File.dirname(__FILE__) + '/fixtures/ing/eu_incasso_foreign_transaction.txt'
+      @bank_statements = MT940Structured::Parser.parse_mt940(@file_name)["1234567"]
+      @transactions = @bank_statements.flat_map(&:transactions)
+      @transaction = @transactions.first
+    end
+
+    it 'has a description' do
+      @transaction.description.should == 'GB40G01SDDCITI00000011091334 9087653421 NL0 001MKXD ADWORDS:3455667788:NL0001MKXD'
+    end
+
+    it 'has a contra account' do
+      @transaction.contra_account.should == "BB123456789876567898"
+    end
+
+    it 'has a contra account iban' do
+      @transaction.contra_account_iban.should == "BB123456789876567898"
+    end
+
+    it 'has a contra account owner' do
+      @transaction.contra_account_owner.should == "Google Ireland Limited"
+    end
+  end
+
+  describe 'new line in reference after company name' do
+    before :each do
+      @file_name = File.dirname(__FILE__) + '/fixtures/ing/failing.txt'
+      @bank_statements = MT940Structured::Parser.parse_mt940(@file_name)["1234567"]
+      @transactions = @bank_statements.flat_map(&:transactions)
+      @transaction = @transactions.first
+    end
+
+    it 'has a description' do
+      @transaction.description.should == 'NL72 BOB998877665544 BOB213654789387485940392049 1234567898765432 Kenmerk: 3333.1111.2222.3333 Omschrijving: 987654321 01-01-2012 3 MND 9878878787 Servicecontract'
+    end
+
+    it 'has a contra account' do
+      @transaction.contra_account.should == "123456789"
+    end
+
+    it 'has a contra account iban' do
+      @transaction.contra_account_iban.should == "NL80RABO0123456789"
+    end
+
+    it 'has a contra account owner' do
+      @transaction.contra_account_owner.should == "BOB"
+    end
+
+  end
 end

data/spec/mt940_rabobank_spec.rb

@@ -4,7 +4,7 @@ describe "Rabobank" do
 
   context "parse whole file" do
     let(:file_name) { File.dirname(__FILE__) + '/fixtures/rabobank.txt' }
-    let(:bank_statements) { MT940::Base.parse_mt940(file_name) }
+    let(:bank_statements) { MT940Structured::Parser.parse_mt940(file_name) }
 
     it "should have the correct number of bank account's" do
       bank_statements.keys.size.should == 1
@@ -155,7 +155,7 @@ describe "Rabobank" do
 
   context "deposit from savings account" do
     let(:file_name) { File.dirname(__FILE__) + '/fixtures/rabobank_mt940_structured_to_savings_account.txt' }
-    let(:bank_statements) { MT940::Base.parse_mt940(file_name) }
+    let(:bank_statements) { MT940Structured::Parser.parse_mt940(file_name) }
 
     it "should have the correct contra account number" do
       bank_statement = bank_statements["123456789"][0]
@@ -168,7 +168,7 @@ describe "Rabobank" do
 
   context "savings account" do
     let(:file_name) { File.dirname(__FILE__) + '/fixtures/rabobank_mt940_structured_savings_account.txt' }
-    let(:bank_statements) { MT940::Base.parse_mt940(file_name) }
+    let(:bank_statements) { MT940Structured::Parser.parse_mt940(file_name) }
 
     it "should have the correct accountnumber" do
       bank_statements["9123456789"].size.should == 1
@@ -178,7 +178,7 @@ describe "Rabobank" do
 
   context "structured betalingskenmerk" do
     let(:file_name) { File.dirname(__FILE__) + '/fixtures/rabobank_mt940_structured_dutch_tax.txt' }
-    let(:bank_statements) { MT940::Base.parse_mt940(file_name) }
+    let(:bank_statements) { MT940Structured::Parser.parse_mt940(file_name) }
 
     it "should put a structuted betalingskenmerk in the description" do
       bank_statement = bank_statements["123456789"][0]
@@ -189,19 +189,19 @@ describe "Rabobank" do
 
   context "structured multiline description" do
     let(:file_name) { File.dirname(__FILE__) + '/fixtures/rabobank_mt940_structured_multi_line.txt' }
-    let(:bank_statements) { MT940::Base.parse_mt940(file_name) }
+    let(:bank_statements) { MT940Structured::Parser.parse_mt940(file_name) }
 
     it "handles multiline in the description" do
       bank_statement = bank_statements["123456789"][0]
       transaction = bank_statement.transactions.first
-      transaction.description.should == "Factuur 2014-002"
+      transaction.description.should == "Factuur 20 14-002"
     end
 
   end
 
   context "mt 940 structured" do
     let(:file_name) { File.dirname(__FILE__) + '/fixtures/rabobank_mt940_structured.txt' }
-    let(:bank_statements) { MT940::Base.parse_mt940(file_name) }
+    let(:bank_statements) { MT940Structured::Parser.parse_mt940(file_name) }
 
     it "should have the correct number of bank account's" do
       bank_statements.keys.size.should == 1
@@ -269,7 +269,7 @@ describe "Rabobank" do
           end
 
           it "should have a contra account owner" do
-            transaction.contra_account_owner.should == "Nespresso Nederland B.V."
+            transaction.contra_account_owner.should == "Nespresso Nede rland B.V."
           end
 
           it "should have a bank" do
@@ -304,7 +304,7 @@ describe "Rabobank" do
         end
 
         it "should have the correct contra account" do
-          transaction.contra_account.should == "NONREF"
+          transaction.contra_account.should == "663616476"
         end
 
         it "should have the correct contra account iban" do
@@ -325,7 +325,7 @@ describe "Rabobank" do
         end
 
         it "should have the correct contra account iban" do
-          transaction.contra_account_iban.should == "4500018"
+          transaction.contra_account_iban.should == nil
         end
 
         it "should have the correct contra account owner" do
@@ -362,7 +362,7 @@ describe "Rabobank" do
 
   it "should be able to handle a debet current balance" do
     debet_file_name = File.dirname(__FILE__) + '/fixtures/rabobank_with_debet_previous_balance.txt'
-    bank_statement = MT940::Base.parse_mt940(debet_file_name)["129199348"].first
+    bank_statement = MT940Structured::Parser.parse_mt940(debet_file_name)["129199348"].first
 
     bank_statement.previous_balance.amount.should == -12
     bank_statement.previous_balance.currency.should == "EUR"

data/spec/mt940_structured/file_content_spec.rb

@@ -0,0 +1,77 @@
+require 'spec_helper'
+
+describe MT940Structured::FileContent do
+
+  subject { MT940Structured::FileContent.new(raw_lines).group_lines }
+
+  context "ignores all lines up to :20:" do
+    let(:raw_lines) { [":940:", ":20:940A121001", ":86:2121.21.211EUR"] }
+    its(:size) { should eq 2 }
+    its(:first) { should eq ":20:940A121001" }
+    its(:last) { should eq ":86:2121.21.211EUR" }
+  end
+
+  context "two :86: lines" do
+    let(:raw_lines) { [":20:940A121001", ":86:2121.21.211EUR", "belongs to first :86:", ":61:bla"] }
+    it "groups them" do
+      expect(subject[1]).to eq(":86:2121.21.211EUR belongs to first :86:")
+    end
+
+    its(:last) { should eq ":61:bla" }
+  end
+
+  context "multiple :86: lines divided by newline" do
+    let(:raw_lines) { [":20:940A121001", ":86:2121.21.211EUR", "belongs to first :86:", "also belongs to first :86:", ":61:bla"] }
+    it "groups them" do
+      expect(subject[1]).to eq(":86:2121.21.211EUR belongs to first :86: also belongs to first :86:")
+    end
+
+    its(:last) { should eq ":61:bla" }
+  end
+
+  context "multiple :86: lines divided by :86:" do
+    let(:raw_lines) do
+      [
+          ":20:940A121008",
+          ":25:2121.21.211EUR",
+          ":28:00000/00",
+          ":60F:C121005EUR000000017351,42",
+          ":61:121008D000000000190,14N0600101000731      INSURRANCE",
+          ":86:BETALINGSKENM.  490022201282",
+          ":86:ARBEIDS ONG. VERZ. 00333333333",
+          ":86:PERIODE 06.10.2012 - 06.11.2012",
+          ":61:bla"
+      ]
+    end
+    it "groups them" do
+      expect(subject[5]).to eq(":86:BETALINGSKENM.  490022201282 ARBEIDS ONG. VERZ. 00333333333 PERIODE 06.10.2012 - 06.11.2012")
+    end
+
+    its(:last) { should eq ":61:bla" }
+
+  end
+
+  context "stops at end of file character for ING" do
+    let(:raw_lines) { [":20:940A121001", ":86:2121.21.211EUR", "-XXX"] }
+    its(:last) { should eq ":86:2121.21.211EUR" }
+  end
+
+  context "stops at end of file character for Rabobank" do
+    let(:raw_lines) { [":20:940A121001", ":86:2121.21.211EUR", ":62F:C121031EUR000000006675,99"] }
+    its(:last) { should eq ":62F:C121031EUR000000006675,99" }
+  end
+
+  context "stops at end of file character for Abn Amro" do
+    let(:raw_lines) { [":20:940A121001", ":86:2121.21.211EUR", "-"] }
+    its(:last) { should eq ":86:2121.21.211EUR" }
+  end
+
+  context "custom grouping divider" do
+    let(:raw_lines) { [":20:940A121001", ":86:2121.21.211EUR", "belongs to first :86:", ":61:bla"] }
+    it "groups them using the custom divider" do
+      custom = MT940Structured::FileContent.new(raw_lines, "\n").group_lines
+      expect(custom[1]).to eq(":86:2121.21.211EUR\nbelongs to first :86:")
+    end
+  end
+
+end