zhong 0.1.6 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8f1dac5a4ab2bbf39455eb3ae3aa85b8db281f71
-  data.tar.gz: bad4a27f7f28e8d9e09bd89e722c8d14de24135f
+  metadata.gz: e8e24ce8cbfc3ebd6b0574c791aef211bb0777c1
+  data.tar.gz: cd327270c61bbfb6817096ff5e2f2aee1ade850e
 SHA512:
-  metadata.gz: 09b25ced5faf77601dcc4056f32441cdf9183a542e4fcdc87ce689806e38e1fc1189613ff9ca11f776c8967e1c4fba9bab83049022860c21ab4893255c64fa4b
-  data.tar.gz: 50d880d5819a8d103d99740a1cacd3a828277015d0def4d486fa777d20f082daa7c1e9d6a56f89469de22f3d9c26245b056165fad4f2339b7fcc45647471a4fd
+  metadata.gz: b5955bed476e79f2b79520523724320404733986912bda9d3d6fc1396c578a935336fd2927295579f9bfe838baf2ee4d55ff953ab6a0f5f4332d3afb85ad0678
+  data.tar.gz: e8082120c278422e3d1f04660739877d4d7fba6573745c31f63df0df4116d719a424087e1d3b8ac06d863d1dd0c98ebfd3489a7e411dcebe08228a1c6fc07ec4

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.1.7
+
+- Improve test coverage.
+- Fix a small serialization issue.
+
 ## 0.1.6
 
 - Add Zhong.any_running? for monitoring that any Zhong node has checked in rencently

data/lib/zhong/at.rb

@@ -71,6 +71,10 @@ module Zhong
       MessagePack.pack(as_json)
     end
 
+    def ==(other)
+      other.class == self.class && other.state == state
+    end
+
     def self.parse_serialized(at)
       if at.is_a?(Array)
         MultiAt.new(at.map { |a| parse_serialized(a) })
@@ -114,10 +118,6 @@ module Zhong
       end
     end
 
-    def ==(other)
-      other.class == self.class && other.state == state
-    end
-
     def state
       [@minute, @hour, @wday]
     end

data/lib/zhong/scheduler.rb

@@ -45,10 +45,7 @@ module Zhong
 
       job = Job.new(name, opts.merge(@config).merge(every: period, category: @category), &block)
 
-      if jobs.key?(job.id)
-        @logger.error "duplicate job #{job}, skipping"
-        return
-      end
+      raise "duplicate job #{job}" if jobs.key?(job.id)
 
       @jobs[job.id] = job
     end

data/lib/zhong/version.rb

@@ -1,3 +1,3 @@
 module Zhong
-  VERSION = "0.1.6".freeze
+  VERSION = "0.1.7".freeze
 end

data/lib/zhong/web.rb

@@ -10,6 +10,7 @@ module Zhong
     enable :sessions
     use ::Rack::Protection, use: :authenticity_token unless ENV["RACK_ENV"] == "test"
 
+    # :nocov:
     if ENV["ZHONG_WEB_USERNAME"] && ENV["ZHONG_WEB_PASSWORD"]
       use Rack::Auth::Basic, "Sorry." do |username, password|
         username == ENV["ZHONG_WEB_USERNAME"] and password == ENV["ZHONG_WEB_PASSWORD"]
@@ -21,6 +22,7 @@ module Zhong
         STDERR.puts "[params] #{params}" unless params.empty?
       end
     end
+    # :nocov:
 
     set :root, File.expand_path(File.dirname(__FILE__) + "/../../web")
     set :public_folder, proc { "#{root}/assets" }
@@ -69,10 +71,12 @@ if defined?(::ActionDispatch::Request::Session) && !::ActionDispatch::Request::S
   # mperham/sidekiq#2460
   # Rack apps can't reuse the Rails session store without
   # this monkeypatch
+  # :nocov:
   class ActionDispatch::Request::Session
     def each(&block)
       hash = self.to_hash
       hash.each(&block)
     end
   end
+  # :nocov:
 end

data/test/test_at.rb

@@ -159,12 +159,18 @@ class TestAt < Minitest::Test
     assert_equal([{m: nil, h: 8, w: nil, g: 0.seconds}, {m: 30, h: 12, w: 0, g: 0.seconds}], at.as_json)
   end
 
-  def test_serialize
+  def test_serialize_multi
     at = Zhong::At.parse(["8:20", "tues 12:30"])
 
     assert_equal Zhong::At.deserialize(at.serialize), at
   end
 
+  def test_serialize_single
+    at = Zhong::At.parse("sun 14:20")
+
+    assert_equal Zhong::At.deserialize(at.serialize), at
+  end
+
   def test_invalid_time_32
     assert_raises Zhong::At::FailedToParse do
       Zhong::At.parse("32:00")

data/test/test_library.rb

@@ -10,12 +10,19 @@ class TestLibrary < Minitest::Test
     sleep 1
   end
 
+  def test_logger
+    test_logger = Zhong.logger
+    Zhong.logger = nil
+    assert_output(nil, nil) { Zhong.logger.info "ensure has default logger" }
+    Zhong.logger = test_logger
+  end
+
   def test_heartbeats
     Zhong.schedule { nil }
     t = Thread.new { Zhong.start }
     sleep(1)
     assert_equal true, Zhong.any_running?
-    assert_in_delta Zhong.redis_time.to_f, Time.now.to_f, 0.1
+    assert_in_delta Zhong.redis_time.to_f, Time.now.to_f, 1
     assert_in_delta Zhong.redis_time.to_f, Zhong.latest_heartbeat.to_f, 1
     Zhong.stop
     t.join

data/test/test_scheduler.rb

@@ -44,6 +44,17 @@ class TestScheduler < Minitest::Test
     end
   end
 
+  def test_duplicate_job_name
+    boom = assert_raises RuntimeError do
+      Zhong.schedule do
+        every(1.second, "dupe_job") { nil }
+        every(1.second, "dupe_job") { nil }
+      end
+    end
+
+    assert_match(/duplicate job dupe_job/, boom.message)
+  end
+
   def test_scheduler_callbacks
     test_before_tick = 0
     test_after_tick = 0

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zhong
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.7
 platform: ruby
 authors:
 - Nick Elser