zfs_mgmt 0.4.0 → 0.4.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 96ec8b7a9e8ba4111f9a8e5d58d347de8a62d00c3d5a681f427abcb21e3560a5
-  data.tar.gz: 2b11bd3aaa99cc664a3a4308ad33e40a640db631c86490ebb2e571718aa5e5c5
+  metadata.gz: fac87cc44c07a79f517498916f2e542113eda412cee4696803bf333b31754b15
+  data.tar.gz: aedb919ad2cbab314a21b5a7fd4847cd96ef1f68607c839a274fa5fc62f2a7b6
 SHA512:
-  metadata.gz: 0dd229c996513d93439e82e08cfeeefc712202c3af28e72df3256c0a58254f8c525c47e4b1457dc0c50a8d3f3a871cebe9e3c5d9a34974c03adec921e8ed870c
-  data.tar.gz: 1a659593c4efa623cb41a8d1586e5d3f34516f960527a1829635b26baad33fcfe8a988585d0be78749692b4b5d6c05cb23dbc4c30be160de8a1c303ed975c13c
+  metadata.gz: fbdcedb2cb08b6babbde7a72002a1afdf7d4be1ab2584de266fdff300777dd0bcd54ad9e1b21883f58d19fe2d32f378d732e8255202ca994ac7d4c4273415bf8
+  data.tar.gz: 7284a85c909b18606f2efffd68aa329f72d7ed003c3ff8ac8a7accf271065e2aa72bedee53ca26f79a2d9262524519c71a6b5087ea5fbe9d09bd0ee67696adda

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    zfs_mgmt (0.4.0)
+    zfs_mgmt (0.4.5)
 
 GEM
   remote: https://rubygems.org/

data/lib/zfs_mgmt.rb

@@ -238,7 +238,7 @@ module ZfsMgmt
     }
     return saved,saved_snaps,deleteme
   end
-  def self.zfs_managed_list(filter: '.+', properties: ['all'], property_match: { 'zfsmgmt:manage' => 'true' } )
+  def self.zfs_managed_list(filter: '.+', properties: ['all'], property_match: { 'zfsmgmt:manage' => method(:prop_on?) } )
     zfss = [] # array of arrays
     zfsget(properties: properties).each do |zfs,props|
       unless /#{filter}/ =~ zfs
@@ -246,7 +246,7 @@ module ZfsMgmt
       end
       managed = true
       property_match.each do |k,v|
-        unless props.has_key?(k) and props[k] == v
+        unless key_comp?(props,k,v)
           managed = false
           break
         end
@@ -311,7 +311,7 @@ module ZfsMgmt
         $logger.debug("delete: #{snap_name} #{local_epoch_to_datetime(snaps[snap_name]['creation']).strftime('%F %T')}")
       end
 
-      com_base = ['zfs', 'destroy']
+      com_base = [ZfsMgmt.global_options[:zfs_binary], 'destroy']
       com_base.push('-d') if deleteme.length > 0 # why?
       com_base.push('-n') if noop
       com_base.push('-v') if verbose
@@ -349,11 +349,11 @@ module ZfsMgmt
     res
   end
   # snapshot all filesystems configured for snapshotting
-  def self.snapshot_create(noop: false, verbose: false, filter: '.+')
+  def self.snapshot_create(noop: false, filter: '.+')
     dt = DateTime.now
     zfsget.select { |zfs,props|
       # must match filter
-      match_filter?(zfs: zfs, filter: filter) and
+      match_filter?(zfs, filter) and
         # snapshot must be on or true
         (
           key_comp?(props,'zfsmgmt:snapshot') or
@@ -367,7 +367,6 @@ module ZfsMgmt
       if key_comp?(props,'zfsmgmt:snapshot','recursive') and key_comp?(props,'zfsmgmt:snapshot@source',['local','received'])
         com.push('-r')
       end
-      com.push('-v') if verbose
       com.push("#{zfs}@#{[prefix,dt.strftime(ts)].join('-')}")
       system_com(com,noop)
     end
@@ -423,8 +422,8 @@ module ZfsMgmt
       com = []
       source = sorted[0]
       if options[:initial_snapshot] == 'newest' or
-        ( options.has_key?('replicate') and options['replicate'] == true ) or
-        ( props.has_key?('zfsmgmt:send_replicate') and props['zfsmgmt:send_replicate'] == 'true' )
+        key_comp?(options, 'replicate') or
+        key_comp?(props, 'zfsmgmt:send_replcate')
         source = sorted[-1]
       end
       com += zfs_send_com(options,
@@ -446,7 +445,7 @@ module ZfsMgmt
       # should be resumable!
       com = [ ]
       com.push( ZfsMgmt.global_options[:zfs_binary], 'send', '-t', remote_zfs_state )
-      com.push('-v','-P') if options[:verbose] and options[:verbose] == 'send'
+      com.push('-v','-P') if key_comp?(options, 'verbose', 'send')
       com.push('|')
       e = zfs_send_estimate(com) if options[:verbose] == 'pv'
       com += mbuffer_command(options) if options[:mbuffer]
@@ -499,7 +498,15 @@ module ZfsMgmt
       if snaps.has_key?(rsnap.sub(destination_path,zfs))
         $logger.debug("process #{rsnap} to #{sorted[-1]}")
         com = []
-        com += zfs_send_com(options,props,[(options[:intermediary] ? '-I' : '-i'),dq(rsnap.split('@')[1])],sorted[-1])
+        i_opt = '-i'
+        # allow the command line option for intermediary to override the property
+        if key_comp?(options,'intermediary',[true,false])
+          i_opt = '-I' if key_comp?(options, 'intermediary', true)
+        elsif key_comp?(props, 'zfsmgmt:send_intermediary')
+          i_opt = '-I'
+        end
+
+        com += zfs_send_com(options,props,[i_opt, dq('@' + rsnap.split('@')[1])], sorted[-1])
         e = zfs_send_estimate(com) if options[:verbose] == 'pv'
         com += mbuffer_command(options) if options[:mbuffer]
         com += pv_command(options,e) if options[:verbose] == 'pv'
@@ -522,7 +529,7 @@ module ZfsMgmt
   end
   def self.zfs_send_com(options,props,extra_opts,target)
     zfs_send_com = [ ZfsMgmt.global_options[:zfs_binary], 'send' ]
-    zfs_send_com.push('-v','-P') if options[:verbose] and options[:verbose] == 'send'
+    zfs_send_com.push('-v','-P') if key_comp?(options,'verbose','send')
     send_opts = {
       'backup'      => '-b',
       'compressed'  => '-c',
@@ -534,10 +541,11 @@ module ZfsMgmt
       'replicate'   => '-R',
     }
     send_opts.each do |p,o|
-      if options.has_key?(p)
-        zfs_send_com.push(o) if options[p] == true
-      elsif props.has_key?("zfsmgmt:send_#{p}")
-        zfs_send_com.push(o) if props["zfsmgmt:send_#{p}"] == 'true'
+      # allow the command line options to override the properties value
+      if key_comp?(options,p,[true,false])
+        zfs_send_com.push(o) if key_comp?(options,p,true)
+      elsif key_comp?(props,"zfsmgmt:send_#{p}")
+        zfs_send_com.push(o)
       end
     end
     zfs_send_com + extra_opts + [dq(target),'|']
@@ -545,18 +553,21 @@ module ZfsMgmt
   def self.zfs_recv_com(options,extra_opts,props,target)
     zfs_recv_com = [ ZfsMgmt.global_options[:zfs_binary], 'recv', '-F', '-s' ]
     recv_opts = {
-      'noop'       => '-n',
-      'drop_holds' => '-h',
-      'unmount'    => '-u',
+      'noop'          => '-n',
+      'drop_holds'    => '-h',
+      'unmount'       => '-u',
+      #'discard_last'  => '-e',
+      #'discard_first' => '-d',
     }
     recv_opts.each do |p,o|
-      if options.has_key?(p)
-        zfs_recv_com.push(o) if options[p] == true
-      elsif props.has_key?("zfsmgmt:recv_#{p}")
-        zfs_recv_com.push(o) if props["zfsmgmt:recv_#{p}"] == 'true'
+      # allow the command line options to override the properties value
+      if key_comp?(options,p,[true,false])
+        zfs_recv_com.push(o) if key_comp?(options,p,true)
+      elsif key_comp?(props,"zfsmgmt:recv_#{p}")
+        zfs_recv_com.push(o)
       end
     end
-    zfs_recv_com.push('-v') if options[:verbose] and ( options[:verbose] == 'receive' or options[:verbose] == 'recv' )
+    zfs_recv_com.push('-v') if key_comp?(options, 'verbose', ['receive', 'recv'])
     if options[:exclude]
       options[:exclude].each do |x|
         zfs_recv_com.push('-x',x)
@@ -619,7 +630,7 @@ module ZfsMgmt
   def self.prop_on?(v)
     ['true','on'].include?(v)
   end
-  def self.match_filter?(zfs:, filter:)
+  def self.match_filter?(zfs, filter)
     /#{filter}/ =~ zfs
   end
   def self.key_comp?(h,p,v = method(:prop_on?))
@@ -629,14 +640,13 @@ module ZfsMgmt
       return v.include?(h[p])
     elsif v.kind_of?(Hash)
       return v.keys.include?(h[p])
-    elsif v.kind_of?(String)
-      return h[p] == v
     elsif v.kind_of?(Method)
       return v.call(h[p])
     elsif v.kind_of?(Regexp)
       return v =~ h[p]
     else
-      raise ArgumentError
+      # string, boolean, numbers?
+      return h[p] == v
     end
   end
   def self.set_log_level(sev)
@@ -653,4 +663,23 @@ module ZfsMgmt
       $logger.level = Logger::FATAL
     end
   end
+  def self.zfs_send_all(options)
+    zfs_managed_list(filter: options[:filter],
+                     property_match: { 'zfsmgmt:send' => method(:prop_on?) }).each do |zfs,props,snaps|
+      
+      if props['zfsmgmt:send@source'] == 'received'
+        $logger.debug("skipping received filesystem: #{zfs}")
+        next
+      end
+      if key_comp?(props,'zfsmgmt:send_replicate') and props['zfsmgmt:send_replicate@source'] != 'local'
+        $logger.debug("skipping descendant of replicated filesystems: #{zfs}")
+        next
+      end
+      unless props['zfsmgmt:destination']
+        $logger.error("#{zfs}: you must specify a destination zfs path via the user property zfsmgmt:destination, even if using --destination on the command line, skipping")
+        next
+      end
+      zfs_send(options,zfs,props,snaps)
+    end
+  end
 end

data/lib/zfs_mgmt/restic.rb

@@ -70,7 +70,7 @@ module ZfsMgmt::Restic
                                           'zfsmgmt:restic_repository',
                                           'userrefs',
                                          ],
-                             property_match: { 'zfsmgmt:restic_backup' => 'true' }).each do |blob|
+                             property_match: { 'zfsmgmt:restic_backup' => ['on','true'] }).each do |blob|
       zfs,props,zfs_snapshots = blob
       last_zfs_snapshot = zfs_snapshots.keys.sort { |a,b| zfs_snapshots[a]['creation'] <=> zfs_snapshots[b]['creation'] }.last
       zfs_snap_time = Time.at(zfs_snapshots[last_zfs_snapshot]['creation'])

data/lib/zfs_mgmt/version.rb

@@ -1,3 +1,3 @@
 module ZfsMgmt
-  VERSION = "0.4.0"
+  VERSION = "0.4.5"
 end

data/lib/zfs_mgmt/zfs_mgr/list.rb

@@ -13,7 +13,7 @@ class ZfsMgmt::ZfsMgr::List < Thor
     table = Text::Table.new
     table.head = ['zfs','snapshot','age']
     table.rows = []
-    ZfsMgmt.zfs_managed_list(filter: options[:filter]).each do |zfs,props,snap|
+    ZfsMgmt.zfs_managed_list(filter: options[:filter]).each do |zfs,props,snaps|
       last = snaps.keys.sort { |a,b| snaps[a]['creation'] <=> snaps[b]['creation'] }.last
       snap_time = Time.at(snaps[last]['creation'])
       if snap_time < cutoff

data/lib/zfs_mgmt/zfs_mgr/send.rb

@@ -35,29 +35,6 @@ class ZfsMgmt::ZfsMgr::Send < Thor
     ZfsMgmt.set_log_level(options[:loglevel])
     ZfsMgmt.global_options = options
 
-    [
-      { 'zfsmgmt:send' => 'true' },
-      # {
-      #   'zfsmgmt:send' => 'replicate',
-      #   'zfsmgmt:send@source' => 'local'
-      # },
-    ].each do |match|
-      ZfsMgmt.zfs_managed_list(filter: options[:filter],
-                               property_match: match).each do |zfs,props,snaps|
-        if props['zfsmgmt:send@source'] == 'received'
-          $logger.debug("skipping received filesystem: #{zfs}")
-          next
-        end
-        if props.has_key?('zfsmgmt:send_replicate') and props['zfsmgmt:send_replicate'] == 'true' and props['zfsmgmt:send_replicate@source'] != 'local'
-          $logger.debug("skipping descendant of replicated filesystems: #{zfs}")
-          next
-        end
-        unless props['zfsmgmt:destination']
-          $logger.error("#{zfs}: you must specify a destination zfs path via the user property zfsmgmt:destination, even if using --destination on the command line, skipping")
-          next
-        end
-        ZfsMgmt.zfs_send(options,zfs,props,snaps)
-      end
-    end
+    ZfsMgmt.zfs_send_all(options)
   end
 end

data/lib/zfs_mgmt/zfs_mgr/snapshot.rb

@@ -22,11 +22,9 @@ class ZfsMgmt::ZfsMgr::Snapshot < Thor
   desc "create", "execute zfs snapshot based on zfs properties"
   method_option :noop, :type => :boolean, :default => false,
                 :desc => 'log snapshot commands without running zfs snapshot'
-  method_option :verbose, :type => :boolean, :default => false,
-                :desc => 'pass -v option to zfs commands'
   def create()
     ZfsMgmt.set_log_level(options[:loglevel])
     ZfsMgmt.global_options = options
-    ZfsMgmt.snapshot_create(noop: options[:noop], verbose: options[:verbose], filter: options[:filter])
+    ZfsMgmt.snapshot_create(noop: options[:noop], filter: options[:filter])
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: zfs_mgmt
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.5
 platform: ruby
 authors:
 - Aran Cox
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-03-11 00:00:00.000000000 Z
+date: 2021-04-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -155,7 +155,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: Misc. helpers regarding snapshots and send/recv.