zeus-parallel_tests 0.2.4 → 0.3.0

data/spec/dummy/config/boot.rb

@@ -3,4 +3,4 @@ require 'rubygems'
 # Set up gems listed in the Gemfile.
 ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
 
-require 'bundler/setup' if File.exists?(ENV['BUNDLE_GEMFILE'])
+require 'bundler/setup' if File.exist?(ENV['BUNDLE_GEMFILE'])

data/spec/dummy/config/environments/development.rb

@@ -21,12 +21,4 @@ Dummy::Application.configure do
 
   # Only use best-standards-support built into browsers
   config.action_dispatch.best_standards_support = :builtin
-
-  # Raise exception on mass assignment protection for Active Record models
-  config.active_record.mass_assignment_sanitizer = :strict
-
-  # Log the query plan for queries taking more than this (works
-  # with SQLite, MySQL, and PostgreSQL)
-  config.active_record.auto_explain_threshold_in_seconds = 0.5
-
 end

data/spec/dummy/config/environments/production.rb

@@ -11,7 +11,6 @@ Dummy::Application.configure do
   # Disable Rails's static asset server (Apache or nginx will already do this)
   config.serve_static_assets = false
 
-
   # Specifies the header that your server uses for sending files
   # config.action_dispatch.x_sendfile_header = "X-Sendfile" # for apache
   # config.action_dispatch.x_sendfile_header = 'X-Accel-Redirect' # for nginx
@@ -34,7 +33,6 @@ Dummy::Application.configure do
   # Enable serving of images, stylesheets, and JavaScripts from an asset server
   # config.action_controller.asset_host = "http://assets.example.com"
 
-
   # Disable delivery errors, bad email addresses will be ignored
   # config.action_mailer.raise_delivery_errors = false
 
@@ -47,8 +45,4 @@ Dummy::Application.configure do
 
   # Send deprecation notices to registered listeners
   config.active_support.deprecation = :notify
-
-  # Log the query plan for queries taking more than this (works
-  # with SQLite, MySQL, and PostgreSQL)
-  # config.active_record.auto_explain_threshold_in_seconds = 0.5
 end

data/spec/dummy/config/environments/test.rb

@@ -9,7 +9,7 @@ Dummy::Application.configure do
 
   # Configure static asset server for tests with Cache-Control for performance
   config.serve_static_assets = true
-  config.static_cache_control = "public, max-age=3600"
+  config.static_cache_control = 'public, max-age=3600'
 
   # Log error messages when you accidentally call methods on nil
   config.whiny_nils = true
@@ -29,9 +29,6 @@ Dummy::Application.configure do
   # ActionMailer::Base.deliveries array.
   config.action_mailer.delivery_method = :test
 
-  # Raise exception on mass assignment protection for Active Record models
-  config.active_record.mass_assignment_sanitizer = :strict
-
   # Print deprecation notices to the stderr
   config.active_support.deprecation = :stderr
 end

data/spec/dummy/custom_plan.rb

@@ -1,3 +1,4 @@
+require 'bundler/setup'
 require 'zeus/parallel_tests'
 
 class CustomPlan < Zeus::ParallelTests::Rails

data/spec/dummy/features/support/env.rb

@@ -33,7 +33,7 @@ ActionController::Base.allow_rescue = false
 begin
   DatabaseCleaner.strategy = :transaction
 rescue NameError
-  raise "You need to add database_cleaner to your Gemfile (in the :test group) if you wish to use it."
+  raise 'You need to add database_cleaner to your Gemfile (in the :test group) if you wish to use it.'
 end
 
 # You may also want to configure DatabaseCleaner to use different strategies for certain features and scenarios.
@@ -55,4 +55,3 @@ end
 # The :transaction strategy is faster, but might give you threading problems.
 # See https://github.com/cucumber/cucumber-rails/blob/master/features/choose_javascript_database_strategy.feature
 Cucumber::Rails::Database.javascript_strategy = :truncation
-

data/spec/dummy/lib/tasks/cucumber.rake

@@ -4,62 +4,61 @@
 # instead of editing this one. Cucumber will automatically load all features/**/*.rb
 # files.
 
+unless ARGV.any? { |a| a =~ /^gems/ } # Don't load anything when running the gems:* tasks
 
-unless ARGV.any? {|a| a =~ /^gems/} # Don't load anything when running the gems:* tasks
+  vendored_cucumber_bin = Dir["#{Rails.root}/vendor/{gems,plugins}/cucumber*/bin/cucumber"].first
+  $LOAD_PATH.unshift(File.dirname(vendored_cucumber_bin) + '/../lib') unless vendored_cucumber_bin.nil?
 
-vendored_cucumber_bin = Dir["#{Rails.root}/vendor/{gems,plugins}/cucumber*/bin/cucumber"].first
-$LOAD_PATH.unshift(File.dirname(vendored_cucumber_bin) + '/../lib') unless vendored_cucumber_bin.nil?
+  begin
+    require 'cucumber/rake/task'
 
-begin
-  require 'cucumber/rake/task'
+    namespace :cucumber do
+      Cucumber::Rake::Task.new({ ok: 'test:prepare' }, 'Run features that should pass') do |t|
+        t.binary = vendored_cucumber_bin # If nil, the gem's binary is used.
+        t.fork = true # You may get faster startup if you set this to false
+        t.profile = 'default'
+      end
 
-  namespace :cucumber do
-    Cucumber::Rake::Task.new({:ok => 'test:prepare'}, 'Run features that should pass') do |t|
-      t.binary = vendored_cucumber_bin # If nil, the gem's binary is used.
-      t.fork = true # You may get faster startup if you set this to false
-      t.profile = 'default'
-    end
-
-    Cucumber::Rake::Task.new({:wip => 'test:prepare'}, 'Run features that are being worked on') do |t|
-      t.binary = vendored_cucumber_bin
-      t.fork = true # You may get faster startup if you set this to false
-      t.profile = 'wip'
-    end
+      Cucumber::Rake::Task.new({ wip: 'test:prepare' }, 'Run features that are being worked on') do |t|
+        t.binary = vendored_cucumber_bin
+        t.fork = true # You may get faster startup if you set this to false
+        t.profile = 'wip'
+      end
 
-    Cucumber::Rake::Task.new({:rerun => 'test:prepare'}, 'Record failing features and run only them if any exist') do |t|
-      t.binary = vendored_cucumber_bin
-      t.fork = true # You may get faster startup if you set this to false
-      t.profile = 'rerun'
-    end
+      Cucumber::Rake::Task.new({ rerun: 'test:prepare' }, 'Record failing features and run only them if any exist') do |t|
+        t.binary = vendored_cucumber_bin
+        t.fork = true # You may get faster startup if you set this to false
+        t.profile = 'rerun'
+      end
 
-    desc 'Run all features'
-    task :all => [:ok, :wip]
+      desc 'Run all features'
+      task all: [:ok, :wip]
 
-    task :statsetup do
-      require 'rails/code_statistics'
-      ::STATS_DIRECTORIES << %w(Cucumber\ features features) if File.exist?('features')
-      ::CodeStatistics::TEST_TYPES << "Cucumber features" if File.exist?('features')
+      task :statsetup do
+        require 'rails/code_statistics'
+        ::STATS_DIRECTORIES << %w(Cucumber\ features features) if File.exist?('features')
+        ::CodeStatistics::TEST_TYPES << 'Cucumber features' if File.exist?('features')
+      end
     end
-  end
-  desc 'Alias for cucumber:ok'
-  task :cucumber => 'cucumber:ok'
+    desc 'Alias for cucumber:ok'
+    task cucumber: 'cucumber:ok'
 
-  task :default => :cucumber
+    task default: :cucumber
 
-  task :features => :cucumber do
-    STDERR.puts "*** The 'features' task is deprecated. See rake -T cucumber ***"
-  end
+    task features: :cucumber do
+      STDERR.puts "*** The 'features' task is deprecated. See rake -T cucumber ***"
+    end
 
-  # In case we don't have the generic Rails test:prepare hook, append a no-op task that we can depend upon.
-  task 'test:prepare' do
-  end
+    # In case we don't have the generic Rails test:prepare hook, append a no-op task that we can depend upon.
+    task 'test:prepare' do
+    end
 
-  task :stats => 'cucumber:statsetup'
-rescue LoadError
-  desc 'cucumber rake task not available (cucumber not installed)'
-  task :cucumber do
-    abort 'Cucumber rake task is not available. Be sure to install cucumber as a gem or plugin'
+    task stats: 'cucumber:statsetup'
+  rescue LoadError
+    desc 'cucumber rake task not available (cucumber not installed)'
+    task :cucumber do
+      abort 'Cucumber rake task is not available. Be sure to install cucumber as a gem or plugin'
+    end
   end
-end
 
 end

data/spec/dummy/spec/spec_helper.rb

@@ -1,11 +1,11 @@
 # This file is copied to spec/ when you run 'rails generate rspec:install'
-ENV["RAILS_ENV"] ||= 'test'
-require File.expand_path("../../config/environment", __FILE__)
+ENV['RAILS_ENV'] ||= 'test'
+require File.expand_path('../../config/environment', __FILE__)
 require 'rspec/rails'
 
 # Requires supporting ruby files with custom matchers and macros, etc,
 # in spec/support/ and its subdirectories.
-Dir[Rails.root.join("spec/support/**/*.rb")].each {|f| require f}
+Dir[Rails.root.join('spec/support/**/*.rb')].each { |f| require f }
 
 RSpec.configure do |config|
   # ## Mock Framework
@@ -33,5 +33,5 @@ RSpec.configure do |config|
   # order dependency and want to debug it, you can fix the order by providing
   # the seed, which is printed after each run.
   #     --seed 1234
-  config.order = "random"
+  config.order = 'random'
 end

data/spec/dummy/spec/unit_test_a_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
-describe "Unit A" do
-  it "should be true" do
-    expect(true).to be_true
+describe 'Unit A' do
+  it 'should be true' do
+    expect(true).to be true
   end
 end

data/spec/dummy/spec/unit_test_b_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
-describe "Unit B" do
-  it "should be true" do
-    expect(true).to be_true
+describe 'Unit B' do
+  it 'should be true' do
+    expect(true).to be true
   end
 end

data/spec/lib/zeus/parallel_tests/worker_spec.rb

@@ -1,61 +1,59 @@
-require "spec_helper"
-
-require_relative "../../../../lib/zeus/parallel_tests/worker"
+require './lib/zeus/parallel_tests/worker'
 
 describe Zeus::ParallelTests::Worker do
-  describe ".run" do
-    let(:cli_argv) { ["rspec", "spec/models/model_spec.rb"] }
-    let(:cli_env)  { {"TEST_ENV_NUMBER" => "3"} }
-    let(:worker)   { double("worker", spawn: 0) }
-    before  { Zeus::ParallelTests::Worker.stub(new: worker) }
+  describe '.run' do
+    let(:cli_argv) { ['rspec', 'spec/models/model_spec.rb'] }
+    let(:cli_env)  { { 'TEST_ENV_NUMBER' => '3' } }
+    let(:worker)   { double('worker', spawn: 0) }
+    before  { allow(Zeus::ParallelTests::Worker).to receive_messages(new: worker) }
     subject { Zeus::ParallelTests::Worker.run(cli_argv, cli_env)  }
 
-    it "creates instance of worker" do
-      Zeus::ParallelTests::Worker.should_receive(:new)
-        .with("rspec", cli_env, ["spec/models/model_spec.rb"])
+    it 'creates instance of worker' do
+      expect(Zeus::ParallelTests::Worker).to receive(:new)
+        .with('rspec', cli_env, ['spec/models/model_spec.rb'])
         .and_return(worker)
       subject
     end
 
-    it "does not modify original env and argv" do
+    it 'does not modify original env and argv' do
       subject
-      expect(cli_argv).to eq(["rspec", "spec/models/model_spec.rb"])
-      expect(cli_env).to eq({"TEST_ENV_NUMBER" => "3"})
+      expect(cli_argv).to eq(['rspec', 'spec/models/model_spec.rb'])
+      expect(cli_env).to eq('TEST_ENV_NUMBER' => '3')
     end
 
-    it "returns exit code" do
+    it 'returns exit code' do
       expect(subject).to eq(0)
     end
   end
 
-  describe "#spawn" do
+  describe '#spawn' do
     subject { worker.spawn }
-    let(:worker) { Zeus::ParallelTests::Worker.new("rspec", cli_env, ["spec/file_spec.rb"]) }
-    let(:cli_env) { {"TEST_ENV_NUMBER" => 2, "PARALLEL_TEST_GROUPS" => 4} }
-    let(:argv_file) { double("argv_file", path: "argv_file_path", unlink: true, puts: nil, close: nil) }
+    let(:worker) { Zeus::ParallelTests::Worker.new('rspec', cli_env, ['spec/file_spec.rb']) }
+    let(:cli_env) { { 'TEST_ENV_NUMBER' => 2, 'PARALLEL_TEST_GROUPS' => 4 } }
+    let(:argv_file) { double('argv_file', path: 'argv_file_path', unlink: true, puts: nil, close: nil) }
     before do
-      Tempfile.stub(new: argv_file)
-      worker.stub(system: true)
+      allow(Tempfile).to receive_messages(new: argv_file)
+      allow(worker).to receive_messages(system: true)
     end
 
-    it "writes args to file" do
-      argv_file.should_receive(:puts).with("spec/file_spec.rb")
+    it 'writes args to file' do
+      expect(argv_file).to receive(:puts).with('spec/file_spec.rb')
       subject
     end
 
-    it "spawns worker and passes TEST_ENV_NUMBER, PARALLEL_TEST_GROUPS and argv file path" do
-      worker.should_receive(:system).with("zeus parallel_rspec_worker 2 4 argv_file_path")
+    it 'spawns worker and passes TEST_ENV_NUMBER, PARALLEL_TEST_GROUPS and argv file path' do
+      expect(worker).to receive(:system).with('zeus parallel_rspec_worker 2 4 argv_file_path')
       subject
     end
 
-    it "removes argv_file after run" do
-      argv_file.should_receive(:unlink)
+    it 'removes argv_file after run' do
+      expect(argv_file).to receive(:unlink)
       subject
     end
 
-    it "returns exit code" do
-      system "true"
-      worker.should_receive(:system) { $?.stub(to_i: 1) }
+    it 'returns exit code' do
+      system 'true'
+      expect(worker).to receive(:system) { allow($CHILD_STATUS).to receive_messages(to_i: 1) }
       expect(subject).to eq(1)
     end
   end

data/spec/parallel_spec.rb

@@ -0,0 +1,56 @@
+$LOAD_PATH.unshift File.expand_path('../../../lib', __FILE__)
+
+require 'zeus/parallel_tests/version'
+require 'open3'
+require 'English'
+
+describe 'zeus parallel spec' do
+  def launch_server
+    pid = fork do
+      Dir.chdir 'spec/dummy/' do
+        exec 'bundle exec zeus start > /dev/null'
+      end
+    end
+    sleep 3
+    pid
+  end
+
+  before(:all) do
+    # Copy current Appraisal gemfile to dummy app.
+    gemfile = File.read(ENV['BUNDLE_GEMFILE']).gsub(':path => "../"', ':path => "../../"')
+    File.open('spec/dummy/Gemfile', 'w+') { |f| f.write gemfile }
+    gemfile_lock = File.read("#{ENV['BUNDLE_GEMFILE']}.lock").gsub('remote: ../', 'remote: ../../')
+    File.open('spec/dummy/Gemfile.lock', 'w+') { |f| f.write gemfile_lock }
+
+    # Launch Zeus.
+    @server_pid = launch_server.to_s
+  end
+
+  it 'connects to server' do
+    Dir.chdir 'spec/dummy/' do
+      system('bundle', 'exec', 'zeus', 'r', 'true')
+      expect($CHILD_STATUS.success?).to be true
+    end
+  end
+
+  it 'runs rspec specs in two processes' do
+    Dir.chdir 'spec/dummy' do
+      Open3.popen2e('bundle', 'exec', 'zeus', 'parallel_rspec', '-n', '2', 'spec') do |_, output|
+        expect(output.to_a.map(&:chomp)).to include('2 processes for 2 specs, ~ 1 specs per process')
+      end
+    end
+  end
+
+  it 'runs cucumbers in two processes' do
+    Dir.chdir 'spec/dummy' do
+      Open3.popen2e('bundle', 'exec', 'zeus', 'parallel_cucumber', '-n', '2', 'features') do |_, output|
+        expect(output.to_a.map(&:chomp)).to include('2 processes for 2 features, ~ 1 features per process')
+      end
+    end
+  end
+
+  after(:all) do
+    system('kill', '-9', @server_pid)
+    system('rm', '-f', 'spec/dummy/Gemfile', 'spec/dummy/Gemfile.lock', 'spec/dummy/.zeus.sock')
+  end
+end

data/spec/spec_helper.rb

@@ -1,14 +1,6 @@
-# This file was generated by the `rspec --init` command. Conventionally, all
-# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
-# Require this file using `require "spec_helper"` to ensure that it is only
-# loaded once.
-#
-# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
-RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
-  config.run_all_when_everything_filtered = true
-  config.filter_run :focus
+require 'rspec'
 
+RSpec.configure do |config|
   # Run specs in random order to surface order dependencies. If you find an
   # order dependency and want to debug it, you can fix the order by providing
   # the seed, which is printed after each run.

data/spec/zeus_parallel_tests_spec.rb

@@ -0,0 +1,16 @@
+describe 'Configuration file generation' do
+  let(:project_dir) { File.expand_path(Dir.mktmpdir) }
+  let(:bin) { File.expand_path('../../bin/zeus-parallel_tests', __FILE__) }
+
+  subject { system(bin, 'init', chdir: project_dir) }
+
+  after { FileUtils.rm_rf project_dir }
+
+  it 'creates zeus configuration projects directory' do
+    subject
+
+    ['zeus.json', 'custom_plan.rb'].each do |f|
+      expect(File.exist?(File.join(project_dir, f))).to be_truthy
+    end
+  end
+end

data/zeus-parallel_tests.gemspec

@@ -4,24 +4,33 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'zeus/parallel_tests/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "zeus-parallel_tests"
+  spec.name          = 'zeus-parallel_tests'
   spec.version       = Zeus::ParallelTests::VERSION
-  spec.authors       = ["Artur Roszczyk"]
-  spec.email         = ["artur.roszczyk@gmail.com"]
-  spec.description   = %q{Integration for zeus and parallel_tests}
-  spec.summary       = %q{}
-  spec.homepage      = ""
-  spec.license       = "MIT"
+  spec.authors       = ['Artur Roszczyk']
+  spec.email         = ['artur.roszczyk@gmail.com']
+  spec.description   = 'Integration for zeus and parallel_tests'
+  spec.summary       = ''
+  spec.homepage      = ''
+  spec.license       = 'MIT'
 
-  spec.files         = `git ls-files`.split($/)
+  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_dependency "zeus", "~> 0.13.3"
-  spec.add_dependency "parallel_tests", ">= 0.11.3"
+  spec.add_dependency 'zeus', '>= 0.13.0'
+  spec.add_dependency 'parallel_tests', '>= 0.11.3'
 
-  spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec"
+  spec.add_development_dependency 'appraisal'
+  spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rubocop'
+  spec.add_development_dependency 'rspec', '>= 3.0'
+
+  # Gems used by dummy app in testing.
+  spec.add_development_dependency 'cucumber-rails'
+  spec.add_development_dependency 'database_cleaner'
+  spec.add_development_dependency 'guard-rspec'
+  spec.add_development_dependency 'rspec-rails'
+  spec.add_development_dependency 'sqlite3'
 end