zensana 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ea308a2a19d3adbe4fbd80bca3ddc3a09042668b
-  data.tar.gz: fa62e437c65bd88ebf8a2ec4ff0d716ae04813f8
+  metadata.gz: b18b7ff525379225c8f69bce1b3ea35a6e0d792b
+  data.tar.gz: 4a4230204921505fcd69183c7d1d1e61e2edcdd9
 SHA512:
-  metadata.gz: d0383bcc73118353f5c0bacf11beb5fd10ce72bd6b663ceafddf5ca521b5a6387d80aec6b221a6646f5104a93ec1bc51fe9e7db65428b71def38b6c11a8132a2
-  data.tar.gz: 1b81528f9917e9f6982e81355c0fa595711625c26fe286f1ec209920b9b0c5ffef6772d5cd9e890ca8d836e60cbe30e83f0d85939e66e5732175103f76140ebb
+  metadata.gz: 01a350826753a4d61e3ac7fe73089540d2745b7c114707e5dafecb383616e95e3aa3cd34b40379977473268c690a2756f6c60d635dafe309f0392a263f62377c
+  data.tar.gz: a575ccec62f200adf69cf5a84086d518c4348c9f3368ff28b418c2c480f28af80214bcc59218c08380dde36d9bc41e21be4c360a1919594c0e27da78604f17a1

data/README.md

@@ -4,6 +4,8 @@ This gem provides access to the Asana API and ZenDesk Ticket Import API
 for the purpose of importing tasks from Asana Projects into ZenDesk
 tickets.
 
+[![Gem Version](https://badge.fury.io/rb/zensana.svg)](http://badge.fury.io/rb/zensana)
+
 ## Installation
 
 Add this line to your application's Gemfile:

data/lib/zensana/commands/project.rb

@@ -27,12 +27,12 @@ module Zensana
     end
 
     desc 'convert PROJECT', 'Convert PROJECT tasks to ZenDesk tickets (exact ID or NAME required)'
-    option :attachments,  type: 'boolean', aliases: '-a', default: true,  desc: 'download and upload any attachments'
-    option :completed,    type: 'boolean', aliases: '-c', default: false, desc: 'include tasks that are completed'
-    option :default_user, type: 'string',  aliases: '-u', default: nil,   desc: 'set a default user to assign to tickets'
-    #    option :followers,    type: 'boolean', aliases: '-f', default: false, desc: 'add followers of tasks to tickets'
-    option :stories,      type: 'boolean', aliases: '-s', default: true,  desc: 'import stories as comments'
-    option :verified,     type: 'boolean', aliases: '-v', default: true,  desc: '`false` will send email to zendesk users created'
+    option :attachments,  type: 'boolean', aliases: '-a', default: true,        desc: 'download and upload any attachments'
+    option :completed,    type: 'boolean', aliases: '-c', default: false,       desc: 'include tasks that are completed'
+    option :global_tags,  type: 'array',   aliases: '-t', default: ['zensana'], desc: 'array of tag(s) to be applied to every ticket imported'
+    option :stories,      type: 'boolean', aliases: '-s', default: true,        desc: 'import stories as comments'
+    option :default_user, type: 'string',  aliases: '-u', default: nil,         desc: 'set a default user to assign to tickets'
+    option :verified,     type: 'boolean', aliases: '-v', default: true,        desc: '`false` will send email to zendesk users created'
     def convert(project)
       @asana_project = Zensana::Asana::Project.new(project)
       say <<-BANNER
@@ -60,7 +60,11 @@ using options #{options}
       # `section_tag_list` holds the tags for the last
       # section task which are also added to tickets
       #
-      tags = [ 'zensana', 'imported' ]
+      tags = [ 'imported' ]
+      options[:global_tags].each do |t|
+        tags << normalize(t)
+      end
+      puts tags
       project_tags = [] << tags
       section_tags = []
 
@@ -114,10 +118,10 @@ using options #{options}
       if task.is_section?
         say "\nProcessing section: #{task.section_name} "
         section_tags.pop
-        section_tags.push task.tags << snake_case(task.section_name)
+        section_tags.push task.tags << normalize(task.section_name)
       else
         say "\nProcessing task: #{task.name} "
-        project_tags.push snake_case(task.tags)
+        project_tags.push normalize(task.tags)
 
         if Zensana::Zendesk::Ticket.external_id_exists?(task.id)
           say "\n >>> skip ticket creation, task already imported ", :yellow
@@ -156,9 +160,10 @@ using options #{options}
 
           # if assignee is not an agent then leave unassigned
           if (assignee_key = options[:default_user] || task.attributes['assignee'])
-            unless (assignee = asana_to_zendesk_user(assignee_key, false)) &&
-                (assignee.role != 'end-user')
-              assignee = nil
+            if (assignee = asana_to_zendesk_user(assignee_key, false))
+              unless assignee.attributes && assignee.attributes['role'] != 'end-user'
+                assignee = nil
+              end
             end
           end
 
@@ -176,12 +181,13 @@ using options #{options}
 
             Task attributes:  #{task.attributes}
             EOF
-            :assignee_id  => assignee ? assignee.id : '',
+            :assignee_id  => assignee ? assignee.id : nil,
             :created_at   => task.created_at,
             :tags         => flatten_tags(project_tags, section_tags),
             :comments     => comments
           )
           ticket.import
+          say "\n >>> ticket imported "
         end
 
         # rinse and repeat for subtasks and their subtasks and ...
@@ -275,19 +281,19 @@ using options #{options}
       tags.flatten.uniq
     end
 
-    def snake_case(thing)
+    def normalize(thing)
       case
       when thing.is_a?(String)
-        snake_case_it thing
+        normalize_it thing
       when thing.is_a?(Array)
-        thing.map { |a| snake_case a }
+        thing.map { |a| normalize a }
       else
-        raise ArgumentError, "I don't know how to snake_case instances of #{thing.class}"
+        raise ArgumentError, "I don't know how to normalize instances of #{thing.class}"
       end
     end
 
-    def snake_case_it(thing)
-      thing.gsub(/(.)([A-Z])/,'\1_\2').gsub(' ', '_').downcase
+    def normalize_it(thing)
+      thing.gsub(/(\/| |-)+/,'_').downcase
     end
   end
 end

data/lib/zensana/models/zendesk/user.rb

@@ -53,8 +53,9 @@ module Zensana
 
       def lookup_by_email(email)
         unless (user = read_cache(email))
-          user = search("email:#{email}")
-          update_cache user
+          if (user = search("email:#{email}"))
+            update_cache user
+          end
         end
         user
       end
@@ -78,7 +79,7 @@ module Zensana
       end
 
       def update_cache(user)
-        [ :id, :email ].each do |attr|
+        [ 'id', 'email' ].each do |attr|
           key = user[attr].to_s
           cache[key] = user
         end

data/lib/zensana/version.rb

@@ -1,3 +1,3 @@
 module Zensana
-  VERSION = "1.0.0"
+  VERSION = "1.1.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zensana
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Warren Bain