zenps-ruby 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 931e2368e823cda7839fa93c039c78c1c8100abe3946b43ef5823e87b8145e32
-  data.tar.gz: c316c9c3acaabda72b797ecd47bc5017f6491e64055ff1b51f720606c64c5c28
+  metadata.gz: 2cdf4ec564f1ea34c3123c569c756457ba9ad61b49a836efe2dacde0513317a2
+  data.tar.gz: 4163d373e87d92f495a53bb614420a989b4a9c48bdd95c7fbc07a172410d8e9b
 SHA512:
-  metadata.gz: 32cab1857eecb8c81e3fce35cf1d9ff2fe07e394441987f8df03a2be7032c3137d7e8a8fad7f6f0b21197ecbfd95fcc40e6bea12c84151d3647a7fcb90d99d9c
-  data.tar.gz: ecfbe289ddf70293b10bb8a1d50647da99e0d24f91ead8bffd783bf80ed656804b8d53a623bd2b38eff446094f2cb8339cdcfc227404a878d60f02557944e885
+  metadata.gz: cd93e3b6d9bbefac6129db2d240e1ab4d0d15c2f4c22ff5ec07d3476074146f9f45298341f59f6c630187b91b39e4b9ea8a682d6fb7c344a6f3135a6fa88a8ab
+  data.tar.gz: 96d7bc60e3a96b15b11f60ba7c6b2bca5e573d4a14b772a0616b15626b76764ae15bccb9c89d3b2ce192879c3e823f3f743cec73d0cab80f69bbc84c78d17267

data/README.md

@@ -52,10 +52,14 @@ A user subject can either be:
   - A string (email of user to be surveyed)
   - A hash containing the following keys:
     - email (compulsory)
-    - locale (optional --> defaults to `en`)
+    - first_name (optional)
+    - last_name (optional)
+    - locale (optional --> defaults to `en` unless overwritten in general call)
   - An object that responds to
     - email method (compulsory)
-    - locale (optional --> defaults to `en`)
+    - first_name method (optional)
+    - last_name method (optional)
+    - locale (optional --> defaults to `en` unless overwritten in general call)
 
 This allows for the gem to be used eg. in a rails application with User models that respond to the email method (and/or locale) as follows
 
@@ -84,15 +88,15 @@ Zenps::Survey.call(user, locale: 'fr', event: 'sign_up', tags: ['man', 'facebook
 ```
 
 
-## Contributing to pipedrive-ruby
+## Contributing to zenps-ruby
 
 * Check out the latest master to make sure the feature hasn't been implemented or the bug hasn't been fixed yet.
 * Check out the issue tracker to make sure someone already hasn't requested it and/or contributed it.
 * Fork the project.
 * Start a feature/bugfix branch.
 * Commit and push until you are happy with your contribution.
-* Make sure to add tests for it. This is important so I don't break it in a future version unintentionally.
-* Please try not to mess with the Rakefile, version, or history. If you want to have your own version, or is otherwise necessary, that is fine, but please isolate to its own commit so I can cherry-pick around it.
+* Make sure to add tests for it. This is important so I don't break it in a future version unintentionally. Coverage should remain as high as possible.
+* Make sure all tests pass as well as rubocop checks.
 
 ## License
 

data/lib/zenps/client.rb

@@ -31,23 +31,12 @@ module Zenps
 
     def expose_response
       {
-        email: email,
+        email: get_attribute(:email),
         code: response.code.to_i,
         body: response.body
       }
     end
 
-    def body
-      {
-        to: {
-          email: email
-        },
-        locale: locale,
-        event: event,
-        tags: tags
-      }.compact.to_json
-    end
-
     def uri
       @uri ||= URI.parse(end_point)
     end
@@ -59,20 +48,29 @@ module Zenps
       }
     end
 
-    def email
-      options[:email]
+    def body
+      {
+        to: to,
+        locale: get_attribute(:locale, default: 'en'),
+        event: get_attribute(:event),
+        tags: tags
+      }.compact.to_json
     end
 
-    def locale
-      options['locale'] || options[:locale] || 'en'
+    def to
+      {
+        email: get_attribute(:email),
+        first_name: get_attribute(:first_name),
+        last_name: get_attribute(:last_name)
+      }.compact
     end
 
-    def event
-      options['event'] || options[:event]
+    def get_attribute(attribute, params = {})
+      options[attribute.to_s] || options[attribute] || params[:default]
     end
 
     def tags
-      (options['tags'] || options[:tags] || []).join(', ')
+      get_attribute('tags', default: []).join(', ')
     rescue NoMethodError
       nil
     end

data/lib/zenps/payload.rb

@@ -22,21 +22,21 @@ module Zenps
       subjects.map do |subject|
         {
           email: get_email(subject),
-          locale: get_locale(subject)
+          first_name: get_attribute(subject, :first_name),
+          last_name: get_attribute(subject, :last_name),
+          locale: get_attribute(subject, :locale)
         }.compact
       end
     end
 
-    def get_email(object)
-      return object if object.class == String
-      return object[:email] || object['email'] if object.class == Hash
-      return object.email if object.respond_to? :email
+    def get_email(subject)
+      subject.class == String ? subject : get_attribute(subject, :email)
     end
 
-    def get_locale(object)
-      return if object.class == String
-      return object[:locale] || object['locale'] if object.class == Hash
-      return object.locale if object.respond_to? :locale
+    def get_attribute(subject, attribute)
+      return if subject.class == String
+      return subject[attribute.to_s] || subject[attribute] if subject.class == Hash
+      return subject.send(attribute) if subject.respond_to?(attribute)
     end
 
     def array_but_not_hash?

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zenps-ruby
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Alexis Philippart de Foy